)]}'
{"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cfcd513e6413f1048aedfefc1a0b1ffb32d789b3","unresolved":true,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"PORT_PATCH_SCHEMA \u003d copy.deepcopy(PORT_SCHEMA)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"PATCH_ALLOWED_FIELDS \u003d ["},{"line_number":64,"context_line":"    \u0027address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6b6b3529_dc607530","line":61,"updated":"2021-03-22 15:51:50.000000000","message":"nit? I don\u0027t think there is a need for PORT_PATCH_SCHEMA. Or if we want it, it doesn\u0027t need to be a deepcopy, it can be the same as PORT_SCHEMA.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"PORT_PATCH_SCHEMA \u003d copy.deepcopy(PORT_SCHEMA)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"PATCH_ALLOWED_FIELDS \u003d ["},{"line_number":64,"context_line":"    \u0027address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"03c927fc_95bcf480","line":61,"in_reply_to":"6b6b3529_dc607530","updated":"2021-03-23 13:11:25.000000000","message":"I guess we don\u0027t need it, we can remove the deepcopy.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cfcd513e6413f1048aedfefc1a0b1ffb32d789b3","unresolved":true,"context_lines":[{"line_number":577,"context_line":"            if not portgroup.standalone_ports_supported:"},{"line_number":578,"context_line":"                msg \u003d _(\"Port group %s doesn\u0027t support standalone ports. \""},{"line_number":579,"context_line":"                        \"This port cannot be created as a member of that \""},{"line_number":580,"context_line":"                        \"portgroup as the port \u0027pxe_enabled\u0027 was set to \""},{"line_number":581,"context_line":"                        \"True.\")"},{"line_number":582,"context_line":"                raise exception.Conflict("},{"line_number":583,"context_line":"                    msg % portgroup.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb541f72_09e19025","line":580,"updated":"2021-03-22 15:51:50.000000000","message":"nit s/port/port\u0027s/","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            if not portgroup.standalone_ports_supported:"},{"line_number":578,"context_line":"                msg \u003d _(\"Port group %s doesn\u0027t support standalone ports. \""},{"line_number":579,"context_line":"                        \"This port cannot be created as a member of that \""},{"line_number":580,"context_line":"                        \"portgroup as the port \u0027pxe_enabled\u0027 was set to \""},{"line_number":581,"context_line":"                        \"True.\")"},{"line_number":582,"context_line":"                raise exception.Conflict("},{"line_number":583,"context_line":"                    msg % portgroup.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"166ac1a5_52e30840","line":580,"in_reply_to":"cb541f72_09e19025","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"ironic/api/controllers/v1/portgroup.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cfcd513e6413f1048aedfefc1a0b1ffb32d789b3","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"PORTGROUP_PATCH_SCHEMA \u003d copy.deepcopy(PORTGROUP_SCHEMA)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"PORTGROUP_VALIDATOR_EXTRA \u003d args.dict_valid("},{"line_number":56,"context_line":"    address\u003dargs.mac_address,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b7e17f9_8cd49dd8","line":53,"updated":"2021-03-22 15:51:50.000000000","message":"ditto, no need for deepcopy","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"PORTGROUP_PATCH_SCHEMA \u003d copy.deepcopy(PORTGROUP_SCHEMA)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"PORTGROUP_VALIDATOR_EXTRA \u003d args.dict_valid("},{"line_number":56,"context_line":"    address\u003dargs.mac_address,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2dd4f740_f688ddfa","line":53,"in_reply_to":"9b7e17f9_8cd49dd8","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cfcd513e6413f1048aedfefc1a0b1ffb32d789b3","unresolved":true,"context_lines":[{"line_number":1324,"context_line":"    if vif:"},{"line_number":1325,"context_line":"        # TODO(rloo): in Stein cycle: if API version \u003e\u003d 1.28, remove"},{"line_number":1326,"context_line":"        #             warning and support for extra[]; else (\u003c 1.28)"},{"line_number":1327,"context_line":"        #             still support it; continue copying to internal_info"},{"line_number":1328,"context_line":"        #             (see bug 1722850). i.e., change the 7 lines of code"},{"line_number":1329,"context_line":"        #             below to something like:"},{"line_number":1330,"context_line":"        #                 if not api_utils.allow_vifs_subcontroller():"}],"source_content_type":"text/x-python","patch_set":4,"id":"bb956cfa_27e19e66","side":"PARENT","line":1327,"updated":"2021-03-22 15:51:50.000000000","message":"based on this comment, we need to still support it if the microversion is \u003c 1.28?","commit_id":"043de26884c4b0014b019d1112ea8af9fad37d30"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"    if vif:"},{"line_number":1325,"context_line":"        # TODO(rloo): in Stein cycle: if API version \u003e\u003d 1.28, remove"},{"line_number":1326,"context_line":"        #             warning and support for extra[]; else (\u003c 1.28)"},{"line_number":1327,"context_line":"        #             still support it; continue copying to internal_info"},{"line_number":1328,"context_line":"        #             (see bug 1722850). i.e., change the 7 lines of code"},{"line_number":1329,"context_line":"        #             below to something like:"},{"line_number":1330,"context_line":"        #                 if not api_utils.allow_vifs_subcontroller():"}],"source_content_type":"text/x-python","patch_set":4,"id":"2febbcb9_be2766cc","side":"PARENT","line":1327,"in_reply_to":"482c47ae_1217155d","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"043de26884c4b0014b019d1112ea8af9fad37d30"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":1324,"context_line":"    if vif:"},{"line_number":1325,"context_line":"        # TODO(rloo): in Stein cycle: if API version \u003e\u003d 1.28, remove"},{"line_number":1326,"context_line":"        #             warning and support for extra[]; else (\u003c 1.28)"},{"line_number":1327,"context_line":"        #             still support it; continue copying to internal_info"},{"line_number":1328,"context_line":"        #             (see bug 1722850). i.e., change the 7 lines of code"},{"line_number":1329,"context_line":"        #             below to something like:"},{"line_number":1330,"context_line":"        #                 if not api_utils.allow_vifs_subcontroller():"}],"source_content_type":"text/x-python","patch_set":4,"id":"482c47ae_1217155d","side":"PARENT","line":1327,"in_reply_to":"bb956cfa_27e19e66","updated":"2021-03-22 17:14:07.000000000","message":"Discussed with Julia. The deprecation of this was announced in ocata: https://docs.openstack.org/releasenotes/ironic/ocata.html#deprecation-notes so remove it!","commit_id":"043de26884c4b0014b019d1112ea8af9fad37d30"}],"ironic/tests/unit/api/controllers/v1/test_port.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":2275,"context_line":"                          http_status\u003dhttp_client.CREATED):"},{"line_number":2276,"context_line":"        extra \u003d {}"},{"line_number":2277,"context_line":"        if has_vif:"},{"line_number":2278,"context_line":"            extra \u003d {\u0027vif_port_id\u0027: uuidutils.generate_uuid()}"},{"line_number":2279,"context_line":"        pdict \u003d post_get_test_port("},{"line_number":2280,"context_line":"            node_uuid\u003dself.node.uuid,"},{"line_number":2281,"context_line":"            pxe_enabled\u003dpxe_enabled,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e976ee72_60551308","line":2278,"updated":"2021-03-22 17:14:07.000000000","message":"i think we should delete the code that handles \u0027has_vif\u0027 or change it so that has_vif puts the vif in port.internal_info. or ?? This extra stuff should be deleted since it makes no sense any more.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":2382,"context_line":"                                                                mock_create):"},{"line_number":2383,"context_line":"        # NOTE(TheJulia): This test used to fail with a conflict as you"},{"line_number":2384,"context_line":"        # previously would encounter a failure attempting to create a port"},{"line_number":2385,"context_line":"        # and add a VIF at the same time via the extra field."},{"line_number":2386,"context_line":"        self._test_create_port(mock_create, has_vif\u003dTrue, in_portgroup\u003dTrue,"},{"line_number":2387,"context_line":"                               pxe_enabled\u003dFalse,"},{"line_number":2388,"context_line":"                               standalone_ports\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3c6b1969_3ee231eb","line":2385,"updated":"2021-03-22 17:14:07.000000000","message":"i\u0027d remove this note. seems like it is useful as a comment in the PR to explain why it got changed from CONFLICT to CREATED. But anyone reading this file will not know what this \u0027via the extra field\u0027 means, given that we\u0027ve removing that functionality now :)","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":true,"context_lines":[{"line_number":2382,"context_line":"                                                                mock_create):"},{"line_number":2383,"context_line":"        # NOTE(TheJulia): This test used to fail with a conflict as you"},{"line_number":2384,"context_line":"        # previously would encounter a failure attempting to create a port"},{"line_number":2385,"context_line":"        # and add a VIF at the same time via the extra field."},{"line_number":2386,"context_line":"        self._test_create_port(mock_create, has_vif\u003dTrue, in_portgroup\u003dTrue,"},{"line_number":2387,"context_line":"                               pxe_enabled\u003dFalse,"},{"line_number":2388,"context_line":"                               standalone_ports\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2fc481d8_6b26bb61","line":2385,"in_reply_to":"3c6b1969_3ee231eb","updated":"2021-03-23 13:11:25.000000000","message":"I think we can just remove the test at this point, since it is to ensure that you can\u0027t create a port with a vif except you can\u0027t witht he new model and now it is just ignored.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"ironic/tests/unit/api/controllers/v1/test_portgroup.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"        del pgdict[\u0027extra\u0027]"},{"line_number":1211,"context_line":"        response \u003d self.post_json(\u0027/portgroups\u0027, pgdict, headers\u003dself.headers)"},{"line_number":1212,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1213,"context_line":"        self.assertEqual(http_client.CREATED, response.status_int)"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"    def test_create_portgroup_no_address(self):"},{"line_number":1216,"context_line":"        pdict \u003d apiutils.post_get_test_portgroup()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3bd260af_c16477fd","line":1213,"updated":"2021-03-22 17:14:07.000000000","message":"i\u0027m not sure i see the value for this test, unless it is to test that support for the extra stuff has been removed...","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"        del pgdict[\u0027extra\u0027]"},{"line_number":1211,"context_line":"        response \u003d self.post_json(\u0027/portgroups\u0027, pgdict, headers\u003dself.headers)"},{"line_number":1212,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1213,"context_line":"        self.assertEqual(http_client.CREATED, response.status_int)"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"    def test_create_portgroup_no_address(self):"},{"line_number":1216,"context_line":"        pdict \u003d apiutils.post_get_test_portgroup()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ef8bc4f_428e4322","line":1213,"in_reply_to":"3bd260af_c16477fd","updated":"2021-03-23 13:11:25.000000000","message":"I concur, it was testing warn and nothing else.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"ironic/tests/unit/common/test_network.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(expected, result)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_get_node_vif_ids_one_port_int_info(self):"},{"line_number":60,"context_line":"        self._test_get_node_vif_ids_one_port(\"internal_info\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _test_get_node_vif_ids_one_portgroup(self, key):"},{"line_number":63,"context_line":"        if key \u003d\u003d \"extra\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"af8ee22c_69062981","line":60,"updated":"2021-03-22 17:14:07.000000000","message":"should delete this, change above _test_get_node_vif_ids_one_port() so it is test_get_node_vif_ids_one_port(self). And delete the \u0027key\u0027 related code.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(expected, result)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_get_node_vif_ids_one_port_int_info(self):"},{"line_number":60,"context_line":"        self._test_get_node_vif_ids_one_port(\"internal_info\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _test_get_node_vif_ids_one_portgroup(self, key):"},{"line_number":63,"context_line":"        if key \u003d\u003d \"extra\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"3d46028a_8064b62e","line":60,"in_reply_to":"af8ee22c_69062981","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        self.assertEqual(expected, result)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_get_node_vif_ids_one_portgroup_int_info(self):"},{"line_number":77,"context_line":"        self._test_get_node_vif_ids_one_portgroup(\"internal_info\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _test_get_node_vif_ids_two_ports(self, key):"},{"line_number":80,"context_line":"        if key \u003d\u003d \"extra\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"b791031d_b7459a9a","line":77,"updated":"2021-03-22 17:14:07.000000000","message":"do similar change.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.assertEqual(expected, result)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_get_node_vif_ids_one_portgroup_int_info(self):"},{"line_number":77,"context_line":"        self._test_get_node_vif_ids_one_portgroup(\"internal_info\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _test_get_node_vif_ids_two_ports(self, key):"},{"line_number":80,"context_line":"        if key \u003d\u003d \"extra\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe3655a3_a0fdde88","line":77,"in_reply_to":"b791031d_b7459a9a","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        self.assertEqual(expected, result)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_get_node_vif_ids_two_ports_int_info(self):"},{"line_number":102,"context_line":"        self._test_get_node_vif_ids_two_ports(\u0027internal_info\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _test_get_node_vif_ids_two_portgroups(self, key):"},{"line_number":105,"context_line":"        if key \u003d\u003d \"extra\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"b3157170_c49f3f17","line":102,"updated":"2021-03-22 17:14:07.000000000","message":"do similar change.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertEqual(expected, result)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_get_node_vif_ids_two_ports_int_info(self):"},{"line_number":102,"context_line":"        self._test_get_node_vif_ids_two_ports(\u0027internal_info\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _test_get_node_vif_ids_two_portgroups(self, key):"},{"line_number":105,"context_line":"        if key \u003d\u003d \"extra\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"466d9ec4_1d6e56de","line":102,"in_reply_to":"b3157170_c49f3f17","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(expected, result)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_node_vif_ids_two_portgroups_int_info(self):"},{"line_number":126,"context_line":"        self._test_get_node_vif_ids_two_portgroups(\u0027internal_info\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _test_get_node_vif_ids_multitenancy(self, int_info_key):"},{"line_number":129,"context_line":"        port \u003d db_utils.create_test_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"a450a5e3_c79d922e","line":126,"updated":"2021-03-22 17:14:07.000000000","message":"do similar change.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(expected, result)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_node_vif_ids_two_portgroups_int_info(self):"},{"line_number":126,"context_line":"        self._test_get_node_vif_ids_two_portgroups(\u0027internal_info\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _test_get_node_vif_ids_multitenancy(self, int_info_key):"},{"line_number":129,"context_line":"        port \u003d db_utils.create_test_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"63b04786_36c5c7d2","line":126,"in_reply_to":"a450a5e3_c79d922e","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"ironic/tests/unit/drivers/modules/network/test_common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":657,"context_line":"        self.port.save()"},{"line_number":658,"context_line":"        with task_manager.acquire(self.context, self.node.id) as task:"},{"line_number":659,"context_line":"            vif \u003d self.interface.get_current_vif(task, self.port)"},{"line_number":660,"context_line":"            self.assertIsNone(vif)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def test_get_current_vif_internal_info_cleaning(self):"},{"line_number":663,"context_line":"        internal_info \u003d {\u0027cleaning_vif_port_id\u0027: \u0027foo\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"596275d9_770b11d8","line":660,"updated":"2021-03-22 17:14:07.000000000","message":"i suggest deleting this test.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        self.port.save()"},{"line_number":658,"context_line":"        with task_manager.acquire(self.context, self.node.id) as task:"},{"line_number":659,"context_line":"            vif \u003d self.interface.get_current_vif(task, self.port)"},{"line_number":660,"context_line":"            self.assertIsNone(vif)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def test_get_current_vif_internal_info_cleaning(self):"},{"line_number":663,"context_line":"        internal_info \u003d {\u0027cleaning_vif_port_id\u0027: \u0027foo\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c26b188_ffc322f8","line":660,"in_reply_to":"596275d9_770b11d8","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":867,"context_line":"                       autospec\u003dTrue)"},{"line_number":868,"context_line":"    def test_vif_attach_update_port_exception(self, mock_gpbpi, mock_upa,"},{"line_number":869,"context_line":"                                              mock_client, mock_save):"},{"line_number":870,"context_line":"        self.port.extra \u003d {}"},{"line_number":871,"context_line":"        self.port.internal_info \u003d {}"},{"line_number":872,"context_line":"        self.port.physical_network \u003d \u0027physnet1\u0027"},{"line_number":873,"context_line":"        self.port.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"06f7af0f_012cf037","line":870,"updated":"2021-03-22 17:14:07.000000000","message":"nit, don\u0027t need this. or rather, shouldn\u0027t need it ;)","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                       autospec\u003dTrue)"},{"line_number":868,"context_line":"    def test_vif_attach_update_port_exception(self, mock_gpbpi, mock_upa,"},{"line_number":869,"context_line":"                                              mock_client, mock_save):"},{"line_number":870,"context_line":"        self.port.extra \u003d {}"},{"line_number":871,"context_line":"        self.port.internal_info \u003d {}"},{"line_number":872,"context_line":"        self.port.physical_network \u003d \u0027physnet1\u0027"},{"line_number":873,"context_line":"        self.port.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ed4165b_30fdbaaa","line":870,"in_reply_to":"06f7af0f_012cf037","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"ironic/tests/unit/drivers/modules/network/test_neutron.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":667,"context_line":"            self.port.extra \u003d {}"},{"line_number":668,"context_line":"        else:"},{"line_number":669,"context_line":"            raise NotImplementedError(\u0027no longer implemented\u0027)"},{"line_number":670,"context_line":"        second_port \u003d utils.create_test_port("},{"line_number":671,"context_line":"            self.context, node_id\u003dself.node.id, address\u003d\u002752:54:00:cf:2d:33\u0027,"},{"line_number":672,"context_line":"            uuid\u003duuidutils.generate_uuid(),"},{"line_number":673,"context_line":"            local_link_connection\u003d{\u0027switch_id\u0027: \u00270a:1b:2c:3d:4e:ff\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fb0853b6_ab1ac32a","line":670,"updated":"2021-03-22 17:14:07.000000000","message":"maybe just delete \u0027vif_int_info\u0027 parameter from the test.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            self.port.extra \u003d {}"},{"line_number":668,"context_line":"        else:"},{"line_number":669,"context_line":"            raise NotImplementedError(\u0027no longer implemented\u0027)"},{"line_number":670,"context_line":"        second_port \u003d utils.create_test_port("},{"line_number":671,"context_line":"            self.context, node_id\u003dself.node.id, address\u003d\u002752:54:00:cf:2d:33\u0027,"},{"line_number":672,"context_line":"            uuid\u003duuidutils.generate_uuid(),"},{"line_number":673,"context_line":"            local_link_connection\u003d{\u0027switch_id\u0027: \u00270a:1b:2c:3d:4e:ff\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a71d88b_d280f4cc","line":670,"in_reply_to":"fb0853b6_ab1ac32a","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}],"releasenotes/notes/remove-extra-vif-port-id-ea4e59176c2065fd.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7cbe41762da5f42b0149459fd05264ee3da1b0db","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The long deprecated functionality of using a port.extra ``vif_port_id``"},{"line_number":5,"context_line":"    value to signal and control a VIF attachment has been removed in"},{"line_number":6,"context_line":"    anticipation of changing the permission model and access control policy."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b7b4725a_1684fe4f","line":4,"updated":"2021-03-22 17:14:07.000000000","message":"wonder if we want to mention that it was deprecated in \u0027ocata\u0027 relesae.","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8717168e2f8722ae8ffd5237f1257cde823eb83d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The long deprecated functionality of using a port.extra ``vif_port_id``"},{"line_number":5,"context_line":"    value to signal and control a VIF attachment has been removed in"},{"line_number":6,"context_line":"    anticipation of changing the permission model and access control policy."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"05bf5257_e41a91c9","line":4,"in_reply_to":"b7b4725a_1684fe4f","updated":"2021-03-23 13:11:25.000000000","message":"Done","commit_id":"6164b81f0f112fb7dabe8368ab06aef75330d024"}]}