)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a3081d6cc403b79a5107f8d143f5542643fe7fc2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-12-29 10:15:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"when set boot_devices bios here, as the time user finishes deploying the node,the node will power on go to bios setup. so we should set the boot_devices to disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8e7cc0e7bfde6bb3e690db2ed133aed09ae594ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6df7d3ee_211809a1","line":8,"updated":"2020-12-31 16:09:11.000000000","message":"Please file a bug to indicate why this is perceived as an issue. This was done intentionally to prevent the node from being able to boot while the smartnic is receiving it\u0027s configuration. That node could be on untrusted networks during that time and thus booting to bios prevents the user workload from loading.\n\nSome sort of further detail is needed.","commit_id":"2dfaa8620cbbac586f8ad3a3ae7316ed32acb30c"}],"ironic/conductor/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a3081d6cc403b79a5107f8d143f5542643fe7fc2","unresolved":true,"context_lines":[{"line_number":901,"context_line":"    previous_power_state \u003d task.driver.power.get_power_state(task)"},{"line_number":902,"context_line":"    if previous_power_state \u003d\u003d states.POWER_OFF:"},{"line_number":903,"context_line":"        node_set_boot_device("},{"line_number":904,"context_line":"            task, boot_devices.BIOS, persistent\u003dFalse)"},{"line_number":905,"context_line":"        node_power_action(task, states.POWER_ON)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        # local import is necessary to avoid circular import"}],"source_content_type":"text/x-python","patch_set":2,"id":"017508f8_8b8e5933","side":"PARENT","line":904,"range":{"start_line":904,"start_character":13,"end_line":904,"end_character":42},"updated":"2020-12-31 16:09:11.000000000","message":"The system is intentionally booted to BIOS as a security mechanism to enable the smartnic enough time to come online, report in, receive it\u0027s configuration, and then the deployment can finish. In this case the user requested cannot be booted as the networking still may be in an intermediate state where the provisioning network may still be attached which presents a security risk. It would help to understand why you feel this change is necessary.","commit_id":"6c9e28dd505a19d405b5ab75500cde555b4aca8d"},{"author":{"_account_id":32148,"name":"liuyuanfeng","email":"liuyuanfeng@inspur.com","username":"liuyuanfeng"},"change_message_id":"bdc431fc0b4a896efc130c194ae138402e680a4e","unresolved":true,"context_lines":[{"line_number":901,"context_line":"    previous_power_state \u003d task.driver.power.get_power_state(task)"},{"line_number":902,"context_line":"    if previous_power_state \u003d\u003d states.POWER_OFF:"},{"line_number":903,"context_line":"        node_set_boot_device("},{"line_number":904,"context_line":"            task, boot_devices.BIOS, persistent\u003dFalse)"},{"line_number":905,"context_line":"        node_power_action(task, states.POWER_ON)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        # local import is necessary to avoid circular import"}],"source_content_type":"text/x-python","patch_set":2,"id":"569cb8a6_f9012ea9","side":"PARENT","line":904,"range":{"start_line":904,"start_character":13,"end_line":904,"end_character":42},"in_reply_to":"017508f8_8b8e5933","updated":"2021-01-04 12:08:50.000000000","message":"There is nothing wrong  when booted to BIOS as a security mechanism in the preparing progress.\nBut after ironic downloads the user image and set boot to disk，in reboot_and_finish_deploy (agent_base.py) function, before removing provision network，set boot to BIOS will cover boot from disk as set before. So when finished deploy, user image will boot from bios. I feel that is unreasonable.How do you think?","commit_id":"6c9e28dd505a19d405b5ab75500cde555b4aca8d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"336cc606ef24ae4a64bb54790cfb0671aca0745f","unresolved":true,"context_lines":[{"line_number":901,"context_line":"    previous_power_state \u003d task.driver.power.get_power_state(task)"},{"line_number":902,"context_line":"    if previous_power_state \u003d\u003d states.POWER_OFF:"},{"line_number":903,"context_line":"        node_set_boot_device("},{"line_number":904,"context_line":"            task, boot_devices.BIOS, persistent\u003dFalse)"},{"line_number":905,"context_line":"        node_power_action(task, states.POWER_ON)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        # local import is necessary to avoid circular import"}],"source_content_type":"text/x-python","patch_set":2,"id":"70ce053d_12f8c2d5","side":"PARENT","line":904,"range":{"start_line":904,"start_character":13,"end_line":904,"end_character":42},"in_reply_to":"569cb8a6_f9012ea9","updated":"2021-01-17 19:24:49.000000000","message":"But we need to program the ovs rules for the tenant network. So we need to set to bios program the ovs rules and then boot from disk","commit_id":"6c9e28dd505a19d405b5ab75500cde555b4aca8d"}]}