)]}'
{"ironic/drivers/modules/redfish/bios.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d9e1ea47895170238dfb01b9d2e29429127ee7e0","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":219,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":220,"context_line":"        self._reboot(task)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def post_configuration(self, task, settings):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8beb40d_ff73ad55","line":219,"range":{"start_line":218,"start_character":0,"end_line":219,"end_character":59},"updated":"2021-01-11 17:28:58.000000000","message":"Here and and in other steps, would it be possible to skip this ramdisk preparation if running without IPA?","commit_id":"503a8135057acaef1e13ee0b4888462b7ff8e9a6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1cebda66f1831c1a95e8f884eb5a3f93817423dd","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":219,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":220,"context_line":"        self._reboot(task)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def post_configuration(self, task, settings):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c067d8c_36d91a9a","line":219,"range":{"start_line":218,"start_character":0,"end_line":219,"end_character":59},"in_reply_to":"9228a0d1_1cc6a3ae","updated":"2021-01-13 10:37:02.000000000","message":"JFYI, WS-Man does not have this because it\u0027s a bug[1] and a bit tricky to fix as in WS-Man setting boot device requires BIOS job\u0026reboot. As such these WS-Man clean steps work just fine without IPA.\n\n[1] https://storyboard.openstack.org/#!/story/2008312","commit_id":"503a8135057acaef1e13ee0b4888462b7ff8e9a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"420bae02ef997274f51266fbd43381e9e051ac61","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":219,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":220,"context_line":"        self._reboot(task)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def post_configuration(self, task, settings):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9228a0d1_1cc6a3ae","line":219,"range":{"start_line":218,"start_character":0,"end_line":219,"end_character":59},"in_reply_to":"c8beb40d_ff73ad55","updated":"2021-01-11 19:15:53.000000000","message":"Yep, this and similar places (e.g. in iLO) will need clean up.","commit_id":"503a8135057acaef1e13ee0b4888462b7ff8e9a6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d9e1ea47895170238dfb01b9d2e29429127ee7e0","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        task.node.driver_internal_info \u003d info"},{"line_number":308,"context_line":"        task.node.save()"},{"line_number":309,"context_line":"        deploy_utils.set_async_step_flags(task.node, reboot\u003dTrue,"},{"line_number":310,"context_line":"                                          skip_current_step\u003dFalse)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _clear_reboot_requested(self, task):"},{"line_number":313,"context_line":"        \"\"\"Clear driver_internal_info flags after reboot completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"fc6b1e5c_8954c2c5","line":310,"range":{"start_line":310,"start_character":42,"end_line":310,"end_character":65},"updated":"2021-01-11 17:28:58.000000000","message":"when I was looking at this BIOS implementation, my understanding was that, because it does not skip current step, it requires IPA to continue and this class might not host IPA free steps. Is this correct or how does conductor know that system has rebooted and it\u0027s time to enter the next phase on ln 199?","commit_id":"503a8135057acaef1e13ee0b4888462b7ff8e9a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"420bae02ef997274f51266fbd43381e9e051ac61","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        task.node.driver_internal_info \u003d info"},{"line_number":308,"context_line":"        task.node.save()"},{"line_number":309,"context_line":"        deploy_utils.set_async_step_flags(task.node, reboot\u003dTrue,"},{"line_number":310,"context_line":"                                          skip_current_step\u003dFalse)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _clear_reboot_requested(self, task):"},{"line_number":313,"context_line":"        \"\"\"Clear driver_internal_info flags after reboot completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe6dd03_46ed22e1","line":310,"range":{"start_line":310,"start_character":42,"end_line":310,"end_character":65},"in_reply_to":"fc6b1e5c_8954c2c5","updated":"2021-01-11 19:15:53.000000000","message":"It\u0027s a very good question. I need to think about it. It may indeed prevent us from using BIOS in IPA-free fashion...","commit_id":"503a8135057acaef1e13ee0b4888462b7ff8e9a6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1cebda66f1831c1a95e8f884eb5a3f93817423dd","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        task.node.driver_internal_info \u003d info"},{"line_number":308,"context_line":"        task.node.save()"},{"line_number":309,"context_line":"        deploy_utils.set_async_step_flags(task.node, reboot\u003dTrue,"},{"line_number":310,"context_line":"                                          skip_current_step\u003dFalse)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _clear_reboot_requested(self, task):"},{"line_number":313,"context_line":"        \"\"\"Clear driver_internal_info flags after reboot completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"0b3e4492_9d868793","line":310,"range":{"start_line":310,"start_character":42,"end_line":310,"end_character":65},"in_reply_to":"ffe6dd03_46ed22e1","updated":"2021-01-13 10:37:02.000000000","message":"as talked on IRC, it should be possible to update apply configuration to use task monitor, for factory_reset not so easy - need to find a proper, reliable way to determine that factory reset is done/system rebooted.","commit_id":"503a8135057acaef1e13ee0b4888462b7ff8e9a6"}]}