)]}'
{"ironic/conductor/utils.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"ccf4f3b2e55ae743bf2f121e2820c97feaf692fb","unresolved":true,"context_lines":[{"line_number":431,"context_line":"    LOG.error(logmsg, exc_info\u003dtraceback)"},{"line_number":432,"context_line":"    node \u003d task.node"},{"line_number":433,"context_line":"    if set_maintenance:"},{"line_number":434,"context_line":"        node.fault \u003d faults.CLEAN_FAILURE"},{"line_number":435,"context_line":"        node.maintenance \u003d True"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if tear_down_cleaning:"}],"source_content_type":"text/x-python","patch_set":1,"id":"89b2c3fe_15d2ad21","line":434,"range":{"start_line":434,"start_character":0,"end_line":434,"end_character":41},"updated":"2021-01-08 14:11:14.000000000","message":"Shouldn\u0027t this be outside the condition or is the node moved to clean_failed somewhere else?","commit_id":"ad696c9bac379a690b1f674de4983bf1a06a243e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"935b3822e0d51faf0dc8863d62b904941556f074","unresolved":true,"context_lines":[{"line_number":431,"context_line":"    LOG.error(logmsg, exc_info\u003dtraceback)"},{"line_number":432,"context_line":"    node \u003d task.node"},{"line_number":433,"context_line":"    if set_maintenance:"},{"line_number":434,"context_line":"        node.fault \u003d faults.CLEAN_FAILURE"},{"line_number":435,"context_line":"        node.maintenance \u003d True"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if tear_down_cleaning:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8231411_290cd20b","line":434,"range":{"start_line":434,"start_character":0,"end_line":434,"end_character":41},"in_reply_to":"6284a628_b4c68b9f","updated":"2021-01-08 15:47:29.000000000","message":"Fault is a situation that may need a manual intervention. Setting a fault without maintenance mode violates our (possibly implicit) contract around faults.\n\nAdditionally, then we need to have code somewhere to remove faults.","commit_id":"ad696c9bac379a690b1f674de4983bf1a06a243e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"56ab382ac7cc7e41b5e2bc237eee19c84abdf370","unresolved":true,"context_lines":[{"line_number":431,"context_line":"    LOG.error(logmsg, exc_info\u003dtraceback)"},{"line_number":432,"context_line":"    node \u003d task.node"},{"line_number":433,"context_line":"    if set_maintenance:"},{"line_number":434,"context_line":"        node.fault \u003d faults.CLEAN_FAILURE"},{"line_number":435,"context_line":"        node.maintenance \u003d True"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if tear_down_cleaning:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6284a628_b4c68b9f","line":434,"range":{"start_line":434,"start_character":0,"end_line":434,"end_character":41},"in_reply_to":"89b2c3fe_15d2ad21","updated":"2021-01-08 15:07:50.000000000","message":"The idea could be to never send it to a failed state, in that things failed outside our control, but I\u0027m not sure that is a good idea. :\\ I guess I have mixed feelings here. Thoughts?","commit_id":"ad696c9bac379a690b1f674de4983bf1a06a243e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c52eac2e763de336e7410e14947441c96fdd07ff","unresolved":true,"context_lines":[{"line_number":431,"context_line":"    LOG.error(logmsg, exc_info\u003dtraceback)"},{"line_number":432,"context_line":"    node \u003d task.node"},{"line_number":433,"context_line":"    if set_maintenance:"},{"line_number":434,"context_line":"        node.fault \u003d faults.CLEAN_FAILURE"},{"line_number":435,"context_line":"        node.maintenance \u003d True"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if tear_down_cleaning:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ae66426_84f2341d","line":434,"range":{"start_line":434,"start_character":0,"end_line":434,"end_character":41},"in_reply_to":"c8231411_290cd20b","updated":"2021-01-11 14:21:47.000000000","message":"I have a vague impression that we discussed turning maintenance into onne of fault in a broader scope, we will be able to handle this kind of case if we have more flexible fault handling instead of via the maintenance flag.","commit_id":"ad696c9bac379a690b1f674de4983bf1a06a243e"}]}