)]}'
{"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2d5583333c53b1e9c9769755bd39f1a568c3d012","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                     write_protected\u003dTrue)"},{"line_number":177,"context_line":"            except sushy.exceptions.ServerSideError:"},{"line_number":178,"context_line":"                # On some Dell hw, the eject media may still be in progress"},{"line_number":179,"context_line":"                # https://storyboard.openstack.org/#!/story/2008504"},{"line_number":180,"context_line":"                time.sleep(5)"},{"line_number":181,"context_line":"                v_media.insert_media(boot_url, inserted\u003dTrue,"},{"line_number":182,"context_line":"                                     write_protected\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"822da4f9_3bf90931","line":179,"updated":"2021-01-12 15:44:27.000000000","message":"Le sigh :( Let\u0027s log a debug message here.","commit_id":"5ba7b5ee36def2e7f492feca7d4891038fdff5c7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5c4076dfea1305d2ee32826319d63441bd46ce03","unresolved":true,"context_lines":[{"line_number":172,"context_line":"                continue"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                v_media.insert_media(boot_url, inserted\u003dTrue,"},{"line_number":176,"context_line":"                                     write_protected\u003dTrue)"},{"line_number":177,"context_line":"            except sushy.exceptions.ServerSideError:"},{"line_number":178,"context_line":"                # On some Dell hw, the eject media may still be in progress"}],"source_content_type":"text/x-python","patch_set":3,"id":"0dd108f1_59b08b59","line":175,"updated":"2021-01-13 10:04:48.000000000","message":"maybe it\u0027s overkill, but just wondering if this can be solved using tenacity to retry instead of just a sleep call","commit_id":"9b2101da99ce30ea6585265dba8d3282ac21d7a3"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"eaa72f5ed73e24780de1cd13c0db206652e5913b","unresolved":true,"context_lines":[{"line_number":172,"context_line":"                continue"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                v_media.insert_media(boot_url, inserted\u003dTrue,"},{"line_number":176,"context_line":"                                     write_protected\u003dTrue)"},{"line_number":177,"context_line":"            except sushy.exceptions.ServerSideError:"},{"line_number":178,"context_line":"                # On some Dell hw, the eject media may still be in progress"}],"source_content_type":"text/x-python","patch_set":3,"id":"122bd89a_127fd82b","line":175,"in_reply_to":"0dd108f1_59b08b59","updated":"2021-01-13 10:24:55.000000000","message":"@retry would work, if its preferred I can change the patch.","commit_id":"9b2101da99ce30ea6585265dba8d3282ac21d7a3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1958404a868c40b82c5a82242cad1bad6fbd4c72","unresolved":true,"context_lines":[{"line_number":172,"context_line":"                continue"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                v_media.insert_media(boot_url, inserted\u003dTrue,"},{"line_number":176,"context_line":"                                     write_protected\u003dTrue)"},{"line_number":177,"context_line":"            except sushy.exceptions.ServerSideError:"},{"line_number":178,"context_line":"                # On some Dell hw, the eject media may still be in progress"}],"source_content_type":"text/x-python","patch_set":3,"id":"abfa0807_fc431ca4","line":175,"in_reply_to":"122bd89a_127fd82b","updated":"2021-01-13 10:30:44.000000000","message":"I\u0027m for the retry, but let\u0027s see what other people say","commit_id":"9b2101da99ce30ea6585265dba8d3282ac21d7a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0d4c1ebfc6250e41fc3f8f8a568a1a7ea552c413","unresolved":true,"context_lines":[{"line_number":172,"context_line":"                continue"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                v_media.insert_media(boot_url, inserted\u003dTrue,"},{"line_number":176,"context_line":"                                     write_protected\u003dTrue)"},{"line_number":177,"context_line":"            except sushy.exceptions.ServerSideError:"},{"line_number":178,"context_line":"                # On some Dell hw, the eject media may still be in progress"}],"source_content_type":"text/x-python","patch_set":3,"id":"b9c063de_03b35721","line":175,"in_reply_to":"abfa0807_fc431ca4","updated":"2021-01-13 11:22:24.000000000","message":"+1 for retry","commit_id":"9b2101da99ce30ea6585265dba8d3282ac21d7a3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"afe25a98d58ffdd603ed2357806e0d244ef3c995","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import retrying"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":5,"id":"4253f20b_42ae1b14","line":16,"updated":"2021-01-14 09:01:04.000000000","message":"we\u0027re trying to get rid of the retrying module as it\u0027s not maintained anymore, please use tenacity instead, you can check https://review.opendev.org/c/openstack/ironic/+/376574 for the ongoing work on replacing retrying with tenacity","commit_id":"7d901065338637efd3c5e0cbc82959bc30c748ba"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"e96a938acf564779549f35574a111690f9bdca07","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import retrying"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":5,"id":"689f4f89_1634d224","line":16,"in_reply_to":"4253f20b_42ae1b14","updated":"2021-01-14 11:09:20.000000000","message":"thanks, done.","commit_id":"7d901065338637efd3c5e0cbc82959bc30c748ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"248ec1b5eac26912bf0791502ff521a5f028033a","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"@tenacity.retry(retry\u003dtenacity.retry_if_exception(_test_retry),"},{"line_number":158,"context_line":"                stop\u003dtenacity.stop_after_attempt(3),"},{"line_number":159,"context_line":"                wait\u003dtenacity.wait_fixed(2),"},{"line_number":160,"context_line":"                reraise\u003dTrue)"},{"line_number":161,"context_line":"def _insert_vmedia(task, boot_url, boot_device):"},{"line_number":162,"context_line":"    \"\"\"Insert bootable ISO image into virtual CD or DVD"}],"source_content_type":"text/x-python","patch_set":6,"id":"b43fdb78_101a1ae8","line":159,"updated":"2021-01-14 14:38:12.000000000","message":"This is hard coded to 2, the _test_retry method says 5..","commit_id":"5117e9f089a4d486b582658e212e8d199557dd24"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bb3d21578009487cb0c9ac4b22e7ff1c29a49f0e","unresolved":true,"context_lines":[{"line_number":153,"context_line":"    return False"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"@retrying.retry(wait_fixed\u003d3000, stop_max_attempt_number\u003d3,"},{"line_number":157,"context_line":"                retry_on_exception\u003d_test_retry)"},{"line_number":158,"context_line":"def _insert_vmedia(task, boot_url, boot_device):"},{"line_number":159,"context_line":"    \"\"\"Insert bootable ISO image into virtual CD or DVD"}],"source_content_type":"text/x-python","patch_set":8,"id":"9e975768_9b8c21ab","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":58},"updated":"2021-01-18 06:52:05.000000000","message":"It may be useful to make these configurable instead of hard coding it.","commit_id":"1a0f1cd545f0ff22e72d89fda40b1e64d61401f5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa2a6be8414b8cf70013731b9be0ce4c76829be4","unresolved":true,"context_lines":[{"line_number":153,"context_line":"    return False"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"@retrying.retry(wait_fixed\u003d3000, stop_max_attempt_number\u003d3,"},{"line_number":157,"context_line":"                retry_on_exception\u003d_test_retry)"},{"line_number":158,"context_line":"def _insert_vmedia(task, boot_url, boot_device):"},{"line_number":159,"context_line":"    \"\"\"Insert bootable ISO image into virtual CD or DVD"}],"source_content_type":"text/x-python","patch_set":8,"id":"ee193337_c97ff532","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":58},"in_reply_to":"9e975768_9b8c21ab","updated":"2021-01-18 12:02:32.000000000","message":"Maybe we can do in a follow-up? since we will switch to tenacity, we are using retry now so we can do the backport to stable branches.","commit_id":"1a0f1cd545f0ff22e72d89fda40b1e64d61401f5"}],"releasenotes/notes/retry-vmedia-1999742c84f11103.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"54ab44f2eeb6f82bbbd47d9bac04906b38f7f554","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Retries virtula media insert on failure to allow"},{"line_number":5,"context_line":"    for a eject that may not have finished."},{"line_number":6,"context_line":"    https://storyboard.openstack.org/#!/story/2008504"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"12cb3f86_e7b589d6","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":19},"updated":"2021-01-12 23:29:27.000000000","message":"Nit - typo","commit_id":"64c925b9774039693855329c9e9ac8ec0264b1ed"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"54ab44f2eeb6f82bbbd47d9bac04906b38f7f554","unresolved":true,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Retries virtula media insert on failure to allow"},{"line_number":5,"context_line":"    for a eject that may not have finished."},{"line_number":6,"context_line":"    https://storyboard.openstack.org/#!/story/2008504"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1b98c934_774d5a1c","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":9},"updated":"2021-01-12 23:29:27.000000000","message":"s/a/an/","commit_id":"64c925b9774039693855329c9e9ac8ec0264b1ed"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"248ec1b5eac26912bf0791502ff521a5f028033a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Retries virtual media insert on failure to allow"},{"line_number":5,"context_line":"    for an eject that may not have finished."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"257bad5a_d82dc359","line":2,"updated":"2021-01-14 14:38:12.000000000","message":"Mark this a fix to handle intermittent hardware issue or delayed transaction issue. Fix also means it can be backported without much headache.","commit_id":"5117e9f089a4d486b582658e212e8d199557dd24"}],"requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"248ec1b5eac26912bf0791502ff521a5f028033a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"keystonemiddleware\u003e\u003d4.17.0 # Apache-2.0"},{"line_number":38,"context_line":"oslo.messaging\u003e\u003d5.29.0 # Apache-2.0"},{"line_number":39,"context_line":"retrying!\u003d1.3.0,\u003e\u003d1.2.3 # Apache-2.0"},{"line_number":40,"context_line":"tenacity\u003e\u003d6.2.0  # Apache-2.0"},{"line_number":41,"context_line":"oslo.versionedobjects\u003e\u003d1.31.2 # Apache-2.0"},{"line_number":42,"context_line":"jsonschema\u003e\u003d3.2.0 # MIT"},{"line_number":43,"context_line":"psutil\u003e\u003d3.2.2 # BSD"}],"source_content_type":"text/plain","patch_set":6,"id":"37ceaba0_172f1436","line":40,"updated":"2021-01-14 14:38:12.000000000","message":"offff... this can\u0027t be backported. :\\","commit_id":"5117e9f089a4d486b582658e212e8d199557dd24"}]}