)]}'
{"doc/source/admin/drivers/idrac.rst":[{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5510c6678248e9134c2712bfa1b6e044c3debc38","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Below is the list of supported interface implementations in priority"},{"line_number":98,"context_line":"order:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"Interface            Supported Implementations"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":103,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b5af6bab_6e9f168d","line":100,"in_reply_to":"72891124_b7422545","updated":"2021-02-11 13:06:05.000000000","message":"\u003e docs: Malformed table.\n\nPlease fix.","commit_id":"ddaf7e44bc0fc1abdc627d40a5e1b4a3965dcbf6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of its functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":6,"id":"95c70079_a17173f3","line":12,"range":{"start_line":12,"start_character":66,"end_line":12,"end_character":69},"updated":"2021-02-18 08:36:19.000000000","message":"I know this was part of the original text, but what is being proposed is now 3 different ways. It may be better to say \"driver\" functions, because I can see people assuming with this that there is complete parity and behavior continuity across all three drivers.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of its functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":6,"id":"adb73344_a4e1a9d8","line":12,"range":{"start_line":12,"start_character":66,"end_line":12,"end_character":69},"in_reply_to":"95c70079_a17173f3","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The iDRAC driver supports WSMAN for the bios, inspect, management, power,"},{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"e476420d_066e979f","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":54},"updated":"2021-02-18 08:36:19.000000000","message":"s/it/It/? That being said, often it helps the reader to not start a sentence with It assuming context has been carried over, since sentences can be read with the context of the reader. So in other words, maybe say \"The driver\"","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The iDRAC driver supports WSMAN for the bios, inspect, management, power,"},{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d8c1d39d_add35f85","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":54},"in_reply_to":"e476420d_066e979f","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":55,"context_line":"The iDRAC driver supports WSMAN for the bios, inspect, management, power,"},{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7579415d_7d90fdc8","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":30},"updated":"2021-02-18 08:36:19.000000000","message":"Missing space before console, and a comma after after console.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":55,"context_line":"The iDRAC driver supports WSMAN for the bios, inspect, management, power,"},{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"}],"source_content_type":"text/x-rst","patch_set":6,"id":"631b6a16_1a4189a2","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":30},"in_reply_to":"7579415d_7d90fdc8","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"}],"source_content_type":"text/x-rst","patch_set":6,"id":"10beed26_a2c4c059","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":34},"updated":"2021-02-18 08:36:19.000000000","message":"Missing space after comma.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"}],"source_content_type":"text/x-rst","patch_set":6,"id":"87753ed4_8db54913","line":59,"range":{"start_line":59,"start_character":37,"end_line":59,"end_character":39},"updated":"2021-02-18 08:36:19.000000000","message":"Oxford comma use is preferred (comma after IPMI). 😊","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d59ca5b6_ce3538de","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":34},"in_reply_to":"10beed26_a2c4c059","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. it supports IPMI for"},{"line_number":58,"context_line":"the management, power,console and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN,IPMI and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"}],"source_content_type":"text/x-rst","patch_set":6,"id":"cf8c09c0_d2d3c07a","line":59,"range":{"start_line":59,"start_character":37,"end_line":59,"end_character":39},"in_reply_to":"87753ed4_8db54913","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"},{"line_number":63,"context_line":"to use Redfish for an interface.The ``idrac-ipmi`` implementation"},{"line_number":64,"context_line":"must be enabled to use IPMI for an interface."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ee9cad03_9507ec46","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":33},"updated":"2021-02-18 08:36:19.000000000","message":"Missing space after a period.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"},{"line_number":63,"context_line":"to use Redfish for an interface.The ``idrac-ipmi`` implementation"},{"line_number":64,"context_line":"must be enabled to use IPMI for an interface."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e56135ef_58e60773","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":33},"in_reply_to":"ee9cad03_9507ec46","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":93,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Restart the Ironic conductor service."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Below is the list of supported interface implementations in priority"},{"line_number":98,"context_line":"order:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9b792298_d85258a9","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":37},"updated":"2021-02-18 08:36:19.000000000","message":"This is out of context, and I think these are HUP\u0027able fields. I guess ultimately it is kind of a redundant statement unrelated to the core change.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":93,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Restart the Ironic conductor service."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Below is the list of supported interface implementations in priority"},{"line_number":98,"context_line":"order:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"72245fb3_ea551fe4","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":37},"in_reply_to":"9b792298_d85258a9","updated":"2021-02-22 16:33:59.000000000","message":"this statement is removed","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Protocol-specific Properties"},{"line_number":124,"context_line":"----------------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The WSMAN,IPMI and Redfish protocols require different properties to be specified"},{"line_number":127,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":128,"context_line":"metal system\u0027s iDRAC."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f9f51a9_fc61d43f","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":14},"updated":"2021-02-18 08:36:19.000000000","message":"Please add a comma after IPMI.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Protocol-specific Properties"},{"line_number":124,"context_line":"----------------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The WSMAN,IPMI and Redfish protocols require different properties to be specified"},{"line_number":127,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":128,"context_line":"metal system\u0027s iDRAC."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"c4c74233_d1bd22bf","line":126,"range":{"start_line":126,"start_character":9,"end_line":126,"end_character":11},"updated":"2021-02-18 08:36:19.000000000","message":"missing space after the comma","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Protocol-specific Properties"},{"line_number":124,"context_line":"----------------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The WSMAN,IPMI and Redfish protocols require different properties to be specified"},{"line_number":127,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":128,"context_line":"metal system\u0027s iDRAC."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5e1d4fd0_c329a852","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":14},"in_reply_to":"1f9f51a9_fc61d43f","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Protocol-specific Properties"},{"line_number":124,"context_line":"----------------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The WSMAN,IPMI and Redfish protocols require different properties to be specified"},{"line_number":127,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":128,"context_line":"metal system\u0027s iDRAC."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"4bd91db4_37435084","line":126,"range":{"start_line":126,"start_character":9,"end_line":126,"end_character":11},"in_reply_to":"c4c74233_d1bd22bf","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":152,"context_line":"The IPMI protocol requires the following properties:"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* ``ipmi_address``: The IP address of the iDRAC."},{"line_number":155,"context_line":"* ``ipmi_username``: The IPMI user name to use when communicating with the iDRAC.Usually ``root``."},{"line_number":156,"context_line":"* ``ipmi_password``: The password for the IPMI user to use when communicating with the iDRAC."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"For other IPMI protocol parameters see :doc:`/admin/drivers/ipmitool`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"35046923_ae46ecd5","line":155,"range":{"start_line":155,"start_character":80,"end_line":155,"end_character":81},"updated":"2021-02-18 08:36:19.000000000","message":"Missing space after the period.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":152,"context_line":"The IPMI protocol requires the following properties:"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* ``ipmi_address``: The IP address of the iDRAC."},{"line_number":155,"context_line":"* ``ipmi_username``: The IPMI user name to use when communicating with the iDRAC.Usually ``root``."},{"line_number":156,"context_line":"* ``ipmi_password``: The password for the IPMI user to use when communicating with the iDRAC."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"For other IPMI protocol parameters see :doc:`/admin/drivers/ipmitool`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"d05c25f8_45790b5f","line":155,"range":{"start_line":155,"start_character":80,"end_line":155,"end_character":81},"in_reply_to":"35046923_ae46ecd5","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":160,"context_line":"If using only interfaces which use WSMAN (``idrac-wsman``), then only"},{"line_number":161,"context_line":"the WSMAN properties must be supplied. If using only interfaces which"},{"line_number":162,"context_line":"use Redfish (``idrac-redfish``), then only the Redfish properties must be"},{"line_number":163,"context_line":"supplied. If using only interfaces which use IPMI (``idrac-ipmi``), then only"},{"line_number":164,"context_line":"the IPMI properties must be supplied. If using a mix of interfaces, where"},{"line_number":165,"context_line":"some use WSMAN and others use Redfish, both the WSMAN and Redfish properties"},{"line_number":166,"context_line":"must be supplied."}],"source_content_type":"text/x-rst","patch_set":6,"id":"6da474fd_ee69b763","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":71},"updated":"2021-02-18 08:36:19.000000000","message":"For everyone on the thread, this is just what is confusing. The interfaces get referred to as idrac-ipmi, but the doc is /admin/drivers/ipmitool. 😭","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":true,"context_lines":[{"line_number":160,"context_line":"If using only interfaces which use WSMAN (``idrac-wsman``), then only"},{"line_number":161,"context_line":"the WSMAN properties must be supplied. If using only interfaces which"},{"line_number":162,"context_line":"use Redfish (``idrac-redfish``), then only the Redfish properties must be"},{"line_number":163,"context_line":"supplied. If using only interfaces which use IPMI (``idrac-ipmi``), then only"},{"line_number":164,"context_line":"the IPMI properties must be supplied. If using a mix of interfaces, where"},{"line_number":165,"context_line":"some use WSMAN and others use Redfish, both the WSMAN and Redfish properties"},{"line_number":166,"context_line":"must be supplied."}],"source_content_type":"text/x-rst","patch_set":6,"id":"61cc552a_9ecff468","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":71},"in_reply_to":"6da474fd_ee69b763","updated":"2021-02-22 16:33:59.000000000","message":"the interface referred as idrac-ipmi is for iDRAC driver, the doc referred /admin/drivers/ipmitool for other information on IPMI protocol","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":210,"context_line":"        --console-interface idrac-ipmi"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":213,"context_line":"hardware type assuming a mix of Redfish,IPMI and WSMAN interfaces are used:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. code-block:: bash"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa0067_f0987632","line":213,"range":{"start_line":213,"start_character":39,"end_line":213,"end_character":40},"updated":"2021-02-18 08:36:19.000000000","message":"Missing space after the comma.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        --console-interface idrac-ipmi"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":213,"context_line":"hardware type assuming a mix of Redfish,IPMI and WSMAN interfaces are used:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. code-block:: bash"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"274b7eb9_645e170d","line":213,"range":{"start_line":213,"start_character":39,"end_line":213,"end_character":40},"in_reply_to":"3aaa0067_f0987632","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":215,"context_line":".. code-block:: bash"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    baremetal node create --driver idrac \\"},{"line_number":218,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":219,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":220,"context_line":"        --driver-info drac_address\u003ddrac.host \\"},{"line_number":221,"context_line":"        --driver-info redfish_username\u003duser \\"},{"line_number":222,"context_line":"        --driver-info redfish_password\u003dpa$$w0rd \\"},{"line_number":223,"context_line":"        --driver-info redfish_address\u003ddrac.host \\"},{"line_number":224,"context_line":"        --driver-info redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1 \\"},{"line_number":225,"context_line":"        --driver-info ipmi_username\u003duser \\"},{"line_number":226,"context_line":"        --driver-info ipmi_password\u003dpa$$w0rd \\"},{"line_number":227,"context_line":"        --driver-info ipmi_address\u003ddrac.host \\"},{"line_number":228,"context_line":"        --bios-interface idrac-redfish \\"},{"line_number":229,"context_line":"        --inspect-interface idrac-redfish \\"},{"line_number":230,"context_line":"        --management-interface idrac-redfish \\"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6373bb5a_96cfaffb","line":227,"range":{"start_line":218,"start_character":0,"end_line":227,"end_character":46},"updated":"2021-02-18 08:36:19.000000000","message":"side comment: I can\u0027t imagine support folks being happy about this :( Since it is now 3x the number of things to be checked and asserted.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":true,"context_lines":[{"line_number":215,"context_line":".. code-block:: bash"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    baremetal node create --driver idrac \\"},{"line_number":218,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":219,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":220,"context_line":"        --driver-info drac_address\u003ddrac.host \\"},{"line_number":221,"context_line":"        --driver-info redfish_username\u003duser \\"},{"line_number":222,"context_line":"        --driver-info redfish_password\u003dpa$$w0rd \\"},{"line_number":223,"context_line":"        --driver-info redfish_address\u003ddrac.host \\"},{"line_number":224,"context_line":"        --driver-info redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1 \\"},{"line_number":225,"context_line":"        --driver-info ipmi_username\u003duser \\"},{"line_number":226,"context_line":"        --driver-info ipmi_password\u003dpa$$w0rd \\"},{"line_number":227,"context_line":"        --driver-info ipmi_address\u003ddrac.host \\"},{"line_number":228,"context_line":"        --bios-interface idrac-redfish \\"},{"line_number":229,"context_line":"        --inspect-interface idrac-redfish \\"},{"line_number":230,"context_line":"        --management-interface idrac-redfish \\"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c7206ee5_0c2939e0","line":227,"range":{"start_line":218,"start_character":0,"end_line":227,"end_character":46},"in_reply_to":"6373bb5a_96cfaffb","updated":"2021-02-22 16:33:59.000000000","message":"I agree with this ,but these changes is not in the scope of this patch","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":8,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is an out-of-band"},{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b7260e2c_628cc4ab","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":35},"updated":"2021-02-23 01:43:56.000000000","message":"nit: Since this sentence now lists three protocols, instead of two, please replace the \u0027and\u0027 here with a comma. Also, \u0027protocol\u0027 and \u0027the\u0027 can be removed. I realize those were in the original text. TL;DR,\n\ns/ protocol and the/,/","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is an out-of-band"},{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0ec36f93_721d0aec","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":35},"in_reply_to":"b7260e2c_628cc4ab","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":8,"id":"58e7a2de_53dfd5a5","line":12,"range":{"start_line":12,"start_character":59,"end_line":12,"end_character":72},"updated":"2021-02-23 01:43:56.000000000","message":"How about if we change this to the possessive \u0027its\u0027? TL/DR,\n\ns/all of driver/its/","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":8,"id":"e37aa918_9edbb74e","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":47},"updated":"2021-02-23 01:43:56.000000000","message":"nit: \u0027protocol\u0027 is referring to the three protocols listed before it, so it should be plural \u0027protocols\u0027.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":8,"id":"38f05927_5585cc18","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":29},"updated":"2021-02-23 01:43:56.000000000","message":"nit: An Oxford (serial) comma is preferred. \u0027protocol\u0027 may be removed, because it is redundant. I realize it was in the original text. TL;DR,\n\ns/ protocol/,/","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":8,"id":"b826d170_91496f33","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":29},"in_reply_to":"38f05927_5585cc18","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3d3e0d88_7353c28e","line":12,"range":{"start_line":12,"start_character":59,"end_line":12,"end_character":72},"in_reply_to":"58e7a2de_53dfd5a5","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"management platform on Dell EMC servers, and is supported directly by"},{"line_number":10,"context_line":"the ``idrac`` hardware type. This driver uses the Dell Web Services for"},{"line_number":11,"context_line":"Management (WSMAN) protocol and the standard Distributed Management Task"},{"line_number":12,"context_line":"Force (DMTF) Redfish protocol and IPMI protocol to perform all of driver functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."}],"source_content_type":"text/x-rst","patch_set":8,"id":"bd6ec956_0d23a30b","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":47},"in_reply_to":"e37aa918_9edbb74e","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":55,"context_line":"The iDRAC driver supports WSMAN for the bios, inspect, management, power,"},{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. The driver supports IPMI for"},{"line_number":58,"context_line":"the management, power, console, and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN, IPMI, and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"}],"source_content_type":"text/x-rst","patch_set":8,"id":"067b7920_36c0d840","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":30},"updated":"2021-02-23 01:43:56.000000000","message":"nit: In this paragraph, the interfaces supported by each protocol are listed in alphabetical order. Please list \u0027console\u0027 before \u0027management\u0027.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"The iDRAC driver supports WSMAN for the bios, inspect, management, power,"},{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. The driver supports IPMI for"},{"line_number":58,"context_line":"the management, power, console, and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN, IPMI, and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7104d166_e69acc6a","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":30},"in_reply_to":"067b7920_36c0d840","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. The driver supports IPMI for"},{"line_number":58,"context_line":"the management, power, console, and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN, IPMI, and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"}],"source_content_type":"text/x-rst","patch_set":8,"id":"e63268f7_05fc7ea0","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":39},"updated":"2021-02-23 01:43:56.000000000","message":"Let us be consistent in the ordering of the protocols.\n\n1. WSMan\n2. Redfish\n3. IPMI","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":57,"context_line":"the bios, inspect, management, and power interfaces. The driver supports IPMI for"},{"line_number":58,"context_line":"the management, power, console, and vendor interfaces.The iDRAC driver"},{"line_number":59,"context_line":"allows you to mix and match WSMAN, IPMI, and Redfish interfaces."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"}],"source_content_type":"text/x-rst","patch_set":8,"id":"504b0080_106886e8","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":39},"in_reply_to":"e63268f7_05fc7ea0","updated":"2021-02-25 14:39:10.000000000","message":"Ack","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"},{"line_number":63,"context_line":"to use Redfish for an interface. The ``idrac-ipmi`` implementation"},{"line_number":64,"context_line":"must be enabled to use IPMI for an interface."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8ce20744_f4d8c71e","line":63,"range":{"start_line":63,"start_character":39,"end_line":63,"end_character":49},"updated":"2021-02-23 01:43:56.000000000","message":"To follow the pattern established when the iDRAC driver added support for Redfish, let us name the new iDRAC IPMI hardware interface implementations idrac-ipmitool*. That suggests they are similar to the interface implementations from which they are derived.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The ``idrac-wsman`` implementation must be enabled to use WSMAN for"},{"line_number":62,"context_line":"an interface. The ``idrac-redfish`` implementation must be enabled"},{"line_number":63,"context_line":"to use Redfish for an interface. The ``idrac-ipmi`` implementation"},{"line_number":64,"context_line":"must be enabled to use IPMI for an interface."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"436a2a7a_747f38f6","line":63,"range":{"start_line":63,"start_character":39,"end_line":63,"end_character":49},"in_reply_to":"8ce20744_f4d8c71e","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``no-console``, ``idrac-ipmi``"},{"line_number":104,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"},{"line_number":105,"context_line":"``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":106,"context_line":"                     ``inspector``, ``no-inspect``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"6ebd74b9_9b23d1a5","line":103,"range":{"start_line":103,"start_character":37,"end_line":103,"end_character":51},"updated":"2021-02-23 01:43:56.000000000","message":"This table lists the supported interface implementations in the priority order they are supported by the iDRAC type, from highest to lowest priority. Please list idrac-ipmitool* before no-console.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``no-console``, ``idrac-ipmi``"},{"line_number":104,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"},{"line_number":105,"context_line":"``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":106,"context_line":"                     ``inspector``, ``no-inspect``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"70459915_0d730a62","line":103,"range":{"start_line":103,"start_character":37,"end_line":103,"end_character":51},"in_reply_to":"6ebd74b9_9b23d1a5","updated":"2021-02-25 14:39:10.000000000","message":"idrac-ipmitool-socatconsole also added","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":104,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"},{"line_number":105,"context_line":"``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":106,"context_line":"                     ``inspector``, ``no-inspect``"},{"line_number":107,"context_line":"``management``       ``idrac-wsman``, ``idrac``, ``idrac-redfish``, ``idrac-ipmi``"},{"line_number":108,"context_line":"``network``          ``flat``, ``neutron``, ``noop``"},{"line_number":109,"context_line":"``power``            ``idrac-wsman``, ``idrac``, ``idrac-redfish``, ``idrac-ipmi``"},{"line_number":110,"context_line":"``raid``             ``idrac-wsman``, ``idrac``, ``no-raid``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b536119c_98177049","line":107,"updated":"2021-02-23 01:43:56.000000000","message":"nit: OpenStack documentation general guidelines state each line should not be more than 79 characters [1]. This applies to other lines this change has modified.\n\n[1] https://docs.openstack.org/doc-contrib-guide/rst-conv/general-guidelines.html#lines-length","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"},{"line_number":105,"context_line":"``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":106,"context_line":"                     ``inspector``, ``no-inspect``"},{"line_number":107,"context_line":"``management``       ``idrac-wsman``, ``idrac``, ``idrac-redfish``, ``idrac-ipmi``"},{"line_number":108,"context_line":"``network``          ``flat``, ``neutron``, ``noop``"},{"line_number":109,"context_line":"``power``            ``idrac-wsman``, ``idrac``, ``idrac-redfish``, ``idrac-ipmi``"},{"line_number":110,"context_line":"``raid``             ``idrac-wsman``, ``idrac``, ``no-raid``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b8cf760d_e91b1444","line":107,"in_reply_to":"b536119c_98177049","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":110,"context_line":"``raid``             ``idrac-wsman``, ``idrac``, ``no-raid``"},{"line_number":111,"context_line":"``rescue``           ``no-rescue``, ``agent``"},{"line_number":112,"context_line":"``storage``          ``noop``, ``cinder``, ``external``"},{"line_number":113,"context_line":"``vendor``           ``idrac-wsman``, ``idrac``, ``idrac-redfish``, ``no-vendor``, ``idrac-ipmi``"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"100b629c_d25e81f5","line":113,"range":{"start_line":113,"start_character":83,"end_line":113,"end_character":97},"updated":"2021-02-23 01:43:56.000000000","message":"Ditto re: priority ordering. Please list idrac-ipmitool before no-vendor.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"``raid``             ``idrac-wsman``, ``idrac``, ``no-raid``"},{"line_number":111,"context_line":"``rescue``           ``no-rescue``, ``agent``"},{"line_number":112,"context_line":"``storage``          ``noop``, ``cinder``, ``external``"},{"line_number":113,"context_line":"``vendor``           ``idrac-wsman``, ``idrac``, ``idrac-redfish``, ``no-vendor``, ``idrac-ipmi``"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"e157b6ee_4d6bf6f0","line":113,"range":{"start_line":113,"start_character":83,"end_line":113,"end_character":97},"in_reply_to":"100b629c_d25e81f5","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":121,"context_line":"Protocol-specific Properties"},{"line_number":122,"context_line":"----------------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The WSMAN, IPMI, and Redfish protocols require different properties to be specified"},{"line_number":125,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":126,"context_line":"metal system\u0027s iDRAC."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ad50f1b6_2b4286b4","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":28},"updated":"2021-02-23 01:43:56.000000000","message":"Ditto re: ordering.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Protocol-specific Properties"},{"line_number":122,"context_line":"----------------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The WSMAN, IPMI, and Redfish protocols require different properties to be specified"},{"line_number":125,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":126,"context_line":"metal system\u0027s iDRAC."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"2a23d61d_252ce6aa","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":28},"in_reply_to":"ad50f1b6_2b4286b4","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":159,"context_line":"the WSMAN properties must be supplied. If using only interfaces which"},{"line_number":160,"context_line":"use Redfish (``idrac-redfish``), then only the Redfish properties must be"},{"line_number":161,"context_line":"supplied. If using only interfaces which use IPMI (``idrac-ipmi``), then only"},{"line_number":162,"context_line":"the IPMI properties must be supplied. If using a mix of interfaces, where"},{"line_number":163,"context_line":"some use WSMAN and others use Redfish, both the WSMAN and Redfish properties"},{"line_number":164,"context_line":"must be supplied."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"8c813b3e_40f05638","line":162,"range":{"start_line":162,"start_character":68,"end_line":162,"end_character":73},"updated":"2021-02-23 01:43:56.000000000","message":"To make it clear this is an example, please change this to \"such as where\".","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"the WSMAN properties must be supplied. If using only interfaces which"},{"line_number":160,"context_line":"use Redfish (``idrac-redfish``), then only the Redfish properties must be"},{"line_number":161,"context_line":"supplied. If using only interfaces which use IPMI (``idrac-ipmi``), then only"},{"line_number":162,"context_line":"the IPMI properties must be supplied. If using a mix of interfaces, where"},{"line_number":163,"context_line":"some use WSMAN and others use Redfish, both the WSMAN and Redfish properties"},{"line_number":164,"context_line":"must be supplied."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"2a263898_73856179","line":162,"range":{"start_line":162,"start_character":68,"end_line":162,"end_character":73},"in_reply_to":"8c813b3e_40f05638","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        --management-interface idrac-ipmi \\"},{"line_number":206,"context_line":"        --power-interface idrac-ipmi \\"},{"line_number":207,"context_line":"        --vendor-interface idrac-ipmi \\"},{"line_number":208,"context_line":"        --console-interface idrac-ipmi"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":211,"context_line":"hardware type assuming a mix of Redfish, WSMAN, and IPMI interfaces are used:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0861ae2f_50405fd9","line":208,"updated":"2021-02-23 01:43:56.000000000","message":"nit: Please keep this in alphabetical order by placing it above\n\n    --management-interface idrac-ipmi","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        --management-interface idrac-ipmi \\"},{"line_number":206,"context_line":"        --power-interface idrac-ipmi \\"},{"line_number":207,"context_line":"        --vendor-interface idrac-ipmi \\"},{"line_number":208,"context_line":"        --console-interface idrac-ipmi"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":211,"context_line":"hardware type assuming a mix of Redfish, WSMAN, and IPMI interfaces are used:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"85fc0975_570c35b6","line":208,"in_reply_to":"0861ae2f_50405fd9","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":".. NOTE::"},{"line_number":232,"context_line":"   If using WSMAN for the management interface, then WSMAN must be  used"},{"line_number":233,"context_line":"   for the power interface. The same applies to Redfish. It is currently not"},{"line_number":234,"context_line":"   possible to use Redfish for one and WSMAN for the other."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"BIOS Interface"},{"line_number":237,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f00402b6_32b25925","line":234,"range":{"start_line":233,"start_character":27,"end_line":234,"end_character":59},"updated":"2021-02-23 01:43:56.000000000","message":"I feel this note would be clearer if this sentence were deleted.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":".. NOTE::"},{"line_number":232,"context_line":"   If using WSMAN for the management interface, then WSMAN must be  used"},{"line_number":233,"context_line":"   for the power interface. The same applies to Redfish. It is currently not"},{"line_number":234,"context_line":"   possible to use Redfish for one and WSMAN for the other."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"BIOS Interface"},{"line_number":237,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"e6a152d0_ffe44e8e","line":234,"range":{"start_line":233,"start_character":27,"end_line":234,"end_character":59},"in_reply_to":"f00402b6_32b25925","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":202,"context_line":".. NOTE::"},{"line_number":203,"context_line":"   If using WSMAN for the management interface, then WSMAN must be  used"},{"line_number":204,"context_line":"   for the power interface. The same applies to Redfish. It is currently not"},{"line_number":205,"context_line":"   possible to use Redfish for one and WSMAN for the other."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"BIOS Interface"},{"line_number":208,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"b0e84942_d6bdb01b","side":"PARENT","line":205,"updated":"2021-03-25 11:42:31.000000000","message":"Why is this deleted? Has this changed? Does it also apply to IPMI?","commit_id":"4a3bbf6d28eeede0bab36cf7ed412192c2300a1f"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":true,"context_lines":[{"line_number":202,"context_line":".. NOTE::"},{"line_number":203,"context_line":"   If using WSMAN for the management interface, then WSMAN must be  used"},{"line_number":204,"context_line":"   for the power interface. The same applies to Redfish. It is currently not"},{"line_number":205,"context_line":"   possible to use Redfish for one and WSMAN for the other."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"BIOS Interface"},{"line_number":208,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"b03f9405_99507ea1","side":"PARENT","line":205,"in_reply_to":"b0e84942_d6bdb01b","updated":"2021-03-26 07:57:11.000000000","message":"as this sentence were not clearer its deleted according to Richard comment\nhttps://review.opendev.org/c/openstack/ironic/+/771862/8/doc/source/admin/drivers/idrac.rst#234","commit_id":"4a3bbf6d28eeede0bab36cf7ed412192c2300a1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Interface            Supported Implementations"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``idrac-ipmitool-shellinabox``, ``idrac-ipmitool-socatconsole``,"},{"line_number":104,"context_line":"                     ``no-console``"},{"line_number":105,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"b4179845_88802977","line":102,"range":{"start_line":102,"start_character":38,"end_line":102,"end_character":71},"updated":"2021-03-25 11:42:31.000000000","message":"this change is not part of the patch, looks like smth that was added with rebasing.","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Interface            Supported Implementations"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``idrac-ipmitool-shellinabox``, ``idrac-ipmitool-socatconsole``,"},{"line_number":104,"context_line":"                     ``no-console``"},{"line_number":105,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ec7c3657_5284ce3b","line":102,"range":{"start_line":102,"start_character":38,"end_line":102,"end_character":71},"in_reply_to":"6cd05d79_46bd1d05","updated":"2021-03-26 13:32:54.000000000","message":"Done","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Interface            Supported Implementations"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``idrac-ipmitool-shellinabox``, ``idrac-ipmitool-socatconsole``,"},{"line_number":104,"context_line":"                     ``no-console``"},{"line_number":105,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"6cd05d79_46bd1d05","line":102,"range":{"start_line":102,"start_character":38,"end_line":102,"end_character":71},"in_reply_to":"b4179845_88802977","updated":"2021-03-26 07:57:11.000000000","message":"Yes its added during rebase","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``idrac-ipmitool-shellinabox``, ``idrac-ipmitool-socatconsole``,"},{"line_number":104,"context_line":"                     ``no-console``"},{"line_number":105,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"},{"line_number":106,"context_line":"``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ed958b05_04e4214a","line":103,"range":{"start_line":103,"start_character":23,"end_line":103,"end_character":84},"updated":"2021-03-25 11:42:31.000000000","message":"when changing order in drac.py, need to update here too","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"``bios``             ``idrac-wsman``, ``idrac-redfish``, ``no-bios``"},{"line_number":102,"context_line":"``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``"},{"line_number":103,"context_line":"``console``          ``idrac-ipmitool-shellinabox``, ``idrac-ipmitool-socatconsole``,"},{"line_number":104,"context_line":"                     ``no-console``"},{"line_number":105,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"},{"line_number":106,"context_line":"``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"0bcd2405_60ce3fac","line":103,"range":{"start_line":103,"start_character":23,"end_line":103,"end_character":84},"in_reply_to":"ed958b05_04e4214a","updated":"2021-03-26 07:57:11.000000000","message":"Done","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                     ``idrac-ipmitool``"},{"line_number":110,"context_line":"``network``          ``flat``, ``neutron``, ``noop``"},{"line_number":111,"context_line":"``power``            ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":112,"context_line":"                     ``idrac-ipmitool``"},{"line_number":113,"context_line":"``raid``             ``idrac-wsman``, ``idrac``, ``no-raid``"},{"line_number":114,"context_line":"``rescue``           ``no-rescue``, ``agent``"},{"line_number":115,"context_line":"``storage``          ``noop``, ``cinder``, ``external``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e3b6021a_be67bd2c","line":112,"range":{"start_line":112,"start_character":22,"end_line":112,"end_character":37},"updated":"2021-03-26 13:32:54.000000000","message":"should be put back for power and vendor interfaces","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                     ``idrac-ipmitool``"},{"line_number":110,"context_line":"``network``          ``flat``, ``neutron``, ``noop``"},{"line_number":111,"context_line":"``power``            ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":112,"context_line":"                     ``idrac-ipmitool``"},{"line_number":113,"context_line":"``raid``             ``idrac-wsman``, ``idrac``, ``no-raid``"},{"line_number":114,"context_line":"``rescue``           ``no-rescue``, ``agent``"},{"line_number":115,"context_line":"``storage``          ``noop``, ``cinder``, ``external``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"b00067dd_7e82ec8b","line":112,"range":{"start_line":112,"start_character":22,"end_line":112,"end_character":37},"in_reply_to":"e3b6021a_be67bd2c","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":214,"context_line":"        --vendor-interface idrac-ipmitool"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":217,"context_line":"hardware type assuming a mix of WSMAN, Redfish, and IPMI interfaces are used:"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":".. code-block:: bash"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"aee70862_166dd925","line":217,"range":{"start_line":217,"start_character":14,"end_line":217,"end_character":31},"updated":"2021-03-25 11:42:31.000000000","message":"I don\u0027t see that this is the mix of WS-Man, Redfish and IPMI. It has converged to idrac-redfish only in previous updates :) Let\u0027s update to have different interfaces from all 3 that make sense.","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        --vendor-interface idrac-ipmitool"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":217,"context_line":"hardware type assuming a mix of WSMAN, Redfish, and IPMI interfaces are used:"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":".. code-block:: bash"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"93c8d1b4_0c6749bc","line":217,"range":{"start_line":217,"start_character":14,"end_line":217,"end_character":31},"in_reply_to":"aee70862_166dd925","updated":"2021-03-26 07:57:11.000000000","message":"Done","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":210,"context_line":"        --vendor-interface idrac-ipmitool"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":213,"context_line":"hardware type to have different interfaces of WSMAN, Redfish, and IPMI"},{"line_number":214,"context_line":"interfaces are used:"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":12,"id":"e8d211a6_1dd805cc","line":213,"range":{"start_line":213,"start_character":14,"end_line":213,"end_character":42},"updated":"2021-03-26 13:32:54.000000000","message":"and a mix","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        --vendor-interface idrac-ipmitool"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The following command enrolls a bare metal node with the ``idrac``"},{"line_number":213,"context_line":"hardware type to have different interfaces of WSMAN, Redfish, and IPMI"},{"line_number":214,"context_line":"interfaces are used:"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":12,"id":"96e419d0_642eb904","line":213,"range":{"start_line":213,"start_character":14,"end_line":213,"end_character":42},"in_reply_to":"e8d211a6_1dd805cc","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        --driver-info ipmi_username\u003duser \\"},{"line_number":227,"context_line":"        --driver-info ipmi_password\u003dpa$$w0rd \\"},{"line_number":228,"context_line":"        --driver-info ipmi_address\u003ddrac.host \\"},{"line_number":229,"context_line":"        --bios-interface idrac-redfish \\"},{"line_number":230,"context_line":"        --inspect-interface idrac-redfish \\"},{"line_number":231,"context_line":"        --management-interface idrac-redfish \\"},{"line_number":232,"context_line":"        --power-interface idrac-redfish"}],"source_content_type":"text/x-rst","patch_set":12,"id":"0a822264_33626b89","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":1},"updated":"2021-03-26 13:32:54.000000000","message":"let\u0027s update ln 232-235 to represent this setup:\n\nIPMI - power, management, vendor, console\nWS-Man - RAID, BIOS, inspect\nRedfish - boot (virtual-media-boot)\n\nand make sure the interfaces are in alphabetical order","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        --driver-info ipmi_username\u003duser \\"},{"line_number":227,"context_line":"        --driver-info ipmi_password\u003dpa$$w0rd \\"},{"line_number":228,"context_line":"        --driver-info ipmi_address\u003ddrac.host \\"},{"line_number":229,"context_line":"        --bios-interface idrac-redfish \\"},{"line_number":230,"context_line":"        --inspect-interface idrac-redfish \\"},{"line_number":231,"context_line":"        --management-interface idrac-redfish \\"},{"line_number":232,"context_line":"        --power-interface idrac-redfish"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7a85e007_a6dd8bda","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":1},"in_reply_to":"0a822264_33626b89","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8bbc368976df993c489fa4869007a015888bfce1","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        --driver-info ipmi_password\u003dpa$$w0rd \\"},{"line_number":229,"context_line":"        --driver-info ipmi_address\u003ddrac.host \\"},{"line_number":230,"context_line":"        --console-interface idrac-ipmitool-socatconsole \\"},{"line_number":231,"context_line":"        --management-interface idrac-ipmitool \\"},{"line_number":232,"context_line":"        --power-interface idrac-ipmitool \\"},{"line_number":233,"context_line":"        --vendor-interface idrac-ipmitool \\"},{"line_number":234,"context_line":"        --raid-interface idrac-wsman \\"}],"source_content_type":"text/x-rst","patch_set":13,"id":"81a32126_a7bbadd3","line":231,"updated":"2021-03-29 12:44:03.000000000","message":"order alphabetically by interface names bios, boot, console, ...","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5d6018b29d14a782218ea5f4b36b85883108fa14","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        --driver-info ipmi_password\u003dpa$$w0rd \\"},{"line_number":229,"context_line":"        --driver-info ipmi_address\u003ddrac.host \\"},{"line_number":230,"context_line":"        --console-interface idrac-ipmitool-socatconsole \\"},{"line_number":231,"context_line":"        --management-interface idrac-ipmitool \\"},{"line_number":232,"context_line":"        --power-interface idrac-ipmitool \\"},{"line_number":233,"context_line":"        --vendor-interface idrac-ipmitool \\"},{"line_number":234,"context_line":"        --raid-interface idrac-wsman \\"}],"source_content_type":"text/x-rst","patch_set":13,"id":"d8e02130_2a1f5848","line":231,"in_reply_to":"81a32126_a7bbadd3","updated":"2021-03-29 15:20:22.000000000","message":"Done","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"}],"ironic/drivers/drac.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91a03e83cbbe4c0d1ac056767a6d02e5186f7769","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    def supported_management_interfaces(self):"},{"line_number":49,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":50,"context_line":"        return [management.DracWSManManagement, management.DracManagement,"},{"line_number":51,"context_line":"                management.DracIPMIManagement,"},{"line_number":52,"context_line":"                management.DracRedfishManagement]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":6,"id":"04306161_59e6dcee","line":51,"updated":"2021-02-18 08:13:57.000000000","message":"So this puts IPMI as the priority over redfish. Is this intentional? It doesn\u0027t match the power interface option, which will create a mismatched driver if the interfaces are not all declared together. Granted, if someone populates all of the possible authentication parameters, it should work just fine, but it is not ideal nor something I would want to support with a customer that went and did things manually and then was frustrated at differing behaviors.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def supported_management_interfaces(self):"},{"line_number":49,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":50,"context_line":"        return [management.DracWSManManagement, management.DracManagement,"},{"line_number":51,"context_line":"                management.DracIPMIManagement,"},{"line_number":52,"context_line":"                management.DracRedfishManagement]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":6,"id":"ac1c9597_597e88eb","line":51,"in_reply_to":"04306161_59e6dcee","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91a03e83cbbe4c0d1ac056767a6d02e5186f7769","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def supported_power_interfaces(self):"},{"line_number":56,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":57,"context_line":"        return [power.DracWSManPower, power.DracPower, power.DracRedfishPower,"},{"line_number":58,"context_line":"                power.DracIPMIPower]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Optional hardware interfaces"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d715444c_ab5450c4","line":58,"updated":"2021-02-18 08:13:57.000000000","message":"This puts Redfish power management before IPMI power management. Mismatches with the list of management interfaces.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def supported_power_interfaces(self):"},{"line_number":56,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":57,"context_line":"        return [power.DracWSManPower, power.DracPower, power.DracRedfishPower,"},{"line_number":58,"context_line":"                power.DracIPMIPower]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Optional hardware interfaces"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ed3fe202_ddb5093b","line":58,"in_reply_to":"d715444c_ab5450c4","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91a03e83cbbe4c0d1ac056767a6d02e5186f7769","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        \"\"\"List of supported vendor interfaces.\"\"\""},{"line_number":86,"context_line":"        return [vendor_passthru.DracWSManVendorPassthru,"},{"line_number":87,"context_line":"                vendor_passthru.DracVendorPassthru, noop.NoVendor,"},{"line_number":88,"context_line":"                vendor_passthru.DracIPMIVendorPassthru]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @property"},{"line_number":91,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"13f0340b_b07f4aae","line":88,"updated":"2021-02-18 08:13:57.000000000","message":"Is IPMI after NoVendor intentional? I guess both would have to be explicitly enabled.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\"List of supported vendor interfaces.\"\"\""},{"line_number":86,"context_line":"        return [vendor_passthru.DracWSManVendorPassthru,"},{"line_number":87,"context_line":"                vendor_passthru.DracVendorPassthru, noop.NoVendor,"},{"line_number":88,"context_line":"                vendor_passthru.DracIPMIVendorPassthru]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @property"},{"line_number":91,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b77f1783_00def86d","line":88,"in_reply_to":"13f0340b_b07f4aae","updated":"2021-02-22 16:33:59.000000000","message":"Done","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    @property"},{"line_number":92,"context_line":"    def supported_console_interfaces(self):"},{"line_number":93,"context_line":"        \"\"\"List of supported console interfaces.\"\"\""},{"line_number":94,"context_line":"        return [console.DracIPMIConsole]"}],"source_content_type":"text/x-python","patch_set":8,"id":"2305590a_d76f99a8","line":94,"updated":"2021-02-23 01:43:56.000000000","message":"noop.NoConsole should be supported at the lowest priority. Please add it to the end of the list.\n\n    return [console.DracIPMIConsole] + super(\n        IDRACHardware, self).supported_console_interfaces","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    @property"},{"line_number":92,"context_line":"    def supported_console_interfaces(self):"},{"line_number":93,"context_line":"        \"\"\"List of supported console interfaces.\"\"\""},{"line_number":94,"context_line":"        return [console.DracIPMIConsole]"}],"source_content_type":"text/x-python","patch_set":8,"id":"86879710_a9e01b2e","line":94,"in_reply_to":"2305590a_d76f99a8","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"99105f2e_f8dbdbd5","line":95,"range":{"start_line":91,"start_character":0,"end_line":95,"end_character":0},"updated":"2021-02-23 01:43:56.000000000","message":"nit: These properties are listed in alphabetical order in their respective section, required or optional hardware interfaces. Please move this up so it is just after supported_bios_interfaces.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9a3b0fa2_898295cf","line":95,"range":{"start_line":91,"start_character":0,"end_line":95,"end_character":0},"in_reply_to":"99105f2e_f8dbdbd5","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"6b6b370635dbe0e4ac14eb40520292c4020cb5da","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    @property"},{"line_number":68,"context_line":"    def supported_console_interfaces(self):"},{"line_number":69,"context_line":"        \"\"\"List of supported console interfaces.\"\"\""},{"line_number":70,"context_line":"        return [console.DracIPMIShellinaboxConsole,"},{"line_number":71,"context_line":"                console.DracIPMISocatConsole] + super("},{"line_number":72,"context_line":"                    IDRACHardware, self).supported_console_interfaces"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"029b500b_97f9d761","line":70,"updated":"2021-03-02 05:53:56.000000000","message":"create node by default it will create a idrac-ipmitool-shellinabox priority over no-console as console interface.","commit_id":"7895cecc773f28626a28c64578266f2a5490676c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    @property"},{"line_number":68,"context_line":"    def supported_console_interfaces(self):"},{"line_number":69,"context_line":"        \"\"\"List of supported console interfaces.\"\"\""},{"line_number":70,"context_line":"        return [console.DracIPMIShellinaboxConsole,"},{"line_number":71,"context_line":"                console.DracIPMISocatConsole] + super("},{"line_number":72,"context_line":"                    IDRACHardware, self).supported_console_interfaces"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"d922fbcf_abc74844","line":70,"updated":"2021-03-25 11:42:31.000000000","message":"better have same order as in ipmi.py","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    @property"},{"line_number":68,"context_line":"    def supported_console_interfaces(self):"},{"line_number":69,"context_line":"        \"\"\"List of supported console interfaces.\"\"\""},{"line_number":70,"context_line":"        return [console.DracIPMIShellinaboxConsole,"},{"line_number":71,"context_line":"                console.DracIPMISocatConsole] + super("},{"line_number":72,"context_line":"                    IDRACHardware, self).supported_console_interfaces"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ebbbf0b8_646ea0e5","line":70,"in_reply_to":"d922fbcf_abc74844","updated":"2021-03-26 07:57:11.000000000","message":"Done","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"}],"ironic/drivers/modules/drac/console.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91a03e83cbbe4c0d1ac056767a6d02e5186f7769","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class DracIPMIConsole(ipmitool.IPMIShellinaboxConsole):"},{"line_number":18,"context_line":"    \"\"\"iDRAC IPMI ConsoleInterface that uses ipmitool and shellinabox.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"34b9e419_133f006d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":73},"updated":"2021-02-18 08:13:57.000000000","message":"You might want to check this, because I\u0027m not sure of many using shellinabox. The preferred solution, afaik is socat console, but apparently shellinabox works these days.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"dfc44ef60b445cd0e5a4ec035a04b2c08375c550","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class DracIPMIConsole(ipmitool.IPMIShellinaboxConsole):"},{"line_number":18,"context_line":"    \"\"\"iDRAC IPMI ConsoleInterface that uses ipmitool and shellinabox.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"6b730be9_df7497a5","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":73},"in_reply_to":"34b9e419_133f006d","updated":"2021-02-22 16:33:59.000000000","message":"shellinabox used in the ilo also, please refer the below code , and with the testing i found out shellinabox works\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/ilo/console.py#L28","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":8,"id":"225f9e94_95125e96","line":1,"updated":"2021-02-23 01:43:56.000000000","message":"Please add a copyright notice as the first line.\n\n    # Copyright (c) 2021 Dell Inc. or its subsidiaries.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":8,"id":"c2e42c35_ae5364b3","line":1,"in_reply_to":"225f9e94_95125e96","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":14,"context_line":"from ironic.drivers.modules import ipmitool"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class DracIPMIConsole(ipmitool.IPMIShellinaboxConsole):"},{"line_number":18,"context_line":"    \"\"\"iDRAC IPMI ConsoleInterface that uses ipmitool and shellinabox.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"09b6b87b_e6856315","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":21},"updated":"2021-02-23 01:43:56.000000000","message":"Please rename this DracIPMIShellinaboxConsole.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from ironic.drivers.modules import ipmitool"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class DracIPMIConsole(ipmitool.IPMIShellinaboxConsole):"},{"line_number":18,"context_line":"    \"\"\"iDRAC IPMI ConsoleInterface that uses ipmitool and shellinabox.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"91a5b3b8_bf558d68","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":21},"in_reply_to":"09b6b87b_e6856315","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class DracIPMIConsole(ipmitool.IPMIShellinaboxConsole):"},{"line_number":18,"context_line":"    \"\"\"iDRAC IPMI ConsoleInterface that uses ipmitool and shellinabox.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ac85f4de_f53ac1a0","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":18},"updated":"2021-02-23 01:43:56.000000000","message":"This word may be deleted.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class DracIPMIConsole(ipmitool.IPMIShellinaboxConsole):"},{"line_number":18,"context_line":"    \"\"\"iDRAC IPMI ConsoleInterface that uses ipmitool and shellinabox.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"32204a42_4432c2a9","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":18},"in_reply_to":"ac85f4de_f53ac1a0","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"44decdbb_18802fb8","line":19,"updated":"2021-02-23 01:43:56.000000000","message":"Should this class implement get_properties() and validate() like the ilo driver\u0027s implementation [1] does?\n\nCould the IPMI socat console be supported, too?\n\n[1] https://opendev.org/openstack/ironic/src/commit/2020a5070f680a8c34c21831df6e551dcfcb6cc3/ironic/drivers/modules/ilo/console.py#L31-L52","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a0b0055a_fb5cd186","line":19,"in_reply_to":"44decdbb_18802fb8","updated":"2021-02-25 14:39:10.000000000","message":"validation and get_property is already done in IPMIConsole any other field validation not required\n\nIPMI socat console is supported added a new class","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":12,"id":"a6c6b6d7_2f244a15","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":51},"updated":"2021-03-26 13:32:54.000000000","message":"move this one line up to remove blank line at the beginning and leave one line before actual license","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":12,"id":"cb726e45_144860a1","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":51},"in_reply_to":"a6c6b6d7_2f244a15","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8bbc368976df993c489fa4869007a015888bfce1","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    \"\"\"iDRAC ConsoleInterface that uses ipmitool and shellinabox."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Presently, this class entirely defers to its base class, a generic,"},{"line_number":22,"context_line":"    vendor-independent IPMI interface. Future resolution of Dell EMC-"},{"line_number":23,"context_line":"    specific incompatibilities and introduction of vendor value added"},{"line_number":24,"context_line":"    should be implemented by this class."},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"f374cf49_9b47da4b","line":22,"range":{"start_line":22,"start_character":60,"end_line":22,"end_character":68},"updated":"2021-03-29 12:44:03.000000000","message":"Dell Technologies, same below","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5d6018b29d14a782218ea5f4b36b85883108fa14","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \"\"\"iDRAC ConsoleInterface that uses ipmitool and shellinabox."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Presently, this class entirely defers to its base class, a generic,"},{"line_number":22,"context_line":"    vendor-independent IPMI interface. Future resolution of Dell EMC-"},{"line_number":23,"context_line":"    specific incompatibilities and introduction of vendor value added"},{"line_number":24,"context_line":"    should be implemented by this class."},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"21820be1_f7879cd9","line":22,"range":{"start_line":22,"start_character":60,"end_line":22,"end_character":68},"in_reply_to":"f374cf49_9b47da4b","updated":"2021-03-29 15:20:22.000000000","message":"Done","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"}],"ironic/drivers/modules/drac/management.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"# Copyright (c) 2017-2020 Dell Inc. or its subsidiaries."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":8,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"bc6efc31_e6ccec76","line":5,"range":{"start_line":5,"start_character":21,"end_line":5,"end_character":25},"updated":"2021-02-23 01:43:56.000000000","message":"2021","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"# Copyright (c) 2017-2020 Dell Inc. or its subsidiaries."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":8,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"4f628350_de237ee5","line":5,"range":{"start_line":5,"start_character":21,"end_line":5,"end_character":25},"in_reply_to":"bc6efc31_e6ccec76","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":311,"context_line":"    pass"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"class DracIPMIManagement(ipmi_management.IPMIManagement):"},{"line_number":315,"context_line":"    \"\"\"iDRAC IPMI interface for management-related actions.\"\"\""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"class DracWSManManagement(base.ManagementInterface):"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"876ace33_e82c2599","line":317,"range":{"start_line":314,"start_character":0,"end_line":317,"end_character":0},"updated":"2021-02-23 01:43:56.000000000","message":"nit: Please move this definition above class DracRedfishManagement\u0027s.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    pass"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"class DracIPMIManagement(ipmi_management.IPMIManagement):"},{"line_number":315,"context_line":"    \"\"\"iDRAC IPMI interface for management-related actions.\"\"\""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"class DracWSManManagement(base.ManagementInterface):"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"19614991_33630c24","line":317,"range":{"start_line":314,"start_character":0,"end_line":317,"end_character":0},"in_reply_to":"876ace33_e82c2599","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":36,"context_line":"from ironic.drivers.modules.drac import job as drac_job"},{"line_number":37,"context_line":"from ironic.drivers.modules.redfish import management as redfish_management"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"drac_exceptions \u003d importutils.try_import(\u0027dracclient.exceptions\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"f1242768_5528cc4a","side":"PARENT","line":39,"updated":"2021-03-26 13:32:54.000000000","message":"revert line deletion","commit_id":"8e34aa53ce24bb09ff3fed55dcdfc9094539ce03"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ironic.drivers.modules.drac import job as drac_job"},{"line_number":37,"context_line":"from ironic.drivers.modules.redfish import management as redfish_management"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"drac_exceptions \u003d importutils.try_import(\u0027dracclient.exceptions\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"17acc6e5_d9d26b16","side":"PARENT","line":39,"in_reply_to":"f1242768_5528cc4a","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"8e34aa53ce24bb09ff3fed55dcdfc9094539ce03"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8bbc368976df993c489fa4869007a015888bfce1","unresolved":true,"context_lines":[{"line_number":304,"context_line":"class DracIPMIManagement(ipmi_management.IPMIManagement):"},{"line_number":305,"context_line":"    \"\"\"iDRAC IPMI interface for management-related actions.\"\"\""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"class DracRedfishManagement(redfish_management.RedfishManagement):"},{"line_number":309,"context_line":"    \"\"\"iDRAC Redfish interface for management-related actions."},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"b4181210_dff0e319","line":307,"updated":"2021-03-29 12:44:03.000000000","message":"add block about that it presently defers to its base class","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5d6018b29d14a782218ea5f4b36b85883108fa14","unresolved":false,"context_lines":[{"line_number":304,"context_line":"class DracIPMIManagement(ipmi_management.IPMIManagement):"},{"line_number":305,"context_line":"    \"\"\"iDRAC IPMI interface for management-related actions.\"\"\""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"class DracRedfishManagement(redfish_management.RedfishManagement):"},{"line_number":309,"context_line":"    \"\"\"iDRAC Redfish interface for management-related actions."},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"cb19ee7e_d142bb35","line":307,"in_reply_to":"b4181210_dff0e319","updated":"2021-03-29 15:20:22.000000000","message":"Done","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"}],"ironic/drivers/modules/drac/power.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":175,"context_line":"    pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class DracIPMIPower(ipmi_management.IPMIPower):"},{"line_number":179,"context_line":"    \"\"\"iDRAC IPMI interface for power-related actions.\"\"\""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"class DracWSManPower(base.PowerInterface):"},{"line_number":183,"context_line":"    \"\"\"Interface for power-related actions.\"\"\""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"8eec3b31_4004d6c2","line":181,"range":{"start_line":178,"start_character":0,"end_line":181,"end_character":0},"updated":"2021-02-23 01:43:56.000000000","message":"nit: Please move this definition above class DracRedfishPower\u0027s.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class DracIPMIPower(ipmi_management.IPMIPower):"},{"line_number":179,"context_line":"    \"\"\"iDRAC IPMI interface for power-related actions.\"\"\""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"class DracWSManPower(base.PowerInterface):"},{"line_number":183,"context_line":"    \"\"\"Interface for power-related actions.\"\"\""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"4eb3a872_e3c8b218","line":181,"range":{"start_line":178,"start_character":0,"end_line":181,"end_character":0},"in_reply_to":"8eec3b31_4004d6c2","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8bbc368976df993c489fa4869007a015888bfce1","unresolved":true,"context_lines":[{"line_number":167,"context_line":"class DracIPMIPower(ipmi_management.IPMIPower):"},{"line_number":168,"context_line":"    \"\"\"iDRAC IPMI interface for power-related actions.\"\"\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class DracRedfishPower(redfish_power.RedfishPower):"},{"line_number":172,"context_line":"    \"\"\"iDRAC Redfish interface for power-related actions."},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7145e6d9_59b8986d","line":170,"updated":"2021-03-29 12:44:03.000000000","message":"block about deferring","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5d6018b29d14a782218ea5f4b36b85883108fa14","unresolved":false,"context_lines":[{"line_number":167,"context_line":"class DracIPMIPower(ipmi_management.IPMIPower):"},{"line_number":168,"context_line":"    \"\"\"iDRAC IPMI interface for power-related actions.\"\"\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class DracRedfishPower(redfish_power.RedfishPower):"},{"line_number":172,"context_line":"    \"\"\"iDRAC Redfish interface for power-related actions."},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bbd668a0_c11c856c","line":170,"in_reply_to":"7145e6d9_59b8986d","updated":"2021-03-29 15:20:22.000000000","message":"Done","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"}],"ironic/drivers/modules/drac/vendor_passthru.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"59a7be52_67ad5fe7","line":206,"range":{"start_line":202,"start_character":0,"end_line":206,"end_character":0},"updated":"2021-02-23 01:43:56.000000000","message":"nit: Please move this definition above class DracWSManVendorPassthru\u0027s.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4470d901_25e52201","line":206,"range":{"start_line":202,"start_character":0,"end_line":206,"end_character":0},"in_reply_to":"59a7be52_67ad5fe7","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class DracIPMIVendorPassthru(ipmi_management.VendorPassthru):"},{"line_number":198,"context_line":"    \"\"\"iDRAC IPMI interface for VendorPassthru.\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class DracRedfishVendorPassthru(redfish_vendor.RedfishVendorPassthru):"}],"source_content_type":"text/x-python","patch_set":12,"id":"b6c89ec4_99159d2a","line":198,"range":{"start_line":198,"start_character":32,"end_line":198,"end_character":46},"updated":"2021-03-26 13:32:54.000000000","message":"something to check","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e33068a5798e7e204f5a269e2125fceee086bf40","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class DracIPMIVendorPassthru(ipmi_management.VendorPassthru):"},{"line_number":198,"context_line":"    \"\"\"iDRAC IPMI interface for VendorPassthru.\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class DracRedfishVendorPassthru(redfish_vendor.RedfishVendorPassthru):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dccf01c5_c68f77f7","line":198,"range":{"start_line":198,"start_character":32,"end_line":198,"end_character":46},"in_reply_to":"b6c89ec4_99159d2a","updated":"2021-03-26 23:43:25.000000000","message":"I guess I\u0027m still a bit confused why empty classes are being pre-created. The only reasoning I can see behind it is functionally just to put an idrac label on the driver. If there was actual code differences that needed to be accounted for or supported, that would be a totally different (and quite acceptable) situation.","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class DracIPMIVendorPassthru(ipmi_management.VendorPassthru):"},{"line_number":198,"context_line":"    \"\"\"iDRAC IPMI interface for VendorPassthru.\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class DracRedfishVendorPassthru(redfish_vendor.RedfishVendorPassthru):"}],"source_content_type":"text/x-python","patch_set":12,"id":"83b3737c_af7bdd09","line":198,"range":{"start_line":198,"start_character":32,"end_line":198,"end_character":46},"in_reply_to":"dccf01c5_c68f77f7","updated":"2021-03-29 08:09:22.000000000","message":"Presently, this class is empty, Future resolution of Dell EMC-\nspecific incompatibilities and introduction of vendor value added\nshould be implemented by this class.","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8bbc368976df993c489fa4869007a015888bfce1","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    \"\"\"iDRAC IPMI interface for VendorPassthru."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    Presently, this class entirely defers to its base class, a generic,"},{"line_number":201,"context_line":"    vendor-independent IPMI interface. Future resolution of Dell EMC-"},{"line_number":202,"context_line":"    specific incompatibilities and introduction of vendor value added"},{"line_number":203,"context_line":"    should be implemented by this class."},{"line_number":204,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"832bc737_374410c9","line":201,"range":{"start_line":201,"start_character":60,"end_line":201,"end_character":68},"updated":"2021-03-29 12:44:03.000000000","message":"Dell Technologies","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5d6018b29d14a782218ea5f4b36b85883108fa14","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    \"\"\"iDRAC IPMI interface for VendorPassthru."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    Presently, this class entirely defers to its base class, a generic,"},{"line_number":201,"context_line":"    vendor-independent IPMI interface. Future resolution of Dell EMC-"},{"line_number":202,"context_line":"    specific incompatibilities and introduction of vendor value added"},{"line_number":203,"context_line":"    should be implemented by this class."},{"line_number":204,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"e0ad1327_c99e5614","line":201,"range":{"start_line":201,"start_character":60,"end_line":201,"end_character":68},"in_reply_to":"832bc737_374410c9","updated":"2021-03-29 15:20:22.000000000","message":"Done","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"}],"ironic/tests/unit/drivers/modules/drac/utils.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-vendor\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":42,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-raid\u0027],"},{"line_number":43,"context_line":"                    enabled_bios_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027no-bios\u0027],"},{"line_number":44,"context_line":"                    enabled_console_interfaces\u003d[\u0027idrac-ipmitool-shellinabox\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DictToObj(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"98afe81a_299b1e4b","line":44,"range":{"start_line":44,"start_character":49,"end_line":44,"end_character":75},"updated":"2021-03-25 11:42:31.000000000","message":"is it necessary to add Socat here too?","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-vendor\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":42,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-raid\u0027],"},{"line_number":43,"context_line":"                    enabled_bios_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027no-bios\u0027],"},{"line_number":44,"context_line":"                    enabled_console_interfaces\u003d[\u0027idrac-ipmitool-shellinabox\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DictToObj(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"d58a3ad8_f15d85ca","line":44,"range":{"start_line":44,"start_character":49,"end_line":44,"end_character":75},"in_reply_to":"98afe81a_299b1e4b","updated":"2021-03-26 07:57:11.000000000","message":"not necessary","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                    enabled_boot_interfaces\u003d["},{"line_number":33,"context_line":"                        \u0027idrac-redfish-virtual-media\u0027, \u0027fake\u0027],"},{"line_number":34,"context_line":"                    enabled_power_interfaces\u003d["},{"line_number":35,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":36,"context_line":"                    enabled_management_interfaces\u003d["},{"line_number":37,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":38,"context_line":"                    enabled_inspect_interfaces\u003d["}],"source_content_type":"text/x-python","patch_set":12,"id":"31a315be_2dddaf84","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":62},"updated":"2021-03-26 13:32:54.000000000","message":"remove idrac-ipmitool from power, management and vendor interfaces here","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                    enabled_boot_interfaces\u003d["},{"line_number":33,"context_line":"                        \u0027idrac-redfish-virtual-media\u0027, \u0027fake\u0027],"},{"line_number":34,"context_line":"                    enabled_power_interfaces\u003d["},{"line_number":35,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":36,"context_line":"                    enabled_management_interfaces\u003d["},{"line_number":37,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":38,"context_line":"                    enabled_inspect_interfaces\u003d["}],"source_content_type":"text/x-python","patch_set":12,"id":"fc56e626_21d0c525","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":62},"in_reply_to":"31a315be_2dddaf84","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-vendor\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":42,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-raid\u0027],"},{"line_number":43,"context_line":"                    enabled_bios_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027no-bios\u0027],"},{"line_number":44,"context_line":"                    enabled_console_interfaces\u003d[\u0027idrac-ipmitool-socatconsole\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DictToObj(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"4d3feab4_714d9d7f","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":78},"updated":"2021-03-26 13:32:54.000000000","message":"let\u0027s move this after boot_interfaces at ln 32","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-vendor\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":42,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-raid\u0027],"},{"line_number":43,"context_line":"                    enabled_bios_interfaces\u003d[\u0027idrac-wsman\u0027, \u0027no-bios\u0027],"},{"line_number":44,"context_line":"                    enabled_console_interfaces\u003d[\u0027idrac-ipmitool-socatconsole\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DictToObj(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7de7a5ea_1a48572f","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":78},"in_reply_to":"4d3feab4_714d9d7f","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DictToObj(object):"},{"line_number":48,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, dictionary):"},{"line_number":51,"context_line":"        for key in dictionary:"},{"line_number":52,"context_line":"            setattr(self, key, dictionary[key])"}],"source_content_type":"text/x-python","patch_set":12,"id":"6235bd6c_0574ae14","line":49,"updated":"2021-03-26 13:32:54.000000000","message":"no need for a new line here","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DictToObj(object):"},{"line_number":48,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, dictionary):"},{"line_number":51,"context_line":"        for key in dictionary:"},{"line_number":52,"context_line":"            setattr(self, key, dictionary[key])"}],"source_content_type":"text/x-python","patch_set":12,"id":"54395c7d_d7d4f80f","line":49,"in_reply_to":"6235bd6c_0574ae14","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8bbc368976df993c489fa4869007a015888bfce1","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                    enabled_power_interfaces\u003d["},{"line_number":36,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027],"},{"line_number":37,"context_line":"                    enabled_management_interfaces\u003d["},{"line_number":38,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027],"},{"line_number":39,"context_line":"                    enabled_inspect_interfaces\u003d["},{"line_number":40,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-inspect\u0027],"},{"line_number":41,"context_line":"                    enabled_vendor_interfaces\u003d["}],"source_content_type":"text/x-python","patch_set":13,"id":"3ee0fcae_f1a6ea6d","line":38,"updated":"2021-03-29 12:44:03.000000000","message":"revert new lines","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"5d6018b29d14a782218ea5f4b36b85883108fa14","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                    enabled_power_interfaces\u003d["},{"line_number":36,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027],"},{"line_number":37,"context_line":"                    enabled_management_interfaces\u003d["},{"line_number":38,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027],"},{"line_number":39,"context_line":"                    enabled_inspect_interfaces\u003d["},{"line_number":40,"context_line":"                        \u0027idrac-wsman\u0027, \u0027fake\u0027, \u0027no-inspect\u0027],"},{"line_number":41,"context_line":"                    enabled_vendor_interfaces\u003d["}],"source_content_type":"text/x-python","patch_set":13,"id":"58ff2534_f3f9f1db","line":38,"in_reply_to":"3ee0fcae_f1a6ea6d","updated":"2021-03-29 15:20:22.000000000","message":"Done","commit_id":"b1c28fbbe2de791b48c729660ea7a52525f568ec"}],"ironic/tests/unit/drivers/test_drac.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":46,"context_line":"                    enabled_raid_interfaces\u003d["},{"line_number":47,"context_line":"                        \u0027idrac\u0027, \u0027idrac-wsman\u0027, \u0027no-raid\u0027, \u0027agent\u0027],"},{"line_number":48,"context_line":"                    enabled_vendor_interfaces\u003d["},{"line_number":49,"context_line":"                        \u0027idrac\u0027, \u0027idrac-wsman\u0027, \u0027no-vendor\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":50,"context_line":"                    enabled_bios_interfaces\u003d["},{"line_number":51,"context_line":"                        \u0027idrac-wsman\u0027, \u0027idrac-redfish\u0027, \u0027no-bios\u0027],"},{"line_number":52,"context_line":"                    enabled_console_interfaces\u003d[\u0027idrac-ipmitool-shellinabox\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"b7a4cd32_56784992","line":49,"range":{"start_line":49,"start_character":60,"end_line":49,"end_character":77},"updated":"2021-03-25 11:42:31.000000000","message":"add this before `no-vendor`","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    enabled_raid_interfaces\u003d["},{"line_number":47,"context_line":"                        \u0027idrac\u0027, \u0027idrac-wsman\u0027, \u0027no-raid\u0027, \u0027agent\u0027],"},{"line_number":48,"context_line":"                    enabled_vendor_interfaces\u003d["},{"line_number":49,"context_line":"                        \u0027idrac\u0027, \u0027idrac-wsman\u0027, \u0027no-vendor\u0027, \u0027idrac-ipmitool\u0027],"},{"line_number":50,"context_line":"                    enabled_bios_interfaces\u003d["},{"line_number":51,"context_line":"                        \u0027idrac-wsman\u0027, \u0027idrac-redfish\u0027, \u0027no-bios\u0027],"},{"line_number":52,"context_line":"                    enabled_console_interfaces\u003d[\u0027idrac-ipmitool-shellinabox\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"cedbe679_d5fabb01","line":49,"range":{"start_line":49,"start_character":60,"end_line":49,"end_character":77},"in_reply_to":"b7a4cd32_56784992","updated":"2021-03-26 07:57:11.000000000","message":"Done","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class IDRACHardwareTestCase(db_base.DbTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(IDRACHardwareTestCase, self).setUp()"},{"line_number":33,"context_line":"        self.config_temp_dir(\u0027http_root\u0027, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"f195dcd7_daf28df3","side":"PARENT","line":30,"updated":"2021-03-26 13:32:54.000000000","message":"unrelated line deletion - need to revert","commit_id":"8e34aa53ce24bb09ff3fed55dcdfc9094539ce03"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class IDRACHardwareTestCase(db_base.DbTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(IDRACHardwareTestCase, self).setUp()"},{"line_number":33,"context_line":"        self.config_temp_dir(\u0027http_root\u0027, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"a80c882d_213af107","side":"PARENT","line":30,"in_reply_to":"f195dcd7_daf28df3","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"8e34aa53ce24bb09ff3fed55dcdfc9094539ce03"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                        \u0027idrac-redfish-virtual-media\u0027, \u0027ipxe\u0027, \u0027pxe\u0027],"},{"line_number":36,"context_line":"                    enabled_management_interfaces\u003d["},{"line_number":37,"context_line":"                        \u0027idrac\u0027, \u0027idrac-redfish\u0027, \u0027idrac-wsman\u0027,"},{"line_number":38,"context_line":"                        \u0027idrac-ipmitool\u0027],"},{"line_number":39,"context_line":"                    enabled_power_interfaces\u003d["},{"line_number":40,"context_line":"                        \u0027idrac\u0027, \u0027idrac-redfish\u0027, \u0027idrac-wsman\u0027,"},{"line_number":41,"context_line":"                        \u0027idrac-ipmitool\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"8c089b15_f959d5f7","line":38,"range":{"start_line":38,"start_character":25,"end_line":38,"end_character":39},"updated":"2021-03-26 13:32:54.000000000","message":"here and other lines - add in alphabetical order, so that \u0027idrac-ipmitool\u0027 is after \u0027idrac\u0027","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                        \u0027idrac-redfish-virtual-media\u0027, \u0027ipxe\u0027, \u0027pxe\u0027],"},{"line_number":36,"context_line":"                    enabled_management_interfaces\u003d["},{"line_number":37,"context_line":"                        \u0027idrac\u0027, \u0027idrac-redfish\u0027, \u0027idrac-wsman\u0027,"},{"line_number":38,"context_line":"                        \u0027idrac-ipmitool\u0027],"},{"line_number":39,"context_line":"                    enabled_power_interfaces\u003d["},{"line_number":40,"context_line":"                        \u0027idrac\u0027, \u0027idrac-redfish\u0027, \u0027idrac-wsman\u0027,"},{"line_number":41,"context_line":"                        \u0027idrac-ipmitool\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"cc6c29f2_05075877","line":38,"range":{"start_line":38,"start_character":25,"end_line":38,"end_character":39},"in_reply_to":"8c089b15_f959d5f7","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027idrac\u0027,"},{"line_number":190,"context_line":"                                          console_interface\u003d\u0027idrac-ipmitool-\u0027"},{"line_number":191,"context_line":"                                          \u0027shellinabox\u0027)"},{"line_number":192,"context_line":"        with task_manager.acquire(self.context, node.id) as task:"},{"line_number":193,"context_line":"            self._validate_interfaces(task.driver,"},{"line_number":194,"context_line":"                                      console\u003ddrac.console."},{"line_number":195,"context_line":"                                      DracIPMIShellinaboxConsole)"}],"source_content_type":"text/x-python","patch_set":12,"id":"676abd3d_5deb6fc8","line":192,"updated":"2021-03-26 13:32:54.000000000","message":"reorganize params so \u0027idrac-ipmitool-shellinabox\u0027 is in one line, same below, e.g., \n\n  node \u003d obj_utils.create_test_node(\n      self.context, driver\u003d\u0027idrac\u0027,\n      console_interface\u003d\u0027idrac-ipmitool-shellinabox\u0027)","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027idrac\u0027,"},{"line_number":190,"context_line":"                                          console_interface\u003d\u0027idrac-ipmitool-\u0027"},{"line_number":191,"context_line":"                                          \u0027shellinabox\u0027)"},{"line_number":192,"context_line":"        with task_manager.acquire(self.context, node.id) as task:"},{"line_number":193,"context_line":"            self._validate_interfaces(task.driver,"},{"line_number":194,"context_line":"                                      console\u003ddrac.console."},{"line_number":195,"context_line":"                                      DracIPMIShellinaboxConsole)"}],"source_content_type":"text/x-python","patch_set":12,"id":"74e9d698_e5f7bdd2","line":192,"in_reply_to":"676abd3d_5deb6fc8","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7715974e39c05fe142fa30849d330e1b6e38ade","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                console\u003dnoop.NoConsole,"},{"line_number":210,"context_line":"                vendor\u003ddrac.vendor_passthru.DracIPMIVendorPassthru)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_override_with_idrac_ipmi_socatconsole(self):"},{"line_number":213,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027idrac\u0027,"},{"line_number":214,"context_line":"                                          management_interface\u003d\u0027idrac-\u0027"},{"line_number":215,"context_line":"                                          \u0027ipmitool\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"c70bd0d8_45a84c11","line":212,"range":{"start_line":212,"start_character":8,"end_line":212,"end_character":50},"updated":"2021-03-26 13:32:54.000000000","message":"rename: test_override_with_idrac_ipmi","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"cc861b94dec854bf2375d168f2d88cb848f29eaf","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                console\u003dnoop.NoConsole,"},{"line_number":210,"context_line":"                vendor\u003ddrac.vendor_passthru.DracIPMIVendorPassthru)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_override_with_idrac_ipmi_socatconsole(self):"},{"line_number":213,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027idrac\u0027,"},{"line_number":214,"context_line":"                                          management_interface\u003d\u0027idrac-\u0027"},{"line_number":215,"context_line":"                                          \u0027ipmitool\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"c85bb12d_80f0f5a5","line":212,"range":{"start_line":212,"start_character":8,"end_line":212,"end_character":50},"in_reply_to":"c70bd0d8_45a84c11","updated":"2021-03-29 08:09:22.000000000","message":"Done","commit_id":"a64c15db50740cafabd9bb6fa509b11464edc8ca"}],"releasenotes/notes/idrac-add-ipmi-interface-support-bb86391f9a2badcf.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"718f6c3e312c4679f1c2e12c1d9dd632529c49e7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    * storage: ``noop``, ``cinder``, ``external``"},{"line_number":28,"context_line":"    * vendor: ``idrac-wsman``, ``idrac``, ``no-vendor``,``idrac-ipmi``"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    For more information, see `story 2008528"},{"line_number":31,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2008528\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c96d8bc6_e2fbba2c","line":31,"range":{"start_line":30,"start_character":1,"end_line":31,"end_character":58},"updated":"2021-02-18 08:36:19.000000000","message":"Side comment. Seems like, at a minimum, this should be proposed as a discussion item for rfe review.","commit_id":"39519fc24e3c15059c73d1d42f0d65a28e875d1a"}],"setup.cfg":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":80,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":81,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"},{"line_number":82,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":83,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.console:DracIPMIConsole"},{"line_number":84,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"},{"line_number":85,"context_line":"    ipmitool-socat \u003d ironic.drivers.modules.ipmitool:IPMISocatConsole"},{"line_number":86,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"c422c02a_ac1354a9","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":68},"updated":"2021-02-23 01:43:56.000000000","message":"It looks like these are listed in alphabetical order. Let us maintain that by moving this up so it is just above ilo. This applies elsewhere in this file.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":80,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":81,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"},{"line_number":82,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":83,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.console:DracIPMIConsole"},{"line_number":84,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"},{"line_number":85,"context_line":"    ipmitool-socat \u003d ironic.drivers.modules.ipmitool:IPMISocatConsole"},{"line_number":86,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"89f55c53_df71dac0","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":14},"updated":"2021-02-23 01:43:56.000000000","message":"Please rename this idrac-ipmitool-shellinabox.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":81,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"},{"line_number":82,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":83,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.console:DracIPMIConsole"},{"line_number":84,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"},{"line_number":85,"context_line":"    ipmitool-socat \u003d ironic.drivers.modules.ipmitool:IPMISocatConsole"},{"line_number":86,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"588f1ac1_f6b3a3a1","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":14},"in_reply_to":"89f55c53_df71dac0","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":81,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"},{"line_number":82,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":83,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.console:DracIPMIConsole"},{"line_number":84,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"},{"line_number":85,"context_line":"    ipmitool-socat \u003d ironic.drivers.modules.ipmitool:IPMISocatConsole"},{"line_number":86,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"2a35fd6e_4ae24ff7","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":68},"in_reply_to":"c422c02a_ac1354a9","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    idrac \u003d ironic.drivers.modules.drac.management:DracManagement"},{"line_number":110,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.management:DracRedfishManagement"},{"line_number":111,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.management:DracWSManManagement"},{"line_number":112,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.management:DracIPMIManagement"},{"line_number":113,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.management:IloManagement"},{"line_number":114,"context_line":"    ilo5 \u003d ironic.drivers.modules.ilo.management:Ilo5Management"},{"line_number":115,"context_line":"    intel-ipmitool \u003d ironic.drivers.modules.intel_ipmi.management:IntelIPMIManagement"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"2b62e579_3b3c2901","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":14},"updated":"2021-02-23 01:43:56.000000000","message":"Please rename this idrac-ipmitool.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    idrac \u003d ironic.drivers.modules.drac.management:DracManagement"},{"line_number":110,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.management:DracRedfishManagement"},{"line_number":111,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.management:DracWSManManagement"},{"line_number":112,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.management:DracIPMIManagement"},{"line_number":113,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.management:IloManagement"},{"line_number":114,"context_line":"    ilo5 \u003d ironic.drivers.modules.ilo.management:Ilo5Management"},{"line_number":115,"context_line":"    intel-ipmitool \u003d ironic.drivers.modules.intel_ipmi.management:IntelIPMIManagement"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"cbbc08b9_0f006a97","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":14},"in_reply_to":"2b62e579_3b3c2901","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    idrac \u003d ironic.drivers.modules.drac.power:DracPower"},{"line_number":132,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.power:DracRedfishPower"},{"line_number":133,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.power:DracWSManPower"},{"line_number":134,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.power:DracIPMIPower"},{"line_number":135,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.power:IloPower"},{"line_number":136,"context_line":"    ipmitool \u003d ironic.drivers.modules.ipmitool:IPMIPower"},{"line_number":137,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.power:IRMCPower"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"8ddb6bbf_d8622557","line":134,"range":{"start_line":134,"start_character":4,"end_line":134,"end_character":14},"updated":"2021-02-23 01:43:56.000000000","message":"Please rename this idrac-ipmitool.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    idrac \u003d ironic.drivers.modules.drac.power:DracPower"},{"line_number":132,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.power:DracRedfishPower"},{"line_number":133,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.power:DracWSManPower"},{"line_number":134,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.power:DracIPMIPower"},{"line_number":135,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.power:IloPower"},{"line_number":136,"context_line":"    ipmitool \u003d ironic.drivers.modules.ipmitool:IPMIPower"},{"line_number":137,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.power:IRMCPower"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"66d2be37_a196f9e8","line":134,"range":{"start_line":134,"start_character":4,"end_line":134,"end_character":14},"in_reply_to":"8ddb6bbf_d8622557","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"622af349768cfd002bf36a68fffa5c587d4cd1db","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    idrac \u003d ironic.drivers.modules.drac.vendor_passthru:DracVendorPassthru"},{"line_number":167,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.vendor_passthru:DracWSManVendorPassthru"},{"line_number":168,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.vendor_passthru:DracRedfishVendorPassthru"},{"line_number":169,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.vendor_passthru:DracIPMIVendorPassthru"},{"line_number":170,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.vendor:VendorPassthru"},{"line_number":171,"context_line":"    ipmitool \u003d ironic.drivers.modules.ipmitool:VendorPassthru"},{"line_number":172,"context_line":"    no-vendor \u003d ironic.drivers.modules.noop:NoVendor"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"b6923035_ad50a251","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":14},"updated":"2021-02-23 01:43:56.000000000","message":"Please rename this idrac-ipmitool.","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"8ff5166f009f188f779cede3f4fd55e465237dd7","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    idrac \u003d ironic.drivers.modules.drac.vendor_passthru:DracVendorPassthru"},{"line_number":167,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.vendor_passthru:DracWSManVendorPassthru"},{"line_number":168,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.vendor_passthru:DracRedfishVendorPassthru"},{"line_number":169,"context_line":"    idrac-ipmi \u003d ironic.drivers.modules.drac.vendor_passthru:DracIPMIVendorPassthru"},{"line_number":170,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.vendor:VendorPassthru"},{"line_number":171,"context_line":"    ipmitool \u003d ironic.drivers.modules.ipmitool:VendorPassthru"},{"line_number":172,"context_line":"    no-vendor \u003d ironic.drivers.modules.noop:NoVendor"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"a048305b_5a4c2947","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":14},"in_reply_to":"b6923035_ad50a251","updated":"2021-02-25 14:39:10.000000000","message":"Done","commit_id":"875b4c286ca5a7d118d5065d877ed98cbe072c98"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c880e14a3cdfe18e1804e3a25e42862f3b34a642","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":81,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"},{"line_number":82,"context_line":"    idrac-ipmitool-shellinabox \u003dironic.drivers.modules.drac.console:DracIPMIShellinaboxConsole"},{"line_number":83,"context_line":"    idrac-ipmitool-socatconsole \u003dironic.drivers.modules.drac.console:DracIPMISocatConsole"},{"line_number":84,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":85,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"144b0dab_fac6d18b","line":82,"updated":"2021-03-25 11:42:31.000000000","message":"white space after \"\u003d\", same in the next line","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"},{"author":{"_account_id":32108,"name":"Yogesh","email":"yogesh.ramachandra@dell.com","username":"yogeshr20"},"change_message_id":"88a69d6a68ff6b71ed748a65cad9f12bc4bfff18","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":81,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"},{"line_number":82,"context_line":"    idrac-ipmitool-shellinabox \u003dironic.drivers.modules.drac.console:DracIPMIShellinaboxConsole"},{"line_number":83,"context_line":"    idrac-ipmitool-socatconsole \u003dironic.drivers.modules.drac.console:DracIPMISocatConsole"},{"line_number":84,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":85,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"63fd249b_4e78ae5e","line":82,"in_reply_to":"144b0dab_fac6d18b","updated":"2021-03-26 07:57:11.000000000","message":"Ack","commit_id":"e3ef04849b4ef89668f30ef3d74718dafbe6b3c5"}]}