)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"92cd3dba3fb412e06f205062414b95dff54df70b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"securely delete the contents of a NVMe drive and enable using nvme-cli"},{"line_number":12,"context_line":"tools instead, improving cleaning performance and reducing wear on the device."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: 2008290"},{"line_number":15,"context_line":"Change-Id: I2f63db9b739e53699bd5f164b79640927bf757d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3eb018e9_f3d68d99","line":14,"updated":"2021-02-02 09:46:11.000000000","message":"let\u0027s add the task too","commit_id":"d0897373be0faaf748cc7b8946713bc7d1a63648"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"1a83a0636810206959c8c9b1d4eed0bbe74c281e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"securely delete the contents of a NVMe drive and enable using nvme-cli"},{"line_number":12,"context_line":"tools instead, improving cleaning performance and reducing wear on the device."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: 2008290"},{"line_number":15,"context_line":"Change-Id: I2f63db9b739e53699bd5f164b79640927bf757d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cbb5f114_018a6155","line":14,"in_reply_to":"3eb018e9_f3d68d99","updated":"2021-02-02 23:40:14.000000000","message":"Done","commit_id":"d0897373be0faaf748cc7b8946713bc7d1a63648"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"6bca74ea51f76c310b60634cc62b747779f4f552","unresolved":true,"context_lines":[{"line_number":309,"context_line":"    info[\u0027agent_erase_devices_zeroize\u0027] \u003d zeroize"},{"line_number":310,"context_line":"    erase_fallback \u003d CONF.deploy.continue_if_disk_secure_erase_fails"},{"line_number":311,"context_line":"    info[\u0027agent_continue_if_secure_erase_failed\u0027] \u003d erase_fallback"},{"line_number":312,"context_line":"    # NOTE(janders) ``agent_continue_if_ata_erase_failed`` is deprecated and"},{"line_number":313,"context_line":"    # has been replaced with ``agent_continue_if_secure_erase_failed`` so that"},{"line_number":314,"context_line":"    # it can be used to control shred fallback for both ATA Secure Erase and"},{"line_number":315,"context_line":"    # NVMe Secure Erase. The ``agent_continue_if_ata_erase_failed`` line can"}],"source_content_type":"text/x-python","patch_set":6,"id":"1e969dab_9f1add5e","line":312,"updated":"2021-02-22 10:46:18.000000000","message":"if possible we should add also in which lifecycle agent_continue_if_ata_erase_failed is supposed to be removed","commit_id":"14c33f4e0532ff8ccc6f2149572c633ee780eef3"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"911bc3cc389268e6ac7801a53d18a82ec39d6db8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    info[\u0027agent_erase_devices_zeroize\u0027] \u003d zeroize"},{"line_number":310,"context_line":"    erase_fallback \u003d CONF.deploy.continue_if_disk_secure_erase_fails"},{"line_number":311,"context_line":"    info[\u0027agent_continue_if_secure_erase_failed\u0027] \u003d erase_fallback"},{"line_number":312,"context_line":"    # NOTE(janders) ``agent_continue_if_ata_erase_failed`` is deprecated and"},{"line_number":313,"context_line":"    # has been replaced with ``agent_continue_if_secure_erase_failed`` so that"},{"line_number":314,"context_line":"    # it can be used to control shred fallback for both ATA Secure Erase and"},{"line_number":315,"context_line":"    # NVMe Secure Erase. The ``agent_continue_if_ata_erase_failed`` line can"}],"source_content_type":"text/x-python","patch_set":6,"id":"9c9cc777_e723182c","line":312,"in_reply_to":"1e969dab_9f1add5e","updated":"2021-02-22 12:15:53.000000000","message":"Thank you Riccardo, very good point. I added the required comment in the current revision of the change.","commit_id":"14c33f4e0532ff8ccc6f2149572c633ee780eef3"}],"releasenotes/notes/adds-nvme-erase-switch-fa91e867e45ede3c.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"308999704a07cc5e1ea632f6f15d4ab72415951e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the conductor."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Deprecates ``driver_internal_info[\u0027agent_continue_if_ata_erase_failed\u0027]``"},{"line_number":10,"context_line":"    field in favor of"},{"line_number":11,"context_line":"    ``driver_internal_info[\u0027agent_continue_if_secure_erase_failed\u0027]`` which"},{"line_number":12,"context_line":"    is suitable to control fallback behavior of both ATA Secure Erase and NVMe"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3eb74547_38f0eff6","line":9,"updated":"2021-02-22 12:32:52.000000000","message":"Let\u0027s not talk about driver_internal_info deprecations, this is not something an admin can change. What we need to say is that the agent\u0027s ``agent_continue_if_ata_erase_failed`` option is deprecated, so if an operator is relying on the ironic\u0027s ``[deploy]continue_if_disk_secure_erase_fails``, they will need to update IPA to Wallaby before updating to Xena.","commit_id":"4dfd797c448d0cc1e88270cfdd58deae2b86a8bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8bca2bc259d5196079a715851b20edef367fa93","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    the conductor."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Deprecates ATA specifc ``[deploy]/agent_continue_if_ata_erase_failed``"},{"line_number":10,"context_line":"    option which is replaced with"},{"line_number":11,"context_line":"    ``[deploy]/agent_continue_if_secure_erase_failed``. The new option"},{"line_number":12,"context_line":"    supports both ATA and NVMe secure erase. In order to ensure a smooth"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6a0b1e36_4aedb4c9","line":9,"updated":"2021-02-22 12:58:56.000000000","message":"It\u0027s not a real ironic.conf option, let\u0027s call it \"the agent\u0027s option\" and remove [deploy]\n\nnit: specific.","commit_id":"3a09f078374252b50db8beb59f355d752d3dbb65"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"940af6e40a080ac25a02146a69de34c1bd676357","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the conductor."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Deprecates ATA specifc ``[deploy]/agent_continue_if_ata_erase_failed``"},{"line_number":10,"context_line":"    option which is replaced with"},{"line_number":11,"context_line":"    ``[deploy]/agent_continue_if_secure_erase_failed``. The new option"},{"line_number":12,"context_line":"    supports both ATA and NVMe secure erase. In order to ensure a smooth"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c1fe1fed_eb43d8e0","line":9,"in_reply_to":"6a0b1e36_4aedb4c9","updated":"2021-02-22 13:05:19.000000000","message":"Done","commit_id":"3a09f078374252b50db8beb59f355d752d3dbb65"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8bca2bc259d5196079a715851b20edef367fa93","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    ``[deploy]/agent_continue_if_secure_erase_failed``. The new option"},{"line_number":12,"context_line":"    supports both ATA and NVMe secure erase. In order to ensure a smooth"},{"line_number":13,"context_line":"    migration to the new configuration option, the operators need to upgrade"},{"line_number":14,"context_line":"    Ironic Python Agent image to Wallaby release prior to upgrading Ironic API"},{"line_number":15,"context_line":"    and Conductor to Xena."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bfd11881_4abb4e1f","line":14,"updated":"2021-02-22 12:58:56.000000000","message":"nit: strictly speaking, only Conductor","commit_id":"3a09f078374252b50db8beb59f355d752d3dbb65"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"940af6e40a080ac25a02146a69de34c1bd676357","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    ``[deploy]/agent_continue_if_secure_erase_failed``. The new option"},{"line_number":12,"context_line":"    supports both ATA and NVMe secure erase. In order to ensure a smooth"},{"line_number":13,"context_line":"    migration to the new configuration option, the operators need to upgrade"},{"line_number":14,"context_line":"    Ironic Python Agent image to Wallaby release prior to upgrading Ironic API"},{"line_number":15,"context_line":"    and Conductor to Xena."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"06592594_05baad05","line":14,"in_reply_to":"bfd11881_4abb4e1f","updated":"2021-02-22 13:05:19.000000000","message":"Done","commit_id":"3a09f078374252b50db8beb59f355d752d3dbb65"}]}