)]}'
{"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"28677126671b338157555a03b1d82a17751b9101","unresolved":true,"context_lines":[{"line_number":691,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def detect_vendor(self, task):"},{"line_number":694,"context_line":"        \"\"\"Detects, stores, and returns the hardware vendor."},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        Uses the System\u0027s Manufacturer field."},{"line_number":697,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fc4ed6c3_dbfafcde","line":694,"updated":"2021-01-27 21:59:56.000000000","message":"This method doesn\u0027t seem to be used anywhere, and it looks incomplete given the docstring mentioning storing, maybe it has leaked into this change from here? https://review.opendev.org/c/openstack/ironic/+/760675/1/ironic/drivers/modules/redfish/management.py","commit_id":"9edcbfa722ec1e3235c1045f69e721e280441d71"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"4c584d0c301779e26369ec03c71f854e051b7b2f","unresolved":true,"context_lines":[{"line_number":691,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def detect_vendor(self, task):"},{"line_number":694,"context_line":"        \"\"\"Detects, stores, and returns the hardware vendor."},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        Uses the System\u0027s Manufacturer field."},{"line_number":697,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"cd891109_2213b90d","line":694,"in_reply_to":"fc4ed6c3_dbfafcde","updated":"2021-01-27 22:23:41.000000000","message":"Yeah this was intentional and came about in discussion of https://review.opendev.org/c/openstack/ironic/+/771619 where it was added. In case that patch didn\u0027t merge we\u0027d need to add it here for backporting.\n\nI can remove this for now until we have a clearer way of handling this.","commit_id":"9edcbfa722ec1e3235c1045f69e721e280441d71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    # persistent setting must be set when setting the boot device"},{"line_number":98,"context_line":"    # (see https://storyboard.openstack.org/#!/story/2008547)."},{"line_number":99,"context_line":"    vendor \u003d task.node.properties.get(\u0027vendor\u0027, None)"},{"line_number":100,"context_line":"    if vendor and str(vendor).lower() \u003d\u003d \u0027supermicro\u0027:"},{"line_number":101,"context_line":"        enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"},{"line_number":102,"context_line":"        LOG.info(\u0027Setting BootSourceOverrideEnable to %s on Supermicro BMC\u0027,"},{"line_number":103,"context_line":"                 enabled)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa01c730_11fa9efc","line":100,"updated":"2021-01-28 17:06:58.000000000","message":"nit: str() not needed","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    # persistent setting must be set when setting the boot device"},{"line_number":98,"context_line":"    # (see https://storyboard.openstack.org/#!/story/2008547)."},{"line_number":99,"context_line":"    vendor \u003d task.node.properties.get(\u0027vendor\u0027, None)"},{"line_number":100,"context_line":"    if vendor and str(vendor).lower() \u003d\u003d \u0027supermicro\u0027:"},{"line_number":101,"context_line":"        enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"},{"line_number":102,"context_line":"        LOG.info(\u0027Setting BootSourceOverrideEnable to %s on Supermicro BMC\u0027,"},{"line_number":103,"context_line":"                 enabled)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fb01808b_75cfb857","line":100,"in_reply_to":"fa01c730_11fa9efc","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    vendor \u003d task.node.properties.get(\u0027vendor\u0027, None)"},{"line_number":100,"context_line":"    if vendor and str(vendor).lower() \u003d\u003d \u0027supermicro\u0027:"},{"line_number":101,"context_line":"        enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"},{"line_number":102,"context_line":"        LOG.info(\u0027Setting BootSourceOverrideEnable to %s on Supermicro BMC\u0027,"},{"line_number":103,"context_line":"                 enabled)"},{"line_number":104,"context_line":"    else:"},{"line_number":105,"context_line":"        desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"}],"source_content_type":"text/x-python","patch_set":5,"id":"762bee8d_0dd283a2","line":102,"updated":"2021-01-28 17:06:58.000000000","message":"Should be debug, also please add node UUID","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    vendor \u003d task.node.properties.get(\u0027vendor\u0027, None)"},{"line_number":100,"context_line":"    if vendor and str(vendor).lower() \u003d\u003d \u0027supermicro\u0027:"},{"line_number":101,"context_line":"        enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"},{"line_number":102,"context_line":"        LOG.info(\u0027Setting BootSourceOverrideEnable to %s on Supermicro BMC\u0027,"},{"line_number":103,"context_line":"                 enabled)"},{"line_number":104,"context_line":"    else:"},{"line_number":105,"context_line":"        desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"}],"source_content_type":"text/x-python","patch_set":5,"id":"40428ea4_e3e741ce","line":102,"in_reply_to":"762bee8d_0dd283a2","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"}],"ironic/tests/unit/drivers/modules/redfish/test_management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":245,"context_line":"                sushy.BOOT_SOURCE_TARGET_PXE,"},{"line_number":246,"context_line":"                task.node.driver_internal_info[\u0027redfish_boot_device\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @mock.patch.object(redfish_mgmt.LOG, \u0027info\u0027, autospec\u003dTrue)"},{"line_number":249,"context_line":"    @mock.patch.object(redfish_utils, \u0027get_system\u0027, autospec\u003dTrue)"},{"line_number":250,"context_line":"    def test_set_boot_device_persistency_vendor_match(self, mock_get_system,"},{"line_number":251,"context_line":"                                                      mock_log):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0ab86d89_b89d85e7","line":248,"updated":"2021-01-28 17:06:58.000000000","message":"Please don\u0027t test for info logging, we only test for warnings and above (and only when it\u0027s critical).","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                sushy.BOOT_SOURCE_TARGET_PXE,"},{"line_number":246,"context_line":"                task.node.driver_internal_info[\u0027redfish_boot_device\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @mock.patch.object(redfish_mgmt.LOG, \u0027info\u0027, autospec\u003dTrue)"},{"line_number":249,"context_line":"    @mock.patch.object(redfish_utils, \u0027get_system\u0027, autospec\u003dTrue)"},{"line_number":250,"context_line":"    def test_set_boot_device_persistency_vendor_match(self, mock_get_system,"},{"line_number":251,"context_line":"                                                      mock_log):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9be9cd1b_3986539b","line":248,"in_reply_to":"0ab86d89_b89d85e7","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":251,"context_line":"                                                      mock_log):"},{"line_number":252,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":253,"context_line":"        mock_get_system.return_value \u003d fake_system"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        properties \u003d self.node.properties"},{"line_number":256,"context_line":"        properties[\u0027vendor\u0027] \u003d \u0027SuperMicro\u0027"},{"line_number":257,"context_line":"        self.node.properties \u003d properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"9c2f0565_8ee7a88d","line":254,"updated":"2021-01-28 17:06:58.000000000","message":"nit:\n\n fake_system \u003d mock_get_system.return_value\n\n(same below)","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                                      mock_log):"},{"line_number":252,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":253,"context_line":"        mock_get_system.return_value \u003d fake_system"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        properties \u003d self.node.properties"},{"line_number":256,"context_line":"        properties[\u0027vendor\u0027] \u003d \u0027SuperMicro\u0027"},{"line_number":257,"context_line":"        self.node.properties \u003d properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ca68340_ded09bc4","line":254,"in_reply_to":"9c2f0565_8ee7a88d","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":288,"context_line":"                task, boot_devices.PXE, persistent\u003dTrue)"},{"line_number":289,"context_line":"            self.assertFalse(mock_log.called)"},{"line_number":290,"context_line":"            fake_system.boot.get.assert_has_calls([mock.call(\u0027enabled\u0027),"},{"line_number":291,"context_line":"                                                  mock.call(\u0027mode\u0027)])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"            fake_system.set_system_boot_options.assert_has_calls("},{"line_number":294,"context_line":"                [mock.call(sushy.BOOT_SOURCE_TARGET_PXE,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d3bafd6_6b1ba39a","line":291,"updated":"2021-01-28 17:06:58.000000000","message":"nit: I don\u0027t quite like mocking dicts..","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                task, boot_devices.PXE, persistent\u003dTrue)"},{"line_number":289,"context_line":"            self.assertFalse(mock_log.called)"},{"line_number":290,"context_line":"            fake_system.boot.get.assert_has_calls([mock.call(\u0027enabled\u0027),"},{"line_number":291,"context_line":"                                                  mock.call(\u0027mode\u0027)])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"            fake_system.set_system_boot_options.assert_has_calls("},{"line_number":294,"context_line":"                [mock.call(sushy.BOOT_SOURCE_TARGET_PXE,"}],"source_content_type":"text/x-python","patch_set":5,"id":"76e86c0a_d5015320","line":291,"in_reply_to":"1d3bafd6_6b1ba39a","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"            fake_system.set_system_boot_options.assert_has_calls("},{"line_number":294,"context_line":"                [mock.call(sushy.BOOT_SOURCE_TARGET_PXE,"},{"line_number":295,"context_line":"                           enabled\u003dsushy.BOOT_SOURCE_ENABLED_CONTINUOUS),"},{"line_number":296,"context_line":"                 mock.call(mode\u003dsushy.BOOT_SOURCE_MODE_BIOS)])"},{"line_number":297,"context_line":"            mock_get_system.assert_called_with(task.node)"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"be3d3dec_4de00720","line":295,"updated":"2021-01-28 17:06:58.000000000","message":"This looks identical to the test above, don\u0027t we expect to see any difference? Would it be possible to set up the tests so that they behave differently?","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":true,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"            fake_system.set_system_boot_options.assert_has_calls("},{"line_number":294,"context_line":"                [mock.call(sushy.BOOT_SOURCE_TARGET_PXE,"},{"line_number":295,"context_line":"                           enabled\u003dsushy.BOOT_SOURCE_ENABLED_CONTINUOUS),"},{"line_number":296,"context_line":"                 mock.call(mode\u003dsushy.BOOT_SOURCE_MODE_BIOS)])"},{"line_number":297,"context_line":"            mock_get_system.assert_called_with(task.node)"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8917b3a4_e93f2f02","line":295,"in_reply_to":"be3d3dec_4de00720","updated":"2021-01-28 19:19:03.000000000","message":"Concatenated into a single test that checks differences between vendors.","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"}],"releasenotes/notes/supermicro-redfish-override-enabled-aa51686ed33d3061.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When setting the boot settings on Supermicro BMCs the"},{"line_number":5,"context_line":"    BootSourceOverrideEnabled must be set to the desired value whenever"},{"line_number":6,"context_line":"    the BootSourceOverrideTarget is set or it will revert to default (Once),"},{"line_number":7,"context_line":"    see `story 2008547 \u003chttps://storyboard.openstack.org/#!/story/2008547\u003e`__"},{"line_number":8,"context_line":"    for details.  This is different than what is currently implemented for"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"807c16eb_fd40ce78","line":5,"updated":"2021-01-28 17:06:58.000000000","message":"\"must be set\" is a bit confusing and may be interpreted as something the operators must do. let\u0027s phrase it in terms what ironic does.","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When setting the boot settings on Supermicro BMCs the"},{"line_number":5,"context_line":"    BootSourceOverrideEnabled must be set to the desired value whenever"},{"line_number":6,"context_line":"    the BootSourceOverrideTarget is set or it will revert to default (Once),"},{"line_number":7,"context_line":"    see `story 2008547 \u003chttps://storyboard.openstack.org/#!/story/2008547\u003e`__"},{"line_number":8,"context_line":"    for details.  This is different than what is currently implemented for"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b3e4dfe8_cc388083","line":5,"in_reply_to":"807c16eb_fd40ce78","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    When setting the boot settings on Supermicro BMCs the"},{"line_number":5,"context_line":"    BootSourceOverrideEnabled must be set to the desired value whenever"},{"line_number":6,"context_line":"    the BootSourceOverrideTarget is set or it will revert to default (Once),"},{"line_number":7,"context_line":"    see `story 2008547 \u003chttps://storyboard.openstack.org/#!/story/2008547\u003e`__"},{"line_number":8,"context_line":"    for details.  This is different than what is currently implemented for"},{"line_number":9,"context_line":"    other BMCs in which the BootSourceOverrideEnabled is not set if it"},{"line_number":10,"context_line":"    matches the current setting (see `story 2007355"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0910135c_dd4acbdd","line":7,"updated":"2021-01-28 17:06:58.000000000","message":"double underscore?","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When setting the boot settings on Supermicro BMCs the"},{"line_number":5,"context_line":"    BootSourceOverrideEnabled must be set to the desired value whenever"},{"line_number":6,"context_line":"    the BootSourceOverrideTarget is set or it will revert to default (Once),"},{"line_number":7,"context_line":"    see `story 2008547 \u003chttps://storyboard.openstack.org/#!/story/2008547\u003e`__"},{"line_number":8,"context_line":"    for details.  This is different than what is currently implemented for"},{"line_number":9,"context_line":"    other BMCs in which the BootSourceOverrideEnabled is not set if it"},{"line_number":10,"context_line":"    matches the current setting (see `story 2007355"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"92795abd_7c968cef","line":7,"in_reply_to":"0910135c_dd4acbdd","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e36f428c14cb05fc49482555290e229c3804ff45","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    for details.  This is different than what is currently implemented for"},{"line_number":9,"context_line":"    other BMCs in which the BootSourceOverrideEnabled is not set if it"},{"line_number":10,"context_line":"    matches the current setting (see `story 2007355"},{"line_number":11,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2007355\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"070304d0_a7c998a5","line":11,"updated":"2021-01-28 17:06:58.000000000","message":"same + unmatched (","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9913b0010f2c3f6cc65dcc566eac4832c70280b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    for details.  This is different than what is currently implemented for"},{"line_number":9,"context_line":"    other BMCs in which the BootSourceOverrideEnabled is not set if it"},{"line_number":10,"context_line":"    matches the current setting (see `story 2007355"},{"line_number":11,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2007355\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"86669e92_c2794901","line":11,"in_reply_to":"070304d0_a7c998a5","updated":"2021-01-28 19:19:03.000000000","message":"Done","commit_id":"55fbe4b3dd426d49a2fbb29f98d0e92c50eb5907"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9521ce1cc03bfd7b1083276605e39f593124682","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f2e847ab_26ecbd85","line":12,"range":{"start_line":4,"start_character":4,"end_line":12,"end_character":0},"updated":"2021-01-29 07:24:29.000000000","message":"It is required to mention that one needs to set the node.properties[\u0027vendor\u0027] to \u0027supermicro\u0027 for this to work. Or you can rebase this patch on top of [1] where vendor detection is implemented for Redfish.\n[1] https://review.opendev.org/c/openstack/ironic/+/771595","commit_id":"09203bef925947e7dfc4a643f0835b6753e3fd1a"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5c226763e05b46973c550ce375caa940996a1a4b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97896776_9c2fc5dd","line":12,"range":{"start_line":4,"start_character":4,"end_line":12,"end_character":0},"in_reply_to":"de6fd393_08716bdd","updated":"2021-01-29 22:51:34.000000000","message":"Thank you.  Updated release note regarding state node.properties[\u0027vendor\u0027]. Rebased to include https://review.opendev.org/c/openstack/ironic/+/771595 which has merged.","commit_id":"09203bef925947e7dfc4a643f0835b6753e3fd1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f5d4d163cbdd36d87152e93482c6f09ae0c79329","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"de6fd393_08716bdd","line":12,"range":{"start_line":4,"start_character":4,"end_line":12,"end_character":0},"in_reply_to":"f2e847ab_26ecbd85","updated":"2021-01-29 14:13:07.000000000","message":"I just approved the other patch.","commit_id":"09203bef925947e7dfc4a643f0835b6753e3fd1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee86af40fa11b6e95b6c1dee02780465440856fc","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    current setting (see `story 2007355"},{"line_number":11,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2007355\u003e`_)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    This requires that node.properties[\u0027vendor\u0027] be \u0027supermicro\u0027 which will"},{"line_number":14,"context_line":"    be set by Ironic from the Redfish system response or can be set"},{"line_number":15,"context_line":"    manually."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"407addca_3e0979a6","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":49},"updated":"2021-01-29 22:51:36.000000000","message":"Likely only developers will actually grok this. Admins might think in terms of Node field ``properties`` should contain a ``vendor`` field consisting a ``vendor`` with a value of ``supermicro``. A bit heavy on words though. :\\","commit_id":"4a7d50ce56b88c82e95665ac6df44666d3e647ed"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"606f332775097a8485f5cc3171aaf14ed3f9078b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    current setting (see `story 2007355"},{"line_number":11,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2007355\u003e`_)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    This requires that node.properties[\u0027vendor\u0027] be \u0027supermicro\u0027 which will"},{"line_number":14,"context_line":"    be set by Ironic from the Redfish system response or can be set"},{"line_number":15,"context_line":"    manually."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6d936c06_e6f6fae4","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":49},"in_reply_to":"407addca_3e0979a6","updated":"2021-01-30 07:14:22.000000000","message":"+1","commit_id":"4a7d50ce56b88c82e95665ac6df44666d3e647ed"}]}