)]}'
{"ironic/drivers/modules/inspector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31f0a394c5454e6d9ba99c421bad5586e1586106","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            enabled_macs \u003d task.driver.management.get_mac_addresses(task)"},{"line_number":248,"context_line":"            if enabled_macs:"},{"line_number":249,"context_line":"                inspect_utils.create_ports_if_not_exist("},{"line_number":250,"context_line":"                    task, enabled_macs, get_mac_address\u003dlambda x: x[0])"},{"line_number":251,"context_line":"            else:"},{"line_number":252,"context_line":"                LOG.warning(\"Not attempting to create any port as no NICs \""},{"line_number":253,"context_line":"                            \"were discovered in \u0027enabled\u0027 state for node \""}],"source_content_type":"text/x-python","patch_set":10,"id":"f7f809e4_5f1808dc","line":250,"updated":"2021-03-22 11:09:45.000000000","message":"This addition doesn\u0027t seem to be unit-tested, could you add some tests? At least an assertion that create_ports_if_not_exists is called with the result of get_mac_addresses.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e8640cef1adaf71480a3e9e6c8d4dd95c14ce29f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            enabled_macs \u003d task.driver.management.get_mac_addresses(task)"},{"line_number":248,"context_line":"            if enabled_macs:"},{"line_number":249,"context_line":"                inspect_utils.create_ports_if_not_exist("},{"line_number":250,"context_line":"                    task, enabled_macs, get_mac_address\u003dlambda x: x[0])"},{"line_number":251,"context_line":"            else:"},{"line_number":252,"context_line":"                LOG.warning(\"Not attempting to create any port as no NICs \""},{"line_number":253,"context_line":"                            \"were discovered in \u0027enabled\u0027 state for node \""}],"source_content_type":"text/x-python","patch_set":10,"id":"4ba323a2_b9476191","line":250,"in_reply_to":"f7f809e4_5f1808dc","updated":"2021-03-23 11:01:28.000000000","message":"Done.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31f0a394c5454e6d9ba99c421bad5586e1586106","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                             \u0027node\u0027: task.node.uuid})"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        except exception.UnsupportedDriverExtension:"},{"line_number":259,"context_line":"            LOG.info(\u0027Pre-creating ports prior to inspection not supported\u0027"},{"line_number":260,"context_line":"                     \u0027 on node %s.\u0027, task.node.uuid)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        ironic_manages_boot \u003d _ironic_manages_boot("}],"source_content_type":"text/x-python","patch_set":10,"id":"521a8f3a_39f0bab7","line":259,"updated":"2021-03-22 11:09:45.000000000","message":"nit: s/info/debug/ since it will normally happen for IPMI","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e8640cef1adaf71480a3e9e6c8d4dd95c14ce29f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                             \u0027node\u0027: task.node.uuid})"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        except exception.UnsupportedDriverExtension:"},{"line_number":259,"context_line":"            LOG.info(\u0027Pre-creating ports prior to inspection not supported\u0027"},{"line_number":260,"context_line":"                     \u0027 on node %s.\u0027, task.node.uuid)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        ironic_manages_boot \u003d _ironic_manages_boot("}],"source_content_type":"text/x-python","patch_set":10,"id":"7c0bebba_55efdcee","line":259,"in_reply_to":"521a8f3a_39f0bab7","updated":"2021-03-23 11:01:28.000000000","message":"Done.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31f0a394c5454e6d9ba99c421bad5586e1586106","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def _create_ports(self, task, system):"},{"line_number":163,"context_line":"        enabled_macs \u003d redfish_utils.get_enabled_macs(task, system)"},{"line_number":164,"context_line":"        if enabled_macs:"},{"line_number":165,"context_line":"            inspect_utils.create_ports_if_not_exist("},{"line_number":166,"context_line":"                task, enabled_macs, get_mac_address\u003dlambda x: x[0])"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            LOG.warning(\"Not attempting to create any port as no NICs \""}],"source_content_type":"text/x-python","patch_set":10,"id":"aa0ba232_e763657c","line":165,"updated":"2021-03-22 11:09:45.000000000","message":"No, I think the enablement check is encapsulated in get_enabled_macs now.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d874ade73f13a01552d7627f4bbc5e0c102ccafa","unresolved":true,"context_lines":[{"line_number":162,"context_line":"    def _create_ports(self, task, system):"},{"line_number":163,"context_line":"        enabled_macs \u003d redfish_utils.get_enabled_macs(task, system)"},{"line_number":164,"context_line":"        if enabled_macs:"},{"line_number":165,"context_line":"            inspect_utils.create_ports_if_not_exist("},{"line_number":166,"context_line":"                task, enabled_macs, get_mac_address\u003dlambda x: x[0])"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            LOG.warning(\"Not attempting to create any port as no NICs \""}],"source_content_type":"text/x-python","patch_set":10,"id":"e784c805_f4a772b1","line":165,"updated":"2021-03-18 17:06:25.000000000","message":"So if I\u0027m groking this properly. We\u0027re just going to record macs regardless of enabled state, if even present.. (which if not, seems like we won\u0027t), which will help for identification of machines. So I guess that makes sense. In a sense unrelated, but a good improvement... or necessary improvement in the end.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e8640cef1adaf71480a3e9e6c8d4dd95c14ce29f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def _create_ports(self, task, system):"},{"line_number":163,"context_line":"        enabled_macs \u003d redfish_utils.get_enabled_macs(task, system)"},{"line_number":164,"context_line":"        if enabled_macs:"},{"line_number":165,"context_line":"            inspect_utils.create_ports_if_not_exist("},{"line_number":166,"context_line":"                task, enabled_macs, get_mac_address\u003dlambda x: x[0])"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            LOG.warning(\"Not attempting to create any port as no NICs \""}],"source_content_type":"text/x-python","patch_set":10,"id":"05f985ba_e67c024d","line":165,"in_reply_to":"aa0ba232_e763657c","updated":"2021-03-23 11:01:28.000000000","message":"Thank you Julia and Dmitry.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e8640cef1adaf71480a3e9e6c8d4dd95c14ce29f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def _create_ports(self, task, system):"},{"line_number":163,"context_line":"        enabled_macs \u003d redfish_utils.get_enabled_macs(task, system)"},{"line_number":164,"context_line":"        if enabled_macs:"},{"line_number":165,"context_line":"            inspect_utils.create_ports_if_not_exist("},{"line_number":166,"context_line":"                task, enabled_macs, get_mac_address\u003dlambda x: x[0])"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            LOG.warning(\"Not attempting to create any port as no NICs \""}],"source_content_type":"text/x-python","patch_set":10,"id":"c144ffec_9f172b1d","line":165,"in_reply_to":"e784c805_f4a772b1","updated":"2021-03-23 11:01:28.000000000","message":"Done","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31f0a394c5454e6d9ba99c421bad5586e1586106","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        return enabled_macs"},{"line_number":353,"context_line":"    else:"},{"line_number":354,"context_line":"        LOG.warning(\"No NIC information discovered \""},{"line_number":355,"context_line":"                    \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ab57727_1199bdf6","line":355,"updated":"2021-03-22 11:09:45.000000000","message":"Let\u0027s avoid warnings in general-purpose calls, especially since you already have warnings in all places where it\u0027s called.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e8640cef1adaf71480a3e9e6c8d4dd95c14ce29f","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        return enabled_macs"},{"line_number":353,"context_line":"    else:"},{"line_number":354,"context_line":"        LOG.warning(\"No NIC information discovered \""},{"line_number":355,"context_line":"                    \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"e1919eb1_55a31ab0","line":355,"in_reply_to":"3ab57727_1199bdf6","updated":"2021-03-23 11:01:28.000000000","message":"Done - changed it to debug. Or is it better to remove entirely?","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"}],"ironic/tests/unit/drivers/modules/redfish/test_management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31f0a394c5454e6d9ba99c421bad5586e1586106","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1491,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":1492,"context_line":"            self.assertEqual(expected_properties,"},{"line_number":1493,"context_line":"                             task.driver.management.get_mac_addresses(task))"}],"source_content_type":"text/x-python","patch_set":10,"id":"1b64a0aa_068ec21b","line":1493,"updated":"2021-03-22 11:09:45.000000000","message":"nit: self.assertIsNone","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e8640cef1adaf71480a3e9e6c8d4dd95c14ce29f","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1491,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":1492,"context_line":"            self.assertEqual(expected_properties,"},{"line_number":1493,"context_line":"                             task.driver.management.get_mac_addresses(task))"}],"source_content_type":"text/x-python","patch_set":10,"id":"a85c2d8a_e7d397d0","line":1493,"in_reply_to":"1b64a0aa_068ec21b","updated":"2021-03-23 11:01:28.000000000","message":"Done.","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"}],"ironic/tests/unit/drivers/test_base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31f0a394c5454e6d9ba99c421bad5586e1586106","unresolved":false,"context_lines":[{"line_number":831,"context_line":"            expected, management.get_indicator_state("},{"line_number":832,"context_line":"                task_mock, components.CHASSIS, \u0027led-0\u0027))"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    def test_get_mac_addresses(self):"},{"line_number":835,"context_line":"        management \u003d fake.FakeManagement()"},{"line_number":836,"context_line":"        task_mock \u003d mock.MagicMock(spec_set\u003d[\u0027node\u0027])"},{"line_number":837,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bd73692b_b34acf28","line":834,"updated":"2021-03-22 11:09:45.000000000","message":"nit: this test is not needed IMO","commit_id":"05df3d7aa4aa7a1fd25a2f2d55726197e1b5f9df"}]}