)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22b7a290d0761c6d1739d9c8854de4e882b7bedb","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Story: 2008602"},{"line_number":17,"context_line":"Task: 41778"},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/x/sushy-oem-idrac/+/776224"},{"line_number":19,"context_line":"Change-Id: Iefb7f882c97e33a176962e4e907163d9e4809445"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"01b73eaa_030a4635","line":18,"updated":"2021-03-15 14:18:58.000000000","message":"We\u0027ll need driver-requirements.txt updated once this is released.","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ab3fbeea8857b22acd79a9a73db76af2ec667745","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Story: 2008602"},{"line_number":17,"context_line":"Task: 41778"},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/x/sushy-oem-idrac/+/776224"},{"line_number":19,"context_line":"Change-Id: Iefb7f882c97e33a176962e4e907163d9e4809445"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0861fa7e_cefe25f9","line":18,"in_reply_to":"01b73eaa_030a4635","updated":"2021-03-19 16:17:34.000000000","message":"added, have to wait till it\u0027s released, until then driver libs tests will fail.\n\n@Richard, please recheck once released.","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"}],"doc/source/admin/drivers/idrac.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"See :doc:`/admin/raid` for more information on Ironic RAID support."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"The following properties are supported by the iDRAC WSMAN and Redfish raid"},{"line_number":281,"context_line":"interface implementation:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9693fcc5_96129c64","line":280,"updated":"2021-03-10 15:19:38.000000000","message":"nit: RAID","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"See :doc:`/admin/raid` for more information on Ironic RAID support."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"The following properties are supported by the iDRAC WSMAN and Redfish raid"},{"line_number":281,"context_line":"interface implementation:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"36599015_f01c0b14","line":280,"in_reply_to":"9693fcc5_96129c64","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":281,"context_line":"interface implementation:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":".. NOTE::"},{"line_number":284,"context_line":"  When using ``idrac-redfish`` for RAID interface iDRAC greater than 4.40.00.00"},{"line_number":285,"context_line":"  is required."},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"Mandatory properties"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c515a059_f9f9e9a0","line":284,"updated":"2021-03-10 15:19:38.000000000","message":"nit: \"iDRAC firmware\"","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"interface implementation:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":".. NOTE::"},{"line_number":284,"context_line":"  When using ``idrac-redfish`` for RAID interface iDRAC greater than 4.40.00.00"},{"line_number":285,"context_line":"  is required."},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"Mandatory properties"}],"source_content_type":"text/x-rst","patch_set":5,"id":"47518756_75e32329","line":284,"in_reply_to":"c515a059_f9f9e9a0","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22b7a290d0761c6d1739d9c8854de4e882b7bedb","unresolved":true,"context_lines":[{"line_number":410,"context_line":"  physical_disks \u003d client.list_physical_disks()"},{"line_number":411,"context_line":"  print(physical_disks)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"Or using ``sushy`` with Redfish:"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":".. code-block:: python"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"  import sushy"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  client \u003d sushy.Sushy(\u0027https://192.168.1.1\u0027, username\u003d\u0027root\u0027, password\u003d\u0027calvin\u0027, verify\u003dFalse)"},{"line_number":421,"context_line":"  for s in client.get_system_collection().get_members():"},{"line_number":422,"context_line":"    print(\"System: %(id)s\" % {\u0027id\u0027: s.identity})"},{"line_number":423,"context_line":"    for c in system1.storage.get_members():"},{"line_number":424,"context_line":"        print(\"\\tController: %(id)s\" % {\u0027id\u0027: c.identity})"},{"line_number":425,"context_line":"        for d in c.drives:"},{"line_number":426,"context_line":"          print(\"\\t\\tDrive: %(id)s\" % {\u0027id\u0027: d.identity})"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"Vendor Interface"},{"line_number":429,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ab68f3c9_eb34b647","line":426,"range":{"start_line":413,"start_character":0,"end_line":426,"end_character":57},"updated":"2021-03-15 14:18:58.000000000","message":"shouldn\u0027t this be in sushy?","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"170b5b6dfe37ff257c0717382e0f0caf71ff0ffc","unresolved":true,"context_lines":[{"line_number":410,"context_line":"  physical_disks \u003d client.list_physical_disks()"},{"line_number":411,"context_line":"  print(physical_disks)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"Or using ``sushy`` with Redfish:"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":".. code-block:: python"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"  import sushy"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"  client \u003d sushy.Sushy(\u0027https://192.168.1.1\u0027, username\u003d\u0027root\u0027, password\u003d\u0027calvin\u0027, verify\u003dFalse)"},{"line_number":421,"context_line":"  for s in client.get_system_collection().get_members():"},{"line_number":422,"context_line":"    print(\"System: %(id)s\" % {\u0027id\u0027: s.identity})"},{"line_number":423,"context_line":"    for c in system1.storage.get_members():"},{"line_number":424,"context_line":"        print(\"\\tController: %(id)s\" % {\u0027id\u0027: c.identity})"},{"line_number":425,"context_line":"        for d in c.drives:"},{"line_number":426,"context_line":"          print(\"\\t\\tDrive: %(id)s\" % {\u0027id\u0027: d.identity})"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"Vendor Interface"},{"line_number":429,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"572a9425_6017903c","line":426,"range":{"start_line":413,"start_character":0,"end_line":426,"end_character":57},"in_reply_to":"ab68f3c9_eb34b647","updated":"2021-03-22 08:08:24.000000000","message":"No, the context of this change starts at ln 394.","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"    return disk.size_mb if pending_delete else disk.free_size_mb"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"def _wait_till_realtime_ready(task, max_retry_count\u003d30):"},{"line_number":1168,"context_line":"    \"\"\"Waits till real time operations are ready to be executed."},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    Useful for RAID operations where almost all controllers support"}],"source_content_type":"text/x-python","patch_set":5,"id":"5b51f30b_deee5c7d","line":1167,"updated":"2021-03-10 15:19:38.000000000","message":"nit: use tenacity instead of custom retry","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"    return disk.size_mb if pending_delete else disk.free_size_mb"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"def _wait_till_realtime_ready(task, max_retry_count\u003d30):"},{"line_number":1168,"context_line":"    \"\"\"Waits till real time operations are ready to be executed."},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    Useful for RAID operations where almost all controllers support"}],"source_content_type":"text/x-python","patch_set":5,"id":"5c31f87b_cc3b2abc","line":1167,"in_reply_to":"5b51f30b_deee5c7d","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":1219,"context_line":"        try:"},{"line_number":1220,"context_line":"            return manager_oem.lifecycle_service.is_realtime_ready()"},{"line_number":1221,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":1222,"context_line":"            LOG.debug(\"Sushy OEM extension Python package \u0027sushy-oem-idrac\u0027 \""},{"line_number":1223,"context_line":"                      \"failed to get real time ready status with system \""},{"line_number":1224,"context_line":"                      \"%(system)s manager %(manager)s for node %(node)s. Will \""},{"line_number":1225,"context_line":"                      \"try next manager, if available. Error: %(error)s\","}],"source_content_type":"text/x-python","patch_set":5,"id":"73cbc640_5ba2c782","line":1222,"updated":"2021-03-10 15:19:38.000000000","message":"nit: it\u0027s not help to refer to the python package, I\u0027d remove everything before \"failed\"","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":1219,"context_line":"        try:"},{"line_number":1220,"context_line":"            return manager_oem.lifecycle_service.is_realtime_ready()"},{"line_number":1221,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":1222,"context_line":"            LOG.debug(\"Sushy OEM extension Python package \u0027sushy-oem-idrac\u0027 \""},{"line_number":1223,"context_line":"                      \"failed to get real time ready status with system \""},{"line_number":1224,"context_line":"                      \"%(system)s manager %(manager)s for node %(node)s. Will \""},{"line_number":1225,"context_line":"                      \"try next manager, if available. Error: %(error)s\","}],"source_content_type":"text/x-python","patch_set":5,"id":"02524e36_a3b9f31e","line":1222,"in_reply_to":"73cbc640_5ba2c782","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        break"},{"line_number":1234,"context_line":""},{"line_number":1235,"context_line":"    else:"},{"line_number":1236,"context_line":"        error_msg \u003d (_(\"iDRAC Redfish get real time stready status ailed for \""},{"line_number":1237,"context_line":"                       \"node %(node)s, because system %(system)s has no \""},{"line_number":1238,"context_line":"                       \"manager%(no_manager)s.\") %"},{"line_number":1239,"context_line":"                     {\u0027node\u0027: task.node.uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"e4c41f37_733a405d","line":1236,"updated":"2021-03-10 15:19:38.000000000","message":"\"ready\", \"failed\"","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        break"},{"line_number":1234,"context_line":""},{"line_number":1235,"context_line":"    else:"},{"line_number":1236,"context_line":"        error_msg \u003d (_(\"iDRAC Redfish get real time stready status ailed for \""},{"line_number":1237,"context_line":"                       \"node %(node)s, because system %(system)s has no \""},{"line_number":1238,"context_line":"                       \"manager%(no_manager)s.\") %"},{"line_number":1239,"context_line":"                     {\u0027node\u0027: task.node.uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"40a917ec_6576aca8","line":1236,"in_reply_to":"e4c41f37_733a405d","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"    else:"},{"line_number":1236,"context_line":"        error_msg \u003d (_(\"iDRAC Redfish get real time stready status ailed for \""},{"line_number":1237,"context_line":"                       \"node %(node)s, because system %(system)s has no \""},{"line_number":1238,"context_line":"                       \"manager%(no_manager)s.\") %"},{"line_number":1239,"context_line":"                     {\u0027node\u0027: task.node.uuid,"},{"line_number":1240,"context_line":"                      \u0027system\u0027: system.uuid if system.uuid else"},{"line_number":1241,"context_line":"                      system.identity,"}],"source_content_type":"text/x-python","patch_set":5,"id":"953bf7a1_934d719d","line":1238,"updated":"2021-03-10 15:19:38.000000000","message":"This no_manage bit seems out of place here. Copy-paste?","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"    else:"},{"line_number":1236,"context_line":"        error_msg \u003d (_(\"iDRAC Redfish get real time stready status ailed for \""},{"line_number":1237,"context_line":"                       \"node %(node)s, because system %(system)s has no \""},{"line_number":1238,"context_line":"                       \"manager%(no_manager)s.\") %"},{"line_number":1239,"context_line":"                     {\u0027node\u0027: task.node.uuid,"},{"line_number":1240,"context_line":"                      \u0027system\u0027: system.uuid if system.uuid else"},{"line_number":1241,"context_line":"                      system.identity,"}],"source_content_type":"text/x-python","patch_set":5,"id":"621948f0_642b961e","line":1238,"in_reply_to":"953bf7a1_934d719d","updated":"2021-03-12 11:37:08.000000000","message":"the message\u0026overall structure is taken from the first that started to use sushy-oem-idrac (virtual media boot).\nThis message is to render:\n1) \".. system X has no manager.\" or \n2) \".. system X has no manager which could.\"\n\nIf I got your Q, then this is is intended.","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"}],"ironic/drivers/modules/redfish/raid.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22b7a290d0761c6d1739d9c8854de4e882b7bedb","unresolved":true,"context_lines":[{"line_number":692,"context_line":"        if not vendor:"},{"line_number":693,"context_line":"            return"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        if \u0027Dell\u0027 in vendor.split():"},{"line_number":696,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":697,"context_line":"                _(\"The %(iface)s raid interface is not suitable for node \""},{"line_number":698,"context_line":"                  \"%(node)s with vendor %(vendor)s, use idrac-redfish instead\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"2659d417_dad86dc8","line":695,"range":{"start_line":695,"start_character":0,"end_line":695,"end_character":36},"updated":"2021-03-15 14:18:58.000000000","message":"ideally we should string.lower this and make it lower case in case a non-human sets this.\n\nIdeally, we should support manually set \u0027dell\u0027 as well.","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ab3fbeea8857b22acd79a9a73db76af2ec667745","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        if not vendor:"},{"line_number":693,"context_line":"            return"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        if \u0027Dell\u0027 in vendor.split():"},{"line_number":696,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":697,"context_line":"                _(\"The %(iface)s raid interface is not suitable for node \""},{"line_number":698,"context_line":"                  \"%(node)s with vendor %(vendor)s, use idrac-redfish instead\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"dc295464_1059164b","line":695,"range":{"start_line":695,"start_character":0,"end_line":695,"end_character":36},"in_reply_to":"2659d417_dad86dc8","updated":"2021-03-19 16:17:34.000000000","message":"Done","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"}],"releasenotes/notes/idrac-add-redfish-raid-support-414aad5e633a160f.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds MVP support for managing RAID configuration via the Redfish"},{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7dcb03f6_84e2dc6d","line":4,"updated":"2021-03-10 15:19:38.000000000","message":"nit: I\u0027d replace MVP with \"basic\" or anything else more specific.","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds MVP support for managing RAID configuration via the Redfish"},{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2e9e0431_dfc100e7","line":4,"in_reply_to":"7dcb03f6_84e2dc6d","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    iDRAC greater than 4.40.00.00 is required. Compared to ``idrac-wsman``"},{"line_number":9,"context_line":"    implementation does not yet support foreign disks and converting from"},{"line_number":10,"context_line":"    non-RAID mode."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f0989d3d_1caaa4b5","line":8,"updated":"2021-03-10 15:19:38.000000000","message":"iDRAC firmware (maybe also mention the iDRAC version?)","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    iDRAC greater than 4.40.00.00 is required. Compared to ``idrac-wsman``"},{"line_number":9,"context_line":"    implementation does not yet support foreign disks and converting from"},{"line_number":10,"context_line":"    non-RAID mode."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ab163f25_32fba786","line":8,"in_reply_to":"f0989d3d_1caaa4b5","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22b7a290d0761c6d1739d9c8854de4e882b7bedb","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    iDRAC firmware greater than 4.40.00.00 is required. Compared to"},{"line_number":9,"context_line":"    ``idrac-wsman`` implementation does not yet support foreign disks and"},{"line_number":10,"context_line":"    converting from non-RAID mode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    Backing physical disk hints are not widely tested with ``idrac-redfish``"},{"line_number":13,"context_line":"    yet and they might not work as desired. Backing physical disks"},{"line_number":14,"context_line":"    (``controller``, ``physical_disks``) with ``size_gb\u003d\"MAX\"`` are tested."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    The ``idrac`` hardware type now supports ``idrac-wsman``, ``idrac``,"},{"line_number":17,"context_line":"    ``idrac-redfish``, and ``no-raid`` interfaces in given priority"},{"line_number":18,"context_line":"    order."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f296974_40f95910","line":18,"range":{"start_line":8,"start_character":0,"end_line":18,"end_character":10},"updated":"2021-03-15 14:18:58.000000000","message":"I would break this into multiple entries, specifically the notation of limitation.","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ab3fbeea8857b22acd79a9a73db76af2ec667745","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    iDRAC firmware greater than 4.40.00.00 is required. Compared to"},{"line_number":9,"context_line":"    ``idrac-wsman`` implementation does not yet support foreign disks and"},{"line_number":10,"context_line":"    converting from non-RAID mode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    Backing physical disk hints are not widely tested with ``idrac-redfish``"},{"line_number":13,"context_line":"    yet and they might not work as desired. Backing physical disks"},{"line_number":14,"context_line":"    (``controller``, ``physical_disks``) with ``size_gb\u003d\"MAX\"`` are tested."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    The ``idrac`` hardware type now supports ``idrac-wsman``, ``idrac``,"},{"line_number":17,"context_line":"    ``idrac-redfish``, and ``no-raid`` interfaces in given priority"},{"line_number":18,"context_line":"    order."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a2c9cf37_15fe1225","line":18,"range":{"start_line":8,"start_character":0,"end_line":18,"end_character":10},"in_reply_to":"9f296974_40f95910","updated":"2021-03-19 16:17:34.000000000","message":"it\u0027s all in one the same way as for generic redfish[1], so I\u0027d keep the same approach.\n\n[1] https://opendev.org/openstack/ironic/src/branch/master/releasenotes/notes/redfish-raid-interface-e362e7a0e7140962.yaml","commit_id":"b66ba4d49f61a883e2a1f54f2114cfcc86032562"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0dcab88118060a1d55095138f4a202f9076086e4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds basic support for managing RAID configuration via the Redfish"},{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    iDRAC firmware greater than 4.40.00.00 is required. Compared to"},{"line_number":9,"context_line":"    ``idrac-wsman`` implementation does not yet support foreign disks and"},{"line_number":10,"context_line":"    converting from non-RAID mode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    Backing physical disk hints are not widely tested with ``idrac-redfish``"},{"line_number":13,"context_line":"    yet and they might not work as desired. Backing physical disks"},{"line_number":14,"context_line":"    (``controller``, ``physical_disks``) with ``size_gb\u003d\"MAX\"`` are tested."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    The ``idrac`` hardware type now supports ``idrac-wsman``, ``idrac``,"},{"line_number":17,"context_line":"    ``idrac-redfish``, and ``no-raid`` interfaces in given priority"},{"line_number":18,"context_line":"    order."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1cec75e9_52749ff5","line":18,"range":{"start_line":3,"start_character":0,"end_line":18,"end_character":10},"updated":"2021-03-22 14:26:00.000000000","message":"On the review jam, we\u0027ve discussed merging this together into likey two paragraphs to kind of prevent it being misinterpretted as features on the rendered output..","commit_id":"952695be334c2d68b3abc8315822e512a1caf900"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5d252de6dfb66d87436ddfe7321b27d09bfcbbd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds basic support for managing RAID configuration via the Redfish"},{"line_number":5,"context_line":"    out-of-band (OOB) management protocol to the ``idrac`` hardware type by"},{"line_number":6,"context_line":"    adding new interface named ``idrac-redfish``."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    iDRAC firmware greater than 4.40.00.00 is required. Compared to"},{"line_number":9,"context_line":"    ``idrac-wsman`` implementation does not yet support foreign disks and"},{"line_number":10,"context_line":"    converting from non-RAID mode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    Backing physical disk hints are not widely tested with ``idrac-redfish``"},{"line_number":13,"context_line":"    yet and they might not work as desired. Backing physical disks"},{"line_number":14,"context_line":"    (``controller``, ``physical_disks``) with ``size_gb\u003d\"MAX\"`` are tested."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    The ``idrac`` hardware type now supports ``idrac-wsman``, ``idrac``,"},{"line_number":17,"context_line":"    ``idrac-redfish``, and ``no-raid`` interfaces in given priority"},{"line_number":18,"context_line":"    order."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4884b6f5_79223dd6","line":18,"range":{"start_line":3,"start_character":0,"end_line":18,"end_character":10},"in_reply_to":"1cec75e9_52749ff5","updated":"2021-03-23 10:05:59.000000000","message":"followup - https://review.opendev.org/c/openstack/ironic/+/782391\nRemoved some paragraphs from the release note - that info is in docs. Otherwise keeping same info in 1-2 paragraphs makes this wall of text.","commit_id":"952695be334c2d68b3abc8315822e512a1caf900"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1832f6a545acfaa7ae364d58b1fa71bcffb386d8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    ibmc \u003d ironic.drivers.modules.ibmc.raid:IbmcRAID"},{"line_number":143,"context_line":"    idrac \u003d ironic.drivers.modules.drac.raid:DracRAID"},{"line_number":144,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.raid:DracWSManRAID"},{"line_number":145,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.raid:DracRedfishRAID"},{"line_number":146,"context_line":"    ilo5 \u003d ironic.drivers.modules.ilo.raid:Ilo5RAID"},{"line_number":147,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.raid:IRMCRAID"},{"line_number":148,"context_line":"    no-raid \u003d ironic.drivers.modules.noop:NoRAID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"051e0215_4bd8754d","line":145,"updated":"2021-03-10 15:19:38.000000000","message":"nit: r goes before w","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33941d0120623f0c7f292c7219b0d6d32fd7823f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    ibmc \u003d ironic.drivers.modules.ibmc.raid:IbmcRAID"},{"line_number":143,"context_line":"    idrac \u003d ironic.drivers.modules.drac.raid:DracRAID"},{"line_number":144,"context_line":"    idrac-wsman \u003d ironic.drivers.modules.drac.raid:DracWSManRAID"},{"line_number":145,"context_line":"    idrac-redfish \u003d ironic.drivers.modules.drac.raid:DracRedfishRAID"},{"line_number":146,"context_line":"    ilo5 \u003d ironic.drivers.modules.ilo.raid:Ilo5RAID"},{"line_number":147,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.raid:IRMCRAID"},{"line_number":148,"context_line":"    no-raid \u003d ironic.drivers.modules.noop:NoRAID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"31226805_75474616","line":145,"in_reply_to":"051e0215_4bd8754d","updated":"2021-03-12 11:37:08.000000000","message":"done","commit_id":"221ba825a07a0e509eb28976057a42e9fa4d9e10"}]}