)]}'
{"ironic/common/swift.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c2bb946481d4cf994847d9dd8b7579769dbc9c0f","unresolved":true,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        parse_result \u003d urlparse.urlparse(self.connection.url)"},{"line_number":133,"context_line":"        swift_object_path \u003d \u0027/\u0027.join((parse_result.path, container, obj))"},{"line_number":134,"context_line":"        temp_url_key \u003d account_info.get(\u0027x-account-meta-temp-url-key\u0027)"},{"line_number":135,"context_line":"        if not temp_url_key:"},{"line_number":136,"context_line":"            raise exception.MissingParameterValue(_("},{"line_number":137,"context_line":"                \u0027Swift temporary URLs require a shared secret to be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"22566a41_f88fa502","line":134,"updated":"2021-02-24 13:28:02.000000000","message":"since this fails if the key is not set, shouldn\u0027t we wrap this in a try-except?\nWe won\u0027t reach the next line anyway so maybe better fail here.","commit_id":"5533077c7d3c7afafe365173476e5580ea4b4ba0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b898db0298b33e194e22277caa598fec63c0ed4e","unresolved":true,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        parse_result \u003d urlparse.urlparse(self.connection.url)"},{"line_number":133,"context_line":"        swift_object_path \u003d \u0027/\u0027.join((parse_result.path, container, obj))"},{"line_number":134,"context_line":"        temp_url_key \u003d account_info.get(\u0027x-account-meta-temp-url-key\u0027)"},{"line_number":135,"context_line":"        if not temp_url_key:"},{"line_number":136,"context_line":"            raise exception.MissingParameterValue(_("},{"line_number":137,"context_line":"                \u0027Swift temporary URLs require a shared secret to be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"42d25910_867a685f","line":134,"in_reply_to":"22566a41_f88fa502","updated":"2021-02-24 13:38:26.000000000","message":"nvm, this is a get so it will return None if can\u0027t find the entry","commit_id":"5533077c7d3c7afafe365173476e5580ea4b4ba0"}]}