)]}'
{"ironic/common/pxe_utils.py":[{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"cebb3f5d8df64b6d75fca609f5d01059c333f38a","unresolved":true,"context_lines":[{"line_number":1065,"context_line":"    :raises: InvalidKickstartFile"},{"line_number":1066,"context_line":"    \"\"\""},{"line_number":1067,"context_line":"    if not os.path.isfile(\u0027/usr/bin/ksvalidator\u0027):"},{"line_number":1068,"context_line":"        return"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"    with tempfile.NamedTemporaryFile("},{"line_number":1071,"context_line":"            dir\u003dCONF.tempdir, suffix\u003d\u0027.cfg\u0027) as ks_file:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3d4be10b_ad53b539","line":1068,"updated":"2021-03-02 20:13:39.000000000","message":"Add a warning message.","commit_id":"8e823a205a1576f4c180b30605a3347625ed6425"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"aa7b7973a5d70528126cc578a16507f02b765915","unresolved":true,"context_lines":[{"line_number":1073,"context_line":"    :param ks_cfg: Contents of kickstart file to validate"},{"line_number":1074,"context_line":"    :raises: InvalidKickstartFile"},{"line_number":1075,"context_line":"    \"\"\""},{"line_number":1076,"context_line":"    if not os.path.isfile(\u0027/usr/bin/ksvalidator\u0027):"},{"line_number":1077,"context_line":"        LOG.warning("},{"line_number":1078,"context_line":"            \"Unable to validate the kickstart file as ksvalidator binary is \""},{"line_number":1079,"context_line":"            \"missing. Please install pykickstart package to enable \""}],"source_content_type":"text/x-python","patch_set":7,"id":"14fcfafc_7fdf5664","line":1076,"range":{"start_line":1076,"start_character":27,"end_line":1076,"end_character":47},"updated":"2021-03-22 09:34:24.000000000","message":"As i understand this has to be installed on the conductor node. The conductor node can be any OS based. Suppose the conductor node is Ubuntu based, and the OS beind deployed is RHEL. When you run the ksvalidator on conductor node on the kickstart file, will it verify the kickstart syntaxes against Ubuntu OS or RHEL OS? \nThe Ubuntu OS kickstart and RHEL OS kickstart are similar, but there are differences and some of the kickstart options which work on RHEL, do not work on Ubuntu.","commit_id":"051ed66993875822cec8bcb97c3e37c5aedc2f78"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"2b3df76c9c93c75ed5134363bd3ba90dd97f0786","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    :param ks_cfg: Contents of kickstart file to validate"},{"line_number":1074,"context_line":"    :raises: InvalidKickstartFile"},{"line_number":1075,"context_line":"    \"\"\""},{"line_number":1076,"context_line":"    if not os.path.isfile(\u0027/usr/bin/ksvalidator\u0027):"},{"line_number":1077,"context_line":"        LOG.warning("},{"line_number":1078,"context_line":"            \"Unable to validate the kickstart file as ksvalidator binary is \""},{"line_number":1079,"context_line":"            \"missing. Please install pykickstart package to enable \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1e531606_eb107e63","line":1076,"range":{"start_line":1076,"start_character":27,"end_line":1076,"end_character":47},"in_reply_to":"14fcfafc_7fdf5664","updated":"2021-03-22 19:05:52.000000000","message":"Thanks for the question. ksvalidator can be installed on both ubuntu and RHEL. However the tool willvaldiate against RHEL releases ( deploy OS). I do not think this tool will validate kickstart files generated for ubuntu release. We have called out this in the scope of the SPEC https://review.opendev.org/c/openstack/ironic-specs/+/748503/9/specs/approved/anaconda-deploy-interface.rst#117","commit_id":"051ed66993875822cec8bcb97c3e37c5aedc2f78"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f32c81512cfddb2fae446703efeb87772bedd1ec","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    :param ks_cfg: Contents of kickstart file to validate"},{"line_number":1074,"context_line":"    :raises: InvalidKickstartFile"},{"line_number":1075,"context_line":"    \"\"\""},{"line_number":1076,"context_line":"    if not os.path.isfile(\u0027/usr/bin/ksvalidator\u0027):"},{"line_number":1077,"context_line":"        LOG.warning("},{"line_number":1078,"context_line":"            \"Unable to validate the kickstart file as ksvalidator binary is \""},{"line_number":1079,"context_line":"            \"missing. Please install pykickstart package to enable \""}],"source_content_type":"text/x-python","patch_set":7,"id":"7319dc8a_f35278ed","line":1076,"range":{"start_line":1076,"start_character":27,"end_line":1076,"end_character":47},"in_reply_to":"1e531606_eb107e63","updated":"2021-03-24 08:53:03.000000000","message":"I think you didnt get my query well. To make my query clear, breaking it into different questions:\n\n- Where is this tool going to be installed? Is it in the deploy OS? or the conductor node?\n- If ksvalidator has to be installed on conductor node, then it will validate the kickstart for the OS where ksvalidator is installed. The tool cannot validate the kickstart for RHEL if it is installed on Ubuntu node.","commit_id":"051ed66993875822cec8bcb97c3e37c5aedc2f78"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"34f2e34e3d5b1e3d0926be37f70ac24d62956e1a","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    :param ks_cfg: Contents of kickstart file to validate"},{"line_number":1074,"context_line":"    :raises: InvalidKickstartFile"},{"line_number":1075,"context_line":"    \"\"\""},{"line_number":1076,"context_line":"    if not os.path.isfile(\u0027/usr/bin/ksvalidator\u0027):"},{"line_number":1077,"context_line":"        LOG.warning("},{"line_number":1078,"context_line":"            \"Unable to validate the kickstart file as ksvalidator binary is \""},{"line_number":1079,"context_line":"            \"missing. Please install pykickstart package to enable \""}],"source_content_type":"text/x-python","patch_set":7,"id":"f5844e39_dd8fef72","line":1076,"range":{"start_line":1076,"start_character":27,"end_line":1076,"end_character":47},"in_reply_to":"7319dc8a_f35278ed","updated":"2021-03-24 17:30:06.000000000","message":"\u003e Where is this tool going to be installed? Is it in the deploy OS? or the conductor node?\nConductor node.\n\n\u003e  The tool cannot validate the kickstart for RHEL if it is installed on Ubuntu node.\n\nThis is not true. The tool can validate RHEL kickstart files on an ubuntu node. In fact the tool can *only* validate kickstart files generated for RHEL. The tool does not support validating kickstart files generated for ubuntu. But this driver does not support ubuntu/debian as mentioned in the SPEC.\n\nHere is ksvalidator tool on ubuntu http://paste.openstack.org/show/803877/\n\nI have used \u0027ksvalidator -l\u0027 to list supported releases. As you can see it only lists RHEL (RHELx), Fedora(Fxx) and old Fedora Core (FCx) as supported kickstart versions. It also lists \"DEVEL\" as one of the kickstart versions, DEVEL here means lastest kickstart development version of kickstart.","commit_id":"051ed66993875822cec8bcb97c3e37c5aedc2f78"}],"ironic/drivers/modules/pxe_base.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"47034a01a19a5e54de556faf7e7a9a02b00c9cc7","unresolved":true,"context_lines":[{"line_number":239,"context_line":"                task, ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":240,"context_line":"            pxe_utils.cache_ramdisk_kernel(task, instance_image_info,"},{"line_number":241,"context_line":"                                           ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":242,"context_line":"            if \u0027ks_template\u0027 in instance_image_info:"},{"line_number":243,"context_line":"                ks_cfg \u003d pxe_utils.validate_kickstart_template("},{"line_number":244,"context_line":"                    instance_image_info[\u0027ks_template\u0027][1]"},{"line_number":245,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":7,"id":"72bd19f9_4a3488bd","line":242,"updated":"2021-03-19 22:34:56.000000000","message":"Should this be part of the pxe interface validation or the deploy interface validation? Is there a specific reason you put it here?","commit_id":"051ed66993875822cec8bcb97c3e37c5aedc2f78"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"ad01e27280ec6bb9967cf1916deb7c6ad10e15a6","unresolved":true,"context_lines":[{"line_number":239,"context_line":"                task, ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":240,"context_line":"            pxe_utils.cache_ramdisk_kernel(task, instance_image_info,"},{"line_number":241,"context_line":"                                           ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":242,"context_line":"            if \u0027ks_template\u0027 in instance_image_info:"},{"line_number":243,"context_line":"                ks_cfg \u003d pxe_utils.validate_kickstart_template("},{"line_number":244,"context_line":"                    instance_image_info[\u0027ks_template\u0027][1]"},{"line_number":245,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":7,"id":"88ea8352_b742ad35","line":242,"in_reply_to":"72bd19f9_4a3488bd","updated":"2021-03-19 22:39:48.000000000","message":"This is a good question. The kickstart template is not fetched until the line#240 (pxe_utils.cache_ramdisk_kernel) so we can\u0027t validate it until the template is fetched. We could potentially validate the template in pxe interface validation, if the template is fetched before the validation method is called.","commit_id":"051ed66993875822cec8bcb97c3e37c5aedc2f78"}]}