)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"69f245d4a1f14da0b3e714c64471af5c6c66c34b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The agent can be busy from a prior command which may have seemed completed,"},{"line_number":10,"context_line":"but was not actually completed before the next heartbeat came in and was"},{"line_number":11,"context_line":"processed. Since there are a number of potential cases where these sorts"},{"line_number":12,"context_line":"of issues can exist, espesicaly in clusters in an upgrade, it is best to"},{"line_number":13,"context_line":"try and directly guard the failure point since this should be a"},{"line_number":14,"context_line":"survivable error."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"707da73a_3f873993","line":12,"updated":"2021-05-24 03:30:39.000000000","message":"nit: especially","commit_id":"521bb9e7e217b93b4d24409529aace42497a1010"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"69f245d4a1f14da0b3e714c64471af5c6c66c34b","unresolved":true,"context_lines":[{"line_number":605,"context_line":"        except exception.AgentInProgress:"},{"line_number":606,"context_line":"            # Agent is presently wrapping up a prior task which could have"},{"line_number":607,"context_line":"            # been started by custom deployment process. Lets wait until it"},{"line_number":608,"context_line":"            # clears before allowing this to proceed."},{"line_number":609,"context_line":"            LOG.warning(\u0027Agent for %(node)s is presently executing a \u0027"},{"line_number":610,"context_line":"                        \u0027command. Waiting until next heartbeat.\u0027,"},{"line_number":611,"context_line":"                        {\u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"831f4720_8fdc9306","line":608,"updated":"2021-05-24 03:30:39.000000000","message":"Does this toll the timeout for the deploy? Just making sure we aren\u0027t introducing a case where a stuck agent can be stuck in \"wait\" forever.","commit_id":"521bb9e7e217b93b4d24409529aace42497a1010"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fe7db15d4989f46931b7e852819dbb131664a23d","unresolved":true,"context_lines":[{"line_number":605,"context_line":"        except exception.AgentInProgress:"},{"line_number":606,"context_line":"            # Agent is presently wrapping up a prior task which could have"},{"line_number":607,"context_line":"            # been started by custom deployment process. Lets wait until it"},{"line_number":608,"context_line":"            # clears before allowing this to proceed."},{"line_number":609,"context_line":"            LOG.warning(\u0027Agent for %(node)s is presently executing a \u0027"},{"line_number":610,"context_line":"                        \u0027command. Waiting until next heartbeat.\u0027,"},{"line_number":611,"context_line":"                        {\u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"c8383576_da545732","line":608,"in_reply_to":"831f4720_8fdc9306","updated":"2021-06-10 14:29:49.000000000","message":"Hmm, it would still be heartbeating and the heartbeating would still be recorded. Presumably it would just continue forever if the command never returns. :\\","commit_id":"521bb9e7e217b93b4d24409529aace42497a1010"}]}