)]}'
{"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"008a70d6e9af264ee8c1e7713c318bd1f8b310f5","unresolved":true,"context_lines":[{"line_number":304,"context_line":"                          \u0027error\u0027: e})"},{"line_number":305,"context_line":"            LOG.error(error_msg)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            # NOTE(sbaker): HPE Gen9 does not support setting boot mode"},{"line_number":308,"context_line":"            # and raises a 400 Bad Request error when attempted. Raising"},{"line_number":309,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue"},{"line_number":310,"context_line":"            # *only* when get_boot_mode returns None."}],"source_content_type":"text/x-python","patch_set":3,"id":"bd570747_839b2b3d","line":307,"range":{"start_line":307,"start_character":28,"end_line":307,"end_character":37},"updated":"2021-03-10 10:46:42.000000000","message":"HPE Gen9 does not fully support Redfish. Better to use \u0027ilo\u0027 driver with Gen9 hardware. \u0027redfish\u0027 driver is supported with Gen10 hardware onwards.","commit_id":"74e34addd1e45f79f3917c32a7eaef690ba19d23"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"33d8ec50fabfafd39fec45556a5453da6a17bd51","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue"},{"line_number":310,"context_line":"            # *only* when get_boot_mode returns None."},{"line_number":311,"context_line":"            if isinstance(e, sushy.exceptions.BadRequestError):"},{"line_number":312,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":313,"context_line":"                    driver\u003dtask.node.driver, extension\u003d\u0027set_boot_mode\u0027)"},{"line_number":314,"context_line":"            raise exception.RedfishError(error\u003derror_msg)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bd5537ef_b63407f6","line":312,"updated":"2021-03-15 20:09:45.000000000","message":"What about making the comparison with system.boot.mode ? I think it would be None which would actually make this more supportable against various redfish implementations like ?lenovo?.","commit_id":"74e34addd1e45f79f3917c32a7eaef690ba19d23"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7ead1ab9438306faf213b6d26be9d6c1e4a5a170","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue"},{"line_number":310,"context_line":"            # *only* when get_boot_mode returns None."},{"line_number":311,"context_line":"            if isinstance(e, sushy.exceptions.BadRequestError):"},{"line_number":312,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":313,"context_line":"                    driver\u003dtask.node.driver, extension\u003d\u0027set_boot_mode\u0027)"},{"line_number":314,"context_line":"            raise exception.RedfishError(error\u003derror_msg)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"21fd9615_8f3845bc","line":312,"in_reply_to":"bd5537ef_b63407f6","updated":"2021-03-15 20:57:50.000000000","message":"Done, I think this is a more general solution, and is similar to the set_secure_boot_state behaviour","commit_id":"74e34addd1e45f79f3917c32a7eaef690ba19d23"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5fa4da6dce85b16cd9f84b0238c3f9b8163c1b38","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            # getting or setting the boot mode. When setting failed and the"},{"line_number":309,"context_line":"            # mode attribute is missing from the boot field, raising"},{"line_number":310,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue."},{"line_number":311,"context_line":"            if system.boot.get(\u0027mode\u0027) is None:"},{"line_number":312,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":313,"context_line":"                    driver\u003dtask.node.driver, extension\u003d\u0027set_boot_mode\u0027)"},{"line_number":314,"context_line":"            raise exception.RedfishError(error\u003derror_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fbcc6dc_ba41d43c","line":311,"updated":"2021-03-17 14:43:49.000000000","message":"I think we can add Lenovo to this list of hardware that doesn\u0027t really support the field, but I *think* this is actually kind of reasonable.","commit_id":"96acfb56144a3c6bc575d1283acb70c89038fcdd"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b62ed5576a212efa0ddb4f63e10fcacb3cda4620","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            # getting or setting the boot mode. When setting failed and the"},{"line_number":309,"context_line":"            # mode attribute is missing from the boot field, raising"},{"line_number":310,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue."},{"line_number":311,"context_line":"            if system.boot.get(\u0027mode\u0027) is None:"},{"line_number":312,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":313,"context_line":"                    driver\u003dtask.node.driver, extension\u003d\u0027set_boot_mode\u0027)"},{"line_number":314,"context_line":"            raise exception.RedfishError(error\u003derror_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e397d72e_ed11f9f1","line":311,"range":{"start_line":311,"start_character":15,"end_line":311,"end_character":47},"updated":"2021-03-17 18:28:47.000000000","message":"Would be useful to have an info message here with value of boot_mode.","commit_id":"96acfb56144a3c6bc575d1283acb70c89038fcdd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"53523bfc61ef5f9b72c5cf48c4fe0e274df01015","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            # getting or setting the boot mode. When setting failed and the"},{"line_number":309,"context_line":"            # mode attribute is missing from the boot field, raising"},{"line_number":310,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue."},{"line_number":311,"context_line":"            if system.boot.get(\u0027mode\u0027) is None:"},{"line_number":312,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":313,"context_line":"                    driver\u003dtask.node.driver, extension\u003d\u0027set_boot_mode\u0027)"},{"line_number":314,"context_line":"            raise exception.RedfishError(error\u003derror_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2912c89_f0717636","line":311,"in_reply_to":"5fbcc6dc_ba41d43c","updated":"2021-03-19 19:57:30.000000000","message":"Apparently add ZTE to this list that doesn\u0027t have the flag.","commit_id":"96acfb56144a3c6bc575d1283acb70c89038fcdd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"53523bfc61ef5f9b72c5cf48c4fe0e274df01015","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            # getting or setting the boot mode. When setting failed and the"},{"line_number":309,"context_line":"            # mode attribute is missing from the boot field, raising"},{"line_number":310,"context_line":"            # UnsupportedDriverExtension will allow the deploy to continue."},{"line_number":311,"context_line":"            if system.boot.get(\u0027mode\u0027) is None:"},{"line_number":312,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":313,"context_line":"                    driver\u003dtask.node.driver, extension\u003d\u0027set_boot_mode\u0027)"},{"line_number":314,"context_line":"            raise exception.RedfishError(error\u003derror_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e07e53a7_bef17369","line":311,"range":{"start_line":311,"start_character":15,"end_line":311,"end_character":47},"in_reply_to":"e397d72e_ed11f9f1","updated":"2021-03-19 19:57:30.000000000","message":"It does get logged in the error, and it is none, so I think indicating the BMC just appears not to support it works.","commit_id":"96acfb56144a3c6bc575d1283acb70c89038fcdd"}],"releasenotes/notes/redfish-boot-mode-override-not-present-handling-92e7263617e467c4.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"769cdf205c53370cfc0fd1eac5875e0688c80b2e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds handling of Redfish BMC\u0027s which lack a ``BootSourceOverrideMode``"},{"line_number":5,"context_line":"    flag, such that it is no longer a fatal error for a deployment if the BMC"},{"line_number":6,"context_line":"    does not support this field. This most common on BMCs which feature only"},{"line_number":7,"context_line":"    a partial implementation of the ``ComputerSystem`` resource ``boot``,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6296e79f_62a7b454","line":4,"range":{"start_line":4,"start_character":41,"end_line":4,"end_character":45},"updated":"2021-03-19 23:56:32.000000000","message":"nit: lacks","commit_id":"9f221a7d42350f38bc502c1fd79232593cff7ab2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"769cdf205c53370cfc0fd1eac5875e0688c80b2e","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    does not support this field. This most common on BMCs which feature only"},{"line_number":7,"context_line":"    a partial implementation of the ``ComputerSystem`` resource ``boot``,"},{"line_number":8,"context_line":"    but may also be observable on some older generations of BMCs which"},{"line_number":9,"context_line":"    recieved updates to have partial Redfish support."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ca17a6d_6d748609","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"updated":"2021-03-19 23:56:32.000000000","message":"nit: received","commit_id":"9f221a7d42350f38bc502c1fd79232593cff7ab2"}]}