)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"unresolved":false,"context_lines":[{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"},{"line_number":258,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":259,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":260,"context_line":"        msg \u003d (_(\u0027Image size is larger than the root partition size. \u0027"},{"line_number":261,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":262,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FivA%3D","line":259,"updated":"2014-03-17 07:33:00.000000000","message":"i not sure, if only ensure the image_mb \u003c\u003d root_mb is ok for all image, i.e, does the image use /tmp in root, this might cuase some prolem for the image to running. \n\ndo we need a buffer size for image to run smooth?","commit_id":"b473de037ccb6d25d82035e36b15f27a240d020d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"814c71830c57a59eb4e7f54881f0d140c7c37585","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"},{"line_number":258,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":259,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":260,"context_line":"        msg \u003d (_(\u0027Image size is larger than the root partition size. \u0027"},{"line_number":261,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":262,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_6b2d5146","line":259,"in_reply_to":"AAAAWH%2F%2FivA%3D","updated":"2014-05-02 11:37:40.000000000","message":"I would have to introspect into the image to do that and I don\u0027t think we should really. We are now talking about having Ironic deploy windows images and all... so all we can do is check whether the disk partition is too small to support the requested image or not","commit_id":"b473de037ccb6d25d82035e36b15f27a240d020d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2541f77f430d15ceb0ac8e61c7e0d967e27710c7","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        msg \u003d (_(\u0027Image size is larger than the root partition size. \u0027"},{"line_number":261,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":262,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":263,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    discovery(address, port)"},{"line_number":266,"context_line":"    login_iscsi(address, port, iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FkhM%3D","line":263,"updated":"2014-03-05 10:09:08.000000000","message":"I think we should do this earlier w/o callback waiting, in prepare() for example.","commit_id":"b473de037ccb6d25d82035e36b15f27a240d020d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"814c71830c57a59eb4e7f54881f0d140c7c37585","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        msg \u003d (_(\u0027Image size is larger than the root partition size. \u0027"},{"line_number":261,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":262,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":263,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    discovery(address, port)"},{"line_number":266,"context_line":"    login_iscsi(address, port, iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_2b1b491c","line":263,"in_reply_to":"AAAAVn%2F%2FkhM%3D","updated":"2014-05-02 11:37:40.000000000","message":"will do","commit_id":"b473de037ccb6d25d82035e36b15f27a240d020d"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c304249dbcd84c379fafee6bb12394d3cc6cc3b1","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    root_mb \u003d 1024 * int(driver_info[\u0027root_gb\u0027])"},{"line_number":552,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":553,"context_line":"        msg \u003d (_(\u0027Root partition is too small for requested image. \u0027"},{"line_number":554,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":555,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":556,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_65521515","line":554,"updated":"2014-05-07 16:50:22.000000000","message":"Since the root partition must be \u003e\u003d 1 GB, it might actually be better to give the sizes in GB. And to put the unit \u0027GB\u0027 in the msg too ;)","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8682b26a692ebc407680a747e15596289a982bac","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    root_mb \u003d 1024 * int(driver_info[\u0027root_gb\u0027])"},{"line_number":552,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":553,"context_line":"        msg \u003d (_(\u0027Root partition is too small for requested image. \u0027"},{"line_number":554,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":555,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":556,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_4872777d","line":554,"in_reply_to":"7adec928_27f55f83","updated":"2014-05-08 13:43:23.000000000","message":"That\u0027s fine. \n\nI was only thinking that since this is an error message if the root partition is \u003c the image size, and the root partition must be at least 1 GB, it means the image size here must be \u003e 1 GB. So I thought GB might be easier for the user. Not a big deal.","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c6d631e9b89c6cb69f6da6917f46ee6bf7ae0dda","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    root_mb \u003d 1024 * int(driver_info[\u0027root_gb\u0027])"},{"line_number":552,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":553,"context_line":"        msg \u003d (_(\u0027Root partition is too small for requested image. \u0027"},{"line_number":554,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":555,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":556,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_27f55f83","line":554,"in_reply_to":"7adec928_65521515","updated":"2014-05-08 09:17:14.000000000","message":"+1 about showing the unit. \n\nAbout converting it to GB, I would prefer to show both values using the same unit and I think that MB is more accurate when dealing with cloud images because I mostly of them are under 1 GB in size.\n\nThe reason why usually the root partition is much bigger than the image is because clients could use tools like cloud-init to grow the the image filesystem to fit the whole partition.","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e433b94bdf8b1f6005156c54d68fb522d7221ff8","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    root_mb \u003d 1024 * int(driver_info[\u0027root_gb\u0027])"},{"line_number":459,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":460,"context_line":"        msg \u003d (_(\u0027Root partition is too small for requested image. \u0027"},{"line_number":461,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":462,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":463,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_a89cdb6a","line":461,"updated":"2014-05-08 13:50:38.000000000","message":"I thought you were going to add \u0027MB\u0027 to the msg?","commit_id":"925d64dadfafa792181eed99b005f5688ac12152"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"79bf0f40dff18237533189a51ff2b5daf853a5c7","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    root_mb \u003d 1024 * int(driver_info[\u0027root_gb\u0027])"},{"line_number":459,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":460,"context_line":"        msg \u003d (_(\u0027Root partition is too small for requested image. \u0027"},{"line_number":461,"context_line":"                 \u0027Image size: %(image_mb)d, Root size: %(root_mb)d\u0027)"},{"line_number":462,"context_line":"               % {\u0027image_mb\u0027: image_mb, \u0027root_mb\u0027: root_mb})"},{"line_number":463,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_9634a0df","line":461,"in_reply_to":"7adec928_a89cdb6a","updated":"2014-05-08 14:35:18.000000000","message":"ops, thanks for pointing it out, I got lost rebasing my patches today and forgot to reintroduce this change.\n\nwill do","commit_id":"925d64dadfafa792181eed99b005f5688ac12152"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c304249dbcd84c379fafee6bb12394d3cc6cc3b1","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        mock_tftp_img_info.return_value \u003d None"},{"line_number":720,"context_line":"        mock_pxe_config.return_value \u003d None"},{"line_number":721,"context_line":"        mock_cache_images.return_value \u003d None"},{"line_number":722,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":723,"context_line":"            task.driver.deploy.prepare(task, self.node)"},{"line_number":724,"context_line":"            mock_tftp_img_info.assert_called_once_with(self.node,"},{"line_number":725,"context_line":"                                                       self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_65877562","line":722,"updated":"2014-05-07 16:50:22.000000000","message":"it used to be self.node.uuid :-)","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c6d631e9b89c6cb69f6da6917f46ee6bf7ae0dda","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        mock_tftp_img_info.return_value \u003d None"},{"line_number":720,"context_line":"        mock_pxe_config.return_value \u003d None"},{"line_number":721,"context_line":"        mock_cache_images.return_value \u003d None"},{"line_number":722,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":723,"context_line":"            task.driver.deploy.prepare(task, self.node)"},{"line_number":724,"context_line":"            mock_tftp_img_info.assert_called_once_with(self.node,"},{"line_number":725,"context_line":"                                                       self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_8704737f","line":722,"in_reply_to":"7adec928_65877562","updated":"2014-05-08 09:17:14.000000000","message":"done","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c304249dbcd84c379fafee6bb12394d3cc6cc3b1","unresolved":false,"context_lines":[{"line_number":733,"context_line":"    @mock.patch.object(pxe, \u0027_get_tftp_image_info\u0027)"},{"line_number":734,"context_line":"    @mock.patch.object(pxe, \u0027_cache_images\u0027)"},{"line_number":735,"context_line":"    @mock.patch.object(pxe, \u0027_create_pxe_config\u0027)"},{"line_number":736,"context_line":"    def test_prepare_image_too_large(self, mock_pxe_config,"},{"line_number":737,"context_line":"                                     mock_cache_images, mock_tftp_img_info,"},{"line_number":738,"context_line":"                                     mock_img_path, mock_get_img_mb):"},{"line_number":739,"context_line":"        fake_img_path \u003d \u0027/test/path/test.img\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_c51f6908","line":736,"updated":"2014-05-07 16:50:22.000000000","message":"What about a test that shows that an image \u003c root partition is OK?","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c6d631e9b89c6cb69f6da6917f46ee6bf7ae0dda","unresolved":false,"context_lines":[{"line_number":733,"context_line":"    @mock.patch.object(pxe, \u0027_get_tftp_image_info\u0027)"},{"line_number":734,"context_line":"    @mock.patch.object(pxe, \u0027_cache_images\u0027)"},{"line_number":735,"context_line":"    @mock.patch.object(pxe, \u0027_create_pxe_config\u0027)"},{"line_number":736,"context_line":"    def test_prepare_image_too_large(self, mock_pxe_config,"},{"line_number":737,"context_line":"                                     mock_cache_images, mock_tftp_img_info,"},{"line_number":738,"context_line":"                                     mock_img_path, mock_get_img_mb):"},{"line_number":739,"context_line":"        fake_img_path \u003d \u0027/test/path/test.img\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_c7d11bcf","line":736,"in_reply_to":"7adec928_c51f6908","updated":"2014-05-08 09:17:14.000000000","message":"perhaps test_prepare() should check it? I think it makes sense since it\u0027s intent to check for good inputs, I will modify it to do it","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c304249dbcd84c379fafee6bb12394d3cc6cc3b1","unresolved":false,"context_lines":[{"line_number":742,"context_line":"        mock_cache_images.return_value \u003d None"},{"line_number":743,"context_line":"        mock_img_path.return_value \u003d fake_img_path"},{"line_number":744,"context_line":"        mock_get_img_mb.return_value \u003d 999999"},{"line_number":745,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":746,"context_line":"            self.assertRaises(exception.InstanceDeployFailure,"},{"line_number":747,"context_line":"                              task.driver.deploy.prepare, task, self.node)"},{"line_number":748,"context_line":"            mock_tftp_img_info.assert_called_once_with(self.node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_85f3a109","line":745,"updated":"2014-05-07 16:50:22.000000000","message":"could be self.node.uuid","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c6d631e9b89c6cb69f6da6917f46ee6bf7ae0dda","unresolved":false,"context_lines":[{"line_number":742,"context_line":"        mock_cache_images.return_value \u003d None"},{"line_number":743,"context_line":"        mock_img_path.return_value \u003d fake_img_path"},{"line_number":744,"context_line":"        mock_get_img_mb.return_value \u003d 999999"},{"line_number":745,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":746,"context_line":"            self.assertRaises(exception.InstanceDeployFailure,"},{"line_number":747,"context_line":"                              task.driver.deploy.prepare, task, self.node)"},{"line_number":748,"context_line":"            mock_tftp_img_info.assert_called_once_with(self.node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_c7fe7b6b","line":745,"in_reply_to":"7adec928_85f3a109","updated":"2014-05-08 09:17:14.000000000","message":"done","commit_id":"6e296677683c89effa1eed64d892b94d6d6a6159"}]}
