)]}'
{"ironic/nova/virt/ironic/__init__.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9173e0c6418d1489c27bf236e3ffc7ee9634a8fb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from nova.virt.ironic import driver"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"IronicDriver \u003d driver.IronicDriver"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FdkA%3D","line":16,"updated":"2014-03-05 23:33:00.000000000","message":"from ironic.nova.virt.ironic import driver","commit_id":"52e0a47636a82ca092a427c1f68cba418b720348"}],"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9173e0c6418d1489c27bf236e3ffc7ee9634a8fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from nova.openstack.common import loopingcall"},{"line_number":37,"context_line":"from nova.virt import driver as virt_driver"},{"line_number":38,"context_line":"from nova.virt import firewall"},{"line_number":39,"context_line":"from nova.virt.ironic import ironic_states"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Fdjw%3D","line":39,"updated":"2014-03-05 23:33:00.000000000","message":"from ironic.nova.virt.ironic import ironic_states","commit_id":"52e0a47636a82ca092a427c1f68cba418b720348"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9173e0c6418d1489c27bf236e3ffc7ee9634a8fb","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        if \u0027pxe\u0027 in node.driver:"},{"line_number":237,"context_line":"            # add required fields"},{"line_number":238,"context_line":"            pxe_fields \u003d importutils.import_class("},{"line_number":239,"context_line":"                \u0027nova.virt.ironic.ironic_driver_fields.PXE\u0027)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"            patch \u003d []"},{"line_number":242,"context_line":"            for field in pxe_fields.required:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FdjU%3D","line":239,"updated":"2014-03-05 23:33:00.000000000","message":"ironic.nova.virt.ironic.ironic_driver_fields.PXE","commit_id":"52e0a47636a82ca092a427c1f68cba418b720348"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9173e0c6418d1489c27bf236e3ffc7ee9634a8fb","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        if \u0027pxe\u0027 in node.driver:"},{"line_number":263,"context_line":"            # add required fields"},{"line_number":264,"context_line":"            pxe_fields \u003d importutils.import_class("},{"line_number":265,"context_line":"                \u0027nova.virt.ironic.ironic_driver_fields.PXE\u0027)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"            patch \u003d []"},{"line_number":268,"context_line":"            for field in pxe_fields.required:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FdjQ%3D","line":265,"updated":"2014-03-05 23:33:00.000000000","message":"ironic.nova.virt.ironic.ironic_driver_fields.PXE","commit_id":"52e0a47636a82ca092a427c1f68cba418b720348"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d4014582943ca70e1eb3128e3276666b506767a6","unresolved":false,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        icli \u003d self._get_client()"},{"line_number":559,"context_line":"        node \u003d icli.node.get(instance[\u0027node\u0027])"},{"line_number":560,"context_line":"        ports \u003d icli.node.list_ports(node.uuid)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        if len(network_info) \u003e len(ports):"},{"line_number":563,"context_line":"            raise exception.NovaException(_("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FUqQ%3D","line":560,"updated":"2014-03-06 20:50:26.000000000","message":"I am concerned about the # of Ironic API calls that are going to be made as a part of \u0027spawn\u0027. I like having API calls that do verify specific small tasks, but at scale, this is going to be problematic. Unless you change the API, I realize it must be like this, but it\u0027s something that should be considered at some point.\n\nThere\u0027s at least one change I\u0027d like to see in here that\u0027s simple to do. You can move most of this code to a private method that accepts \u0027node\u0027. Since you\u0027ve already grabbed the node in \u0027spawn\u0027, you can pass it in here (or just its uuid, since that\u0027s all you need). That at least saves 1 API call where you\u0027re fetching something you already know in spawn().","commit_id":"f616e239c778fb122fdab38b81a3868ccc120338"}]}
