)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"272d77397db1c0eef7050af63d4e340adacf9962","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add security dashboard clean steps to ilo drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds new clean steps security_parameters_update,"},{"line_number":10,"context_line":"update_minimum_password_length and update_auth_failure_logging_threshold"},{"line_number":11,"context_line":"to allow users to edit following security parameters -"},{"line_number":12,"context_line":"``Password_Complexity``, ``RequiredLoginForiLORBSU``,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e7ef78e8_9369a46d","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":33},"updated":"2021-03-26 11:03:44.000000000","message":"Also update commit message indicating it fetches these params during node inspection.","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e1d28f249db08ad3388913c9031c192d00fdd413","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add security dashboard clean steps to ilo drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds new clean steps security_parameters_update,"},{"line_number":10,"context_line":"update_minimum_password_length and update_auth_failure_logging_threshold"},{"line_number":11,"context_line":"to allow users to edit following security parameters -"},{"line_number":12,"context_line":"``Password_Complexity``, ``RequiredLoginForiLORBSU``,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"911303d2_c9501e69","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":33},"in_reply_to":"e7ef78e8_9369a46d","updated":"2021-03-29 01:58:26.000000000","message":"Done","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"}],"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b7601c814a604dfbb2c05e6b77bad5d000f20570","unresolved":true,"context_lines":[{"line_number":728,"context_line":"    using Smart Update Manager (SUM). It is an inband step associated with"},{"line_number":729,"context_line":"    the ``management`` interface. See `Smart Update Manager (SUM) based firmware update`_"},{"line_number":730,"context_line":"    for more information on usage."},{"line_number":731,"context_line":"  ``security_parameters_update``:"},{"line_number":732,"context_line":"    Updates the Security Parameters. See `Updating security parameters as manual clean step`_"},{"line_number":733,"context_line":"    for user guidance on usage. The supported security parameters for this clean step are:"},{"line_number":734,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``, ``IPMI/DCMI_Over_LAN``,"},{"line_number":735,"context_line":"    ``RequireHostAuthentication`` and ``Secure_Boot``."},{"line_number":736,"context_line":"  ``update_minimum_password_length``:"},{"line_number":737,"context_line":"    Updates the Minimum Password Length security parameter. See"},{"line_number":738,"context_line":"    `Update Minimum Password Length security parameter as manual clean step`_ for user guidance on usage."},{"line_number":739,"context_line":"  ``update_auth_failure_logging_threshold``:"},{"line_number":740,"context_line":"    Updates the Authentication Failure Logging security parameter. See"},{"line_number":741,"context_line":"    `Update Authentication Failure Logging security parameter as manual clean step`_ for user guidance on usage."},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"},{"line_number":744,"context_line":"  operations."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ef688400_129c2a17","line":741,"range":{"start_line":731,"start_character":0,"end_line":741,"end_character":112},"updated":"2021-03-29 22:08:48.000000000","message":"So these parameters being noted in the docs make it less likely that they should be in the reno.","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2eba728253277a7f7104538c40f9265ab268c07b","unresolved":false,"context_lines":[{"line_number":728,"context_line":"    using Smart Update Manager (SUM). It is an inband step associated with"},{"line_number":729,"context_line":"    the ``management`` interface. See `Smart Update Manager (SUM) based firmware update`_"},{"line_number":730,"context_line":"    for more information on usage."},{"line_number":731,"context_line":"  ``security_parameters_update``:"},{"line_number":732,"context_line":"    Updates the Security Parameters. See `Updating security parameters as manual clean step`_"},{"line_number":733,"context_line":"    for user guidance on usage. The supported security parameters for this clean step are:"},{"line_number":734,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``, ``IPMI/DCMI_Over_LAN``,"},{"line_number":735,"context_line":"    ``RequireHostAuthentication`` and ``Secure_Boot``."},{"line_number":736,"context_line":"  ``update_minimum_password_length``:"},{"line_number":737,"context_line":"    Updates the Minimum Password Length security parameter. See"},{"line_number":738,"context_line":"    `Update Minimum Password Length security parameter as manual clean step`_ for user guidance on usage."},{"line_number":739,"context_line":"  ``update_auth_failure_logging_threshold``:"},{"line_number":740,"context_line":"    Updates the Authentication Failure Logging security parameter. See"},{"line_number":741,"context_line":"    `Update Authentication Failure Logging security parameter as manual clean step`_ for user guidance on usage."},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"},{"line_number":744,"context_line":"  operations."}],"source_content_type":"text/x-rst","patch_set":3,"id":"f6ec5e1f_91c44335","line":741,"range":{"start_line":731,"start_character":0,"end_line":741,"end_character":112},"in_reply_to":"ef688400_129c2a17","updated":"2021-04-05 15:50:15.000000000","message":"Done","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b7601c814a604dfbb2c05e6b77bad5d000f20570","unresolved":true,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"Updating security parameters as manual clean step"},{"line_number":1664,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1665,"context_line":""},{"line_number":1666,"context_line":"iLO driver can invoke security parameters update as a manual clean step. Any"},{"line_number":1667,"context_line":"manual cleaning step can only be initiated when a node is in the ``manageable``"},{"line_number":1668,"context_line":"state. Once the manual cleaning is finished, the node will be put in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"28903af9_5121bcac","line":1665,"updated":"2021-03-29 22:08:48.000000000","message":"It occurs to me that all of this is being added., but doesn\u0027t document minimum ilo controller version. I realize that might seem odd, but there are people still out there where ilo6 and ilo7s in data centers and if these features don\u0027t work, then it would be helpful for them to be able to determine that from the documentation.","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2eba728253277a7f7104538c40f9265ab268c07b","unresolved":false,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"Updating security parameters as manual clean step"},{"line_number":1664,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1665,"context_line":""},{"line_number":1666,"context_line":"iLO driver can invoke security parameters update as a manual clean step. Any"},{"line_number":1667,"context_line":"manual cleaning step can only be initiated when a node is in the ``manageable``"},{"line_number":1668,"context_line":"state. Once the manual cleaning is finished, the node will be put in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5cbd987c_d56b25d1","line":1665,"in_reply_to":"28903af9_5121bcac","updated":"2021-04-05 15:50:15.000000000","message":"Done","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b7601c814a604dfbb2c05e6b77bad5d000f20570","unresolved":true,"context_lines":[{"line_number":1744,"context_line":"        \"step\": \"update_minimum_password_length\","},{"line_number":1745,"context_line":"        \"args\": {"},{"line_number":1746,"context_line":"            \"password_length\": \"8\","},{"line_number":1747,"context_line":"            \"ignore\": \"False\""},{"line_number":1748,"context_line":"        }"},{"line_number":1749,"context_line":"    }]"},{"line_number":1750,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"0729e52b_ccfbd6f1","line":1747,"range":{"start_line":1747,"start_character":0,"end_line":1747,"end_character":29},"updated":"2021-03-29 22:08:48.000000000","message":"Operationally, why would anyone want to ignore a parameter they are explicitly setting? This has me extremely confused.","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1451aadac9e893d883f501f3f906eef80c99e275","unresolved":true,"context_lines":[{"line_number":1668,"context_line":"state. Once the manual cleaning is finished, the node will be put in the"},{"line_number":1669,"context_line":"``manageable`` state again. A user can follow steps from :ref:`manual_cleaning`"},{"line_number":1670,"context_line":"to initiate manual cleaning operation on a node. This feature is only supported"},{"line_number":1671,"context_line":"for ``ilo5`` based hardware."},{"line_number":1672,"context_line":""},{"line_number":1673,"context_line":"An example of a manual clean step with ``security_parameters_update`` as the"},{"line_number":1674,"context_line":"only clean step could be::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b1559f92_a1f3a6fa","line":1671,"range":{"start_line":1671,"start_character":4,"end_line":1671,"end_character":12},"updated":"2021-04-06 10:07:19.000000000","message":"s/ ``ilo5`` / iLO5 /","commit_id":"f5413a9bd5fe51c0d37ff7b7ed482f2ae6ed6b2a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1451aadac9e893d883f501f3f906eef80c99e275","unresolved":true,"context_lines":[{"line_number":1736,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"iLO driver can invoke ``Minimum Password Length`` security parameter update as a manual clean"},{"line_number":1739,"context_line":"step. This feature is only supported for ``ilo5`` based hardware."},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"An example of a manual clean step with ``update_minimum_password_length`` as the"},{"line_number":1742,"context_line":"only clean step could be::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"118e9829_9d04ba5c","line":1739,"range":{"start_line":1739,"start_character":41,"end_line":1739,"end_character":49},"updated":"2021-04-06 10:07:19.000000000","message":"ditto","commit_id":"f5413a9bd5fe51c0d37ff7b7ed482f2ae6ed6b2a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1451aadac9e893d883f501f3f906eef80c99e275","unresolved":true,"context_lines":[{"line_number":1758,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1759,"context_line":""},{"line_number":1760,"context_line":"iLO driver can invoke ``Authentication Failure Logging`` security parameter update as a manual clean"},{"line_number":1761,"context_line":"step. This feature is only supported for ``ilo5`` based hardware."},{"line_number":1762,"context_line":""},{"line_number":1763,"context_line":"An example of a manual clean step with ``Authentication Failure Logging`` as the"},{"line_number":1764,"context_line":"only clean step could be::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"768d1e38_be7da759","line":1761,"range":{"start_line":1761,"start_character":40,"end_line":1761,"end_character":49},"updated":"2021-04-06 10:07:19.000000000","message":"ditto","commit_id":"f5413a9bd5fe51c0d37ff7b7ed482f2ae6ed6b2a"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b7601c814a604dfbb2c05e6b77bad5d000f20570","unresolved":true,"context_lines":[{"line_number":151,"context_line":"    \"\"\""},{"line_number":152,"context_line":"    info \u003d sec_param_info or {}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    LOG.debug(\"Validating security param info: %s ... in progress\", info)"},{"line_number":155,"context_line":"    param \u003d info.get(\u0027param\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    if not param:"}],"source_content_type":"text/x-python","patch_set":3,"id":"aec3913a_72cba426","line":154,"range":{"start_line":154,"start_character":50,"end_line":154,"end_character":53},"updated":"2021-03-29 22:08:48.000000000","message":"Nit: this seems a little weird for someone that may be reviewing logs after the fact, even though ... I do it a lot myself ;)","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2eba728253277a7f7104538c40f9265ab268c07b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    \"\"\""},{"line_number":152,"context_line":"    info \u003d sec_param_info or {}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    LOG.debug(\"Validating security param info: %s ... in progress\", info)"},{"line_number":155,"context_line":"    param \u003d info.get(\u0027param\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    if not param:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a611eb87_e28c7485","line":154,"range":{"start_line":154,"start_character":50,"end_line":154,"end_character":53},"in_reply_to":"aec3913a_72cba426","updated":"2021-04-05 15:50:15.000000000","message":"Done","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5aea023289475578364560452e59c144a601c5a3","unresolved":true,"context_lines":[{"line_number":270,"context_line":"                task.node.properties \u003d node_properties"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        # Inspect the hardware for security parameters related information."},{"line_number":273,"context_line":"        # Since it does only apply for Gen10 based hardware, the method"},{"line_number":274,"context_line":"        # inspect_hardware() doesn\u0027t raise an error."},{"line_number":275,"context_line":"        if model and \u0027Gen10\u0027 in model:"},{"line_number":276,"context_line":"            security_params \u003d _get_security_parameters(task.node, ilo_object)"}],"source_content_type":"text/x-python","patch_set":2,"id":"06b375cb_da111655","line":273,"range":{"start_line":273,"start_character":19,"end_line":273,"end_character":38},"updated":"2021-03-26 10:55:23.000000000","message":"s/ does only apply for / applies only for /","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"64b7675774e80ebbb96d560c610d3041ffb2a007","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                task.node.properties \u003d node_properties"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        # Inspect the hardware for security parameters related information."},{"line_number":273,"context_line":"        # Since it does only apply for Gen10 based hardware, the method"},{"line_number":274,"context_line":"        # inspect_hardware() doesn\u0027t raise an error."},{"line_number":275,"context_line":"        if model and \u0027Gen10\u0027 in model:"},{"line_number":276,"context_line":"            security_params \u003d _get_security_parameters(task.node, ilo_object)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfe14288_0104e285","line":273,"range":{"start_line":273,"start_character":19,"end_line":273,"end_character":38},"in_reply_to":"06b375cb_da111655","updated":"2021-03-29 01:41:45.000000000","message":"Done","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5aea023289475578364560452e59c144a601c5a3","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            \"\u0027ignore\u0027 and \u0027enable\u0027 from which \u0027param\u0027 field will be \""},{"line_number":89,"context_line":"            \"mandatory. These fields represent security parameter \""},{"line_number":90,"context_line":"            \"name, ignore flag and state of the security parameter. \""},{"line_number":91,"context_line":"            \"The supported security parameter names will be \""},{"line_number":92,"context_line":"            \"\u0027password_complexity\u0027, \u0027require_login_for_ilo_rbsu\u0027, \""},{"line_number":93,"context_line":"            \"\u0027ipmi_over_lan\u0027, \u0027secure_boot\u0027, \u0027require_host_authentication\u0027. \""},{"line_number":94,"context_line":"            \"The security parameters will be updated (in the order given) \""}],"source_content_type":"text/x-python","patch_set":2,"id":"78b18f98_7d6ce73e","line":91,"range":{"start_line":91,"start_character":52,"end_line":91,"end_character":59},"updated":"2021-03-26 10:55:23.000000000","message":"s/  will be / are /","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"64b7675774e80ebbb96d560c610d3041ffb2a007","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \"\u0027ignore\u0027 and \u0027enable\u0027 from which \u0027param\u0027 field will be \""},{"line_number":89,"context_line":"            \"mandatory. These fields represent security parameter \""},{"line_number":90,"context_line":"            \"name, ignore flag and state of the security parameter. \""},{"line_number":91,"context_line":"            \"The supported security parameter names will be \""},{"line_number":92,"context_line":"            \"\u0027password_complexity\u0027, \u0027require_login_for_ilo_rbsu\u0027, \""},{"line_number":93,"context_line":"            \"\u0027ipmi_over_lan\u0027, \u0027secure_boot\u0027, \u0027require_host_authentication\u0027. \""},{"line_number":94,"context_line":"            \"The security parameters will be updated (in the order given) \""}],"source_content_type":"text/x-python","patch_set":2,"id":"4dac16c5_71f5ead1","line":91,"range":{"start_line":91,"start_character":52,"end_line":91,"end_character":59},"in_reply_to":"78b18f98_7d6ce73e","updated":"2021-03-29 01:41:45.000000000","message":"Done","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5aea023289475578364560452e59c144a601c5a3","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    },"},{"line_number":109,"context_line":"    \u0027ignore\u0027: {"},{"line_number":110,"context_line":"        \u0027description\u0027: ("},{"line_number":111,"context_line":"            \"This argument represents boolean parameter.\""},{"line_number":112,"context_line":"        ),"},{"line_number":113,"context_line":"        \u0027required\u0027: False"},{"line_number":114,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a280279_1b400497","line":111,"range":{"start_line":111,"start_character":14,"end_line":111,"end_character":56},"updated":"2021-03-26 10:55:23.000000000","message":"Need to elaborate on how it gets used.","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"64b7675774e80ebbb96d560c610d3041ffb2a007","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    },"},{"line_number":109,"context_line":"    \u0027ignore\u0027: {"},{"line_number":110,"context_line":"        \u0027description\u0027: ("},{"line_number":111,"context_line":"            \"This argument represents boolean parameter.\""},{"line_number":112,"context_line":"        ),"},{"line_number":113,"context_line":"        \u0027required\u0027: False"},{"line_number":114,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fb6b7ce_c728cb98","line":111,"range":{"start_line":111,"start_character":14,"end_line":111,"end_character":56},"in_reply_to":"7a280279_1b400497","updated":"2021-03-29 01:41:45.000000000","message":"Done","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5aea023289475578364560452e59c144a601c5a3","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    },"},{"line_number":126,"context_line":"    \u0027ignore\u0027: {"},{"line_number":127,"context_line":"        \u0027description\u0027: ("},{"line_number":128,"context_line":"            \"This argument represents boolean parameter.\""},{"line_number":129,"context_line":"        ),"},{"line_number":130,"context_line":"        \u0027required\u0027: False"},{"line_number":131,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"1daf1c15_51e9067f","line":128,"range":{"start_line":128,"start_character":13,"end_line":128,"end_character":56},"updated":"2021-03-26 10:55:23.000000000","message":"ditto","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"64b7675774e80ebbb96d560c610d3041ffb2a007","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    },"},{"line_number":126,"context_line":"    \u0027ignore\u0027: {"},{"line_number":127,"context_line":"        \u0027description\u0027: ("},{"line_number":128,"context_line":"            \"This argument represents boolean parameter.\""},{"line_number":129,"context_line":"        ),"},{"line_number":130,"context_line":"        \u0027required\u0027: False"},{"line_number":131,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"c54808d0_b8f284c6","line":128,"range":{"start_line":128,"start_character":13,"end_line":128,"end_character":56},"in_reply_to":"1daf1c15_51e9067f","updated":"2021-03-29 01:41:45.000000000","message":"Done","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5aea023289475578364560452e59c144a601c5a3","unresolved":true,"context_lines":[{"line_number":505,"context_line":"                _execute_ilo_step(node, (\u0027update_\u0027 + param), enable, ignore)"},{"line_number":506,"context_line":"                LOG.info(\"%(param)s security parameter for node %(node)s is \""},{"line_number":507,"context_line":"                         \"updated\", {\u0027param\u0027: param, \u0027node\u0027: node.uuid})"},{"line_number":508,"context_line":"        except (exception.MissingParameterValue,"},{"line_number":509,"context_line":"                exception.InvalidParameterValue,"},{"line_number":510,"context_line":"                exception.NodeCleaningFailure):"},{"line_number":511,"context_line":"            LOG.error(\"%(param)s security parameter updation for \""},{"line_number":512,"context_line":"                      \"node: %(node)s failed.\","},{"line_number":513,"context_line":"                      {\u0027param\u0027: param, \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"64adc79b_0f89a942","line":510,"range":{"start_line":508,"start_character":8,"end_line":510,"end_character":47},"updated":"2021-03-26 10:55:23.000000000","message":"These exceptions should not be handled here or needs to be re-raised.","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"64b7675774e80ebbb96d560c610d3041ffb2a007","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                _execute_ilo_step(node, (\u0027update_\u0027 + param), enable, ignore)"},{"line_number":506,"context_line":"                LOG.info(\"%(param)s security parameter for node %(node)s is \""},{"line_number":507,"context_line":"                         \"updated\", {\u0027param\u0027: param, \u0027node\u0027: node.uuid})"},{"line_number":508,"context_line":"        except (exception.MissingParameterValue,"},{"line_number":509,"context_line":"                exception.InvalidParameterValue,"},{"line_number":510,"context_line":"                exception.NodeCleaningFailure):"},{"line_number":511,"context_line":"            LOG.error(\"%(param)s security parameter updation for \""},{"line_number":512,"context_line":"                      \"node: %(node)s failed.\","},{"line_number":513,"context_line":"                      {\u0027param\u0027: param, \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"45f65e82_5a88e8e4","line":510,"range":{"start_line":508,"start_character":8,"end_line":510,"end_character":47},"in_reply_to":"64adc79b_0f89a942","updated":"2021-03-29 01:41:45.000000000","message":"Done. Reraised","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1451aadac9e893d883f501f3f906eef80c99e275","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    \u0027ignore\u0027: {"},{"line_number":110,"context_line":"        \u0027description\u0027: ("},{"line_number":111,"context_line":"            \"This argument represents boolean parameter. If set \u0027True\u0027 the \""},{"line_number":112,"context_line":"            \"security parameters will be ignored. If not specified, default \""},{"line_number":113,"context_line":"            \"will be \u0027False\u0027.\""},{"line_number":114,"context_line":"        ),"},{"line_number":115,"context_line":"        \u0027required\u0027: False"}],"source_content_type":"text/x-python","patch_set":4,"id":"02915944_0408ffa2","line":112,"range":{"start_line":112,"start_character":41,"end_line":112,"end_character":48},"updated":"2021-04-06 10:07:19.000000000","message":"s/ ignored / ignored by iLO while computing the overall iLO security status/","commit_id":"f5413a9bd5fe51c0d37ff7b7ed482f2ae6ed6b2a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1451aadac9e893d883f501f3f906eef80c99e275","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    \u0027ignore\u0027: {"},{"line_number":129,"context_line":"        \u0027description\u0027: ("},{"line_number":130,"context_line":"            \"This argument represents boolean parameter. If set \u0027True\u0027 the \""},{"line_number":131,"context_line":"            \"security parameters will be ignored. If not specified, default \""},{"line_number":132,"context_line":"            \"will be \u0027False\u0027.\""},{"line_number":133,"context_line":"        ),"},{"line_number":134,"context_line":"        \u0027required\u0027: False"}],"source_content_type":"text/x-python","patch_set":4,"id":"77a19bc7_822a1e3b","line":131,"range":{"start_line":131,"start_character":41,"end_line":131,"end_character":48},"updated":"2021-04-06 10:07:19.000000000","message":"ditto","commit_id":"f5413a9bd5fe51c0d37ff7b7ed482f2ae6ed6b2a"}],"releasenotes/notes/adding-security-param-clean-step-00d5548072a397f2.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5aea023289475578364560452e59c144a601c5a3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding new clean steps - security_parameters_update,"},{"line_number":5,"context_line":"    update_minimum_password_length and update_auth_failure_logging_threshold"},{"line_number":6,"context_line":"    to allow users to edit following security parameters -"},{"line_number":7,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eef61dc8_2f626907","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":26},"updated":"2021-03-26 10:55:23.000000000","message":"s/ new clean steps / new clean steps to ``ilo`` hardware type /","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"64b7675774e80ebbb96d560c610d3041ffb2a007","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding new clean steps - security_parameters_update,"},{"line_number":5,"context_line":"    update_minimum_password_length and update_auth_failure_logging_threshold"},{"line_number":6,"context_line":"    to allow users to edit following security parameters -"},{"line_number":7,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"36f4565e_8a6a39fa","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":26},"in_reply_to":"eef61dc8_2f626907","updated":"2021-03-29 01:41:45.000000000","message":"Done","commit_id":"073c29ec79f9dc65a614cf6101d74cb254b150ca"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b7601c814a604dfbb2c05e6b77bad5d000f20570","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding new clean steps to ``ilo`` hardware type -"},{"line_number":5,"context_line":"    security_parameters_update, update_minimum_password_length"},{"line_number":6,"context_line":"    and update_auth_failure_logging_threshold to allow users to"},{"line_number":7,"context_line":"    edit following security parameters -"},{"line_number":8,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f4b57fa_63cc2e0f","line":5,"updated":"2021-03-29 22:08:48.000000000","message":"please wrap the step names in \"``\" characters to highlight them. ``step1``, ``step2``, and ``step 3``. Also oxford comma is preferred since it is a list.","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2eba728253277a7f7104538c40f9265ab268c07b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding new clean steps to ``ilo`` hardware type -"},{"line_number":5,"context_line":"    security_parameters_update, update_minimum_password_length"},{"line_number":6,"context_line":"    and update_auth_failure_logging_threshold to allow users to"},{"line_number":7,"context_line":"    edit following security parameters -"},{"line_number":8,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8002d091_21a9b386","line":5,"in_reply_to":"5f4b57fa_63cc2e0f","updated":"2021-04-05 15:50:15.000000000","message":"Done","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b7601c814a604dfbb2c05e6b77bad5d000f20570","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adding new clean steps to ``ilo`` hardware type -"},{"line_number":5,"context_line":"    security_parameters_update, update_minimum_password_length"},{"line_number":6,"context_line":"    and update_auth_failure_logging_threshold to allow users to"},{"line_number":7,"context_line":"    edit following security parameters -"},{"line_number":8,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``,"},{"line_number":9,"context_line":"    ``RequireHostAuthentication``, ``MinPasswordLength``,"},{"line_number":10,"context_line":"    ``IPMI/DCMI_Over_LAN``, ``Authentication_failure_Logging``,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6e4b4b1c_b13216f4","line":7,"updated":"2021-03-29 22:08:48.000000000","message":"Why not just end this sentence saying something like \"to enable modified BMC system security settings.``, and just make sure all of the parameters are in docs.","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2eba728253277a7f7104538c40f9265ab268c07b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adding new clean steps to ``ilo`` hardware type -"},{"line_number":5,"context_line":"    security_parameters_update, update_minimum_password_length"},{"line_number":6,"context_line":"    and update_auth_failure_logging_threshold to allow users to"},{"line_number":7,"context_line":"    edit following security parameters -"},{"line_number":8,"context_line":"    ``Password_Complexity``, ``RequiredLoginForiLORBSU``,"},{"line_number":9,"context_line":"    ``RequireHostAuthentication``, ``MinPasswordLength``,"},{"line_number":10,"context_line":"    ``IPMI/DCMI_Over_LAN``, ``Authentication_failure_Logging``,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b336a5e3_fdca47b3","line":7,"in_reply_to":"6e4b4b1c_b13216f4","updated":"2021-04-05 15:50:15.000000000","message":"Done","commit_id":"14f4819462b2c62bb7947177823230ed9f0f7bc8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1451aadac9e893d883f501f3f906eef80c99e275","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding new clean steps to ``ilo`` hardware type -"},{"line_number":5,"context_line":"    ``security_parameters_update``, ``update_minimum_password_length``,"},{"line_number":6,"context_line":"    and ``update_auth_failure_logging_threshold`` which allows users to"},{"line_number":7,"context_line":"    modify ilo system security settings."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dd26b4f8_609c108d","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":37},"updated":"2021-04-06 10:07:19.000000000","message":"s/ ``ilo``  hardware type / ``ilo`` and ``ilo5``  hardware types /","commit_id":"f5413a9bd5fe51c0d37ff7b7ed482f2ae6ed6b2a"}]}