)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aae6bfafbf4fe68597c0fadf49d0c53bbbf804d0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up of Use OOB inspection to fetch MACs for IB inspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a follow up to Change-Id: I3debcd1f32a2627dafd8456ec73a71fc7c402ebb"},{"line_number":10,"context_line":"addressing issues with excessive logging and adding a missing unit test."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I827fa5dd813acbf1d478c64508f10c42d1460b4a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"00228949_54f82618","line":9,"updated":"2021-03-24 08:41:43.000000000","message":"nit: we usually mention commit IDs so that they make sense outside of gerrit","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"80f0221647520ca6be51aa159f651804be93e27c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up of Use OOB inspection to fetch MACs for IB inspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a follow up to Change-Id: I3debcd1f32a2627dafd8456ec73a71fc7c402ebb"},{"line_number":10,"context_line":"addressing issues with excessive logging and adding a missing unit test."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I827fa5dd813acbf1d478c64508f10c42d1460b4a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f05ab794_2630f94a","line":9,"in_reply_to":"00228949_54f82618","updated":"2021-03-24 10:07:12.000000000","message":"Done.","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aae6bfafbf4fe68597c0fadf49d0c53bbbf804d0","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        if nic_state \u003d\u003d sushy.STATE_ENABLED}"},{"line_number":371,"context_line":"        return enabled_macs"},{"line_number":372,"context_line":"    else:"},{"line_number":373,"context_line":"        LOG.debug(\"No NIC information discovered \""},{"line_number":374,"context_line":"                  \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"6950b843_ce712753","line":373,"updated":"2021-03-24 08:41:43.000000000","message":"Let\u0027s be more specific here: \"No ethernet interface information is available for node %s\"","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"80f0221647520ca6be51aa159f651804be93e27c","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        if nic_state \u003d\u003d sushy.STATE_ENABLED}"},{"line_number":371,"context_line":"        return enabled_macs"},{"line_number":372,"context_line":"    else:"},{"line_number":373,"context_line":"        LOG.debug(\"No NIC information discovered \""},{"line_number":374,"context_line":"                  \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"105cd217_65cf4cdc","line":373,"in_reply_to":"6950b843_ce712753","updated":"2021-03-24 10:07:12.000000000","message":"Done.","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"}],"ironic/tests/unit/drivers/modules/redfish/test_management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aae6bfafbf4fe68597c0fadf49d0c53bbbf804d0","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"        system_mock.ethernet_interfaces.summary \u003d None"},{"line_number":1522,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1523,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":1524,"context_line":"            self.assertIsNone(expected_properties,"},{"line_number":1525,"context_line":"                              task.driver.management.get_mac_addresses(task))"}],"source_content_type":"text/x-python","patch_set":2,"id":"40038beb_f96cdf4c","line":1524,"updated":"2021-03-24 08:41:43.000000000","message":"this asserts that None is None (the 2nd argument is an error message that is never used because expected_properties is always None)","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1ad1974e8eb9a625dd935194549843a966fc8f39","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"        system_mock.ethernet_interfaces.summary \u003d None"},{"line_number":1522,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1523,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":1524,"context_line":"            self.assertIsNone(expected_properties,"},{"line_number":1525,"context_line":"                              task.driver.management.get_mac_addresses(task))"}],"source_content_type":"text/x-python","patch_set":2,"id":"711d57ce_683f2e2e","line":1524,"in_reply_to":"40038beb_f96cdf4c","updated":"2021-03-24 08:47:43.000000000","message":"gah! I ignored the L1518","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"80f0221647520ca6be51aa159f651804be93e27c","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"        system_mock.ethernet_interfaces.summary \u003d None"},{"line_number":1522,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1523,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":1524,"context_line":"            self.assertIsNone(expected_properties,"},{"line_number":1525,"context_line":"                              task.driver.management.get_mac_addresses(task))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fcbc41da_f77c6e7e","line":1524,"in_reply_to":"711d57ce_683f2e2e","updated":"2021-03-24 10:07:12.000000000","message":"Done! Sorry introduced this while addressing a comment i/r/t the original change and didn\u0027t look properly 😊","commit_id":"9c5b82623824c2bd5dc0509ef2a2898451fa791d"}]}