)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"52d8235d4bc817c05abdaea7c63f3e9997f23f52","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Virtual media deployments can be conducted outside of the provisioning"},{"line_number":10,"context_line":"network as long as the node gets an IP address somehow and can reach"},{"line_number":11,"context_line":"ironic and its HTTP server. This changes adds new configuration that"},{"line_number":12,"context_line":"allows to use public IP addresses for virtual media while keeping PXE"},{"line_number":13,"context_line":"boots working and constrained to the provisioning network."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"48463914_b889e84e","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":40},"updated":"2021-03-24 16:44:48.000000000","message":"nit: change","commit_id":"8fcebb319ed337f0c475a8c9bf81c5d78f47b811"}],"ironic/conf/deploy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"be50218eb8fee0768cf3f647d16c36288eef4dd0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                      \"It is used for boot methods such as virtual media, \""},{"line_number":33,"context_line":"                      \"where images could be served outside of the \""},{"line_number":34,"context_line":"                      \"provisioning network. Defaults to http_url.\")),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027public_callback_url\u0027,"},{"line_number":36,"context_line":"               help\u003d_(\"Public URL of the bare metal API that can be used \""},{"line_number":37,"context_line":"                      \"for the agent to call back. It is used for boot \""},{"line_number":38,"context_line":"                      \"methods such as virtual media, where images could be \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9c1f8b18_2ca0f4e6","line":35,"updated":"2021-03-24 14:31:59.000000000","message":"I *like* the delineation, and really was not a fan when we went down the path of killing wanting to kill explicit api url overrides. I guess it might just be more explicit is may be a public path. I\u0027m not a fan of the delineation because I think deployments should be taking measures and exposing endpoints entirely to the public makes me very worried. I guess at the end of the day it is wording and word meaning.","commit_id":"9f8b441d72c78ce24697bee9915825088504246b"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"52d8235d4bc817c05abdaea7c63f3e9997f23f52","unresolved":true,"context_lines":[{"line_number":618,"context_line":""},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"IPA_URL_PARAM_NAME \u003d \u0027ipa-api-url\u0027"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"def build_agent_options(node):"},{"line_number":624,"context_line":"    \"\"\"Build the options to be passed to the agent ramdisk."}],"source_content_type":"text/x-python","patch_set":3,"id":"09d407cb_249eead5","line":621,"updated":"2021-03-24 16:44:48.000000000","message":"nit: should go at the top of the file with the other constants","commit_id":"8fcebb319ed337f0c475a8c9bf81c5d78f47b811"}],"releasenotes/notes/external-ip-5ec9b7b55a90cec4.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6fe981993ca28af3324863ee7ea76f564bd33bd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Makes it possible to deploy nodes outside of the provisioning network"},{"line_number":5,"context_line":"    using virtual media. Set these two new configuration options using an IP"},{"line_number":6,"context_line":"    address that is available to these nodes (both the ramdisk and the BMCs)::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      [deploy]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4f6b2e7c_b5a02d95","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":24},"updated":"2021-03-24 16:41:02.000000000","message":"Not exactly true. It was possible before. It just wasn\u0027t clearly delineated with explicit override options.\n\nMaybe:\n\nProvides operator ability to provide override URL settings required for provisioning/cleaning in the event of virtual media based deployment as these scenarios tend to require more delineation than more traditional deployments as they often have a different environmental security requirement.\n\nDunno, maybe only half of that?","commit_id":"8fcebb319ed337f0c475a8c9bf81c5d78f47b811"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ccddc38a4fe0b9f2deb3b7aa6d0e6ddc0e3b350b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    provisioning/cleaning in the event of virtual media based deployment."},{"line_number":6,"context_line":"    These scenarios tend to require more delineation than more traditional"},{"line_number":7,"context_line":"    deployments as they often have a different environmental security"},{"line_number":8,"context_line":"    requirement. Set these two new configuration options using an IP"},{"line_number":9,"context_line":"    address that is available to these nodes (both the ramdisk and the BMCs)::"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"      [deploy]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9bd7c087_30064890","line":8,"updated":"2021-03-24 16:47:24.000000000","message":"s/requirement/requirements/ but yeah. It actually does work kind of well.","commit_id":"68fdb4f50dbe2c07ec422c9ef6e44e6ad422fd15"}]}