)]}'
{"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e115c6914809e587c01cc2ca57db830444ea3ed","unresolved":true,"context_lines":[{"line_number":1295,"context_line":"    return api.request.version.minor \u003e\u003d versions.MINOR_37_NODE_TRAITS"},{"line_number":1296,"context_line":""},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"def allow_deploy_verb():"},{"line_number":1299,"context_line":"    \"\"\"Check if we should allow the use of deploy verb for deploy"},{"line_number":1300,"context_line":""},{"line_number":1301,"context_line":"    state."}],"source_content_type":"text/x-python","patch_set":1,"id":"35b5d535_e7d54960","line":1298,"updated":"2021-03-31 12:45:12.000000000","message":"I don\u0027t this you use these two new functions? Maybe the change to MIN_VERB_VERSIONS is enough.","commit_id":"aa8a7896e401ae219b4e85f77b8e66e3500083b7"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e115c6914809e587c01cc2ca57db830444ea3ed","unresolved":true,"context_lines":[{"line_number":185,"context_line":"MINOR_70_CLEAN_DISABLE_RAMDISK \u003d 70"},{"line_number":186,"context_line":"MINOR_71_RBAC_SCOPES \u003d 71"},{"line_number":187,"context_line":"MINOR_72_DEPLOY_VERB \u003d 72"},{"line_number":188,"context_line":"MINOR_73_UNDEPLOY_VERB \u003d 73"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# When adding another version, update:"},{"line_number":191,"context_line":"# - MINOR_MAX_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7d00f8f_ef65bc37","line":188,"updated":"2021-03-31 12:45:12.000000000","message":"It makes sense to use only one version for both additions.\n\nPlease also update doc/source/contributor/webapi-version-history.rst","commit_id":"aa8a7896e401ae219b4e85f77b8e66e3500083b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e115c6914809e587c01cc2ca57db830444ea3ed","unresolved":true,"context_lines":[{"line_number":193,"context_line":"#   explanation of what changed in the new version"},{"line_number":194,"context_line":"# - common/release_mappings.py, RELEASE_MAPPING[\u0027master\u0027][\u0027api\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"MINOR_MAX_VERSION \u003d MINOR_71_RBAC_SCOPES"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"# String representations of the minor and maximum versions"},{"line_number":199,"context_line":"_MIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_1_INITIAL_VERSION)"}],"source_content_type":"text/x-python","patch_set":1,"id":"277f2d65_278f4715","line":196,"updated":"2021-03-31 12:45:12.000000000","message":"You need to adjust this constant.","commit_id":"aa8a7896e401ae219b4e85f77b8e66e3500083b7"}],"ironic/common/states.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e115c6914809e587c01cc2ca57db830444ea3ed","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\"\"\" Node is successfully deployed and associated with an instance. \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"DEPLOY \u003d \u0027deploy\u0027"},{"line_number":102,"context_line":"\"\"\" Node is successfully deployed and associated with an instance. \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":105,"context_line":"\"\"\" Node is waiting to be deployed."}],"source_content_type":"text/x-python","patch_set":1,"id":"cbaed75f_e9301ebb","line":102,"updated":"2021-03-31 12:45:12.000000000","message":"Let\u0027s mention that it\u0027s an alias for ACTIVE","commit_id":"aa8a7896e401ae219b4e85f77b8e66e3500083b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e115c6914809e587c01cc2ca57db830444ea3ed","unresolved":true,"context_lines":[{"line_number":140,"context_line":"\"\"\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"UNDEPLOY \u003d \u0027undeploy\u0027"},{"line_number":143,"context_line":"\"\"\" Node tear down was successful.\"\"\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"CLEANING \u003d \u0027cleaning\u0027"},{"line_number":146,"context_line":"\"\"\" Node is being automatically cleaned to prepare it for provisioning. \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"8a8338cf_f9ad635e","line":143,"updated":"2021-03-31 12:45:12.000000000","message":"I think this comment is a bit dated, what it really means is to start the tear down process.","commit_id":"aa8a7896e401ae219b4e85f77b8e66e3500083b7"}]}
