)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c7613510f99acbdffd2530d475d77f7bfb71574a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-05 09:13:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit test to wait_until_get_system_ready."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I334d6d5d7a35557a57ba118bed0a6beedba934d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"deadecce_ad9e427b","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"updated":"2021-04-06 13:09:55.000000000","message":"No period punctuation mark(.) necessary at the end of commit title.","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2234739d0ea61baa09c5c880a7ab0a4a2618b5b4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-05 09:13:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit test to wait_until_get_system_ready."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I334d6d5d7a35557a57ba118bed0a6beedba934d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b835c731_2e42c847","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"in_reply_to":"deadecce_ad9e427b","updated":"2021-04-07 16:08:27.000000000","message":"Done","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"83b4e410bbb24e920802f9f5bf555f2a3a2e2c08","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up to add iDRAC management via Redfish"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add unit test to wait until system ready."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Folloup to change: Iad69c8d7cf3a373f5cfcc619a479a106efa2e4d4"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cd1fb95d_f258b398","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"updated":"2021-04-12 14:00:29.000000000","message":"\"This change adds\"(grammar) or just \"Add unit tests to ... \" (shorter \u0026 there are 2 tests added)","commit_id":"190ccc649a70f6b732a5137ca1d7f2081dec9e7e"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"83b4e410bbb24e920802f9f5bf555f2a3a2e2c08","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up to add iDRAC management via Redfish"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add unit test to wait until system ready."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Folloup to change: Iad69c8d7cf3a373f5cfcc619a479a106efa2e4d4"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e24a659d_53c78d83","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":52},"updated":"2021-04-12 14:00:29.000000000","message":"instead of \"wait until system ready\" could use the method name and also include context/module (redfish utils).","commit_id":"190ccc649a70f6b732a5137ca1d7f2081dec9e7e"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"83b4e410bbb24e920802f9f5bf555f2a3a2e2c08","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add unit test to wait until system ready."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Folloup to change: Iad69c8d7cf3a373f5cfcc619a479a106efa2e4d4"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I334d6d5d7a35557a57ba118bed0a6beedba934d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9cb7923b_21d24774","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2021-04-12 14:00:29.000000000","message":"typo: Followup","commit_id":"190ccc649a70f6b732a5137ca1d7f2081dec9e7e"}],"ironic/tests/unit/drivers/modules/redfish/test_utils.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c7613510f99acbdffd2530d475d77f7bfb71574a","unresolved":true,"context_lines":[{"line_number":379,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":380,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":381,"context_line":"                \u0027SessionCache._sessions\u0027, {})"},{"line_number":382,"context_line":"    def test_wait_until_get_system_ready(self, mock_sushy):"},{"line_number":383,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":384,"context_line":"        fake_system \u003d fake_conn.get_system.return_value"},{"line_number":385,"context_line":"        response \u003d redfish_utils.wait_until_get_system_ready(self.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"01d9fb18_68cfd8cf","line":382,"range":{"start_line":382,"start_character":8,"end_line":382,"end_character":40},"updated":"2021-04-06 13:09:55.000000000","message":"update this test case to also test for retries - e.g., fail with the first attempt, retry one more time and succeed with the second attempt. Assert that get_system was called 2 times.","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2234739d0ea61baa09c5c880a7ab0a4a2618b5b4","unresolved":true,"context_lines":[{"line_number":379,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":380,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":381,"context_line":"                \u0027SessionCache._sessions\u0027, {})"},{"line_number":382,"context_line":"    def test_wait_until_get_system_ready(self, mock_sushy):"},{"line_number":383,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":384,"context_line":"        fake_system \u003d fake_conn.get_system.return_value"},{"line_number":385,"context_line":"        response \u003d redfish_utils.wait_until_get_system_ready(self.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9de32673_d8e07043","line":382,"range":{"start_line":382,"start_character":8,"end_line":382,"end_character":40},"in_reply_to":"01d9fb18_68cfd8cf","updated":"2021-04-07 16:08:27.000000000","message":"Done","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c7613510f99acbdffd2530d475d77f7bfb71574a","unresolved":true,"context_lines":[{"line_number":388,"context_line":"            \u0027/redfish/v1/Systems/FAKESYSTEM\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":391,"context_line":"    def test_wait_until_get_system_ready_with_connection_error(self,"},{"line_number":392,"context_line":"                                                               mock_sushy):"},{"line_number":393,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":394,"context_line":"        fake_conn.get_system.side_effect \u003d sushy.exceptions.BadRequestError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a73dd3b_cbbe8add","line":391,"range":{"start_line":391,"start_character":8,"end_line":391,"end_character":62},"updated":"2021-04-06 13:09:55.000000000","message":"update this test to also test for retries, e.g., configure connection_attempts to 2, fail both times, assert that get_system was called 2 times.","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2234739d0ea61baa09c5c880a7ab0a4a2618b5b4","unresolved":true,"context_lines":[{"line_number":388,"context_line":"            \u0027/redfish/v1/Systems/FAKESYSTEM\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":391,"context_line":"    def test_wait_until_get_system_ready_with_connection_error(self,"},{"line_number":392,"context_line":"                                                               mock_sushy):"},{"line_number":393,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":394,"context_line":"        fake_conn.get_system.side_effect \u003d sushy.exceptions.BadRequestError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"14cac6de_545f757c","line":391,"range":{"start_line":391,"start_character":8,"end_line":391,"end_character":62},"in_reply_to":"7a73dd3b_cbbe8add","updated":"2021-04-07 16:08:27.000000000","message":"Need to discuss.","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c7613510f99acbdffd2530d475d77f7bfb71574a","unresolved":true,"context_lines":[{"line_number":391,"context_line":"    def test_wait_until_get_system_ready_with_connection_error(self,"},{"line_number":392,"context_line":"                                                               mock_sushy):"},{"line_number":393,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":394,"context_line":"        fake_conn.get_system.side_effect \u003d sushy.exceptions.BadRequestError()"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        self.assertRaises(exception.RedfishConnectionError,"},{"line_number":397,"context_line":"                          redfish_utils.wait_until_get_system_ready, self.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"82807737_f91d1efe","line":394,"range":{"start_line":394,"start_character":60,"end_line":394,"end_character":77},"updated":"2021-04-06 13:09:55.000000000","message":"this is missing some init parms for real instance and thus breaking ironic-tox-unit-with-driver-libs tests as reported by Zuul. Fix this and you can check if it works locally before pushing (tox -e unit-with-driver-libs).","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2234739d0ea61baa09c5c880a7ab0a4a2618b5b4","unresolved":true,"context_lines":[{"line_number":391,"context_line":"    def test_wait_until_get_system_ready_with_connection_error(self,"},{"line_number":392,"context_line":"                                                               mock_sushy):"},{"line_number":393,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":394,"context_line":"        fake_conn.get_system.side_effect \u003d sushy.exceptions.BadRequestError()"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        self.assertRaises(exception.RedfishConnectionError,"},{"line_number":397,"context_line":"                          redfish_utils.wait_until_get_system_ready, self.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5000a028_92a93b54","line":394,"range":{"start_line":394,"start_character":60,"end_line":394,"end_character":77},"in_reply_to":"82807737_f91d1efe","updated":"2021-04-07 16:08:27.000000000","message":"Done.","commit_id":"40829628b1d8e9812c5e986c31462cf83350d725"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"643a06a2a366886bdb6cc191ca56a42d1c22f8b9","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        self.assertRaises(exception.RedfishError,"},{"line_number":377,"context_line":"                          redfish_utils.get_update_service, self.node)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":380,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":381,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":382,"context_line":"                \u0027SessionCache._sessions\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"16667967_66e9f670","line":379,"range":{"start_line":379,"start_character":4,"end_line":379,"end_character":59},"updated":"2021-04-08 07:23:26.000000000","message":"is time mock still necessary if connection_retry_interval is set to 0?","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"9689222f8dc8a6ea4b23a2599eac88633e5f01d3","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        self.assertRaises(exception.RedfishError,"},{"line_number":377,"context_line":"                          redfish_utils.get_update_service, self.node)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":380,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":381,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":382,"context_line":"                \u0027SessionCache._sessions\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"e591b801_16e98388","line":379,"range":{"start_line":379,"start_character":4,"end_line":379,"end_character":59},"in_reply_to":"16667967_66e9f670","updated":"2021-04-12 12:37:57.000000000","message":"Yes, Following the other test cases. https://review.opendev.org/c/openstack/ironic/+/784775/2/ironic/tests/unit/drivers/modules/redfish/test_utils.py#210","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"643a06a2a366886bdb6cc191ca56a42d1c22f8b9","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":389,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":390,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":391,"context_line":"                fake_system]"},{"line_number":392,"context_line":"        response \u003d redfish_utils.wait_until_get_system_ready(self.node)"},{"line_number":393,"context_line":"        self.assertEqual(fake_system, response)"},{"line_number":394,"context_line":"        self.assertEqual(fake_conn.get_system.call_count, 2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5874d379_96c60fb8","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":27},"updated":"2021-04-08 07:23:26.000000000","message":"shouldn\u0027t be indented","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"9689222f8dc8a6ea4b23a2599eac88633e5f01d3","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":389,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":390,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":391,"context_line":"                fake_system]"},{"line_number":392,"context_line":"        response \u003d redfish_utils.wait_until_get_system_ready(self.node)"},{"line_number":393,"context_line":"        self.assertEqual(fake_system, response)"},{"line_number":394,"context_line":"        self.assertEqual(fake_conn.get_system.call_count, 2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"34acc481_f40aa466","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":27},"in_reply_to":"5874d379_96c60fb8","updated":"2021-04-12 12:37:57.000000000","message":"Done","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"643a06a2a366886bdb6cc191ca56a42d1c22f8b9","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        self.assertEqual(fake_conn.get_system.call_count, 2)"},{"line_number":395,"context_line":"        fake_conn.get_system.assert_called_with(uri)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":398,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":399,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":400,"context_line":"                \u0027SessionCache._sessions\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"e9623a6c_33eac847","line":397,"range":{"start_line":397,"start_character":1,"end_line":397,"end_character":59},"updated":"2021-04-08 07:23:26.000000000","message":"ditto","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"9689222f8dc8a6ea4b23a2599eac88633e5f01d3","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        self.assertEqual(fake_conn.get_system.call_count, 2)"},{"line_number":395,"context_line":"        fake_conn.get_system.assert_called_with(uri)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":398,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":399,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":400,"context_line":"                \u0027SessionCache._sessions\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"73ad61eb_6fe66038","line":397,"range":{"start_line":397,"start_character":1,"end_line":397,"end_character":59},"in_reply_to":"e9623a6c_33eac847","updated":"2021-04-12 12:37:57.000000000","message":"Done","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"643a06a2a366886bdb6cc191ca56a42d1c22f8b9","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                \u0027SessionCache._sessions\u0027, {})"},{"line_number":401,"context_line":"    def test_wait_until_get_system_ready_with_connection_error(self,"},{"line_number":402,"context_line":"                                                               mock_sushy):"},{"line_number":403,"context_line":"        cfg.CONF.redfish.connection_attempts \u003d 5"},{"line_number":404,"context_line":"        cfg.CONF.redfish.connection_retry_interval \u003d 0"},{"line_number":405,"context_line":"        uri \u003d \u0027/redfish/v1/Systems/FAKESYSTEM\u0027"},{"line_number":406,"context_line":"        fake_conn \u003d mock_sushy.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"6faaf5d8_ea1be723","line":403,"range":{"start_line":403,"start_character":46,"end_line":403,"end_character":48},"updated":"2021-04-08 07:23:26.000000000","message":"why not set to 2? No need to retry for 5 times in this test.","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"9689222f8dc8a6ea4b23a2599eac88633e5f01d3","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                \u0027SessionCache._sessions\u0027, {})"},{"line_number":401,"context_line":"    def test_wait_until_get_system_ready_with_connection_error(self,"},{"line_number":402,"context_line":"                                                               mock_sushy):"},{"line_number":403,"context_line":"        cfg.CONF.redfish.connection_attempts \u003d 5"},{"line_number":404,"context_line":"        cfg.CONF.redfish.connection_retry_interval \u003d 0"},{"line_number":405,"context_line":"        uri \u003d \u0027/redfish/v1/Systems/FAKESYSTEM\u0027"},{"line_number":406,"context_line":"        fake_conn \u003d mock_sushy.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"613affc5_9a7bfa70","line":403,"range":{"start_line":403,"start_character":46,"end_line":403,"end_character":48},"in_reply_to":"6faaf5d8_ea1be723","updated":"2021-04-12 12:37:57.000000000","message":"Done","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"643a06a2a366886bdb6cc191ca56a42d1c22f8b9","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":408,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":409,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":410,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":411,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":412,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":413,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"63742e66_4583b845","line":410,"range":{"start_line":410,"start_character":13,"end_line":410,"end_character":1},"updated":"2021-04-08 07:23:26.000000000","message":"ditto - no need to indent","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"9689222f8dc8a6ea4b23a2599eac88633e5f01d3","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":408,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":409,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":410,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":411,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":412,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":413,"context_line":"                sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"8826db8c_8f85643f","line":410,"range":{"start_line":410,"start_character":13,"end_line":410,"end_character":1},"in_reply_to":"63742e66_4583b845","updated":"2021-04-12 12:37:57.000000000","message":"Done","commit_id":"bc04de9f1ce972799e30ed29e826ab4acb748826"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c19c2a0243ef3aca574b11e15bf4982ccf19184b","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        uri \u003d \u0027/redfish/v1/Systems/FAKESYSTEM\u0027"},{"line_number":386,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":387,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":388,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":389,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":390,"context_line":"             fake_system]"},{"line_number":391,"context_line":"        response \u003d redfish_utils.wait_until_get_system_ready(self.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1991307_b22f806b","line":388,"updated":"2021-04-22 09:09:54.000000000","message":"nit: don\u0027t use \\ unless really necessary, here it\u0027s not:\n\n ... side_effect \u003d [\n    ...\n ]","commit_id":"09581cd0f6a7ebafd4adc96e3036c3f7865ec5cd"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"17debc687179d6c1cf82be5a0ffcc9162b3f911f","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        uri \u003d \u0027/redfish/v1/Systems/FAKESYSTEM\u0027"},{"line_number":386,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":387,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":388,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":389,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":390,"context_line":"             fake_system]"},{"line_number":391,"context_line":"        response \u003d redfish_utils.wait_until_get_system_ready(self.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c1d3ecf_c023d114","line":388,"in_reply_to":"f1991307_b22f806b","updated":"2021-04-23 09:51:18.000000000","message":"Done","commit_id":"09581cd0f6a7ebafd4adc96e3036c3f7865ec5cd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c19c2a0243ef3aca574b11e15bf4982ccf19184b","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        uri \u003d \u0027/redfish/v1/Systems/FAKESYSTEM\u0027"},{"line_number":404,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":405,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":406,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":407,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":408,"context_line":"             sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system)]"},{"line_number":409,"context_line":"        self.assertRaises(exception.RedfishConnectionError,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e139b38_e148e663","line":406,"updated":"2021-04-22 09:09:54.000000000","message":"same","commit_id":"09581cd0f6a7ebafd4adc96e3036c3f7865ec5cd"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"17debc687179d6c1cf82be5a0ffcc9162b3f911f","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        uri \u003d \u0027/redfish/v1/Systems/FAKESYSTEM\u0027"},{"line_number":404,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":405,"context_line":"        fake_system \u003d mock.Mock()"},{"line_number":406,"context_line":"        fake_conn.get_system.side_effect \u003d\\"},{"line_number":407,"context_line":"            [sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system),"},{"line_number":408,"context_line":"             sushy.exceptions.BadRequestError(\u0027GET\u0027, uri, fake_system)]"},{"line_number":409,"context_line":"        self.assertRaises(exception.RedfishConnectionError,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7eb0de58_987258d3","line":406,"in_reply_to":"9e139b38_e148e663","updated":"2021-04-23 09:51:18.000000000","message":"\u003e same\n\nDone","commit_id":"09581cd0f6a7ebafd4adc96e3036c3f7865ec5cd"}]}