)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"508df5f3c83f17c7a2248611b4487caed5471604","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove vmedia kernel parameter for ilo-uefi-https boot interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do not include vmedia kernel parameter while building the ISO for"},{"line_number":10,"context_line":"ilo-uefi-https boot interface of ilo hardware type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: #2008815"},{"line_number":13,"context_line":"Task: #42259"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"425e77d1_ed8d1e37","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":51},"updated":"2021-04-14 06:46:22.000000000","message":"Can you add more details about the error seen and how its related to kernel params.","commit_id":"c49c265ed5da9b2db305fde11f0fc995654a353b"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e9c5016422457ad95d7b5737707b3a7a6c655e2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove vmedia kernel parameter for ilo-uefi-https boot interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do not include vmedia kernel parameter while building the ISO for"},{"line_number":10,"context_line":"ilo-uefi-https boot interface of ilo hardware type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: #2008815"},{"line_number":13,"context_line":"Task: #42259"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cff9405b_a29ad983","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":51},"in_reply_to":"425e77d1_ed8d1e37","updated":"2021-04-15 10:24:55.000000000","message":"Done","commit_id":"c49c265ed5da9b2db305fde11f0fc995654a353b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"def62966818b2995c777ebf9146e5557331af61c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When conductor recreates deploy ISO it adds \u0027boot_method \u003d vmedia\u0027 to ramdisk"},{"line_number":10,"context_line":"parameters which works fine with virtual media boot. However for"},{"line_number":11,"context_line":"\u0027ilo-uefi-https\u0027 boot interface the IPA fails to find a virtual media device"},{"line_number":12,"context_line":"resulting in heartbeat failure."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: #2008815"},{"line_number":15,"context_line":"Task: #42259"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f71566ba_30b7fb87","line":12,"updated":"2021-04-22 09:08:05.000000000","message":"This parameter shouldn\u0027t result in this. Quite the opposite, if you remove it, passing the token will probably won\u0027t work.","commit_id":"3fd88e09c85c19d48b5af07e17979886407db551"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fd8c0871d415247dd7c1f9f7465b4d8fefa140b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When conductor recreates deploy ISO it adds \u0027boot_method \u003d vmedia\u0027 to ramdisk"},{"line_number":10,"context_line":"parameters which works fine with virtual media boot. However for"},{"line_number":11,"context_line":"\u0027ilo-uefi-https\u0027 boot interface the IPA fails to find a virtual media device"},{"line_number":12,"context_line":"resulting in heartbeat failure."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: #2008815"},{"line_number":15,"context_line":"Task: #42259"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b1b1ebaf_e5a759b5","line":12,"in_reply_to":"f71566ba_30b7fb87","updated":"2021-04-27 06:41:22.000000000","message":"It works only when i remove \"boot_method\u003dvmedia\" as it is the case when we use ilo-uefi-https boot interface. See my reply to the other comment.","commit_id":"3fd88e09c85c19d48b5af07e17979886407db551"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"def62966818b2995c777ebf9146e5557331af61c","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":1093,"context_line":"        manager_utils.add_secret_token(node, pregenerated\u003dTrue)"},{"line_number":1094,"context_line":"        ramdisk_params[\u0027ipa-agent-token\u0027] \u003d \\"},{"line_number":1095,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":1096,"context_line":"        task.node.save()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"21372698_01dd870d","line":1095,"updated":"2021-04-22 09:08:05.000000000","message":"This will be broken now.","commit_id":"3fd88e09c85c19d48b5af07e17979886407db551"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fd8c0871d415247dd7c1f9f7465b4d8fefa140b1","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":1093,"context_line":"        manager_utils.add_secret_token(node, pregenerated\u003dTrue)"},{"line_number":1094,"context_line":"        ramdisk_params[\u0027ipa-agent-token\u0027] \u003d \\"},{"line_number":1095,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":1096,"context_line":"        task.node.save()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec8d9553_c3ad2b2f","line":1095,"in_reply_to":"21372698_01dd870d","updated":"2021-04-27 06:41:22.000000000","message":"Didn\u0027t understand why it will break? Actually i have captured the log from the agent. Below is the trace of the exception.\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]: Traceback (most recent call last):\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:   File \"/usr/local/bin/ironic-python-agent\", line 6, in \u003cmodule\u003e\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:     from ironic_python_agent.cmd.agent import run\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:   File \"/opt/ironic-python-agent/lib64/python3.6/site-packages/ironic_python_agent/cmd/agent.py\", line 21, in \u003cmodule\u003e\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:     from ironic_python_agent import agent\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:   File \"/opt/ironic-python-agent/lib64/python3.6/site-packages/ironic_python_agent/agent.py\", line 32, in \u003cmodule\u003e\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:     from ironic_python_agent import config\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:   File \"/opt/ironic-python-agent/lib64/python3.6/site-packages/ironic_python_agent/config.py\", line 24, in \u003cmodule\u003e\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:     APARAMS \u003d utils.get_agent_params()\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:   File \"/opt/ironic-python-agent/lib64/python3.6/site-packages/ironic_python_agent/utils.py\", line 230, in get_agent_params\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:     vmedia_params \u003d _get_vmedia_params()\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:   File \"/opt/ironic-python-agent/lib64/python3.6/site-packages/ironic_python_agent/utils.py\", line 167, in _get_vmedia_params\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]:     raise errors.VirtualMediaBootError(msg)\nApr 14 15:31:32 localhost.localdomain ironic-python-agent[2999]: ironic_python_agent.errors.VirtualMediaBootError: Configuring agent from virtual media failed: Unable to find virtual media device\nApr 14 15:31:32 localhost.localdomain systemd[1]: ironic-python-agent.service: Main process exited, code\u003dexited, status\u003d1/FAILURE\nApr 14 15:31:32 localhost.localdomain systemd[1]: ironic-python-agent.service: Failed with result \u0027exit-code\u0027.\n-- The unit ironic-python-agent.service has entered the \u0027failed\u0027 state with result \u0027exit-code\u0027.\n\nFrom this and debugging further \"_get_vmedia_device()\" is returning None hence this exception. This is expected as we are forcing the agent to look for a virtual media device which doesn\u0027t exist in this case as it is a different boot mechanism (UEFIHTTPS).","commit_id":"3fd88e09c85c19d48b5af07e17979886407db551"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c10f22d1130881c41d7a9687c1003d2013ed9db3","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":1093,"context_line":"        manager_utils.add_secret_token(node, pregenerated\u003dTrue)"},{"line_number":1094,"context_line":"        ramdisk_params[\u0027ipa-agent-token\u0027] \u003d \\"},{"line_number":1095,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":1096,"context_line":"        task.node.save()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"179beccd_e6030921","line":1095,"in_reply_to":"ec8d9553_c3ad2b2f","updated":"2021-04-27 12:58:10.000000000","message":"Configuration will not be read from the virtual media, so the token can\u0027t be pre-generated. So a choice exists. Master everything for specific nodes all the time, OR not. UEFIHTTP it is much harder and ultimately not virtual media based booting, so I think the wisest choise of action is to both remove the hint to virtual media based boot (since it is not in this case), and remove the agent secret token so it can be generated on lookup.","commit_id":"3fd88e09c85c19d48b5af07e17979886407db551"}]}