)]}'
{"api-ref/source/baremetal-api-v1-nodes-bios.inc":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39af7eb5594d9e09a60d952f352537cbcd263548","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Normal response code: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error codes: 404"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Request"},{"line_number":27,"context_line":"-------"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"b066cd2e_236f38f7","line":25,"updated":"2021-05-27 11:35:13.000000000","message":"nit: add ..versionadded for two new params","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"fd6fed2246a85a79ea450f080db75eea60b3096c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Normal response code: 200"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Error codes: 404"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Request"},{"line_number":27,"context_line":"-------"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":15,"id":"4f085343_653fc825","line":25,"in_reply_to":"b066cd2e_236f38f7","updated":"2021-05-27 14:07:03.000000000","message":"Done","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5af06adc801aa6e9078cd173859fb84e1ebaeeb","unresolved":true,"context_lines":[{"line_number":111,"context_line":"Return the content of the specific bios ``bios_setting`` associated with"},{"line_number":112,"context_line":"``node_ident``."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":". versionadded:: 1.74"},{"line_number":115,"context_line":"  Introduced fields from the BIOS registry."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Normal response code: 200"}],"source_content_type":"text/x-c++src","patch_set":18,"id":"0e8d029d_9eb5ea19","line":114,"updated":"2021-05-31 13:54:57.000000000","message":"Missing one more dot in the beginning","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d05ffd912009e83926954840695ed45011fa06bd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Return the content of the specific bios ``bios_setting`` associated with"},{"line_number":112,"context_line":"``node_ident``."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":". versionadded:: 1.74"},{"line_number":115,"context_line":"  Introduced fields from the BIOS registry."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Normal response code: 200"}],"source_content_type":"text/x-c++src","patch_set":18,"id":"250c5a3b_3f4ca391","line":114,"in_reply_to":"0e8d029d_9eb5ea19","updated":"2021-06-01 09:25:20.000000000","message":"Done","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5af06adc801aa6e9078cd173859fb84e1ebaeeb","unresolved":true,"context_lines":[{"line_number":515,"context_line":"bios_setting_attribute_type:"},{"line_number":516,"context_line":"  description: |"},{"line_number":517,"context_line":"    A string describing the type of the Bios setting - \"Enumeration\","},{"line_number":518,"context_line":"    \"Integer\", \"String\", \"Boolean\", or \"Password\".  May be None."},{"line_number":519,"context_line":"  in: body"},{"line_number":520,"context_line":"  required: true"},{"line_number":521,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6ddf103d_b1a29056","line":518,"updated":"2021-05-31 13:54:57.000000000","message":"I wonder if we should be careful with listing Redfish values here and below","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d05ffd912009e83926954840695ed45011fa06bd","unresolved":true,"context_lines":[{"line_number":515,"context_line":"bios_setting_attribute_type:"},{"line_number":516,"context_line":"  description: |"},{"line_number":517,"context_line":"    A string describing the type of the Bios setting - \"Enumeration\","},{"line_number":518,"context_line":"    \"Integer\", \"String\", \"Boolean\", or \"Password\".  May be None."},{"line_number":519,"context_line":"  in: body"},{"line_number":520,"context_line":"  required: true"},{"line_number":521,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5b304640_dfbc2446","line":518,"in_reply_to":"6ddf103d_b1a29056","updated":"2021-06-01 09:25:20.000000000","message":"I think it makes sense since users need to be aware about the possible values they can use in the API.","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"}],"doc/source/contributor/webapi-version-history.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3e6625846f5e84e73f4e715f9a0a00a88329c0ea","unresolved":true,"context_lines":[{"line_number":2,"context_line":"REST API Version History"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"1.74 (Xena, 17.0)"},{"line_number":6,"context_line":"----------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Add support for BIOS registry fields which include details about the BIOS"}],"source_content_type":"text/x-rst","patch_set":17,"id":"c9ac7d54_4559df1b","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":16},"updated":"2021-05-27 16:03:49.000000000","message":"nit: 18.0 or jsut remove it for now","commit_id":"27ad7f86b44425ae6e105b3be512f5e26e1d4a96"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7c9f8a0a01d1aec498c70c5f09e372a50dc56d15","unresolved":false,"context_lines":[{"line_number":2,"context_line":"REST API Version History"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"1.74 (Xena, 17.0)"},{"line_number":6,"context_line":"----------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Add support for BIOS registry fields which include details about the BIOS"}],"source_content_type":"text/x-rst","patch_set":17,"id":"72820ec0_40380c74","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":16},"in_reply_to":"c9ac7d54_4559df1b","updated":"2021-05-27 16:17:03.000000000","message":"Done","commit_id":"27ad7f86b44425ae6e105b3be512f5e26e1d4a96"}],"ironic/api/controllers/v1/bios.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a5af4f209370d50176182c362feca42835702b05","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    @METRICS.timer(\u0027NodeBiosController.get_all\u0027)"},{"line_number":67,"context_line":"    @method.expose()"},{"line_number":68,"context_line":"    @args.validate(fields\u003dargs.string_list, detail\u003dargs.boolean)"},{"line_number":69,"context_line":"    def get_all(self, detail\u003dNone, fields\u003dNone):"},{"line_number":70,"context_line":"        \"\"\"List node bios settings.\"\"\""},{"line_number":71,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("},{"line_number":72,"context_line":"            \u0027baremetal:node:bios:get\u0027, self.node_ident)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ebe3acca_30a2ebdc","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":46},"updated":"2021-05-27 11:29:59.000000000","message":"Fields and detail should be covered by the same microversion","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f2569242be26590b2beba81414f44c2a8065b38f","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        allow_detail_query \u003d api_utils.allow_detail_query_bios"},{"line_number":75,"context_line":"        fields \u003d api_utils.get_request_return_fields(fields, detail,"},{"line_number":76,"context_line":"                                                     _DEFAULT_RETURN_FIELDS,"},{"line_number":77,"context_line":"                                                     allow_detail_query)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        settings \u003d objects.BIOSSettingList.get_by_node_id("},{"line_number":80,"context_line":"            api.request.context, node.id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"77f0a0ed_c2d4b3c3","line":77,"range":{"start_line":77,"start_character":53,"end_line":77,"end_character":71},"updated":"2021-05-27 11:33:52.000000000","message":"Ah, here it is! But only detail is covered there, I think","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"d95e5306ddbebb13c8cbb3b21ecfda0df021e938","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        allow_detail_query \u003d api_utils.allow_detail_query_bios"},{"line_number":75,"context_line":"        fields \u003d api_utils.get_request_return_fields(fields, detail,"},{"line_number":76,"context_line":"                                                     _DEFAULT_RETURN_FIELDS,"},{"line_number":77,"context_line":"                                                     allow_detail_query)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        settings \u003d objects.BIOSSettingList.get_by_node_id("},{"line_number":80,"context_line":"            api.request.context, node.id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fe431383_d3a38f91","line":77,"range":{"start_line":77,"start_character":53,"end_line":77,"end_character":71},"in_reply_to":"77f0a0ed_c2d4b3c3","updated":"2021-05-27 11:53:02.000000000","message":"It should be getting the fields too, see unit test in ironic/tests/unit/api/controllers/v1/test_node.py. The api-ref and other docs are missing any mention of the fields selector though.","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"fd6fed2246a85a79ea450f080db75eea60b3096c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        allow_detail_query \u003d api_utils.allow_detail_query_bios"},{"line_number":75,"context_line":"        fields \u003d api_utils.get_request_return_fields(fields, detail,"},{"line_number":76,"context_line":"                                                     _DEFAULT_RETURN_FIELDS,"},{"line_number":77,"context_line":"                                                     allow_detail_query)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        settings \u003d objects.BIOSSettingList.get_by_node_id("},{"line_number":80,"context_line":"            api.request.context, node.id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"65c10920_f80efcd1","line":77,"range":{"start_line":77,"start_character":53,"end_line":77,"end_character":71},"in_reply_to":"fe431383_d3a38f91","updated":"2021-05-27 14:07:03.000000000","message":"Done","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f2569242be26590b2beba81414f44c2a8065b38f","unresolved":true,"context_lines":[{"line_number":1359,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1360,"context_line":"            \"Invalid query parameter ?detail\u003d%s received.\" % detail)"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    if fields is not None and detail:"},{"line_number":1363,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1364,"context_line":"            \"Can not specify ?detail\u003dTrue and fields in the same request.\")"},{"line_number":1365,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"b40700c1_f0b5f048","line":1362,"range":{"start_line":1362,"start_character":7,"end_line":1362,"end_character":13},"updated":"2021-05-27 11:33:52.000000000","message":"In BIOS case fields should also be covered","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7be7bf86635b8b8415cf382f0925bb84a2a2d5b3","unresolved":true,"context_lines":[{"line_number":1359,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1360,"context_line":"            \"Invalid query parameter ?detail\u003d%s received.\" % detail)"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    if fields is not None and detail:"},{"line_number":1363,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1364,"context_line":"            \"Can not specify ?detail\u003dTrue and fields in the same request.\")"},{"line_number":1365,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9d58e212_2c4225c6","line":1362,"range":{"start_line":1362,"start_character":7,"end_line":1362,"end_character":13},"in_reply_to":"885cab5b_4f7ae030","updated":"2021-05-27 12:05:47.000000000","message":"I mean, we need a copy of line 1358 for fields. Which was not the case in this function before, so we probably need it in bios.py instead.","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"fd6fed2246a85a79ea450f080db75eea60b3096c","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1360,"context_line":"            \"Invalid query parameter ?detail\u003d%s received.\" % detail)"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    if fields is not None and detail:"},{"line_number":1363,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1364,"context_line":"            \"Can not specify ?detail\u003dTrue and fields in the same request.\")"},{"line_number":1365,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"4c834335_82c94101","line":1362,"range":{"start_line":1362,"start_character":7,"end_line":1362,"end_character":13},"in_reply_to":"9d58e212_2c4225c6","updated":"2021-05-27 14:07:03.000000000","message":"Thanks, fixed.","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"d95e5306ddbebb13c8cbb3b21ecfda0df021e938","unresolved":true,"context_lines":[{"line_number":1359,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1360,"context_line":"            \"Invalid query parameter ?detail\u003d%s received.\" % detail)"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    if fields is not None and detail:"},{"line_number":1363,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1364,"context_line":"            \"Can not specify ?detail\u003dTrue and fields in the same request.\")"},{"line_number":1365,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"885cab5b_4f7ae030","line":1362,"range":{"start_line":1362,"start_character":7,"end_line":1362,"end_character":13},"in_reply_to":"b40700c1_f0b5f048","updated":"2021-05-27 11:53:02.000000000","message":"I think I\u0027m missing the context here. Mainly wanted to prevent using both fields and detail selector.","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a9205a3625e0698e95af85fade2303e28857a56","unresolved":true,"context_lines":[{"line_number":1364,"context_line":"            \"Invalid query parameter ?detail\u003d%s received.\" % detail)"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"    if (fields is not None and callable(check_fields_version)"},{"line_number":1367,"context_line":"        and not check_fields_version()):"},{"line_number":1368,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1369,"context_line":"            \"Invalid query parameter ?fields\u003d% received.\" % fields)"},{"line_number":1370,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"f37c5d86_903476b6","line":1367,"updated":"2021-05-27 15:11:48.000000000","message":"nit: missing indent","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba7e14ecb7adbd17c2294fd8996c841aad8e2783","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            \"Invalid query parameter ?detail\u003d%s received.\" % detail)"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"    if (fields is not None and callable(check_fields_version)"},{"line_number":1367,"context_line":"        and not check_fields_version()):"},{"line_number":1368,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1369,"context_line":"            \"Invalid query parameter ?fields\u003d% received.\" % fields)"},{"line_number":1370,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"de77554d_f5332dc8","line":1367,"in_reply_to":"f37c5d86_903476b6","updated":"2021-05-27 15:59:21.000000000","message":"Done","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a9205a3625e0698e95af85fade2303e28857a56","unresolved":true,"context_lines":[{"line_number":1366,"context_line":"    if (fields is not None and callable(check_fields_version)"},{"line_number":1367,"context_line":"        and not check_fields_version()):"},{"line_number":1368,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1369,"context_line":"            \"Invalid query parameter ?fields\u003d% received.\" % fields)"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"    if fields is not None and detail:"},{"line_number":1372,"context_line":"        raise exception.InvalidParameterValue("}],"source_content_type":"text/x-python","patch_set":16,"id":"a1a20ba2_2660b5f3","line":1369,"updated":"2021-05-27 15:11:48.000000000","message":"s/%/%s/","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba7e14ecb7adbd17c2294fd8996c841aad8e2783","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"    if (fields is not None and callable(check_fields_version)"},{"line_number":1367,"context_line":"        and not check_fields_version()):"},{"line_number":1368,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1369,"context_line":"            \"Invalid query parameter ?fields\u003d% received.\" % fields)"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"    if fields is not None and detail:"},{"line_number":1372,"context_line":"        raise exception.InvalidParameterValue("}],"source_content_type":"text/x-python","patch_set":16,"id":"5333e302_9d7793d0","line":1369,"in_reply_to":"a1a20ba2_2660b5f3","updated":"2021-05-27 15:59:21.000000000","message":"Done","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"}],"ironic/db/sqlalchemy/alembic/versions/2bbd96b6ccb9_add_bios_fields_from_registry.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a9205a3625e0698e95af85fade2303e28857a56","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\"\"\"Add fields from BIOS registry"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 2bbd96b6ccb9"},{"line_number":16,"context_line":"Revises: c0455649680c"},{"line_number":17,"context_line":"Create Date: 2021-04-29 08:52:23.938863"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"9fcf5aa3_a688aae6","line":16,"updated":"2021-05-27 15:11:48.000000000","message":"I suspect this is outdated","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba7e14ecb7adbd17c2294fd8996c841aad8e2783","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"Add fields from BIOS registry"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 2bbd96b6ccb9"},{"line_number":16,"context_line":"Revises: c0455649680c"},{"line_number":17,"context_line":"Create Date: 2021-04-29 08:52:23.938863"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"92b92f5c_4a4e4405","line":16,"in_reply_to":"9fcf5aa3_a688aae6","updated":"2021-05-27 15:59:21.000000000","message":"Thanks, good catch!","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a9205a3625e0698e95af85fade2303e28857a56","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# revision identifiers, used by Alembic."},{"line_number":24,"context_line":"revision \u003d \u00272bbd96b6ccb9\u0027"},{"line_number":25,"context_line":"down_revision \u003d \u0027c0455649680c\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":16,"id":"a4c3fcc5_bc110969","line":25,"updated":"2021-05-27 15:11:48.000000000","message":"ditto","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba7e14ecb7adbd17c2294fd8996c841aad8e2783","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# revision identifiers, used by Alembic."},{"line_number":24,"context_line":"revision \u003d \u00272bbd96b6ccb9\u0027"},{"line_number":25,"context_line":"down_revision \u003d \u0027c0455649680c\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":16,"id":"1d616bc9_635ec425","line":25,"in_reply_to":"a4c3fcc5_bc110969","updated":"2021-05-27 15:59:21.000000000","message":"Done","commit_id":"407b66071eeea00b307e8dc38f037af5b9c63390"}],"ironic/objects/bios.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"a292ceb97b7b16963bf50f82f93d84fcb3c15359","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        for field in self.get_registry_fields():"},{"line_number":157,"context_line":"            field_is_set \u003d self.obj_attr_is_set(field)"},{"line_number":158,"context_line":"            if target_version \u003e\u003d (1, 74):"},{"line_number":159,"context_line":"                # target version supports the major/minor specified"}],"source_content_type":"text/x-python","patch_set":18,"id":"385a6058_882f3214","line":156,"updated":"2026-01-06 22:39:53.000000000","message":"https://bugs.launchpad.net/ironic/+bug/2137596","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5af06adc801aa6e9078cd173859fb84e1ebaeeb","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        for field in self.get_registry_fields():"},{"line_number":157,"context_line":"            field_is_set \u003d self.obj_attr_is_set(field)"},{"line_number":158,"context_line":"            if target_version \u003e\u003d (1, 74):"},{"line_number":159,"context_line":"                # target version supports the major/minor specified"},{"line_number":160,"context_line":"                if not field_is_set:"},{"line_number":161,"context_line":"                    # set it to its default value if it is not set"}],"source_content_type":"text/x-python","patch_set":18,"id":"ed27f217_8b176278","line":158,"updated":"2021-05-31 13:54:57.000000000","message":"(1, 1) since it\u0027s the Object version, not the API version","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d05ffd912009e83926954840695ed45011fa06bd","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        for field in self.get_registry_fields():"},{"line_number":157,"context_line":"            field_is_set \u003d self.obj_attr_is_set(field)"},{"line_number":158,"context_line":"            if target_version \u003e\u003d (1, 74):"},{"line_number":159,"context_line":"                # target version supports the major/minor specified"},{"line_number":160,"context_line":"                if not field_is_set:"},{"line_number":161,"context_line":"                    # set it to its default value if it is not set"}],"source_content_type":"text/x-python","patch_set":18,"id":"48a6a2a5_48ade250","line":158,"in_reply_to":"ed27f217_8b176278","updated":"2021-06-01 09:25:20.000000000","message":"Done","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"}],"ironic/tests/unit/api/controllers/v1/test_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7be7bf86635b8b8415cf382f0925bb84a2a2d5b3","unresolved":true,"context_lines":[{"line_number":6791,"context_line":"                \u0027name\u0027: \u0027virtualization\u0027, \u0027value\u0027: \u0027on\u0027}]"},{"line_number":6792,"context_line":"        self.assertEqual({\u0027bios\u0027: expected_json}, ret)"},{"line_number":6793,"context_line":""},{"line_number":6794,"context_line":"    def test_get_all_bios_detail_old_version(self):"},{"line_number":6795,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?detail\u003dTrue\u0027 % self.node.uuid,"},{"line_number":6796,"context_line":"                            headers\u003d{api_base.Version.string: \"1.72\"},"},{"line_number":6797,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":6798,"context_line":""},{"line_number":6799,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_int)"},{"line_number":6800,"context_line":""},{"line_number":6801,"context_line":"    def test_get_bios_fields(self):"},{"line_number":6802,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?fields\u003dname,read_only\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"0b221073_5fa0ee8a","line":6799,"range":{"start_line":6794,"start_character":0,"end_line":6799,"end_character":65},"updated":"2021-05-27 12:05:47.000000000","message":"Let\u0027s add the same test for fields and old version.","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"fd6fed2246a85a79ea450f080db75eea60b3096c","unresolved":false,"context_lines":[{"line_number":6791,"context_line":"                \u0027name\u0027: \u0027virtualization\u0027, \u0027value\u0027: \u0027on\u0027}]"},{"line_number":6792,"context_line":"        self.assertEqual({\u0027bios\u0027: expected_json}, ret)"},{"line_number":6793,"context_line":""},{"line_number":6794,"context_line":"    def test_get_all_bios_detail_old_version(self):"},{"line_number":6795,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?detail\u003dTrue\u0027 % self.node.uuid,"},{"line_number":6796,"context_line":"                            headers\u003d{api_base.Version.string: \"1.72\"},"},{"line_number":6797,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":6798,"context_line":""},{"line_number":6799,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_int)"},{"line_number":6800,"context_line":""},{"line_number":6801,"context_line":"    def test_get_bios_fields(self):"},{"line_number":6802,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?fields\u003dname,read_only\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"0ee6f907_a5148a0a","line":6799,"range":{"start_line":6794,"start_character":0,"end_line":6799,"end_character":65},"in_reply_to":"0b221073_5fa0ee8a","updated":"2021-05-27 14:07:03.000000000","message":"Done","commit_id":"1270fed75b677944fc9732267de4e3f24f015a3f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3e6625846f5e84e73f4e715f9a0a00a88329c0ea","unresolved":true,"context_lines":[{"line_number":6812,"context_line":""},{"line_number":6813,"context_line":"    def test_get_all_bios_detail_old_version(self):"},{"line_number":6814,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?detail\u003dTrue\u0027 % self.node.uuid,"},{"line_number":6815,"context_line":"                            headers\u003d{api_base.Version.string: \"1.72\"},"},{"line_number":6816,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":6817,"context_line":""},{"line_number":6818,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_int)"}],"source_content_type":"text/x-python","patch_set":17,"id":"44b83cf8_9ffad3f6","line":6815,"range":{"start_line":6815,"start_character":63,"end_line":6815,"end_character":67},"updated":"2021-05-27 16:03:49.000000000","message":"1.73 ?","commit_id":"27ad7f86b44425ae6e105b3be512f5e26e1d4a96"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7c9f8a0a01d1aec498c70c5f09e372a50dc56d15","unresolved":false,"context_lines":[{"line_number":6812,"context_line":""},{"line_number":6813,"context_line":"    def test_get_all_bios_detail_old_version(self):"},{"line_number":6814,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?detail\u003dTrue\u0027 % self.node.uuid,"},{"line_number":6815,"context_line":"                            headers\u003d{api_base.Version.string: \"1.72\"},"},{"line_number":6816,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":6817,"context_line":""},{"line_number":6818,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_int)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da763321_9d535a99","line":6815,"range":{"start_line":6815,"start_character":63,"end_line":6815,"end_character":67},"in_reply_to":"44b83cf8_9ffad3f6","updated":"2021-05-27 16:17:03.000000000","message":"Done","commit_id":"27ad7f86b44425ae6e105b3be512f5e26e1d4a96"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3e6625846f5e84e73f4e715f9a0a00a88329c0ea","unresolved":true,"context_lines":[{"line_number":6820,"context_line":"    def test_get_bios_fields_old_version(self):"},{"line_number":6821,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?fields\u003dname,read_only\u0027"},{"line_number":6822,"context_line":"                            % self.node.uuid,"},{"line_number":6823,"context_line":"                            headers\u003d{api_base.Version.string: \"1.72\"},"},{"line_number":6824,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":6825,"context_line":""},{"line_number":6826,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_int)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ceeed51c_7cb2a2f7","line":6823,"range":{"start_line":6823,"start_character":63,"end_line":6823,"end_character":67},"updated":"2021-05-27 16:03:49.000000000","message":"ditto","commit_id":"27ad7f86b44425ae6e105b3be512f5e26e1d4a96"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7c9f8a0a01d1aec498c70c5f09e372a50dc56d15","unresolved":false,"context_lines":[{"line_number":6820,"context_line":"    def test_get_bios_fields_old_version(self):"},{"line_number":6821,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/bios?fields\u003dname,read_only\u0027"},{"line_number":6822,"context_line":"                            % self.node.uuid,"},{"line_number":6823,"context_line":"                            headers\u003d{api_base.Version.string: \"1.72\"},"},{"line_number":6824,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":6825,"context_line":""},{"line_number":6826,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_int)"}],"source_content_type":"text/x-python","patch_set":17,"id":"85d02766_4ae8eb29","line":6823,"range":{"start_line":6823,"start_character":63,"end_line":6823,"end_character":67},"in_reply_to":"ceeed51c_7cb2a2f7","updated":"2021-05-27 16:17:03.000000000","message":"Done","commit_id":"27ad7f86b44425ae6e105b3be512f5e26e1d4a96"}],"releasenotes/notes/bios-registry-support-e7fd62908e9c222d.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5af06adc801aa6e9078cd173859fb84e1ebaeeb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Provide the registry fields in the BIOS setting API and in the BIOS setting"},{"line_number":5,"context_line":"    list when detail is requested. Also added fields selector to query API."},{"line_number":6,"context_line":"    See `story"},{"line_number":7,"context_line":"    2008571 \u003chttps://storyboard.openstack.org/#!/story/2008571\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"418bfd5e_81a90860","line":4,"updated":"2021-05-31 13:54:57.000000000","message":"nit: Provides","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d05ffd912009e83926954840695ed45011fa06bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Provide the registry fields in the BIOS setting API and in the BIOS setting"},{"line_number":5,"context_line":"    list when detail is requested. Also added fields selector to query API."},{"line_number":6,"context_line":"    See `story"},{"line_number":7,"context_line":"    2008571 \u003chttps://storyboard.openstack.org/#!/story/2008571\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fb9b7e9_b9b21bf1","line":4,"in_reply_to":"418bfd5e_81a90860","updated":"2021-06-01 09:25:20.000000000","message":"Done","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5af06adc801aa6e9078cd173859fb84e1ebaeeb","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Provide the registry fields in the BIOS setting API and in the BIOS setting"},{"line_number":5,"context_line":"    list when detail is requested. Also added fields selector to query API."},{"line_number":6,"context_line":"    See `story"},{"line_number":7,"context_line":"    2008571 \u003chttps://storyboard.openstack.org/#!/story/2008571\u003e`_."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"62548a7c_9479d50a","line":5,"updated":"2021-05-31 13:54:57.000000000","message":"nit: adds","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d05ffd912009e83926954840695ed45011fa06bd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Provide the registry fields in the BIOS setting API and in the BIOS setting"},{"line_number":5,"context_line":"    list when detail is requested. Also added fields selector to query API."},{"line_number":6,"context_line":"    See `story"},{"line_number":7,"context_line":"    2008571 \u003chttps://storyboard.openstack.org/#!/story/2008571\u003e`_."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"dc0a5a7a_852affb2","line":5,"in_reply_to":"62548a7c_9479d50a","updated":"2021-06-01 09:25:20.000000000","message":"Done","commit_id":"e15440370cca1f1a998d3607910697c3129d040a"}]}