)]}'
{"doc/source/admin/database-indexes.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8eea17b9fdd886c4418a24d4dd8739ab03baa194","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Why are indexes important?"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Databases do lots of heavy lifting in terms handling raw data and returning"},{"line_number":9,"context_line":"it to the user. Which means, a database is generally going to have consistent"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7fafbf58_99e2481a","line":6,"updated":"2021-04-29 09:23:41.000000000","message":"Cannot we just link to wikipedia? I\u0027m struggling to understand why we need this document.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f2f95b5f952f942ad88f4c790c9f2f59617b931a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Why are indexes important?"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Databases do lots of heavy lifting in terms handling raw data and returning"},{"line_number":9,"context_line":"it to the user. Which means, a database is generally going to have consistent"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6cdc48b0_43c5ca51","line":6,"in_reply_to":"7fafbf58_99e2481a","updated":"2021-05-06 15:10:52.000000000","message":"I\u0027m adding to troubleshooting instead and will also move some of it to release notes specifically where I can backport just the docs.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8eea17b9fdd886c4418a24d4dd8739ab03baa194","unresolved":false,"context_lines":[{"line_number":34,"context_line":"platform. After the 17.0 release of Ironic, it was determiend that additional"},{"line_number":35,"context_line":"indexes were needed to aid in overall performance of the database. Your query"},{"line_number":36,"context_line":"pattern may vary, but the same indexes listed below as examples are"},{"line_number":37,"context_line":"added automatically when upgrading to ironic 17.1.x or beyond."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This example below is specific to MariaDB/MySQL, but the syntax should be"},{"line_number":40,"context_line":"easy to modify for operators using PostgreSQL."}],"source_content_type":"text/x-rst","patch_set":2,"id":"a05640a5_26677099","line":37,"updated":"2021-04-29 09:23:41.000000000","message":"This should be in release notes, it\u0027s of no use for anyone on newer ironic.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"}],"doc/source/admin/index.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8eea17b9fdd886c4418a24d4dd8739ab03baa194","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   Layer 3 or DHCP-less Ramdisk Booting \u003cdhcp-less\u003e"},{"line_number":56,"context_line":"   Tuning Ironic \u003ctuning\u003e"},{"line_number":57,"context_line":"   Role Based Access Control \u003csecure-rbac\u003e"},{"line_number":58,"context_line":"   Database Indexes \u003cdatabase-indexes\u003e"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. toctree::"},{"line_number":61,"context_line":"  :hidden:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ba79f66_4d2e32e0","line":58,"updated":"2021-04-29 09:23:41.000000000","message":"I don\u0027t feel like this should be here. Maybe under \"Tuning Ironic\", but adding it here seems like unnecessary clutter.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"}],"doc/source/admin/tuning.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b081a564275e6209e497366b23643acf523116f","unresolved":true,"context_lines":[{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Query load upon the database is one of the biggest potential bottlenecks which"},{"line_number":120,"context_line":"can cascade across a deployment. The dat"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Often, depending on load, query patterns, periodic tasks, and so on and so"},{"line_number":123,"context_line":"forth, additional indexes may be needed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"f9730638_8ba62db9","line":120,"updated":"2021-05-17 15:12:03.000000000","message":"unfinished?","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1e4be48217fd724e49c55536a7d4e7b96add8ef9","unresolved":true,"context_lines":[{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Query load upon the database is one of the biggest potential bottlenecks which"},{"line_number":120,"context_line":"can cascade across a deployment. The dat"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Often, depending on load, query patterns, periodic tasks, and so on and so"},{"line_number":123,"context_line":"forth, additional indexes may be needed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"6735e69a_276bc5a1","line":120,"in_reply_to":"f9730638_8ba62db9","updated":"2021-05-17 19:10:17.000000000","message":"Good question.... I\u0027m not quite sure.","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b081a564275e6209e497366b23643acf523116f","unresolved":true,"context_lines":[{"line_number":123,"context_line":"forth, additional indexes may be needed."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Adding indexes"},{"line_number":126,"context_line":"--------------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"This example below is specific to MariaDB/MySQL, but the syntax should be"},{"line_number":129,"context_line":"easy to modify for operators using PostgreSQL."}],"source_content_type":"text/x-rst","patch_set":5,"id":"81c54eb0_a6ff7ab6","line":126,"updated":"2021-05-17 15:12:03.000000000","message":"We\u0027re adding these automatically, why document them?","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ba3e6187550873a6c47fa210cbbec78ce5eeabf3","unresolved":true,"context_lines":[{"line_number":123,"context_line":"forth, additional indexes may be needed."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Adding indexes"},{"line_number":126,"context_line":"--------------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"This example below is specific to MariaDB/MySQL, but the syntax should be"},{"line_number":129,"context_line":"easy to modify for operators using PostgreSQL."}],"source_content_type":"text/x-rst","patch_set":5,"id":"809292ff_9896a0c0","line":126,"in_reply_to":"0bf67b13_f49bf65c","updated":"2021-06-21 16:06:47.000000000","message":"Error is the wrong word, the code is a warning.","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1e4be48217fd724e49c55536a7d4e7b96add8ef9","unresolved":true,"context_lines":[{"line_number":123,"context_line":"forth, additional indexes may be needed."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Adding indexes"},{"line_number":126,"context_line":"--------------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"This example below is specific to MariaDB/MySQL, but the syntax should be"},{"line_number":129,"context_line":"easy to modify for operators using PostgreSQL."}],"source_content_type":"text/x-rst","patch_set":5,"id":"0bf67b13_f49bf65c","line":126,"in_reply_to":"81c54eb0_a6ff7ab6","updated":"2021-05-17 19:10:17.000000000","message":"Because we can\u0027t backport the automatic addition... but we can document the docs and and have the status check return a \"you should consider checking these values\" error. https://review.opendev.org/c/openstack/ironic/+/788625/5/ironic/cmd/status.py#18","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b081a564275e6209e497366b23643acf523116f","unresolved":true,"context_lines":[{"line_number":140,"context_line":"   create index resource_class_idx on nodes (resource_class) LOCK \u003d SHARED;"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. note:: The indexes note above were added for users of ironic 17.1 and"},{"line_number":143,"context_line":"   later."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. note:: It may be possible to use \"LOCK \u003d NONE\". Basic testing indicates"},{"line_number":146,"context_line":"   this takes a little bit longer, but shouldn\u0027t result in the database"}],"source_content_type":"text/x-rst","patch_set":5,"id":"29725e72_083c0aae","line":143,"updated":"2021-05-17 15:12:03.000000000","message":"Exactly. Just a release note? Or a separate documentation patch for stable branches?","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1e4be48217fd724e49c55536a7d4e7b96add8ef9","unresolved":true,"context_lines":[{"line_number":140,"context_line":"   create index resource_class_idx on nodes (resource_class) LOCK \u003d SHARED;"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. note:: The indexes note above were added for users of ironic 17.1 and"},{"line_number":143,"context_line":"   later."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. note:: It may be possible to use \"LOCK \u003d NONE\". Basic testing indicates"},{"line_number":146,"context_line":"   this takes a little bit longer, but shouldn\u0027t result in the database"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1077026f_0fcbf548","line":143,"in_reply_to":"29725e72_083c0aae","updated":"2021-05-17 19:10:17.000000000","message":"I was thinking of taking this patch, ripping out the model change and backporting docs + status check to at least the last Wallaby.","commit_id":"d857b9e69575fbe86ed5c55304ca756c6eb16b6d"}],"ironic/db/sqlalchemy/alembic/versions/ac00b586ab95_node_indexes.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8eea17b9fdd886c4418a24d4dd8739ab03baa194","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # Maintenance"},{"line_number":47,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027maintenance_idx\u0027):"},{"line_number":48,"context_line":"        op.create_index(\u0027maintenance_idx\u0027, \u0027nodes\u0027, [\u0027maintenance\u0027],"},{"line_number":49,"context_line":"                        unique\u003dFalse)"},{"line_number":50,"context_line":"    # Conductor group"},{"line_number":51,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027conductor_group_idx\u0027):"},{"line_number":52,"context_line":"        op.create_index(\u0027conductor_group_idx\u0027, \u0027nodes\u0027, [\u0027conductor_group\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"becce571_40c5e5a8","line":49,"updated":"2021-04-29 09:23:41.000000000","message":"nit: I\u0027m no database expert, but I don\u0027t think an index on a boolean value is helpful.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e77bc20dc70f1d6663ab44754788ab539750c3f9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # Maintenance"},{"line_number":47,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027maintenance_idx\u0027):"},{"line_number":48,"context_line":"        op.create_index(\u0027maintenance_idx\u0027, \u0027nodes\u0027, [\u0027maintenance\u0027],"},{"line_number":49,"context_line":"                        unique\u003dFalse)"},{"line_number":50,"context_line":"    # Conductor group"},{"line_number":51,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027conductor_group_idx\u0027):"},{"line_number":52,"context_line":"        op.create_index(\u0027conductor_group_idx\u0027, \u0027nodes\u0027, [\u0027conductor_group\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"e7653554_10757f18","line":49,"in_reply_to":"2740ddae_064e65ab","updated":"2021-05-04 18:24:27.000000000","message":"Chatted with JayF. Realistically, the difference between in my local testing is 0.01 seconds difference for the cursor to return between w/o an index on the column and an index. At the end of the day, its not worth the time to argue about or fight over to have it or otherwise. Where we\u0027ll want it is on compound indexes potentially later, but even then these base indexes may essentially forever prevent that need. At least, I hope.\n\nJay also it is not an unreasonable experience from his POV when he has run similar queries on his deployment. This is only a fraction of the overall issues.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b84b3f091a7efcdda8f6e7da14960392ebf9b05","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # Maintenance"},{"line_number":47,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027maintenance_idx\u0027):"},{"line_number":48,"context_line":"        op.create_index(\u0027maintenance_idx\u0027, \u0027nodes\u0027, [\u0027maintenance\u0027],"},{"line_number":49,"context_line":"                        unique\u003dFalse)"},{"line_number":50,"context_line":"    # Conductor group"},{"line_number":51,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027conductor_group_idx\u0027):"},{"line_number":52,"context_line":"        op.create_index(\u0027conductor_group_idx\u0027, \u0027nodes\u0027, [\u0027conductor_group\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"2740ddae_064e65ab","line":49,"in_reply_to":"597774ab_c4ebdf41","updated":"2021-05-04 16:58:06.000000000","message":"Inline on the row, but rows are variable length. I don\u0027t think we have the mysql expertise to really guess much more than that. The one thing that does come to mind is the step beyond this will likely consist of compound indexes where we\u0027ll want to try and match the query as much as possible","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57e76a1e88757a76d81d675efb468a8abf06afab","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # Maintenance"},{"line_number":47,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027maintenance_idx\u0027):"},{"line_number":48,"context_line":"        op.create_index(\u0027maintenance_idx\u0027, \u0027nodes\u0027, [\u0027maintenance\u0027],"},{"line_number":49,"context_line":"                        unique\u003dFalse)"},{"line_number":50,"context_line":"    # Conductor group"},{"line_number":51,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027conductor_group_idx\u0027):"},{"line_number":52,"context_line":"        op.create_index(\u0027conductor_group_idx\u0027, \u0027nodes\u0027, [\u0027conductor_group\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"597774ab_c4ebdf41","line":49,"in_reply_to":"adf9ed9c_023be0c1","updated":"2021-04-29 12:57:48.000000000","message":"\u003e It keeps it in memory instead of spread across the disk.\n\nI believe that the whole table will be in memory in most applications. Boolean fields are inline, right?","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cafbea5617ce5c8c6cea43a23248c4c12129ceb5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # Maintenance"},{"line_number":47,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027maintenance_idx\u0027):"},{"line_number":48,"context_line":"        op.create_index(\u0027maintenance_idx\u0027, \u0027nodes\u0027, [\u0027maintenance\u0027],"},{"line_number":49,"context_line":"                        unique\u003dFalse)"},{"line_number":50,"context_line":"    # Conductor group"},{"line_number":51,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027conductor_group_idx\u0027):"},{"line_number":52,"context_line":"        op.create_index(\u0027conductor_group_idx\u0027, \u0027nodes\u0027, [\u0027conductor_group\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"adf9ed9c_023be0c1","line":49,"in_reply_to":"becce571_40c5e5a8","updated":"2021-04-29 12:54:41.000000000","message":"It keeps it in memory instead of spread across the disk. That is the only advantage.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8eea17b9fdd886c4418a24d4dd8739ab03baa194","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        op.create_index(\u0027resource_class_idx\u0027, \u0027nodes\u0027, [\u0027resource_class\u0027],"},{"line_number":57,"context_line":"                        unique\u003dFalse)"},{"line_number":58,"context_line":"    # Owner"},{"line_number":59,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027owner_idx\u0027):"},{"line_number":60,"context_line":"        op.create_index(\u0027owner_idx\u0027, \u0027nodes\u0027, [\u0027owner\u0027], unique\u003dFalse)"},{"line_number":61,"context_line":"    # Lessee"},{"line_number":62,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027lessee_idx\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a84245b4_50ba2f3b","line":59,"updated":"2021-04-29 09:23:41.000000000","message":"I think this should be conditional. For a deployment that does not use owners/lessees (e.g. 99.9% of deployments now and maybe 90% in the future) it\u0027s just a waste of space.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cafbea5617ce5c8c6cea43a23248c4c12129ceb5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        op.create_index(\u0027resource_class_idx\u0027, \u0027nodes\u0027, [\u0027resource_class\u0027],"},{"line_number":57,"context_line":"                        unique\u003dFalse)"},{"line_number":58,"context_line":"    # Owner"},{"line_number":59,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027owner_idx\u0027):"},{"line_number":60,"context_line":"        op.create_index(\u0027owner_idx\u0027, \u0027nodes\u0027, [\u0027owner\u0027], unique\u003dFalse)"},{"line_number":61,"context_line":"    # Lessee"},{"line_number":62,"context_line":"    if not utils.index_exists(engine, \u0027nodes\u0027, \u0027lessee_idx\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a9efff8_56253140","line":59,"in_reply_to":"a84245b4_50ba2f3b","updated":"2021-04-29 12:54:41.000000000","message":"We can\u0027t do that because we\u0027ve got the column pulled in on queries automatically... Plus it won\u0027t wast space or resources since if it is not populated.\n\nIt is all about keeping the hints easy to access for the database on common query paths so the db doesn\u0027t have to go off and do the work to evaluate every single record one by one to return the query.","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"}],"releasenotes/notes/create_node_indexes-841b679e6cf332fd.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8eea17b9fdd886c4418a24d4dd8739ab03baa194","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Depending on database size and complexity, this will take time to complete"},{"line_number":7,"context_line":"    for every single index to be created. These indexes will only be created"},{"line_number":8,"context_line":"    if an index does not already exist matching the field name with \"_idx\""},{"line_number":9,"context_line":"    appended.::"},{"line_number":10,"context_line":"      * ``owner``"},{"line_number":11,"context_line":"      * ``lessee``"},{"line_number":12,"context_line":"      * ``driver``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"333a5588_b1a82114","line":9,"updated":"2021-04-29 09:23:41.000000000","message":"incorrect formatting: no :: before lists, no indentation in lists, new line before and after a list","commit_id":"702c623731ea73f83c9e2263e84441ce1def586d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"92acadd878e6dec8637da287d00bb32652073dc0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``ironic-dbsync upgrade`` command for this verison of ironic will add"},{"line_number":5,"context_line":"    additional database indexes on the ``nodes`` table columns below."},{"line_number":6,"context_line":"    Depending on database size and complexity, this will take time to complete"},{"line_number":7,"context_line":"    for every single index to be created. On MySQL or MariaDB, these indexes"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"cf6d37eb_70873016","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":58},"updated":"2021-05-21 12:47:24.000000000","message":"nit: version","commit_id":"205a8b3037b62cbae7f5385f4d9b9404a702414e"}]}