)]}'
{"ironic/drivers/modules/redfish/bios.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"883279a965cffe682ee1df0624a32c96c2c0ef36","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Get name from ValueName if it exists, otherwise use DisplayValueName"},{"line_number":66,"context_line":"        new_list \u003d []"},{"line_number":67,"context_line":"        for dic in (allowable_values):"},{"line_number":68,"context_line":"            for key in dic:"},{"line_number":69,"context_line":"                if key \u003d\u003d \u0027ValueName\u0027 or key \u003d\u003d \u0027DisplayValueName\u0027:"},{"line_number":70,"context_line":"                    new_list.append(dic[key])"}],"source_content_type":"text/x-python","patch_set":4,"id":"f0169e41_c22cc6ad","line":67,"range":{"start_line":67,"start_character":19,"end_line":67,"end_character":37},"updated":"2021-05-19 10:08:17.000000000","message":"nit: no need for parenthesis","commit_id":"dfead07edddd8636b9920b7abab21933464bcd56"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"50756d69114585a8d493b7cbe96066b8d3122d59","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Get name from ValueName if it exists, otherwise use DisplayValueName"},{"line_number":66,"context_line":"        new_list \u003d []"},{"line_number":67,"context_line":"        for dic in (allowable_values):"},{"line_number":68,"context_line":"            for key in dic:"},{"line_number":69,"context_line":"                if key \u003d\u003d \u0027ValueName\u0027 or key \u003d\u003d \u0027DisplayValueName\u0027:"},{"line_number":70,"context_line":"                    new_list.append(dic[key])"}],"source_content_type":"text/x-python","patch_set":4,"id":"551517e2_107494eb","line":67,"range":{"start_line":67,"start_character":19,"end_line":67,"end_character":37},"in_reply_to":"f0169e41_c22cc6ad","updated":"2021-05-19 13:32:52.000000000","message":"Done","commit_id":"dfead07edddd8636b9920b7abab21933464bcd56"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"883279a965cffe682ee1df0624a32c96c2c0ef36","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        # The BIOS registry will contain more entries than the BIOS settings"},{"line_number":120,"context_line":"        # Find the registry entry matching the setting name and get the fields"},{"line_number":121,"context_line":"        for setting in settings:"},{"line_number":122,"context_line":"            reg \u003d next((r for r in registry_attributes"},{"line_number":123,"context_line":"                        if r.name \u003d\u003d setting[\u0027name\u0027]), None)"},{"line_number":124,"context_line":"            fields \u003d [attr for attr in dir(reg) if not attr.startswith(\"_\")]"},{"line_number":125,"context_line":"            settable_keys \u003d [f for f in fields if f in registry_fields]"}],"source_content_type":"text/x-python","patch_set":4,"id":"0e8f9d76_4d00da8c","line":122,"updated":"2021-05-19 10:08:17.000000000","message":"should we maybe not run this if registry_attributes is empty ?","commit_id":"dfead07edddd8636b9920b7abab21933464bcd56"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"50756d69114585a8d493b7cbe96066b8d3122d59","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # The BIOS registry will contain more entries than the BIOS settings"},{"line_number":120,"context_line":"        # Find the registry entry matching the setting name and get the fields"},{"line_number":121,"context_line":"        for setting in settings:"},{"line_number":122,"context_line":"            reg \u003d next((r for r in registry_attributes"},{"line_number":123,"context_line":"                        if r.name \u003d\u003d setting[\u0027name\u0027]), None)"},{"line_number":124,"context_line":"            fields \u003d [attr for attr in dir(reg) if not attr.startswith(\"_\")]"},{"line_number":125,"context_line":"            settable_keys \u003d [f for f in fields if f in registry_fields]"}],"source_content_type":"text/x-python","patch_set":4,"id":"e761fe73_9199530f","line":122,"in_reply_to":"0e8f9d76_4d00da8c","updated":"2021-05-19 13:32:52.000000000","message":"Done","commit_id":"dfead07edddd8636b9920b7abab21933464bcd56"}],"releasenotes/notes/get-bios-registry-aadc74800e0770f7.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"883279a965cffe682ee1df0624a32c96c2c0ef36","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Get the BIOS Registry from Sushy and store the fields in the Ironic DB"},{"line_number":5,"context_line":"    with the BIOS setting. See `story"},{"line_number":6,"context_line":"    2008571 \u003chttps://storyboard.openstack.org/#!/story/2008571\u003e`_. "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b9c0655a_20e8ac58","line":6,"range":{"start_line":6,"start_character":66,"end_line":6,"end_character":67},"updated":"2021-05-19 10:08:17.000000000","message":"nit: blank space","commit_id":"dfead07edddd8636b9920b7abab21933464bcd56"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"50756d69114585a8d493b7cbe96066b8d3122d59","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Get the BIOS Registry from Sushy and store the fields in the Ironic DB"},{"line_number":5,"context_line":"    with the BIOS setting. See `story"},{"line_number":6,"context_line":"    2008571 \u003chttps://storyboard.openstack.org/#!/story/2008571\u003e`_. "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8d636e15_c7e68175","line":6,"range":{"start_line":6,"start_character":66,"end_line":6,"end_character":67},"in_reply_to":"b9c0655a_20e8ac58","updated":"2021-05-19 13:32:52.000000000","message":"Done","commit_id":"dfead07edddd8636b9920b7abab21933464bcd56"}]}