)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c4608a8309d17455a3cf69f6def10a1040195421","unresolved":true,"context_lines":[{"line_number":1646,"context_line":"                                      vif_id\u003dvif_id, topic\u003dtopic)"},{"line_number":1647,"context_line":""},{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"class NodeTagsController(rest.RestController):"},{"line_number":1650,"context_line":""},{"line_number":1651,"context_line":"    def __init__(self, node_ident):"},{"line_number":1652,"context_line":"        super(NodeTagsController, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c59424c8_e7d83a9f","line":1649,"updated":"2021-05-28 20:24:19.000000000","message":"I don\u0027t see any rest API tests for this, nor do I see any test_acl.py based tests for ensuring he policy checks work as expected with the new policy.\n\nI guess I also have some additional concerns with not having testing on that level since tags is a huge area that can negatively impact API performance given the data model. We\u0027re working on revising traits to be more efficent/faster though, so maybe they might end up fitting together nicely.","commit_id":"3db06bc04c376672fc750141b30f9efe3ce3a349"},{"author":{"_account_id":26580,"name":"liuzhuangzhuang","email":"vpbvmw651078@gmail.com","username":"LiuZhuangzhuang"},"change_message_id":"21ec7659d9cbaac1cd7451a1f68d36de9a81848e","unresolved":true,"context_lines":[{"line_number":1646,"context_line":"                                      vif_id\u003dvif_id, topic\u003dtopic)"},{"line_number":1647,"context_line":""},{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"class NodeTagsController(rest.RestController):"},{"line_number":1650,"context_line":""},{"line_number":1651,"context_line":"    def __init__(self, node_ident):"},{"line_number":1652,"context_line":"        super(NodeTagsController, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5738c2c7_cbd4885b","line":1649,"in_reply_to":"c59424c8_e7d83a9f","updated":"2021-06-01 08:55:55.000000000","message":"How do I do API performance testing? I only add some tests about unit tests. I think tags are independent APIs and will not affect the performance of existing APIs.","commit_id":"3db06bc04c376672fc750141b30f9efe3ce3a349"}]}