)]}'
{"ironic/api/controllers/v1/collection.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"908ad849896f192c2f4a85611ceefe446db51604","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        done in-place"},{"line_number":43,"context_line":"    :param key_field:"},{"line_number":44,"context_line":"        Key name for building next URL"},{"line_number":45,"context_line":"    :parm sanitizer_args:"},{"line_number":46,"context_line":"        Dictionary with additional arguments to be passed to the sanitizer."},{"line_number":47,"context_line":"    :param kwargs:"},{"line_number":48,"context_line":"        other arguments passed to ``get_next``"}],"source_content_type":"text/x-python","patch_set":9,"id":"14f93b71_d5bb5e6c","line":45,"range":{"start_line":45,"start_character":5,"end_line":45,"end_character":9},"updated":"2021-07-07 16:52:46.000000000","message":"Nit: param","commit_id":"9851b68ee9d19d53313853fe93126dcfec7ba1e1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c97dd132cff7fa74dd67984b3bbd3df1bb661723","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        done in-place"},{"line_number":43,"context_line":"    :param key_field:"},{"line_number":44,"context_line":"        Key name for building next URL"},{"line_number":45,"context_line":"    :parm sanitizer_args:"},{"line_number":46,"context_line":"        Dictionary with additional arguments to be passed to the sanitizer."},{"line_number":47,"context_line":"    :param kwargs:"},{"line_number":48,"context_line":"        other arguments passed to ``get_next``"}],"source_content_type":"text/x-python","patch_set":9,"id":"edd75538_e5cb7ba3","line":45,"range":{"start_line":45,"start_character":5,"end_line":45,"end_character":9},"in_reply_to":"14f93b71_d5bb5e6c","updated":"2021-07-07 17:12:33.000000000","message":"Done","commit_id":"9851b68ee9d19d53313853fe93126dcfec7ba1e1"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0b2f528a68d399a2fb223f6d576a6f9b474d94fe","unresolved":true,"context_lines":[{"line_number":1512,"context_line":"        node.pop(\u0027states\u0027, None)"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":"def _node_santizie_extended(node, node_keys, target_dict, cdict):"},{"line_number":1516,"context_line":"    # NOTE(TheJulia): The net effect of this is that by default,"},{"line_number":1517,"context_line":"    # at least matching common/policy.py defaults. is these should"},{"line_number":1518,"context_line":"    # be stripped out."}],"source_content_type":"text/x-python","patch_set":8,"id":"0a731930_b21cc676","line":1515,"updated":"2021-07-02 22:52:24.000000000","message":"s/santizie/sanitize/ here and all the places it\u0027s called","commit_id":"a5ce2d9d63d1b8b2357486ec93892b0b621bb3c3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"65b31a31c8660ce19ad67260cd4189b3264aaa48","unresolved":true,"context_lines":[{"line_number":1512,"context_line":"        node.pop(\u0027states\u0027, None)"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":"def _node_santizie_extended(node, node_keys, target_dict, cdict):"},{"line_number":1516,"context_line":"    # NOTE(TheJulia): The net effect of this is that by default,"},{"line_number":1517,"context_line":"    # at least matching common/policy.py defaults. is these should"},{"line_number":1518,"context_line":"    # be stripped out."}],"source_content_type":"text/x-python","patch_set":8,"id":"697626b3_0c5868e6","line":1515,"in_reply_to":"0a731930_b21cc676","updated":"2021-07-06 17:59:23.000000000","message":"ack","commit_id":"a5ce2d9d63d1b8b2357486ec93892b0b621bb3c3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2699f90c884adfadbde92f0b5d971e1817653797","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"        node.pop(\u0027states\u0027, None)"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":"def _node_santizie_extended(node, node_keys, target_dict, cdict):"},{"line_number":1516,"context_line":"    # NOTE(TheJulia): The net effect of this is that by default,"},{"line_number":1517,"context_line":"    # at least matching common/policy.py defaults. is these should"},{"line_number":1518,"context_line":"    # be stripped out."}],"source_content_type":"text/x-python","patch_set":8,"id":"33446be0_35415e5d","line":1515,"in_reply_to":"697626b3_0c5868e6","updated":"2021-07-06 18:07:51.000000000","message":"Done","commit_id":"a5ce2d9d63d1b8b2357486ec93892b0b621bb3c3"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"908ad849896f192c2f4a85611ceefe446db51604","unresolved":true,"context_lines":[{"line_number":1390,"context_line":"    :type fields: list of str"},{"line_number":1391,"context_line":"    :param cdict: Context dictionary for policy values evaluation."},{"line_number":1392,"context_line":"                  If not provided, it will be executed by the method,"},{"line_number":1393,"context_line":"                  however for enumarting node lists, it is more efficent"},{"line_number":1394,"context_line":"                  to provide."},{"line_number":1395,"context_line":"    :param show_driver_secrets: A boolean value to allow external single"},{"line_number":1396,"context_line":"                                evaluation of policy instead of once per"}],"source_content_type":"text/x-python","patch_set":9,"id":"8603d385_9e35c7b4","line":1393,"range":{"start_line":1393,"start_character":30,"end_line":1393,"end_character":40},"updated":"2021-07-07 16:52:46.000000000","message":"Nit: enumerating","commit_id":"9851b68ee9d19d53313853fe93126dcfec7ba1e1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c97dd132cff7fa74dd67984b3bbd3df1bb661723","unresolved":false,"context_lines":[{"line_number":1390,"context_line":"    :type fields: list of str"},{"line_number":1391,"context_line":"    :param cdict: Context dictionary for policy values evaluation."},{"line_number":1392,"context_line":"                  If not provided, it will be executed by the method,"},{"line_number":1393,"context_line":"                  however for enumarting node lists, it is more efficent"},{"line_number":1394,"context_line":"                  to provide."},{"line_number":1395,"context_line":"    :param show_driver_secrets: A boolean value to allow external single"},{"line_number":1396,"context_line":"                                evaluation of policy instead of once per"}],"source_content_type":"text/x-python","patch_set":9,"id":"04c322f9_e98a7a11","line":1393,"range":{"start_line":1393,"start_character":30,"end_line":1393,"end_character":40},"in_reply_to":"8603d385_9e35c7b4","updated":"2021-07-07 17:12:33.000000000","message":"Done","commit_id":"9851b68ee9d19d53313853fe93126dcfec7ba1e1"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"908ad849896f192c2f4a85611ceefe446db51604","unresolved":true,"context_lines":[{"line_number":1406,"context_line":"    # the time spent preparing to return a node to. If it takes us"},{"line_number":1407,"context_line":"    # ~ 4.5 seconds to get 1000 nodes, we spend approximately 4 seconds"},{"line_number":1408,"context_line":"    # PER 1000 in this call. When the calling method provides"},{"line_number":1409,"context_line":"    # cdict, show_driver_secrets, show_instane_secrets, and"},{"line_number":1410,"context_line":"    # evaluate_additional_policies, then performance of this method takes"},{"line_number":1411,"context_line":"    # roughly half of the time, but performance increases in excess of 200%"},{"line_number":1412,"context_line":"    # as policy checks are costly."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a22024f_2957c866","line":1409,"range":{"start_line":1409,"start_character":34,"end_line":1409,"end_character":46},"updated":"2021-07-07 16:52:46.000000000","message":"Nit: show_instance_secrets","commit_id":"9851b68ee9d19d53313853fe93126dcfec7ba1e1"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"908ad849896f192c2f4a85611ceefe446db51604","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"    # ~ 4.5 seconds to get 1000 nodes, we spend approximately 4 seconds"},{"line_number":1408,"context_line":"    # PER 1000 in this call. When the calling method provides"},{"line_number":1409,"context_line":"    # cdict, show_driver_secrets, show_instane_secrets, and"},{"line_number":1410,"context_line":"    # evaluate_additional_policies, then performance of this method takes"},{"line_number":1411,"context_line":"    # roughly half of the time, but performance increases in excess of 200%"},{"line_number":1412,"context_line":"    # as policy checks are costly."},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"    if not cdict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"d18cff05_f1a8b0bc","line":1411,"range":{"start_line":1410,"start_character":36,"end_line":1411,"end_character":75},"updated":"2021-07-07 16:52:46.000000000","message":"Nit: is this the same statement, or are these different points?","commit_id":"9851b68ee9d19d53313853fe93126dcfec7ba1e1"}]}