)]}'
{"ironic/drivers/fake.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2c8154abb324e31143db59da1f106e45d583c63","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from ironic.drivers.modules import seamicro"},{"line_number":27,"context_line":"from ironic.drivers.modules import ssh"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from ironic.openstack.common import importutils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FakeDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B6yg%3D","line":29,"updated":"2014-03-11 09:58:36.000000000","message":"PEP8 nit: this is import should be grouped with the rest of the imports since it\u0027s a local application/library import","commit_id":"f43b6fd67345b1dd322b4b39d9e32d72c964d116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7a867ff85e49832a4e441167edf22d02a77ab8d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from ironic.drivers.modules import seamicro"},{"line_number":27,"context_line":"from ironic.drivers.modules import ssh"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from ironic.openstack.common import importutils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FakeDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B4eA%3D","line":29,"in_reply_to":"AAAAVn%2F%2B6yg%3D","updated":"2014-03-11 15:11:25.000000000","message":"woops, yep! thanks","commit_id":"f43b6fd67345b1dd322b4b39d9e32d72c964d116"}],"ironic/drivers/pxe.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2c8154abb324e31143db59da1f106e45d583c63","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ironic.drivers.modules import seamicro"},{"line_number":26,"context_line":"from ironic.drivers.modules import ssh"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from ironic.openstack.common import importutils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class PXEAndIPMIToolDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B6yY%3D","line":28,"updated":"2014-03-11 09:58:36.000000000","message":"PEP8 nit: this is import should be grouped with the rest of the imports since it\u0027s a local application/library import","commit_id":"f43b6fd67345b1dd322b4b39d9e32d72c964d116"}],"ironic/tests/drivers/test_seamicro.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2c8154abb324e31143db59da1f106e45d583c63","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    def setUp(self):"},{"line_number":257,"context_line":"        super(SeaMicroPowerDriverTestCase, self).setUp()"},{"line_number":258,"context_line":"        if not seamicroclient:"},{"line_number":259,"context_line":"            self.skipTest(\"Seamicroclient library not found\")"},{"line_number":260,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\u0027fake_seamicro\u0027)"},{"line_number":261,"context_line":"        self.driver \u003d driver_factory.get_driver(\u0027fake_seamicro\u0027)"},{"line_number":262,"context_line":"        self.node \u003d db_utils.get_test_node(driver\u003d\u0027fake_seamicro\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B6yI%3D","line":259,"updated":"2014-03-11 09:58:36.000000000","message":"i18n?","commit_id":"f43b6fd67345b1dd322b4b39d9e32d72c964d116"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"908b216c86940066047a902ae45815a34ba009cc","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    def setUp(self):"},{"line_number":257,"context_line":"        super(SeaMicroPowerDriverTestCase, self).setUp()"},{"line_number":258,"context_line":"        if not seamicroclient:"},{"line_number":259,"context_line":"            self.skipTest(\"Seamicroclient library not found\")"},{"line_number":260,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\u0027fake_seamicro\u0027)"},{"line_number":261,"context_line":"        self.driver \u003d driver_factory.get_driver(\u0027fake_seamicro\u0027)"},{"line_number":262,"context_line":"        self.node \u003d db_utils.get_test_node(driver\u003d\u0027fake_seamicro\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B4Y8%3D","line":259,"in_reply_to":"AAAAVn%2F%2B4dQ%3D","updated":"2014-03-11 15:18:26.000000000","message":"Right, my thinking here was that this string is being printed to the user that is running the tests so we would want to i18n it.\n\nBut you pointed out on IRC, the user running the unittests is a developer and for that case we don\u0027t need i18n","commit_id":"f43b6fd67345b1dd322b4b39d9e32d72c964d116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7a867ff85e49832a4e441167edf22d02a77ab8d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    def setUp(self):"},{"line_number":257,"context_line":"        super(SeaMicroPowerDriverTestCase, self).setUp()"},{"line_number":258,"context_line":"        if not seamicroclient:"},{"line_number":259,"context_line":"            self.skipTest(\"Seamicroclient library not found\")"},{"line_number":260,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\u0027fake_seamicro\u0027)"},{"line_number":261,"context_line":"        self.driver \u003d driver_factory.get_driver(\u0027fake_seamicro\u0027)"},{"line_number":262,"context_line":"        self.node \u003d db_utils.get_test_node(driver\u003d\u0027fake_seamicro\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B4dQ%3D","line":259,"in_reply_to":"AAAAVn%2F%2B6yI%3D","updated":"2014-03-11 15:11:25.000000000","message":"in a unit test? i18n is for user-facing strings...","commit_id":"f43b6fd67345b1dd322b4b39d9e32d72c964d116"}]}
