)]}'
{"ironic/drivers/modules/redfish/raid.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d7b61285b228817d5bdef5e610179e59cdddc014","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    PROTOCOL_MAP \u003d {"},{"line_number":96,"context_line":"        sushy.PROTOCOL_TYPE_SAS: raid.SAS,"},{"line_number":97,"context_line":"        sushy.PROTOCOL_TYPE_SATA: raid.SATA,"},{"line_number":98,"context_line":"        sushy.PROTOCOL_TYPE_iSCSI: raid.SCSI"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a18ecf7_9d04c0e2","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":33},"updated":"2021-06-09 09:24:58.000000000","message":"Redfish does not have SCSI, only iSCI. OK to map? Or not supported in Redfish RAID?","commit_id":"bdb24444a53b866f5a45ddd9f8b6f7b6f0437a7c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ef6b5983e96a1adb3dbcb7ca87611c65632af23","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    PROTOCOL_MAP \u003d {"},{"line_number":96,"context_line":"        sushy.PROTOCOL_TYPE_SAS: raid.SAS,"},{"line_number":97,"context_line":"        sushy.PROTOCOL_TYPE_SATA: raid.SATA,"},{"line_number":98,"context_line":"        sushy.PROTOCOL_TYPE_iSCSI: raid.SCSI"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d54a9748_65e49ec2","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":33},"in_reply_to":"3a18ecf7_9d04c0e2","updated":"2021-06-21 14:16:10.000000000","message":"Doesn\u0027t make sense to map, honestly. iSCSI is typically offered via a storage area network.\nSAS superceeds SCSI http://redfish.dmtf.org/schemas/DSP2046_2020.4.html#redfish.dmtf.org/schemas/v1/Drive.json|details|Protocol","commit_id":"bdb24444a53b866f5a45ddd9f8b6f7b6f0437a7c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d36de972fe48f4b853a93bb9435c8b2e0f337031","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    PROTOCOL_MAP \u003d {"},{"line_number":96,"context_line":"        sushy.PROTOCOL_TYPE_SAS: raid.SAS,"},{"line_number":97,"context_line":"        sushy.PROTOCOL_TYPE_SATA: raid.SATA,"},{"line_number":98,"context_line":"        sushy.PROTOCOL_TYPE_iSCSI: raid.SCSI"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c1ce888b_a9e115b5","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":33},"in_reply_to":"d54a9748_65e49ec2","updated":"2021-06-22 10:38:42.000000000","message":"Done","commit_id":"bdb24444a53b866f5a45ddd9f8b6f7b6f0437a7c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b289135f522349f39ea24631527b06013a7c09c9","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                and logical_disk[\u0027disk_type\u0027].lower() !\u003d disk_type.lower()):"},{"line_number":400,"context_line":"            continue"},{"line_number":401,"context_line":"        if \u0027interface_type\u0027 in logical_disk:"},{"line_number":402,"context_line":"            if logical_disk[\u0027interface_type\u0027].lower() \u003d\u003d raid.SCSI:"},{"line_number":403,"context_line":"                raise exception.RedfishError("},{"line_number":404,"context_line":"                    \u0027interface type `scsi` not supported by Redfish RAID\u0027)"},{"line_number":405,"context_line":"                if (logical_disk[\u0027interface_type\u0027].lower()"}],"source_content_type":"text/x-python","patch_set":2,"id":"805129d2_b86a1fd9","line":402,"updated":"2021-07-01 13:36:06.000000000","message":"RAIDInterface has a validate_raid_config call. Is it possible to add this check there as well?","commit_id":"fcaa5f8107e0001a88a60b59915bcc5ca2824695"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"294a2473d211c371e6be8630a32a8af72db4c0be","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                and logical_disk[\u0027disk_type\u0027].lower() !\u003d disk_type.lower()):"},{"line_number":400,"context_line":"            continue"},{"line_number":401,"context_line":"        if \u0027interface_type\u0027 in logical_disk:"},{"line_number":402,"context_line":"            if logical_disk[\u0027interface_type\u0027].lower() \u003d\u003d raid.SCSI:"},{"line_number":403,"context_line":"                raise exception.RedfishError("},{"line_number":404,"context_line":"                    \u0027interface type `scsi` not supported by Redfish RAID\u0027)"},{"line_number":405,"context_line":"                if (logical_disk[\u0027interface_type\u0027].lower()"}],"source_content_type":"text/x-python","patch_set":2,"id":"00307fc8_c9a02f54","line":402,"in_reply_to":"805129d2_b86a1fd9","updated":"2021-07-02 08:47:20.000000000","message":"moved, not duplicating here, it shouldn\u0027t be possible to get here bypassing validate_raid_config","commit_id":"fcaa5f8107e0001a88a60b59915bcc5ca2824695"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b289135f522349f39ea24631527b06013a7c09c9","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        if \u0027interface_type\u0027 in logical_disk:"},{"line_number":402,"context_line":"            if logical_disk[\u0027interface_type\u0027].lower() \u003d\u003d raid.SCSI:"},{"line_number":403,"context_line":"                raise exception.RedfishError("},{"line_number":404,"context_line":"                    \u0027interface type `scsi` not supported by Redfish RAID\u0027)"},{"line_number":405,"context_line":"                if (logical_disk[\u0027interface_type\u0027].lower()"},{"line_number":406,"context_line":"                        !\u003d PROTOCOL_MAP[protocol].lower()):"},{"line_number":407,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c288e08_bbe98acb","line":404,"updated":"2021-07-01 13:36:06.000000000","message":"nit: missing _() around a user-visible error","commit_id":"fcaa5f8107e0001a88a60b59915bcc5ca2824695"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"294a2473d211c371e6be8630a32a8af72db4c0be","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        if \u0027interface_type\u0027 in logical_disk:"},{"line_number":402,"context_line":"            if logical_disk[\u0027interface_type\u0027].lower() \u003d\u003d raid.SCSI:"},{"line_number":403,"context_line":"                raise exception.RedfishError("},{"line_number":404,"context_line":"                    \u0027interface type `scsi` not supported by Redfish RAID\u0027)"},{"line_number":405,"context_line":"                if (logical_disk[\u0027interface_type\u0027].lower()"},{"line_number":406,"context_line":"                        !\u003d PROTOCOL_MAP[protocol].lower()):"},{"line_number":407,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"e62d2ac5_7963bc60","line":404,"in_reply_to":"0c288e08_bbe98acb","updated":"2021-07-02 08:47:20.000000000","message":"Done","commit_id":"fcaa5f8107e0001a88a60b59915bcc5ca2824695"}]}