)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9779be260eb513a0b0677482798cacbbcaebabea","unresolved":true,"context_lines":[{"line_number":1823,"context_line":"        It returns a list with the node, or an empty list if no node is found."},{"line_number":1824,"context_line":"        \"\"\""},{"line_number":1825,"context_line":"        # NOTE(TheJulia): This method is completely unused and will be removed"},{"line_number":1826,"context_line":"        # in the future."},{"line_number":1827,"context_line":"        try:"},{"line_number":1828,"context_line":"            node \u003d objects.Node.get_by_instance_uuid(api.request.context,"},{"line_number":1829,"context_line":"                                                     instance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f696273c_d3984620","line":1826,"updated":"2021-06-16 18:38:48.000000000","message":"This is an _ method in a non-public interface. Why aren\u0027t we just removing the method?","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"100abf27378e6f065b9d897a50d856f41209e540","unresolved":true,"context_lines":[{"line_number":1823,"context_line":"        It returns a list with the node, or an empty list if no node is found."},{"line_number":1824,"context_line":"        \"\"\""},{"line_number":1825,"context_line":"        # NOTE(TheJulia): This method is completely unused and will be removed"},{"line_number":1826,"context_line":"        # in the future."},{"line_number":1827,"context_line":"        try:"},{"line_number":1828,"context_line":"            node \u003d objects.Node.get_by_instance_uuid(api.request.context,"},{"line_number":1829,"context_line":"                                                     instance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"34c782ec_e23a6f90","line":1826,"in_reply_to":"7c46ffbb_8cdf6a2b","updated":"2021-06-17 15:55:52.000000000","message":"I removed it a later change that I won\u0027t backport. I can remove it in this, just worried if anyone has added something in on their deployment using it.","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94ba35377c6deeb23402f53b0cf85b07ccc59a74","unresolved":true,"context_lines":[{"line_number":1823,"context_line":"        It returns a list with the node, or an empty list if no node is found."},{"line_number":1824,"context_line":"        \"\"\""},{"line_number":1825,"context_line":"        # NOTE(TheJulia): This method is completely unused and will be removed"},{"line_number":1826,"context_line":"        # in the future."},{"line_number":1827,"context_line":"        try:"},{"line_number":1828,"context_line":"            node \u003d objects.Node.get_by_instance_uuid(api.request.context,"},{"line_number":1829,"context_line":"                                                     instance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7c46ffbb_8cdf6a2b","line":1826,"in_reply_to":"f696273c_d3984620","updated":"2021-06-16 19:50:51.000000000","message":"I wondered the same thing. If it is unused, we can remove it. Unless we think some external code might be using it? But it is internal so...","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94ba35377c6deeb23402f53b0cf85b07ccc59a74","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                              \u0027with_power_state\u0027: \u0027power_state\u0027}"},{"line_number":325,"context_line":"    _NODE_FILTERS \u003d ({\u0027chassis_uuid\u0027, \u0027reserved_by_any_of\u0027,"},{"line_number":326,"context_line":"                      \u0027provisioned_before\u0027, \u0027inspection_started_before\u0027,"},{"line_number":327,"context_line":"                      \u0027description_contains\u0027, \u0027project\u0027, \u0027instance_uuid\u0027}"},{"line_number":328,"context_line":"                     | _NODE_QUERY_FIELDS"},{"line_number":329,"context_line":"                     | set(_NODE_IN_QUERY_FIELDS)"},{"line_number":330,"context_line":"                     | set(_NODE_NON_NULL_FILTERS))"}],"source_content_type":"text/x-python","patch_set":2,"id":"21671d6a_fc24a62f","line":327,"updated":"2021-06-16 19:50:51.000000000","message":"is this needed? instance_uuid is in _NODE_QUERY_FIELDS which is or\u0027d below.","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"100abf27378e6f065b9d897a50d856f41209e540","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                              \u0027with_power_state\u0027: \u0027power_state\u0027}"},{"line_number":325,"context_line":"    _NODE_FILTERS \u003d ({\u0027chassis_uuid\u0027, \u0027reserved_by_any_of\u0027,"},{"line_number":326,"context_line":"                      \u0027provisioned_before\u0027, \u0027inspection_started_before\u0027,"},{"line_number":327,"context_line":"                      \u0027description_contains\u0027, \u0027project\u0027, \u0027instance_uuid\u0027}"},{"line_number":328,"context_line":"                     | _NODE_QUERY_FIELDS"},{"line_number":329,"context_line":"                     | set(_NODE_IN_QUERY_FIELDS)"},{"line_number":330,"context_line":"                     | set(_NODE_NON_NULL_FILTERS))"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c821d1f_cece2cce","line":327,"in_reply_to":"21671d6a_fc24a62f","updated":"2021-06-17 15:55:52.000000000","message":"Oh, good catch. It is not needed.  I was hitting an issue with the result set and ended up lifting the original filter command and ran with it, but ended up aligning with the _node_query_fields list. Fixing.","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"}],"releasenotes/notes/correct-detailed-instance-info-behavior-1375914a30621eca.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9eefc5dd5b5ab6e9ae63fad3af7c5590f05f2618","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"security:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with the ``/v1/nodes/detail`` endpoint where an"},{"line_number":5,"context_line":"    an authenticated user could explicitly ask for an ``instance_uuid`` lookup"},{"line_number":6,"context_line":"    and the associated node would be returned to the user with sensitive"},{"line_number":7,"context_line":"    fields redacted in the result payload if the user did not explicitly have"},{"line_number":8,"context_line":"    ``owner`` or ``lessee`` permissions over the node. This is considered a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a4848902_b3128711","line":5,"range":{"start_line":4,"start_character":64,"end_line":5,"end_character":6},"updated":"2021-06-17 07:52:51.000000000","message":"nit: s/an an/an","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"100abf27378e6f065b9d897a50d856f41209e540","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"security:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with the ``/v1/nodes/detail`` endpoint where an"},{"line_number":5,"context_line":"    an authenticated user could explicitly ask for an ``instance_uuid`` lookup"},{"line_number":6,"context_line":"    and the associated node would be returned to the user with sensitive"},{"line_number":7,"context_line":"    fields redacted in the result payload if the user did not explicitly have"},{"line_number":8,"context_line":"    ``owner`` or ``lessee`` permissions over the node. This is considered a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d6870518_c4f9908d","line":5,"range":{"start_line":4,"start_character":64,"end_line":5,"end_character":6},"in_reply_to":"a4848902_b3128711","updated":"2021-06-17 15:55:52.000000000","message":"Done","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94ba35377c6deeb23402f53b0cf85b07ccc59a74","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    ``owner`` or ``lessee`` permissions over the node. This is considered a"},{"line_number":9,"context_line":"    low-impact low-risk issue as it requires the API consumer to already know"},{"line_number":10,"context_line":"    the UUID value of the associated instance, and the returned information"},{"line_number":11,"context_line":"    is mainly mainly metadata in nature. More information can be found in"},{"line_number":12,"context_line":"    `Storyboard story 2008976 \u003chttps://storyboard.openstack.org/#!/story/2008976\u003e`_."},{"line_number":13,"context_line":"fixes:"},{"line_number":14,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"880cc354_3c5e4681","line":11,"updated":"2021-06-16 19:50:51.000000000","message":"nit s/mainly mainly/mainly/","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"100abf27378e6f065b9d897a50d856f41209e540","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    ``owner`` or ``lessee`` permissions over the node. This is considered a"},{"line_number":9,"context_line":"    low-impact low-risk issue as it requires the API consumer to already know"},{"line_number":10,"context_line":"    the UUID value of the associated instance, and the returned information"},{"line_number":11,"context_line":"    is mainly mainly metadata in nature. More information can be found in"},{"line_number":12,"context_line":"    `Storyboard story 2008976 \u003chttps://storyboard.openstack.org/#!/story/2008976\u003e`_."},{"line_number":13,"context_line":"fixes:"},{"line_number":14,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4170284e_2524c512","line":11,"in_reply_to":"880cc354_3c5e4681","updated":"2021-06-17 15:55:52.000000000","message":"Done","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94ba35377c6deeb23402f53b0cf85b07ccc59a74","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Fixes an issue with the ``/v1/nodes/detail`` endpoint where requests"},{"line_number":16,"context_line":"    for an explicit ``instance_uuid`` match would not follow the standard"},{"line_number":17,"context_line":"    query handling path and thus not be filtered appropriately."},{"line_number":18,"context_line":"    Additional information can be found in"},{"line_number":19,"context_line":"    `story 2008976 \u003chttps://storyboard.openstack.org/#!/story/2008976\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"73521ed7_428054bd","line":17,"updated":"2021-06-16 19:50:51.000000000","message":"by \u0027filtered\u0027, do we mean via policy? cuz the code did \u0027filter\u0027 the nodes to return nodes that had that instance uuid.","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"100abf27378e6f065b9d897a50d856f41209e540","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Fixes an issue with the ``/v1/nodes/detail`` endpoint where requests"},{"line_number":16,"context_line":"    for an explicit ``instance_uuid`` match would not follow the standard"},{"line_number":17,"context_line":"    query handling path and thus not be filtered appropriately."},{"line_number":18,"context_line":"    Additional information can be found in"},{"line_number":19,"context_line":"    `story 2008976 \u003chttps://storyboard.openstack.org/#!/story/2008976\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ec9dc32a_71e8a307","line":17,"in_reply_to":"73521ed7_428054bd","updated":"2021-06-17 15:55:52.000000000","message":"Policy and database. Policy no longer means just if they are admin.","commit_id":"2d520d4f2353d96743c582ea7f4eb2d64e4c3019"}]}