)]}'
{"ironic/conductor/deployments.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fc405e984bbe08d0c3cb17a715936311deedfc49","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1bb7d90b_23d62898","line":294,"updated":"2021-06-22 17:02:39.000000000","message":"nit: Perhaps we could fix the step ID without changing the message? Just wondering how many splunk queries this change might break 😄","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8da48137adcf64d441197f859f16b75ac13b9080","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"617f7095_bf758452","line":294,"in_reply_to":"1bb7d90b_23d62898","updated":"2021-06-22 17:04:30.000000000","message":"Just imagine how it will look:\n\n Failed to deploy: Deploy step deploy.deploy, error: ....\n\nI can count 4 deploys just in the prelude :)","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eea5c77e13a3bfa2e38b79d79ea0dfd8488354fd","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"495ff56e_7d1053df","line":294,"in_reply_to":"367d6997_d25d5f83","updated":"2021-06-25 13:11:55.000000000","message":"Ehmmm, are we really going to spam release notes every time we change or add an error message? Because we do it a lot. Can we, as a team, agree on and document this new policy then?","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b9c12d07f42274faab3366f608294aac22a82fef","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"d36dd777_1510bcdc","line":294,"in_reply_to":"495ff56e_7d1053df","updated":"2021-06-25 14:45:10.000000000","message":"There\u0027s probably no reasonable solution other than trying to review initial log message commits with a more critical eye. No need for my offhand nit here to hold this patch up.","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b07aaa67d5fc2f242eaef7c3d4d768ff55c2a9bc","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8056c42_58f191d2","line":294,"in_reply_to":"617f7095_bf758452","updated":"2021-06-22 17:18:48.000000000","message":"Oh, there\u0027s absolutely zero disagreement the new text is better. There\u0027s just a cost -- fully externalized for developers -- to changing a message. Hence the nit","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dbcc8f288b36e6e75b6f9b03c56e8436e2b200b2","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"367d6997_d25d5f83","line":294,"in_reply_to":"bfb777b3_898b6a6e","updated":"2021-06-25 13:05:45.000000000","message":"In that case it can be expected and maybe at worst we note it in the upgrades section?","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8f03f03e18d3e23004d658dbc812b4c674a84df4","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            utils.deploying_error_handler("},{"line_number":292,"context_line":"                task, log_msg,"},{"line_number":293,"context_line":"                _(\"Deploy step %(step)s failed: %(err)s.\")"},{"line_number":294,"context_line":"                % {\u0027step\u0027: conductor_steps.step_id(step), \u0027err\u0027: e})"},{"line_number":295,"context_line":"            return"},{"line_number":296,"context_line":"        except Exception as e:"},{"line_number":297,"context_line":"            log_msg \u003d (\u0027Node %(node)s failed deploy step %(step)s with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb777b3_898b6a6e","line":294,"in_reply_to":"c8056c42_58f191d2","updated":"2021-06-23 10:25:50.000000000","message":"I don\u0027t think we should avoid improving our user-facing messages based on a potential that somebody is doing full-text search. I\u0027m fine with not backporting it.","commit_id":"ebb314bf438914f7bce03394870832bbd884f2fd"}]}