)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b06e0cebe3918d312ff72f3020838af1d1c0556f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"are now generated and transmitted to Neutron for both IPv4 and"},{"line_number":12,"context_line":"IPv6. This option is only used by the internal"},{"line_number":13,"context_line":"``dhcp_options_for_instance`` method in"},{"line_number":14,"context_line":"``ironic.common.pxe_utils``."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Third party drivers using the ``dhcp_options_for_instance`` method"},{"line_number":17,"context_line":"should consider generating options for both IPv4 and IPv6 at all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0a51557c_5ef384ac","line":14,"updated":"2021-06-28 09:47:35.000000000","message":"If it\u0027s used in one place, why doesn\u0027t it have any effect in the code? And if it has no effect, why not remove it from the code? I\u0027m a bit confused.","commit_id":"2ec92230ebfd4a485433005c1527c520e806d2e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5412aa9308fa862f5885c05b7f77a74d32582486","unresolved":false,"context_lines":[{"line_number":11,"context_line":"are now generated and transmitted to Neutron for both IPv4 and"},{"line_number":12,"context_line":"IPv6. This option is only used by the internal"},{"line_number":13,"context_line":"``dhcp_options_for_instance`` method in"},{"line_number":14,"context_line":"``ironic.common.pxe_utils``."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Third party drivers using the ``dhcp_options_for_instance`` method"},{"line_number":17,"context_line":"should consider generating options for both IPv4 and IPv6 at all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4bc04ecf_55aee4b5","line":14,"in_reply_to":"0a51557c_5ef384ac","updated":"2021-06-28 14:00:41.000000000","message":"Updated the commit message to be a little more explicit and continue drawing the line as to why it is redundant.","commit_id":"2ec92230ebfd4a485433005c1527c520e806d2e8"}],"ironic/conf/pxe.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"00f752ddae398c68c762eaa986459adc31867358","unresolved":true,"context_lines":[{"line_number":157,"context_line":"               mutable\u003dTrue,"},{"line_number":158,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":159,"context_line":"               help\u003d_(\u0027The IP version that will be used for PXE booting. \u0027"},{"line_number":160,"context_line":"                      \u0027Defaults to 4.\u0027)),"},{"line_number":161,"context_line":"    cfg.BoolOpt(\u0027ipxe_use_swift\u0027,"},{"line_number":162,"context_line":"                default\u003dFalse,"},{"line_number":163,"context_line":"                mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"858c1d77_0f42a8a7","line":160,"updated":"2021-06-25 20:31:10.000000000","message":"nit: Maybe worthwhile to indicate in the help for this option that it is a no-op for in-tree drivers?","commit_id":"e874ee03c6dbdc69be3da6df8323a8de519fac6e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b06e0cebe3918d312ff72f3020838af1d1c0556f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"               choices\u003d[(\u00274\u0027, _(\u0027IPv4\u0027)),"},{"line_number":156,"context_line":"                        (\u00276\u0027, _(\u0027IPv6\u0027))],"},{"line_number":157,"context_line":"               mutable\u003dTrue,"},{"line_number":158,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":159,"context_line":"               help\u003d_(\u0027The IP version that will be used for PXE booting. \u0027"},{"line_number":160,"context_line":"                      \u0027Defaults to 4. This option has been a no-op for in-tree\u0027"},{"line_number":161,"context_line":"                      \u0027drivers since the Ussuri development cycle.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"592a4c99_d5f4b52e","line":158,"updated":"2021-06-28 09:47:35.000000000","message":"Could you update the devstack plugin to no longer use the deprecation option?","commit_id":"2ec92230ebfd4a485433005c1527c520e806d2e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5412aa9308fa862f5885c05b7f77a74d32582486","unresolved":false,"context_lines":[{"line_number":155,"context_line":"               choices\u003d[(\u00274\u0027, _(\u0027IPv4\u0027)),"},{"line_number":156,"context_line":"                        (\u00276\u0027, _(\u0027IPv6\u0027))],"},{"line_number":157,"context_line":"               mutable\u003dTrue,"},{"line_number":158,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":159,"context_line":"               help\u003d_(\u0027The IP version that will be used for PXE booting. \u0027"},{"line_number":160,"context_line":"                      \u0027Defaults to 4. This option has been a no-op for in-tree\u0027"},{"line_number":161,"context_line":"                      \u0027drivers since the Ussuri development cycle.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2603f79_de44e2fe","line":158,"in_reply_to":"592a4c99_d5f4b52e","updated":"2021-06-28 14:00:41.000000000","message":"Done, we still have the setting in place to control what style of job is used.","commit_id":"2ec92230ebfd4a485433005c1527c520e806d2e8"}]}