)]}'
{"ironic/drivers/modules/inspect_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4bd73011d1a4d7c45822a831b7d3e78a6e33e7ac","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    node \u003d task.node"},{"line_number":40,"context_line":"    for k_v_pair in macs.items():"},{"line_number":41,"context_line":"        mac \u003d get_mac_address(k_v_pair)"},{"line_number":42,"context_line":"        if not mac:"},{"line_number":43,"context_line":"            LOG.warning(\"Skipping Port create for %(node)s as no MAC reported\","},{"line_number":44,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":45,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa666570_095d37e3","line":42,"updated":"2021-06-30 12:54:32.000000000","message":"I\u0027d rather fix the place that supplies empty MACs. Is it coming from redfish get_enabled_macs? How do we even end up with empty MACs in the first place?\n\nIf it\u0027s a normal behavior (redfish, amiright?), I think we rather issue a warning in get_enabled_macs.\n\nWe can also have this check here, but I\u0027d avoid a warning since it\u0027s not helpful at this stage (inside redfish utils we can log the whole EthernetInterfaces object).","commit_id":"9fbd4d266311240974981dfe526d37f1767e11cf"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"edef23dd7d6692224864a1bfc29dfe73061345e7","unresolved":true,"context_lines":[{"line_number":371,"context_line":"            if nic_state !\u003d sushy.STATE_ENABLED:"},{"line_number":372,"context_line":"                continue"},{"line_number":373,"context_line":"            elif not nic_mac:"},{"line_number":374,"context_line":"                LOG.warning(\"Ignoring device for %(node)s as no MAC \""},{"line_number":375,"context_line":"                            \"reported\", {\u0027node\u0027: task.node.uuid})"},{"line_number":376,"context_line":"                continue"},{"line_number":377,"context_line":"            enabled_macs[nic_mac] \u003d nic_state"},{"line_number":378,"context_line":"        if enabled_macs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b33b9aca_e565b3d5","line":375,"range":{"start_line":374,"start_character":0,"end_line":375,"end_character":65},"updated":"2021-06-30 21:22:51.000000000","message":"I guess the question is how do they know what device? Does it matter, I dunno.","commit_id":"0cc6d8204af9ac0fc56052106e5eb0094d85ff2d"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"004529e06901c2c51139ac28c8d2bb192d926208","unresolved":true,"context_lines":[{"line_number":371,"context_line":"            if nic_state !\u003d sushy.STATE_ENABLED:"},{"line_number":372,"context_line":"                continue"},{"line_number":373,"context_line":"            elif not nic_mac:"},{"line_number":374,"context_line":"                LOG.warning(\"Ignoring device for %(node)s as no MAC \""},{"line_number":375,"context_line":"                            \"reported\", {\u0027node\u0027: task.node.uuid})"},{"line_number":376,"context_line":"                continue"},{"line_number":377,"context_line":"            enabled_macs[nic_mac] \u003d nic_state"},{"line_number":378,"context_line":"        if enabled_macs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c76825e_18551277","line":375,"range":{"start_line":374,"start_character":0,"end_line":375,"end_character":65},"in_reply_to":"b33b9aca_e565b3d5","updated":"2021-07-01 10:50:21.000000000","message":"Ya, that info isn\u0027t available without a bunch more logic, I figure this is enough to set somebody down the correct path.","commit_id":"0cc6d8204af9ac0fc56052106e5eb0094d85ff2d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"edef23dd7d6692224864a1bfc29dfe73061345e7","unresolved":true,"context_lines":[{"line_number":367,"context_line":"        macs \u003d system.ethernet_interfaces.summary"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        # Identify ports for the NICs being in \u0027enabled\u0027 state"},{"line_number":370,"context_line":"        for nic_mac, nic_state in macs.items():"},{"line_number":371,"context_line":"            if nic_state !\u003d sushy.STATE_ENABLED:"},{"line_number":372,"context_line":"                continue"},{"line_number":373,"context_line":"            elif not nic_mac:"},{"line_number":374,"context_line":"                LOG.warning(\"Ignoring device for %(node)s as no MAC \""},{"line_number":375,"context_line":"                            \"reported\", {\u0027node\u0027: task.node.uuid})"},{"line_number":376,"context_line":"                continue"},{"line_number":377,"context_line":"            enabled_macs[nic_mac] \u003d nic_state"},{"line_number":378,"context_line":"        if enabled_macs:"},{"line_number":379,"context_line":"            return enabled_macs"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    LOG.debug(\"No ethernet interface information is available \""}],"source_content_type":"text/x-python","patch_set":2,"id":"99eae42f_aa99661f","line":378,"range":{"start_line":370,"start_character":0,"end_line":378,"end_character":24},"updated":"2021-06-30 21:22:51.000000000","message":"ugyh, yeah. Macs were totally optional early on. :(","commit_id":"0cc6d8204af9ac0fc56052106e5eb0094d85ff2d"}]}