)]}'
{"ironic/drivers/fake.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e5fdbce0cb1a24a79b48be4ddff5da013f96cd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.rescue \u003d self.deploy"},{"line_number":92,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":93,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":94,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":95,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":96,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":97,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2Bwdc%3D","line":94,"updated":"2014-03-12 11:15:10.000000000","message":"FakeSeaMicroDriver uses FakeDeploy interface, therefore I think pass_deploy_info method not needed and we should only use self.vendor \u003d seamicro.VendorPassthru().","commit_id":"eb53a286813ab785abdb9ec6dc86b8fe3cfd0812"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"f5d9372e939d3b9fa6f9a3aa649d90bf76ee648b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.rescue \u003d self.deploy"},{"line_number":92,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":93,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":94,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":95,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":96,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":97,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2F8s%3D","line":94,"in_reply_to":"AAAAVn%2F%2Bwdc%3D","updated":"2014-03-12 12:50:29.000000000","message":"True. I was just copying what was before, but it doesn\u0027t make sense.\nDone","commit_id":"eb53a286813ab785abdb9ec6dc86b8fe3cfd0812"}],"ironic/drivers/pxe.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"942acba1fdc99d84044d8577b31c1f3d3c8363bd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":110,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":111,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":112,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":113,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":114,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"},{"line_number":115,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fsos%3D","line":112,"updated":"2014-03-14 12:38:40.000000000","message":"I think better to use VENDOR_PASSTHRU_METHODS list from seamicro driver for generate mapping for seamicro_vendor than duplicate methods names here.","commit_id":"bdf9d958145da9cfc43ee729aca93009cc10e93d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"69dcdd093ff031dc0f9c4b286e7d676e5af2aaa9","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":110,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":111,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":112,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":113,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":114,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"},{"line_number":115,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FU7M%3D","line":112,"updated":"2014-03-18 15:52:09.000000000","message":"Should this mapping be stored in a static file somewhere? like Policy.json in the Nova project? Any comments?","commit_id":"bdf9d958145da9cfc43ee729aca93009cc10e93d"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"4e8d38b30b7faf57c99710c0413b45fbd3b1822c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":110,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":111,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":112,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":113,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":114,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"},{"line_number":115,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FTdo%3D","line":112,"in_reply_to":"AAAAWH%2F%2FU7M%3D","updated":"2014-03-18 18:29:45.000000000","message":"I didn\u0027t though about that but it could be an option. Will propose for discuss in the next Ironic meeting","commit_id":"bdf9d958145da9cfc43ee729aca93009cc10e93d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ab2664aa7c54b699b8257bcb43afae3d6a07c339","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":110,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":111,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":112,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":113,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":114,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"},{"line_number":115,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiKE%3D","line":112,"in_reply_to":"AAAAWH%2F%2FiNE%3D","updated":"2014-03-17 09:04:26.000000000","message":"ok","commit_id":"bdf9d958145da9cfc43ee729aca93009cc10e93d"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"dd50293e5f3f2008f364d150a36e38c958a3e14c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.seamicro_vendor \u003d seamicro.VendorPassthru()"},{"line_number":110,"context_line":"        self.pxe_vendor \u003d pxe.VendorPassthru()"},{"line_number":111,"context_line":"        self.mapping \u003d {\u0027pass_deploy_info\u0027: self.pxe_vendor,"},{"line_number":112,"context_line":"                        \u0027attach_volume\u0027: self.seamicro_vendor,"},{"line_number":113,"context_line":"                        \u0027set_boot_device\u0027: self.seamicro_vendor,"},{"line_number":114,"context_line":"                        \u0027set_node_vlan_id\u0027: self.seamicro_vendor}"},{"line_number":115,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiNE%3D","line":112,"in_reply_to":"AAAAWH%2F%2Fsos%3D","updated":"2014-03-17 08:59:06.000000000","message":"The idea in the new MixinVendorInterface is to made every mapping explicit.  Iterating over the VENDOR_PASSTHRU_METHODS will hide the mapping.","commit_id":"bdf9d958145da9cfc43ee729aca93009cc10e93d"}]}