)]}'
{"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"58d30610e8c2e2781e31b49a5da2ef1c00aa40aa","unresolved":true,"context_lines":[{"line_number":704,"context_line":"    Key Agreement (AKA), then the driver can still be used for executing"},{"line_number":705,"context_line":"    this cleaning step."},{"line_number":706,"context_line":"  ``clear_ca_certificates``:"},{"line_number":707,"context_line":"    Removes the invalid CA certificates from iLO. See "},{"line_number":708,"context_line":"    `Removing CA certificates from iLO as manual clean step`_ for user"},{"line_number":709,"context_line":"    guidance on usage."},{"line_number":710,"context_line":"  ``apply_configuration``:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"244a6722_2c6b65cd","line":707,"range":{"start_line":707,"start_character":53,"end_line":707,"end_character":54},"updated":"2021-08-27 06:14:39.000000000","message":"nit: Extra space at end.","commit_id":"81668cf774e4e4008c02af22a977934a26d2fbef"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"58d30610e8c2e2781e31b49a5da2ef1c00aa40aa","unresolved":true,"context_lines":[{"line_number":1499,"context_line":"        \"args\": {"},{"line_number":1500,"context_line":"            \"certificate_files\" : [\"/path/to/certsA\", \"/path/to/certsB\"]"},{"line_number":1501,"context_line":"        }"},{"line_number":1502,"context_line":"           "},{"line_number":1503,"context_line":"    }]"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"The different attributes of ``clear_ca_certificates`` clean step are as follows:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4d5692_dbc042cf","line":1502,"range":{"start_line":1502,"start_character":0,"end_line":1502,"end_character":11},"updated":"2021-08-27 06:14:39.000000000","message":"Extra line.","commit_id":"81668cf774e4e4008c02af22a977934a26d2fbef"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae53fc7087637c7e081a6ec5bfa60bedea909be5","unresolved":true,"context_lines":[{"line_number":704,"context_line":"    Key Agreement (AKA), then the driver can still be used for executing"},{"line_number":705,"context_line":"    this cleaning step."},{"line_number":706,"context_line":"  ``clear_ca_certificates``:"},{"line_number":707,"context_line":"    Removes the invalid CA certificates from iLO. See"},{"line_number":708,"context_line":"    `Removing CA certificates from iLO as manual clean step`_ for user"},{"line_number":709,"context_line":"    guidance on usage."},{"line_number":710,"context_line":"  ``apply_configuration``:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"4c6604a3_cf9eb979","line":707,"range":{"start_line":707,"start_character":16,"end_line":707,"end_character":24},"updated":"2021-09-07 13:08:05.000000000","message":"nit: it might be good to s/invalid/invalidated/","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"79c79a1bbd8288f253c6f6fa868594cc8f23d25a","unresolved":true,"context_lines":[{"line_number":704,"context_line":"    Key Agreement (AKA), then the driver can still be used for executing"},{"line_number":705,"context_line":"    this cleaning step."},{"line_number":706,"context_line":"  ``clear_ca_certificates``:"},{"line_number":707,"context_line":"    Removes the invalid CA certificates from iLO. See"},{"line_number":708,"context_line":"    `Removing CA certificates from iLO as manual clean step`_ for user"},{"line_number":709,"context_line":"    guidance on usage."},{"line_number":710,"context_line":"  ``apply_configuration``:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"d6aed7c1_98a3d7a4","line":707,"range":{"start_line":707,"start_character":16,"end_line":707,"end_character":24},"in_reply_to":"4c6604a3_cf9eb979","updated":"2021-09-08 09:15:15.000000000","message":"Removed the word \"invalid\" as per comment on other file.","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae53fc7087637c7e081a6ec5bfa60bedea909be5","unresolved":true,"context_lines":[{"line_number":1002,"context_line":"        # NOTE(TheJulia): Since we\u0027re deploying, cleaning, or rescuing,"},{"line_number":1003,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":1004,"context_line":"        manager_utils.add_secret_token(node, pregenerated\u003dTrue)"},{"line_number":1005,"context_line":"        task.node.save()"},{"line_number":1006,"context_line":"        ramdisk_params[\u0027ipa-agent-token\u0027] \u003d \\"},{"line_number":1007,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":1008,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"57ebcfa1_e725f377","line":1005,"range":{"start_line":1005,"start_character":0,"end_line":1005,"end_character":24},"updated":"2021-09-07 13:08:05.000000000","message":"This should not move in that we must ensure the agent token is saved. If it is not saved the agent won\u0027t be able to talk to Ironic. This seems like the one thing which we should revise before merging.","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"79c79a1bbd8288f253c6f6fa868594cc8f23d25a","unresolved":true,"context_lines":[{"line_number":1002,"context_line":"        # NOTE(TheJulia): Since we\u0027re deploying, cleaning, or rescuing,"},{"line_number":1003,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":1004,"context_line":"        manager_utils.add_secret_token(node, pregenerated\u003dTrue)"},{"line_number":1005,"context_line":"        task.node.save()"},{"line_number":1006,"context_line":"        ramdisk_params[\u0027ipa-agent-token\u0027] \u003d \\"},{"line_number":1007,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":1008,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"87bed9bc_f3a0ad65","line":1005,"range":{"start_line":1005,"start_character":0,"end_line":1005,"end_character":24},"in_reply_to":"57ebcfa1_e725f377","updated":"2021-09-08 09:15:15.000000000","message":"Ok","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dbed612a7be1b1d47bb9a2b5282957020b82b66","unresolved":true,"context_lines":[{"line_number":189,"context_line":"_CLEAR_CA_CERTS_ARGSINFO \u003d {"},{"line_number":190,"context_line":"    \u0027certificate_files\u0027: {"},{"line_number":191,"context_line":"        \u0027description\u0027: ("},{"line_number":192,"context_line":"            \"The list of files containing the certificates to be cleared.\""},{"line_number":193,"context_line":"            \"If empty list is specified, all the certificates on the ilo \""},{"line_number":194,"context_line":"            \"will be cleared. In any case, the certificates in the file \""},{"line_number":195,"context_line":"            \"configured for \u0027webserver_verify_ca\u0027 are spared as they are \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1bb98563_10bd8f6c","line":192,"range":{"start_line":192,"start_character":72,"end_line":192,"end_character":74},"updated":"2021-07-16 09:48:21.000000000","message":"Add a space at end.\ns/\"cleared.\" /\"cleared. \"/","commit_id":"7f67e00714a9dcdbd6fc5284a3e6d59b88645ee3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dbed612a7be1b1d47bb9a2b5282957020b82b66","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        \u0027description\u0027: ("},{"line_number":192,"context_line":"            \"The list of files containing the certificates to be cleared.\""},{"line_number":193,"context_line":"            \"If empty list is specified, all the certificates on the ilo \""},{"line_number":194,"context_line":"            \"will be cleared. In any case, the certificates in the file \""},{"line_number":195,"context_line":"            \"configured for \u0027webserver_verify_ca\u0027 are spared as they are \""},{"line_number":196,"context_line":"            \"required for booting the deploy image for some boot interfaces.\""},{"line_number":197,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ffb8996_fe90ffa5","line":194,"range":{"start_line":194,"start_character":28,"end_line":194,"end_character":42},"updated":"2021-07-16 09:48:21.000000000","message":"s/ \". In any case,\" / \", except\"","commit_id":"7f67e00714a9dcdbd6fc5284a3e6d59b88645ee3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dbed612a7be1b1d47bb9a2b5282957020b82b66","unresolved":true,"context_lines":[{"line_number":192,"context_line":"            \"The list of files containing the certificates to be cleared.\""},{"line_number":193,"context_line":"            \"If empty list is specified, all the certificates on the ilo \""},{"line_number":194,"context_line":"            \"will be cleared. In any case, the certificates in the file \""},{"line_number":195,"context_line":"            \"configured for \u0027webserver_verify_ca\u0027 are spared as they are \""},{"line_number":196,"context_line":"            \"required for booting the deploy image for some boot interfaces.\""},{"line_number":197,"context_line":"        ),"},{"line_number":198,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":2,"id":"143da533_506483e8","line":195,"range":{"start_line":195,"start_character":24,"end_line":195,"end_character":27},"updated":"2021-07-16 09:48:21.000000000","message":"s/ for / with configuration parameter/","commit_id":"7f67e00714a9dcdbd6fc5284a3e6d59b88645ee3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae53fc7087637c7e081a6ec5bfa60bedea909be5","unresolved":true,"context_lines":[{"line_number":1144,"context_line":"                                                 errmsg\u003dilo_exception)"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"    @base.clean_step(priority\u003d0, argsinfo\u003d_CLEAR_CA_CERTS_ARGSINFO)"},{"line_number":1147,"context_line":"    def clear_ca_certificates(self, task, certificate_files):"},{"line_number":1148,"context_line":"        \"\"\"Clears the certificates provided in the list of files to iLO."},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":7,"id":"96b91516_896ffc50","line":1147,"updated":"2021-09-07 13:08:05.000000000","message":"So the docs say this is for removing invalidated certificates, I\u0027m a little confused, and I think the docs likely just need to be revised since this seems fairly clear. Remove the provided CA certificates.","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"79c79a1bbd8288f253c6f6fa868594cc8f23d25a","unresolved":true,"context_lines":[{"line_number":1144,"context_line":"                                                 errmsg\u003dilo_exception)"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"    @base.clean_step(priority\u003d0, argsinfo\u003d_CLEAR_CA_CERTS_ARGSINFO)"},{"line_number":1147,"context_line":"    def clear_ca_certificates(self, task, certificate_files):"},{"line_number":1148,"context_line":"        \"\"\"Clears the certificates provided in the list of files to iLO."},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":7,"id":"73239053_13f13596","line":1147,"in_reply_to":"96b91516_896ffc50","updated":"2021-09-08 09:15:15.000000000","message":"ok","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae53fc7087637c7e081a6ec5bfa60bedea909be5","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"    def clear_ca_certificates(self, task, certificate_files):"},{"line_number":1148,"context_line":"        \"\"\"Clears the certificates provided in the list of files to iLO."},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        :param task: a task from TaskManager."},{"line_number":1151,"context_line":"        :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":1152,"context_line":"        :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":1153,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"39826b12_8dbfd5f3","line":1150,"updated":"2021-09-07 13:08:05.000000000","message":"Add a param for certificate_files here.","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"79c79a1bbd8288f253c6f6fa868594cc8f23d25a","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"    def clear_ca_certificates(self, task, certificate_files):"},{"line_number":1148,"context_line":"        \"\"\"Clears the certificates provided in the list of files to iLO."},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        :param task: a task from TaskManager."},{"line_number":1151,"context_line":"        :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":1152,"context_line":"        :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":1153,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"59c5d222_02ac0862","line":1150,"in_reply_to":"39826b12_8dbfd5f3","updated":"2021-09-08 09:15:15.000000000","message":"ok","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae53fc7087637c7e081a6ec5bfa60bedea909be5","unresolved":true,"context_lines":[{"line_number":1153,"context_line":"        \"\"\""},{"line_number":1154,"context_line":"        node \u003d task.node"},{"line_number":1155,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"        if driver_internal_info.get(\u0027clear_ca_certs_flag\u0027):"},{"line_number":1158,"context_line":"            # NOTE(vmud213): Clear the flag and do nothing as this flow"},{"line_number":1159,"context_line":"            # is part of the reboot required by the clean step that is"}],"source_content_type":"text/x-python","patch_set":7,"id":"e223402d_45d22bb7","line":1156,"updated":"2021-09-07 13:08:05.000000000","message":"Wouldn\u0027t it be user friendly to \"if called without a list, clear all CA certificates?\"\n\nI guess a downside of this is we may break communication with the BMC if we actually did that.","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"79c79a1bbd8288f253c6f6fa868594cc8f23d25a","unresolved":true,"context_lines":[{"line_number":1153,"context_line":"        \"\"\""},{"line_number":1154,"context_line":"        node \u003d task.node"},{"line_number":1155,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"        if driver_internal_info.get(\u0027clear_ca_certs_flag\u0027):"},{"line_number":1158,"context_line":"            # NOTE(vmud213): Clear the flag and do nothing as this flow"},{"line_number":1159,"context_line":"            # is part of the reboot required by the clean step that is"}],"source_content_type":"text/x-python","patch_set":7,"id":"56206cbc_e7e85daf","line":1156,"in_reply_to":"e223402d_45d22bb7","updated":"2021-09-08 09:15:15.000000000","message":"Yes Julia if we clear all certificates, then it will break communication with the BMC.","commit_id":"dd24864467bc4864f268e44126fdbf05abed57e3"}],"releasenotes/notes/clear_ca_cert-db41e7be9723c0fb.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"58d30610e8c2e2781e31b49a5da2ef1c00aa40aa","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manual clean step ``clear_ca_certificates`` is added to remove the"},{"line_number":5,"context_line":"    invalidated CA certificates from iLO."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2ab0a457_eb9a3271","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"updated":"2021-08-27 06:14:39.000000000","message":"s/ invalidated //","commit_id":"81668cf774e4e4008c02af22a977934a26d2fbef"}]}