)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7b3dd7eebdaf73c6ee3a0ec1daa0b6e64d596c04","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        :param task: a task from TaskManager."},{"line_number":319,"context_line":"        :param node: a single Node."},{"line_number":320,"context_line":"        :param kwargs: info for action."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        :raises: UnsupportedDriverExtension if \u0027method\u0027 can not be mapped to"},{"line_number":323,"context_line":"                 the supported interfaces."},{"line_number":324,"context_line":"        :raises: InvalidParameterValue if **kwargs does not contain \u0027method\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fz9Y%3D","line":321,"updated":"2014-03-13 16:54:15.000000000","message":"Nit: remove this new line here","commit_id":"b5061c9bafa21d3e6839030df92efbf176038a4c"}],"ironic/drivers/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2be6edd19bda3d77460b5b4fc4e9a0dbed2a656a","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        :returns: an instance of a VendorInterface"},{"line_number":38,"context_line":"        :raises: InvalidParameterValue if **kwargs does not contain \u0027method\u0027"},{"line_number":39,"context_line":"                 or if the method can not be mapped to an interface."},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        method \u003d kwargs.get(\u0027method\u0027)"},{"line_number":42,"context_line":"        return self.mapping.get(method) or _raise_unsupported_error(method)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2Btc%3D","line":39,"updated":"2014-03-12 15:21:15.000000000","message":"This DocString needs to be updated:\n\n:raises: UnsupportedDriverExtension if the method passed through to vendor extension is not supported\n\nI also think that this \":raises:\" should be in the validate() and vendor_passhtru() method, not on this privite _map methods. Mind changing it in this patch? or you think we should put it in another patch?","commit_id":"a9ac11e044b9a5625365edb0482db7a8b81f40c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d4b3761df4ca73a339819e404676ca52f12b424","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def validate(self, *args, **kwargs):"},{"line_number":45,"context_line":"        \"\"\"Call validate on the appropriate interface only."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :raises: UnsupportedDriverExtension if \u0027method\u0027 can not be mapped to"},{"line_number":48,"context_line":"                 the supported interfaces."},{"line_number":49,"context_line":"        :raises: InvalidParameterValue if **kwargs does not contain \u0027method\u0027."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F8FA%3D","line":47,"updated":"2014-03-12 20:07:36.000000000","message":"This is fine. But the docstring in VendorInterface.validate() needs to be updated too.\n\nHmm. Don\u0027t know if you also want to update docstrings for conductor.manager.ConductorManager.vendor_passthru, \"UnsupportedDriverExtension if current driver does not have\n                 vendor interface or method is unsupported\".","commit_id":"53aa72ec716c74636eac50ed94d4c739db7346bf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"bae856d3177b1a0325314e5bbc0b13d8fa2b8826","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def validate(self, *args, **kwargs):"},{"line_number":45,"context_line":"        \"\"\"Call validate on the appropriate interface only."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :raises: UnsupportedDriverExtension if \u0027method\u0027 can not be mapped to"},{"line_number":48,"context_line":"                 the supported interfaces."},{"line_number":49,"context_line":"        :raises: InvalidParameterValue if **kwargs does not contain \u0027method\u0027."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F6pk%3D","line":47,"in_reply_to":"AAAAWH%2F%2F8FA%3D","updated":"2014-03-12 23:49:50.000000000","message":"Ahh, good point, thanks!","commit_id":"53aa72ec716c74636eac50ed94d4c739db7346bf"}]}