)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb1f270540e06ff538331296ca00a10f29440f53","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        delta \u003d node_obj.obj_what_changed()"},{"line_number":228,"context_line":"        if \u0027power_state\u0027 in delta:"},{"line_number":229,"context_line":"            raise exception.IronicException(_("},{"line_number":230,"context_line":"                \"Invalid method call: update_node can not change node state.\"))"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        driver_name \u003d node_obj.get(\u0027driver\u0027) if \u0027driver\u0027 in delta else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FwN8%3D","line":229,"updated":"2014-03-14 01:57:18.000000000","message":"Is this an expected exception?","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d5e0799655b71212c56f387888ccab30b27f4e4","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        delta \u003d node_obj.obj_what_changed()"},{"line_number":228,"context_line":"        if \u0027power_state\u0027 in delta:"},{"line_number":229,"context_line":"            raise exception.IronicException(_("},{"line_number":230,"context_line":"                \"Invalid method call: update_node can not change node state.\"))"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        driver_name \u003d node_obj.get(\u0027driver\u0027) if \u0027driver\u0027 in delta else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FrMY%3D","line":229,"in_reply_to":"AAAAWH%2F%2FwN8%3D","updated":"2014-03-14 15:11:56.000000000","message":"I think it\u0027s not. The API service shouldn\u0027t send a request to update power state via this method.","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb1f270540e06ff538331296ca00a10f29440f53","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            # TODO(deva): Determine what value will be passed by API when"},{"line_number":237,"context_line":"            #             instance_uuid needs to be unset, and handle it."},{"line_number":238,"context_line":"            if \u0027instance_uuid\u0027 in delta:"},{"line_number":239,"context_line":"                task.driver.power.validate(task, node_obj)"},{"line_number":240,"context_line":"                node_obj[\u0027power_state\u0027] \u003d \\"},{"line_number":241,"context_line":"                        task.driver.power.get_power_state(task, node_obj)"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FwNU%3D","line":239,"updated":"2014-03-14 01:57:18.000000000","message":"Are exception.InvalidParameterValue\u0027s expected exceptions?","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d5e0799655b71212c56f387888ccab30b27f4e4","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            # TODO(deva): Determine what value will be passed by API when"},{"line_number":237,"context_line":"            #             instance_uuid needs to be unset, and handle it."},{"line_number":238,"context_line":"            if \u0027instance_uuid\u0027 in delta:"},{"line_number":239,"context_line":"                task.driver.power.validate(task, node_obj)"},{"line_number":240,"context_line":"                node_obj[\u0027power_state\u0027] \u003d \\"},{"line_number":241,"context_line":"                        task.driver.power.get_power_state(task, node_obj)"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FrLY%3D","line":239,"in_reply_to":"AAAAWH%2F%2FwNU%3D","updated":"2014-03-14 15:11:56.000000000","message":"Good point -- yes, they are. The user may attempt to associate a node with insufficient driver_info, triggering InvalidParameterValue here.","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb1f270540e06ff538331296ca00a10f29440f53","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                raise exception.NodeInMaintenance(op\u003d_(\u0027provisioning\u0027),"},{"line_number":369,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"            task.driver.deploy.validate(task, node)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"            # Set target state to expose that work is in progress"},{"line_number":374,"context_line":"            node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FwMI%3D","line":371,"updated":"2014-03-14 01:57:18.000000000","message":"Are exception.InvalidParameterValue\u0027s expected exceptions?","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"98739fd3a35033a3951f9ab5364bce6996b981b6","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                raise exception.NodeInMaintenance(op\u003d_(\u0027provisioning\u0027),"},{"line_number":369,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"            task.driver.deploy.validate(task, node)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"            # Set target state to expose that work is in progress"},{"line_number":374,"context_line":"            node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fk3o%3D","line":371,"in_reply_to":"AAAAWH%2F%2FrLA%3D","updated":"2014-03-16 12:31:29.000000000","message":"Handled in separate review: https://review.openstack.org/80671","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d5e0799655b71212c56f387888ccab30b27f4e4","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                raise exception.NodeInMaintenance(op\u003d_(\u0027provisioning\u0027),"},{"line_number":369,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"            task.driver.deploy.validate(task, node)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"            # Set target state to expose that work is in progress"},{"line_number":374,"context_line":"            node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FrLA%3D","line":371,"in_reply_to":"AAAAWH%2F%2FwMI%3D","updated":"2014-03-14 15:11:56.000000000","message":"This should catch InvalidParameterValue, reraising InstanceDeployFailure","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb1f270540e06ff538331296ca00a10f29440f53","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    \"not allowed for node %(node)s in state %(state)s\")"},{"line_number":439,"context_line":"                    % {\u0027node\u0027: node_id, \u0027state\u0027: node.provision_state})"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            task.driver.deploy.validate(task, node)"},{"line_number":442,"context_line":"            node.provision_state \u003d states.DELETING"},{"line_number":443,"context_line":"            node.target_provision_state \u003d states.DELETED"},{"line_number":444,"context_line":"            node.last_error \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FwLk%3D","line":441,"updated":"2014-03-14 01:57:18.000000000","message":"Are exception.InvalidParameterValue\u0027s expected exceptions?","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"98739fd3a35033a3951f9ab5364bce6996b981b6","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    \"not allowed for node %(node)s in state %(state)s\")"},{"line_number":439,"context_line":"                    % {\u0027node\u0027: node_id, \u0027state\u0027: node.provision_state})"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            task.driver.deploy.validate(task, node)"},{"line_number":442,"context_line":"            node.provision_state \u003d states.DELETING"},{"line_number":443,"context_line":"            node.target_provision_state \u003d states.DELETED"},{"line_number":444,"context_line":"            node.last_error \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fk3k%3D","line":441,"in_reply_to":"AAAAWH%2F%2FrKk%3D","updated":"2014-03-16 12:31:29.000000000","message":"Handled in separate review: https://review.openstack.org/80671","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d5e0799655b71212c56f387888ccab30b27f4e4","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    \"not allowed for node %(node)s in state %(state)s\")"},{"line_number":439,"context_line":"                    % {\u0027node\u0027: node_id, \u0027state\u0027: node.provision_state})"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            task.driver.deploy.validate(task, node)"},{"line_number":442,"context_line":"            node.provision_state \u003d states.DELETING"},{"line_number":443,"context_line":"            node.target_provision_state \u003d states.DELETED"},{"line_number":444,"context_line":"            node.last_error \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FrKk%3D","line":441,"in_reply_to":"AAAAWH%2F%2FwLk%3D","updated":"2014-03-14 15:11:56.000000000","message":"ditto - should reraise InstanceDeployFailure","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"bfaa1d3bb775c29c79c71cbe8e37774e7ac0af1b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            # TODO(deva): Determine what value will be passed by API when"},{"line_number":234,"context_line":"            #             instance_uuid needs to be unset, and handle it."},{"line_number":235,"context_line":"            if \u0027instance_uuid\u0027 in delta:"},{"line_number":236,"context_line":"                task.driver.power.validate(task, node_obj)"},{"line_number":237,"context_line":"                node_obj[\u0027power_state\u0027] \u003d \\"},{"line_number":238,"context_line":"                        task.driver.power.get_power_state(task, node_obj)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FkEo%3D","side":"PARENT","line":236,"updated":"2014-03-17 00:26:23.000000000","message":"From patch set 2, it looks like InvalidParameterValue needs to be added above.","commit_id":"f1dd850b30148f33dc7b5e6f5794d96019669993"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"4cdf51926832973c276e7c3b472de42aa9191fb3","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            # TODO(deva): Determine what value will be passed by API when"},{"line_number":234,"context_line":"            #             instance_uuid needs to be unset, and handle it."},{"line_number":235,"context_line":"            if \u0027instance_uuid\u0027 in delta:"},{"line_number":236,"context_line":"                task.driver.power.validate(task, node_obj)"},{"line_number":237,"context_line":"                node_obj[\u0027power_state\u0027] \u003d \\"},{"line_number":238,"context_line":"                        task.driver.power.get_power_state(task, node_obj)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FfnM%3D","side":"PARENT","line":236,"in_reply_to":"AAAAWH%2F%2FkEo%3D","updated":"2014-03-17 15:17:42.000000000","message":"Done","commit_id":"f1dd850b30148f33dc7b5e6f5794d96019669993"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3140ef4c1286276db8d0ae89c4c43a9f44282014","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                                db_node.uuid,"},{"line_number":308,"context_line":"                                states.POWER_ON)"},{"line_number":309,"context_line":"        # Compare true exception hidden by @messaging.client_exceptions"},{"line_number":310,"context_line":"        self.assertEqual(exc._exc_info[0].__name__, \"NodeLocked\")"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        # In this test worker should not be spawned, but waiting to make sure"},{"line_number":313,"context_line":"        # the below perform_mock assertion is valid."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FqI4%3D","line":310,"updated":"2014-03-14 18:10:58.000000000","message":"I think it\u0027s better to avoid comparing strings because if that exception changes name it will be hard to keep track the string and tools like pylint or pep8 won\u0027t be able to check if the exception exist or not.\n\nSo I would change it to:\n\nself.assertEqual(exception.NodeLocked, exc._exc_info[0])\n\n - same comment for similar checks in this file -","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"360d2192b5799a7d5c505da1533799a1e62713f7","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                                db_node.uuid,"},{"line_number":308,"context_line":"                                states.POWER_ON)"},{"line_number":309,"context_line":"        # Compare true exception hidden by @messaging.client_exceptions"},{"line_number":310,"context_line":"        self.assertEqual(exc._exc_info[0].__name__, \"NodeLocked\")"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        # In this test worker should not be spawned, but waiting to make sure"},{"line_number":313,"context_line":"        # the below perform_mock assertion is valid."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fphs%3D","line":310,"in_reply_to":"AAAAWH%2F%2FqI4%3D","updated":"2014-03-14 18:37:52.000000000","message":"Done","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb1f270540e06ff538331296ca00a10f29440f53","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        # check that it fails because driver not found"},{"line_number":462,"context_line":"        node[\u0027driver\u0027] \u003d wrong_driver"},{"line_number":463,"context_line":"        node[\u0027driver_info\u0027] \u003d {}"},{"line_number":464,"context_line":"        self.assertRaises(exception.DriverNotFound,"},{"line_number":465,"context_line":"                          self.service.update_node,"},{"line_number":466,"context_line":"                          self.context,"},{"line_number":467,"context_line":"                          node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FwGo%3D","line":464,"updated":"2014-03-14 01:57:18.000000000","message":"This is interesting. Is this an expected exception? This can be raised from TaskManager().","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3140ef4c1286276db8d0ae89c4c43a9f44282014","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        # check that it fails because driver not found"},{"line_number":462,"context_line":"        node[\u0027driver\u0027] \u003d wrong_driver"},{"line_number":463,"context_line":"        node[\u0027driver_info\u0027] \u003d {}"},{"line_number":464,"context_line":"        self.assertRaises(exception.DriverNotFound,"},{"line_number":465,"context_line":"                          self.service.update_node,"},{"line_number":466,"context_line":"                          self.context,"},{"line_number":467,"context_line":"                          node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FqHs%3D","line":464,"in_reply_to":"AAAAWH%2F%2FrJc%3D","updated":"2014-03-14 18:10:58.000000000","message":"+1, this exception should continue to be logged because that\u0027s actually an error, the others exceptions that are being inhibited are because they are part of a flow and for that reason they shouldn\u0027t be logged as an error (because they r not)","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d5e0799655b71212c56f387888ccab30b27f4e4","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        # check that it fails because driver not found"},{"line_number":462,"context_line":"        node[\u0027driver\u0027] \u003d wrong_driver"},{"line_number":463,"context_line":"        node[\u0027driver_info\u0027] \u003d {}"},{"line_number":464,"context_line":"        self.assertRaises(exception.DriverNotFound,"},{"line_number":465,"context_line":"                          self.service.update_node,"},{"line_number":466,"context_line":"                          self.context,"},{"line_number":467,"context_line":"                          node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FrJc%3D","line":464,"in_reply_to":"AAAAWH%2F%2FwGo%3D","updated":"2014-03-14 15:11:56.000000000","message":"Interesting indeed... not sure how I would classify this.\n\nDriverNotFound is possible from any TaskManager call, but could indicate a more serious problem if that\u0027s showing up frequently on a conductor. I would suggest not suppressing this exception.","commit_id":"aeec6971abac2799fc14f92e00a166f35f897bf7"}]}
