)]}'
{"ironic/drivers/modules/agent_base.py":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"bbddf1ce8a526c87e42b021bb64456f1985feb23","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"            # after IPA sets the boot order to work around the vendor changing"},{"line_number":1353,"context_line":"            # the order when the device is set"},{"line_number":1354,"context_line":"            vendor \u003d task.node.properties.get(\u0027vendor\u0027, None)"},{"line_number":1355,"context_line":"            if vendor and \u0027intel\u0027 in vendor.lower():"},{"line_number":1356,"context_line":"                set_boot_device_disk()"},{"line_number":1357,"context_line":"                LOG.debug(\u0027Set boot device prior to installing bootloader \u0027"},{"line_number":1358,"context_line":"                          \u0027for node %(node)s and vendor %(vendor)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"28ae6e1e_87d2a201","line":1355,"updated":"2021-08-03 14:27:42.000000000","message":"This may not be needed for all servers of a particular vendor, \nI wonder if we should do this on a flag set on the internal info?","commit_id":"36353639d863b8141c36777662de6f3ea6c2bbf5"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"64e3584bbb2f3d08c7d686b207fc27834af5fd99","unresolved":true,"context_lines":[{"line_number":205,"context_line":"                # hardware."},{"line_number":206,"context_line":"                boot_dev_map[boot_devices.DISK] \u003d \u00270x24\u0027"},{"line_number":207,"context_line":"            elif \u0027intel\u0027 in vendor:"},{"line_number":208,"context_line":"                # On Intel don\u0027t set disk to prevent changing boot order"},{"line_number":209,"context_line":"                boot_dev_map[boot_devices.DISK] \u003d \u00270x00\u0027"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # NOTE(TheJulia): Similar differences may exist with Cisco UCS"}],"source_content_type":"text/x-python","patch_set":8,"id":"79fe4aea_90f57d01","line":208,"updated":"2021-09-16 18:04:21.000000000","message":"I\u0027d add a link to the storyboard entry since instead of what we did with supermicro, we\u0027re explicitly saying \"we\u0027re not going to actually set it.\"","commit_id":"8ded64df07592cceee2800831f49be4df48bf239"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"64e3584bbb2f3d08c7d686b207fc27834af5fd99","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        # NOTE(etingof): this can be racy, esp if BMC is not RESTful"},{"line_number":115,"context_line":"        enabled \u003d (desired_enabled"},{"line_number":116,"context_line":"                   if desired_enabled !\u003d current_enabled else None)"},{"line_number":117,"context_line":"        if vendor and \u0027intel\u0027 in vendor.lower():"},{"line_number":118,"context_line":"            if enabled is None and device \u003d\u003d sushy.BOOT_SOURCE_TARGET_HDD:"},{"line_number":119,"context_line":"                # Don\u0027t set device if already set"},{"line_number":120,"context_line":"                LOG.debug(\u0027Skipping setting boot device disk for node \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"283af930_ab7a3ff0","line":117,"updated":"2021-09-16 18:04:21.000000000","message":"I guess this is UEFI only, so likely that should be a conditioned considered in this?","commit_id":"8ded64df07592cceee2800831f49be4df48bf239"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"64e3584bbb2f3d08c7d686b207fc27834af5fd99","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            if enabled is None and device \u003d\u003d sushy.BOOT_SOURCE_TARGET_HDD:"},{"line_number":119,"context_line":"                # Don\u0027t set device if already set"},{"line_number":120,"context_line":"                LOG.debug(\u0027Skipping setting boot device disk for node \u0027"},{"line_number":121,"context_line":"                          \u0027%(node)s and vendor %(vendor)s as persistence \u0027"},{"line_number":122,"context_line":"                          \u0027already set\u0027, {\u0027node\u0027: task.node.uuid,"},{"line_number":123,"context_line":"                                          \u0027vendor\u0027: vendor})"},{"line_number":124,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":8,"id":"f0356ba6_aa7592ea","line":121,"range":{"start_line":121,"start_character":58,"end_line":121,"end_character":74},"updated":"2021-09-16 18:04:21.000000000","message":"how?\n\nI guess better yet. How do we know we\u0027ve already set bootloader configuration?\n\nI mean, if we know we ran install_bootloader for the agent, cool, setting boot device through the API is possible, and I don\u0027t think we should ignore requests if in UEFI mode and it being intel hardware.  Even *if* it breaks ?due to shim? It just so happens that we *know* we\u0027ve set it properly through that path.","commit_id":"8ded64df07592cceee2800831f49be4df48bf239"}]}