)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f91da6b42592f98279d1d099920af07a5bf9a7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove hardcoded parameters from insert_media call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing hardcoded Inserted and WriteProtected values from sushy"},{"line_number":10,"context_line":"insert_media calls. This is to match sushy change:"},{"line_number":11,"context_line":"https://review.opendev.org/c/openstack/sushy/+/802452"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a3a5943_d4343d60","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"updated":"2021-07-28 14:27:34.000000000","message":"Okay, to match. But why in general?","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022ac5895da83df63162623e1eb3aa7a22261bde","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove hardcoded parameters from insert_media call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing hardcoded Inserted and WriteProtected values from sushy"},{"line_number":10,"context_line":"insert_media calls. This is to match sushy change:"},{"line_number":11,"context_line":"https://review.opendev.org/c/openstack/sushy/+/802452"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"26aec2b2_ca206477","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"1a3a5943_d4343d60","updated":"2021-07-29 01:40:40.000000000","message":"Done","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f91da6b42592f98279d1d099920af07a5bf9a7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"insert_media calls. This is to match sushy change:"},{"line_number":11,"context_line":"https://review.opendev.org/c/openstack/sushy/+/802452"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieab097c63f218c3c262f013c29495f5393dd3cfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"022f5165_e256d042","line":13,"updated":"2021-07-28 14:27:34.000000000","message":"If this should need to be backported downstream, you\u0027ll save yourself headache by tagging this as:\n\nrhbz#1986238\n\nThat being said, this should never be the primary source of context for an upstream reviewer.","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022ac5895da83df63162623e1eb3aa7a22261bde","unresolved":false,"context_lines":[{"line_number":10,"context_line":"insert_media calls. This is to match sushy change:"},{"line_number":11,"context_line":"https://review.opendev.org/c/openstack/sushy/+/802452"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieab097c63f218c3c262f013c29495f5393dd3cfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"52532146_ddf17b91","line":13,"in_reply_to":"022f5165_e256d042","updated":"2021-07-29 01:40:40.000000000","message":"Done","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f91da6b42592f98279d1d099920af07a5bf9a7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://review.opendev.org/c/openstack/sushy/+/802452"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieab097c63f218c3c262f013c29495f5393dd3cfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"78cc8ebd_09f50248","line":14,"updated":"2021-07-28 14:27:34.000000000","message":"Please add story/task references for upstream documentation purposes.","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022ac5895da83df63162623e1eb3aa7a22261bde","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://review.opendev.org/c/openstack/sushy/+/802452"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieab097c63f218c3c262f013c29495f5393dd3cfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af040b8_e75a116e","line":14,"in_reply_to":"78cc8ebd_09f50248","updated":"2021-07-29 01:40:40.000000000","message":"Done","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"}],"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ae747f3bf293376c9c476cb11a01e1f1a018c1f3","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                continue"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                v_media.insert_media(boot_url)"},{"line_number":200,"context_line":"            except sushy.exceptions.ServerSideError as e:"},{"line_number":201,"context_line":"                e.node_uuid \u003d task.node.uuid"},{"line_number":202,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0ab0907_b7cbca14","line":199,"updated":"2021-07-28 06:55:47.000000000","message":"We need to make sure we can receive the parameters I would say, maybe we will have scenarios where we want to set this information?\nI would add the parameters to the function and we probably need to update the places that will call this. Let\u0027s see what people think about it \u003d)","commit_id":"62fad8738d76b977b7ea1d1dc4f10858433ec46c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8c1684a1b9436cda447b9773f24dee87b8305e9","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                continue"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                v_media.insert_media(boot_url)"},{"line_number":200,"context_line":"            except sushy.exceptions.ServerSideError as e:"},{"line_number":201,"context_line":"                e.node_uuid \u003d task.node.uuid"},{"line_number":202,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"e95ed504_86ab8e61","line":199,"in_reply_to":"d0ab0907_b7cbca14","updated":"2021-07-28 08:52:17.000000000","message":"I cannot think of such a scenario (and adding it would probably be a feature).","commit_id":"62fad8738d76b977b7ea1d1dc4f10858433ec46c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"f238679f690264989343288734470f8938c0552c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                continue"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                v_media.insert_media(boot_url)"},{"line_number":200,"context_line":"            except sushy.exceptions.ServerSideError as e:"},{"line_number":201,"context_line":"                e.node_uuid \u003d task.node.uuid"},{"line_number":202,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"924d7d24_6f4e6238","line":199,"in_reply_to":"e95ed504_86ab8e61","updated":"2021-07-28 10:30:21.000000000","message":"Thank you Iury and Dmitry. As discussed on IRC I will leave this as-is in this patch but will take a different approach for the backport candidate.","commit_id":"62fad8738d76b977b7ea1d1dc4f10858433ec46c"}],"releasenotes/notes/remove-hardcoded-insert-media-attrs-6621a811f46cf8d3.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8c1684a1b9436cda447b9773f24dee87b8305e9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed hardcoded attributes from insert_media call to match sushy change:"},{"line_number":5,"context_line":"    https://review.opendev.org/c/openstack/sushy/+/802452"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"31970d06_31bda754","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":57},"updated":"2021-07-28 08:52:17.000000000","message":"I suggest either to rewrite this from an operator\u0027s point of view or remove completely.","commit_id":"62fad8738d76b977b7ea1d1dc4f10858433ec46c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"f238679f690264989343288734470f8938c0552c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed hardcoded attributes from insert_media call to match sushy change:"},{"line_number":5,"context_line":"    https://review.opendev.org/c/openstack/sushy/+/802452"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4a7a3c4b_e7cd685c","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":57},"in_reply_to":"31970d06_31bda754","updated":"2021-07-28 10:30:21.000000000","message":"Done","commit_id":"62fad8738d76b977b7ea1d1dc4f10858433ec46c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f91da6b42592f98279d1d099920af07a5bf9a7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed hardcoded values of \"Inserted\": True and \"WriteProtected\": True in"},{"line_number":5,"context_line":"    the call to VirtualMedia::insert_media(). This is expected to prevent failures"},{"line_number":6,"context_line":"    to configure VirtualMedia on BMCs which treat these attributes as"},{"line_number":7,"context_line":"    read-only and do not allow setting them explicitly"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b623adc5_9b2cc2df","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":75},"updated":"2021-07-28 14:27:34.000000000","message":"These are largely developer known pieces of information. Perhaps suggest what this change is really targetted at doing, enabling supermicro support for virtual media. Lots of bonus points for indicating if this patch has been tested against HPE/Dell hardware. We\u0027ve also had a very recent report of someone working on getting Lenovo virtual media support to work for their scientific labortory, so it might also be good to bring more community awareness to these patches. Extra bonus points for Tagging HPE/Dell reviewers.","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022ac5895da83df63162623e1eb3aa7a22261bde","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed hardcoded values of \"Inserted\": True and \"WriteProtected\": True in"},{"line_number":5,"context_line":"    the call to VirtualMedia::insert_media(). This is expected to prevent failures"},{"line_number":6,"context_line":"    to configure VirtualMedia on BMCs which treat these attributes as"},{"line_number":7,"context_line":"    read-only and do not allow setting them explicitly"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"67c710ec_ad588b4c","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":75},"in_reply_to":"b623adc5_9b2cc2df","updated":"2021-07-29 01:40:40.000000000","message":"Done","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f91da6b42592f98279d1d099920af07a5bf9a7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    the call to VirtualMedia::insert_media(). This is expected to prevent failures"},{"line_number":6,"context_line":"    to configure VirtualMedia on BMCs which treat these attributes as"},{"line_number":7,"context_line":"    read-only and do not allow setting them explicitly"},{"line_number":8,"context_line":"    (e.g. SuperMicro X11/X12)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"840fa8fb_9de73947","line":8,"updated":"2021-07-28 14:27:34.000000000","message":"Please add upgrade section and indicate the version of sushy required for this change.","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f91da6b42592f98279d1d099920af07a5bf9a7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed hardcoded values of \"Inserted\": True and \"WriteProtected\": True in"},{"line_number":5,"context_line":"    the call to VirtualMedia::insert_media(). This is expected to prevent failures"},{"line_number":6,"context_line":"    to configure VirtualMedia on BMCs which treat these attributes as"},{"line_number":7,"context_line":"    read-only and do not allow setting them explicitly"},{"line_number":8,"context_line":"    (e.g. SuperMicro X11/X12)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"848f2712_cec90eab","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":30},"updated":"2021-07-28 14:27:34.000000000","message":"Since I\u0027ve reviewed the sushy change, it would be good to note this allows us to better handle schema changes in 2021.1 coordinated schema release from the DMTF. The *big* question is what about backwards compatibility, and does this break on anything or not.","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022ac5895da83df63162623e1eb3aa7a22261bde","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    the call to VirtualMedia::insert_media(). This is expected to prevent failures"},{"line_number":6,"context_line":"    to configure VirtualMedia on BMCs which treat these attributes as"},{"line_number":7,"context_line":"    read-only and do not allow setting them explicitly"},{"line_number":8,"context_line":"    (e.g. SuperMicro X11/X12)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0e21e0a9_84a4714a","line":8,"in_reply_to":"840fa8fb_9de73947","updated":"2021-07-29 01:40:40.000000000","message":"What\u0027s the best way to determine which version it will be (change is still in flight)?\nStrictly speaking, this will work with older sushy (it accepts insert_media() calls with no inserted/write_protected params) it just won\u0027t work on SuperMicro just yet (as the params will still be added to the payload).","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022ac5895da83df63162623e1eb3aa7a22261bde","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed hardcoded values of \"Inserted\": True and \"WriteProtected\": True in"},{"line_number":5,"context_line":"    the call to VirtualMedia::insert_media(). This is expected to prevent failures"},{"line_number":6,"context_line":"    to configure VirtualMedia on BMCs which treat these attributes as"},{"line_number":7,"context_line":"    read-only and do not allow setting them explicitly"},{"line_number":8,"context_line":"    (e.g. SuperMicro X11/X12)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5012469a_26457980","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":30},"in_reply_to":"848f2712_cec90eab","updated":"2021-07-29 01:40:40.000000000","message":"Done","commit_id":"6df468b23f620737feccc81ba760349e7af5a642"}]}