)]}'
{"ironic/conductor/utils.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"df03ec45ec3f4989252905a3bb11babbf6626ccc","unresolved":true,"context_lines":[{"line_number":1623,"context_line":"        node_history.NodeHistory("},{"line_number":1624,"context_line":"            node_id\u003dnode.id,"},{"line_number":1625,"context_line":"            conductor\u003dCONF.host,"},{"line_number":1626,"context_line":"            user\u003duser,"},{"line_number":1627,"context_line":"            event\u003devent).create()"}],"source_content_type":"text/x-python","patch_set":11,"id":"676d0274_0bdac907","line":1626,"updated":"2021-09-09 02:26:28.000000000","message":"The error boolean is valuable info that is not being recorded. How about we do the following:\n\n  severity\u003derror and \"ERROR\" or \"INFO\"","commit_id":"b4a64c1e9f16fe42076ef59df4603b9671921703"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1c80d820462f784417938957695a9114af15c34f","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        node.provision_state \u003d provision_state"},{"line_number":404,"context_line":"        node.target_provision_state \u003d target_provision_state"},{"line_number":405,"context_line":"        error \u003d (_(\"No free conductor workers available\"))"},{"line_number":406,"context_line":"        node_history_record(node, event\u003derror, event_type\u003d\u0027provisioning\u0027,"},{"line_number":407,"context_line":"                            error\u003dTrue)"},{"line_number":408,"context_line":"        node.save()"},{"line_number":409,"context_line":"        LOG.warning(\"No free conductor workers available to perform \""}],"source_content_type":"text/x-python","patch_set":12,"id":"fd47fc8a_6de4670e","line":406,"range":{"start_line":406,"start_character":58,"end_line":406,"end_character":72},"updated":"2021-09-09 22:05:29.000000000","message":"It might be good to have some kind of enum to establish all the event types and avoid speling errors. And since the node_history_record function is in this file, lets put the enum here too.","commit_id":"77fd88f485d2e7c19b5c0253d616e4eaa875818b"}],"ironic/conf/conductor.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ef81a7916a1fd32651a3850decb95c4f8a92c714","unresolved":true,"context_lines":[{"line_number":296,"context_line":"                       \u0027long as [conductor]node_history_cleanup_batch_count \u0027"},{"line_number":297,"context_line":"                       \u0027is not 0.\u0027)),"},{"line_number":298,"context_line":"    cfg.IntOpt(\u0027node_history_max_entries\u0027,"},{"line_number":299,"context_line":"               default\u003d300,"},{"line_number":300,"context_line":"               min\u003d0,"},{"line_number":301,"context_line":"               mutable\u003dTrue,"},{"line_number":302,"context_line":"               help\u003d_(\u0027Maximum number of history entries which will be stored \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf0dfb93_6e9aba33","line":299,"updated":"2021-08-06 16:47:27.000000000","message":"Would be awesome if there was a Date based option here. I.E. Keep one weeks worth of logs","commit_id":"1ac2b7e980c0170c18080e64ec33bb1694660a20"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f79c3e091ec7c56d841a289c9fab84ed276d19ff","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                      \u0027lower this threshold and decrease the time between \u0027"},{"line_number":325,"context_line":"                      \u0027cleanup operations using the \u0027"},{"line_number":326,"context_line":"                      \u0027``node_history_cleanup_interval`` setting.\u0027)),"},{"line_number":327,"context_line":"    cfg.IntOpt(\u0027node_history_minimum_days\u0027,"},{"line_number":328,"context_line":"               min\u003d0,"},{"line_number":329,"context_line":"               default\u003d0,"},{"line_number":330,"context_line":"               mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2af20476_f8ab5d5b","line":327,"updated":"2021-08-07 18:53:05.000000000","message":"This is awesome... Thank you TheJulia.","commit_id":"4042e5737f551b9cd702e14d4f09a678965ff89a"}],"ironic/tests/unit/conductor/test_utils.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8b6edbfa9f079267658745c7f0dd8e9c720b81a1","unresolved":true,"context_lines":[{"line_number":2619,"context_line":"        mock_history.assert_not_called()"},{"line_number":2620,"context_line":""},{"line_number":2621,"context_line":"    @mock.patch.object(objects, \u0027NodeHistory\u0027, autospec\u003dTrue)"},{"line_number":2622,"context_line":"    def test_record_node_history_disaled(self, mock_history):"},{"line_number":2623,"context_line":"        mock_create \u003d mock.Mock()"},{"line_number":2624,"context_line":"        conductor_utils.node_history_record(self.node, event\u003d\u0027meow\u0027,"},{"line_number":2625,"context_line":"                                            error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1c84c52b_0449b64f","line":2622,"range":{"start_line":2622,"start_character":33,"end_line":2622,"end_character":40},"updated":"2021-09-12 21:40:17.000000000","message":"nit, disabled","commit_id":"d17749249cbe8507c39eb213e5e97aa1fb543a55"}]}