)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Adds API for retrieving node history events"},{"line_number":10,"context_line":"via a node. Includes pagination and limitation"},{"line_number":11,"context_line":"of the response set."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I22a92fa6c30d721f6a5dd0670b2e0a9cf76ad7b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b0be59ae_dc8a9332","line":12,"updated":"2021-09-14 15:28:04.000000000","message":"please link the story+task","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b01e9dcb00e157c51d26ce19380c03dbb190606","unresolved":true,"context_lines":[{"line_number":11,"context_line":"of the response set."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2002980"},{"line_number":14,"context_line":"Tas: 42961"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22a92fa6c30d721f6a5dd0670b2e0a9cf76ad7b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8bdca369_72227e61","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":4},"updated":"2021-09-15 14:36:26.000000000","message":"Nit: \"Task:\"","commit_id":"07f0acea248341e90aa8ea8edfcf409fe47e1eb9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0929c13cc8cad6522b7b3f9f29e4bc9e198e375","unresolved":true,"context_lines":[{"line_number":11,"context_line":"of the response set."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2002980"},{"line_number":14,"context_line":"Tas: 42961"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22a92fa6c30d721f6a5dd0670b2e0a9cf76ad7b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9ed47a8f_c7efcce4","line":14,"updated":"2021-09-17 08:15:22.000000000","message":"typo \u003d)","commit_id":"fb9eae74124007ed1800e11ef9b8a4aac9e1a407"}],"api-ref/source/baremetal-api-v1-nodes-history.inc":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Deleting history entries for a node"},{"line_number":75,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Due to the nature of an imutable history record, records cannot be deleted"},{"line_number":78,"context_line":"via the REST API. Records and ultimately expired history records are managed"},{"line_number":79,"context_line":"by the conductor."}],"source_content_type":"text/x-c++src","patch_set":6,"id":"8f80ba04_d154cd66","line":77,"range":{"start_line":77,"start_character":24,"end_line":77,"end_character":33},"updated":"2021-09-14 15:28:04.000000000","message":"immutable","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Deleting history entries for a node"},{"line_number":75,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Due to the nature of an imutable history record, records cannot be deleted"},{"line_number":78,"context_line":"via the REST API. Records and ultimately expired history records are managed"},{"line_number":79,"context_line":"by the conductor."}],"source_content_type":"text/x-c++src","patch_set":6,"id":"557c457e_05467fe6","line":77,"range":{"start_line":77,"start_character":24,"end_line":77,"end_character":33},"in_reply_to":"8f80ba04_d154cd66","updated":"2021-09-15 21:24:11.000000000","message":"Done","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8a93ede05ac0ddbb2cbbe16eadcb8a1ae97d23b5","unresolved":true,"context_lines":[{"line_number":2111,"context_line":"    \u0027console\u0027, \u0027cleaning\u0027, \u0027monitoring\u0027."},{"line_number":2112,"context_line":"  in: body"},{"line_number":2113,"context_line":"  required: true"},{"line_number":2114,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4f169ef8_0a2b3b25","line":2114,"updated":"2021-09-12 21:54:12.000000000","message":"It looks like the doc builder enforces that these be sorted:\n\nParameters out of order ``volume_targets_link`` should be after ``history_user_ident``","commit_id":"2cbe461c3f40aefb65c1bb6fd6f501e3d98be0fc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"294ee85b7528dc1c8ae952b100da42112890ecd7","unresolved":true,"context_lines":[{"line_number":2111,"context_line":"    \u0027console\u0027, \u0027cleaning\u0027, \u0027monitoring\u0027."},{"line_number":2112,"context_line":"  in: body"},{"line_number":2113,"context_line":"  required: true"},{"line_number":2114,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1c743354_f3a80533","line":2114,"in_reply_to":"4f169ef8_0a2b3b25","updated":"2021-09-13 14:14:28.000000000","message":"Sadness :(","commit_id":"2cbe461c3f40aefb65c1bb6fd6f501e3d98be0fc"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":981,"context_line":"history_severity:"},{"line_number":982,"context_line":"  description: |"},{"line_number":983,"context_line":"    Severity indicator for the event being returned. Typically this will"},{"line_number":984,"context_line":"    indicate if this was an Error or Informaitonal entry."},{"line_number":985,"context_line":"  in: body"},{"line_number":986,"context_line":"  required: true"},{"line_number":987,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"084468ba_a6e1c6bd","line":984,"range":{"start_line":984,"start_character":37,"end_line":984,"end_character":51},"updated":"2021-09-14 15:28:04.000000000","message":"Informational","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":false,"context_lines":[{"line_number":981,"context_line":"history_severity:"},{"line_number":982,"context_line":"  description: |"},{"line_number":983,"context_line":"    Severity indicator for the event being returned. Typically this will"},{"line_number":984,"context_line":"    indicate if this was an Error or Informaitonal entry."},{"line_number":985,"context_line":"  in: body"},{"line_number":986,"context_line":"  required: true"},{"line_number":987,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"61751b7c_5a7b7644","line":984,"range":{"start_line":984,"start_character":37,"end_line":984,"end_character":51},"in_reply_to":"084468ba_a6e1c6bd","updated":"2021-09-15 21:24:11.000000000","message":"Done","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":994,"context_line":"  type: string"},{"line_number":995,"context_line":"history_event_type:"},{"line_number":996,"context_line":"  description: |"},{"line_number":997,"context_line":"    Short descriptive string to indicate where the error occured at to"},{"line_number":998,"context_line":"    enable API users/System Operators to be able to identify repeated"},{"line_number":999,"context_line":"    issues in a particular area of operation, such as \u0027deployment\u0027,"},{"line_number":1000,"context_line":"    \u0027console\u0027, \u0027cleaning\u0027, \u0027monitoring\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6e36cdb7_f3a9348a","line":997,"range":{"start_line":997,"start_character":57,"end_line":997,"end_character":65},"updated":"2021-09-14 15:28:04.000000000","message":"occurred","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":false,"context_lines":[{"line_number":994,"context_line":"  type: string"},{"line_number":995,"context_line":"history_event_type:"},{"line_number":996,"context_line":"  description: |"},{"line_number":997,"context_line":"    Short descriptive string to indicate where the error occured at to"},{"line_number":998,"context_line":"    enable API users/System Operators to be able to identify repeated"},{"line_number":999,"context_line":"    issues in a particular area of operation, such as \u0027deployment\u0027,"},{"line_number":1000,"context_line":"    \u0027console\u0027, \u0027cleaning\u0027, \u0027monitoring\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5d9bb24a_395c942a","line":997,"range":{"start_line":997,"start_character":57,"end_line":997,"end_character":65},"in_reply_to":"6e36cdb7_f3a9348a","updated":"2021-09-15 21:24:11.000000000","message":"Done","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"014a6aeee3d335e251f836593963136976d3e4ed","unresolved":true,"context_lines":[{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"class NodeHistoryController(rest.RestController):"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"    detail_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027updated_at\u0027, \u0027event\u0027,"},{"line_number":1846,"context_line":"                     \u0027conductor\u0027, \u0027user\u0027]"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"    standard_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027event\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"99df439c_769a3f66","line":1845,"range":{"start_line":1845,"start_character":44,"end_line":1845,"end_character":54},"updated":"2021-09-09 02:31:48.000000000","message":"Lets never show updated_at, its an immutable log record","commit_id":"51db3fbf0e1722795794af0231b1cd832826129f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"294ee85b7528dc1c8ae952b100da42112890ecd7","unresolved":true,"context_lines":[{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"class NodeHistoryController(rest.RestController):"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"    detail_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027updated_at\u0027, \u0027event\u0027,"},{"line_number":1846,"context_line":"                     \u0027conductor\u0027, \u0027user\u0027]"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"    standard_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027event\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"827d927d_32d06895","line":1845,"range":{"start_line":1845,"start_character":44,"end_line":1845,"end_character":54},"in_reply_to":"99df439c_769a3f66","updated":"2021-09-13 14:14:28.000000000","message":"I was thinking from a value standpoint, it does return none so they are aware. The primary driver was it is in the object model, but the idea is immutable with the exception of deletion, so we can just remove it.\n\n\\o/ one less object conversion!","commit_id":"51db3fbf0e1722795794af0231b1cd832826129f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"014a6aeee3d335e251f836593963136976d3e4ed","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"    detail_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027updated_at\u0027, \u0027event\u0027,"},{"line_number":1846,"context_line":"                     \u0027conductor\u0027, \u0027user\u0027]"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"    standard_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027event\u0027]"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    def __init__(self, node_ident):"},{"line_number":1851,"context_line":"        super(NodeHistoryController).__init__()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ac066f19_e0d1372c","line":1848,"updated":"2021-09-09 02:31:48.000000000","message":"I\u0027ve left a comment on the previous change that we could be populating the severity\nhttps://review.opendev.org/c/openstack/ironic/+/803292/11/ironic/conductor/utils.py#42\n\nIf this happens, there is a good case for including it in standard_fields","commit_id":"51db3fbf0e1722795794af0231b1cd832826129f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"014a6aeee3d335e251f836593963136976d3e4ed","unresolved":true,"context_lines":[{"line_number":1886,"context_line":"    def get_all(self, **kwargs):"},{"line_number":1887,"context_line":"        \"\"\"List node history.\"\"\""},{"line_number":1888,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("},{"line_number":1889,"context_line":"            \u0027baremetal:node:traits:list\u0027, self.node_ident)"},{"line_number":1890,"context_line":"        events \u003d objects.NodeHistory.list_by_node_id(api.request.context,"},{"line_number":1891,"context_line":"                                                     node.id)"},{"line_number":1892,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"888ffd69_b2644c60","line":1889,"updated":"2021-09-09 02:31:48.000000000","message":"wrong policy name?","commit_id":"51db3fbf0e1722795794af0231b1cd832826129f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"014a6aeee3d335e251f836593963136976d3e4ed","unresolved":true,"context_lines":[{"line_number":1888,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("},{"line_number":1889,"context_line":"            \u0027baremetal:node:traits:list\u0027, self.node_ident)"},{"line_number":1890,"context_line":"        events \u003d objects.NodeHistory.list_by_node_id(api.request.context,"},{"line_number":1891,"context_line":"                                                     node.id)"},{"line_number":1892,"context_line":""},{"line_number":1893,"context_line":"        if kwargs.get(\u0027detail\u0027):"},{"line_number":1894,"context_line":"            detail \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"577a7d6d_f0765bec","line":1891,"updated":"2021-09-09 02:31:48.000000000","message":"Since this is a log, and we\u0027re most interested in the most recent records, which should not scroll away up the console, lets do an explicit sort_key\u003d\"created_at\", sort_dir\u003d\"asc\"","commit_id":"51db3fbf0e1722795794af0231b1cd832826129f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"014a6aeee3d335e251f836593963136976d3e4ed","unresolved":true,"context_lines":[{"line_number":1912,"context_line":"    def get_one(self, event):"},{"line_number":1913,"context_line":"        \"\"\"Get a node history entry\"\"\""},{"line_number":1914,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("},{"line_number":1915,"context_line":"            \u0027baremetal:node:traits:list\u0027, self.node_ident)"},{"line_number":1916,"context_line":"        # TODO(TheJulia): Need to check policy to make sure if policy"},{"line_number":1917,"context_line":"        # check fails, that the entry cannot be found."},{"line_number":1918,"context_line":"        event \u003d objects.NodeHistory.get_by_uuid(api.request.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ccb6242_9fd8e47d","line":1915,"updated":"2021-09-09 02:31:48.000000000","message":"wrong policy name?","commit_id":"51db3fbf0e1722795794af0231b1cd832826129f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8a93ede05ac0ddbb2cbbe16eadcb8a1ae97d23b5","unresolved":true,"context_lines":[{"line_number":1869,"context_line":"            # The spec for this feature calls to truncate the event"},{"line_number":1870,"context_line":"            # field if not detailed, which makes sense environments"},{"line_number":1871,"context_line":"            # with many events."},{"line_number":1872,"context_line":"            event_entry[\u0027event\u0027] \u003d event_entry[\u0027event\u0027][0:254]"},{"line_number":1873,"context_line":"        # These records cannot be changed by the API consumer,"},{"line_number":1874,"context_line":"        # and updated_at gets handed up from the db model"},{"line_number":1875,"context_line":"        # regardless if we want it or not. As such, strip from"}],"source_content_type":"text/x-python","patch_set":5,"id":"ef2f9ac3_0123985c","line":1872,"updated":"2021-09-12 21:54:12.000000000","message":"Could an ascii ellipsis ... be added *if* the text is truncated?","commit_id":"2cbe461c3f40aefb65c1bb6fd6f501e3d98be0fc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"294ee85b7528dc1c8ae952b100da42112890ecd7","unresolved":true,"context_lines":[{"line_number":1869,"context_line":"            # The spec for this feature calls to truncate the event"},{"line_number":1870,"context_line":"            # field if not detailed, which makes sense environments"},{"line_number":1871,"context_line":"            # with many events."},{"line_number":1872,"context_line":"            event_entry[\u0027event\u0027] \u003d event_entry[\u0027event\u0027][0:254]"},{"line_number":1873,"context_line":"        # These records cannot be changed by the API consumer,"},{"line_number":1874,"context_line":"        # and updated_at gets handed up from the db model"},{"line_number":1875,"context_line":"        # regardless if we want it or not. As such, strip from"}],"source_content_type":"text/x-python","patch_set":5,"id":"8af3ca96_7770b6da","line":1872,"in_reply_to":"ef2f9ac3_0123985c","updated":"2021-09-13 14:14:28.000000000","message":"I guess that makes sense.  Truncate it down to 241 chars, add \"...\", and let them request detail to get the full string.","commit_id":"2cbe461c3f40aefb65c1bb6fd6f501e3d98be0fc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f57d85b62176a50c47424ecfcbf91279a63ae81","unresolved":true,"context_lines":[{"line_number":1840,"context_line":"                                      vif_id\u003dvif_id, topic\u003dtopic)"},{"line_number":1841,"context_line":""},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"class NodeHistoryController(rest.RestController):"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"    detail_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027severity\u0027, \u0027event_type\u0027,"},{"line_number":1846,"context_line":"                     \u0027event\u0027, \u0027conductor\u0027, \u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"2a7b0045_60f73558","line":1843,"updated":"2021-09-14 19:01:52.000000000","message":"Note: need to update webapi-history.rst","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"                                      vif_id\u003dvif_id, topic\u003dtopic)"},{"line_number":1841,"context_line":""},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"class NodeHistoryController(rest.RestController):"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"    detail_fields \u003d [\u0027uuid\u0027, \u0027created_at\u0027, \u0027severity\u0027, \u0027event_type\u0027,"},{"line_number":1846,"context_line":"                     \u0027event\u0027, \u0027conductor\u0027, \u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"d10ab667_9edcc633","line":1843,"in_reply_to":"2a7b0045_60f73558","updated":"2021-09-15 21:24:11.000000000","message":"Done","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":1856,"context_line":"        \"\"\"Add link and convert history event\"\"\""},{"line_number":1857,"context_line":"        url \u003d api.request.public_url"},{"line_number":1858,"context_line":"        if not detail:"},{"line_number":1859,"context_line":""},{"line_number":1860,"context_line":"            fields \u003d self.standard_fields"},{"line_number":1861,"context_line":"        else:"},{"line_number":1862,"context_line":"            fields \u003d self.detail_fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"f464ad0e_949993b5","line":1859,"updated":"2021-09-14 15:28:04.000000000","message":"nit: why the newline?","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":true,"context_lines":[{"line_number":1856,"context_line":"        \"\"\"Add link and convert history event\"\"\""},{"line_number":1857,"context_line":"        url \u003d api.request.public_url"},{"line_number":1858,"context_line":"        if not detail:"},{"line_number":1859,"context_line":""},{"line_number":1860,"context_line":"            fields \u003d self.standard_fields"},{"line_number":1861,"context_line":"        else:"},{"line_number":1862,"context_line":"            fields \u003d self.detail_fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f1744a6_06d47b1a","line":1859,"in_reply_to":"f464ad0e_949993b5","updated":"2021-09-15 21:24:11.000000000","message":"No reason, removing.","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"            fields\u003dfields)"},{"line_number":1868,"context_line":"        if not detail:"},{"line_number":1869,"context_line":"            # The spec for this feature calls to truncate the event"},{"line_number":1870,"context_line":"            # field if not detailed, which makes sense environments"},{"line_number":1871,"context_line":"            # with many events."},{"line_number":1872,"context_line":"            entry_len \u003d len(event_entry[\u0027event\u0027])"},{"line_number":1873,"context_line":"            if entry_len \u003e 255:"}],"source_content_type":"text/x-python","patch_set":6,"id":"263c0935_e581bb8b","line":1870,"range":{"start_line":1870,"start_character":49,"end_line":1870,"end_character":67},"updated":"2021-09-14 15:28:04.000000000","message":"smth does not read right  - \"sense _in_ environments\"?","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"            fields\u003dfields)"},{"line_number":1868,"context_line":"        if not detail:"},{"line_number":1869,"context_line":"            # The spec for this feature calls to truncate the event"},{"line_number":1870,"context_line":"            # field if not detailed, which makes sense environments"},{"line_number":1871,"context_line":"            # with many events."},{"line_number":1872,"context_line":"            entry_len \u003d len(event_entry[\u0027event\u0027])"},{"line_number":1873,"context_line":"            if entry_len \u003e 255:"}],"source_content_type":"text/x-python","patch_set":6,"id":"2f806642_ace4768e","line":1870,"range":{"start_line":1870,"start_character":49,"end_line":1870,"end_character":67},"in_reply_to":"263c0935_e581bb8b","updated":"2021-09-15 21:24:11.000000000","message":"Ahh, connecting word and additional context missing. Fixing.","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b01e9dcb00e157c51d26ce19380c03dbb190606","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"        if not detail:"},{"line_number":1868,"context_line":"            # The spec for this feature calls to truncate the event"},{"line_number":1869,"context_line":"            # field if not detailed, which makes sense in some environments"},{"line_number":1870,"context_line":"            # with many events, espescialy if the event text is particullarlly"},{"line_number":1871,"context_line":"            # long."},{"line_number":1872,"context_line":"            entry_len \u003d len(event_entry[\u0027event\u0027])"},{"line_number":1873,"context_line":"            if entry_len \u003e 255:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ec5e21a5_92f8b744","line":1870,"range":{"start_line":1870,"start_character":32,"end_line":1870,"end_character":43},"updated":"2021-09-15 14:36:26.000000000","message":"Nit: especially","commit_id":"07f0acea248341e90aa8ea8edfcf409fe47e1eb9"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b01e9dcb00e157c51d26ce19380c03dbb190606","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"        if not detail:"},{"line_number":1868,"context_line":"            # The spec for this feature calls to truncate the event"},{"line_number":1869,"context_line":"            # field if not detailed, which makes sense in some environments"},{"line_number":1870,"context_line":"            # with many events, espescialy if the event text is particullarlly"},{"line_number":1871,"context_line":"            # long."},{"line_number":1872,"context_line":"            entry_len \u003d len(event_entry[\u0027event\u0027])"},{"line_number":1873,"context_line":"            if entry_len \u003e 255:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fcd60527_ffe161ce","line":1870,"range":{"start_line":1870,"start_character":64,"end_line":1870,"end_character":78},"updated":"2021-09-15 14:36:26.000000000","message":"Nit: particularly","commit_id":"07f0acea248341e90aa8ea8edfcf409fe47e1eb9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e249fe21d2a5cb0f55ff11f63ae64e3f199067ec","unresolved":true,"context_lines":[{"line_number":1928,"context_line":""},{"line_number":1929,"context_line":"    @METRICS.timer(\u0027NodeHistoryController.get_one\u0027)"},{"line_number":1930,"context_line":"    @method.expose()"},{"line_number":1931,"context_line":"    @args.validate(event\u003dargs.uuid_or_name)"},{"line_number":1932,"context_line":"    def get_one(self, event):"},{"line_number":1933,"context_line":"        \"\"\"Get a node history entry\"\"\""},{"line_number":1934,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("}],"source_content_type":"text/x-python","patch_set":10,"id":"197d60c6_55d33e47","line":1931,"updated":"2021-09-20 22:04:37.000000000","message":"nit, strictly this should be args.uuid, but I don\u0027t think its worth a revision just for that.","commit_id":"fb9eae74124007ed1800e11ef9b8a4aac9e1a407"}],"ironic/common/policy.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95ac23cafcd92512b50e997e09d596782b032cca","unresolved":true,"context_lines":[{"line_number":914,"context_line":"        name\u003d\u0027baremetal:node:history:get\u0027,"},{"line_number":915,"context_line":"        check_str\u003dSYSTEM_OR_OWNER_READER,"},{"line_number":916,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":917,"context_line":"        description\u003d\u0027Filter to allow operators to govern the threshold \u0027"},{"line_number":918,"context_line":"                    \u0027where information should be filtered. Non-authorized \u0027"},{"line_number":919,"context_line":"                    \u0027users will be subjected to additional API policy \u0027"},{"line_number":920,"context_line":"                    \u0027checks for API content response bodies.\u0027,"},{"line_number":921,"context_line":"        operations\u003d["},{"line_number":922,"context_line":"            {\u0027path\u0027: \u0027/nodes/{node_ident}/history\u0027, \u0027method\u0027: \u0027GET\u0027},"},{"line_number":923,"context_line":"            {\u0027path\u0027: \u0027/nodes/{node_ident}/history/{event_ident}\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"441e755a_4d8b74ab","line":920,"range":{"start_line":917,"start_character":20,"end_line":920,"end_character":61},"updated":"2021-09-14 15:28:04.000000000","message":"copy-pasted? Not related to node history.","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9f99bb1b0f5e88552279f0e170fab768f77138cb","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        name\u003d\u0027baremetal:node:history:get\u0027,"},{"line_number":915,"context_line":"        check_str\u003dSYSTEM_OR_OWNER_READER,"},{"line_number":916,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":917,"context_line":"        description\u003d\u0027Filter to allow operators to govern the threshold \u0027"},{"line_number":918,"context_line":"                    \u0027where information should be filtered. Non-authorized \u0027"},{"line_number":919,"context_line":"                    \u0027users will be subjected to additional API policy \u0027"},{"line_number":920,"context_line":"                    \u0027checks for API content response bodies.\u0027,"},{"line_number":921,"context_line":"        operations\u003d["},{"line_number":922,"context_line":"            {\u0027path\u0027: \u0027/nodes/{node_ident}/history\u0027, \u0027method\u0027: \u0027GET\u0027},"},{"line_number":923,"context_line":"            {\u0027path\u0027: \u0027/nodes/{node_ident}/history/{event_ident}\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ccac463c_b967f4a5","line":920,"range":{"start_line":917,"start_character":20,"end_line":920,"end_character":61},"in_reply_to":"441e755a_4d8b74ab","updated":"2021-09-15 21:24:11.000000000","message":"Done","commit_id":"c2d2a1d5e9bc653b4b8bfe6dbc7598b465938aaf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"e86649a17156017536a136178e47d5d7b03989ad","unresolved":true,"context_lines":[{"line_number":914,"context_line":"        name\u003d\u0027baremetal:node:history:get\u0027,"},{"line_number":915,"context_line":"        check_str\u003dSYSTEM_OR_OWNER_READER,"},{"line_number":916,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":917,"context_line":"        description\u003d\u0027Filter to allow operators to retreive history records \u0027"},{"line_number":918,"context_line":"                    \u0027for a node.\u0027,"},{"line_number":919,"context_line":"        operations\u003d["},{"line_number":920,"context_line":"            {\u0027path\u0027: \u0027/nodes/{node_ident}/history\u0027, \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"11ae7555_f6f8d7e8","line":917,"range":{"start_line":917,"start_character":50,"end_line":917,"end_character":59},"updated":"2021-09-15 07:26:03.000000000","message":"retrieve","commit_id":"07f0acea248341e90aa8ea8edfcf409fe47e1eb9"}]}