)]}'
{"ironic/drivers/modules/ipminative.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6efdad36d94540c9463bd4115268699f2dd6032c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"opts \u003d ["},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027retry_timeout\u0027,"},{"line_number":34,"context_line":"               default\u003d60,"},{"line_number":35,"context_line":"               help\u003d\u0027Maximum time in seconds to retry IPMI operations.\u0027),"},{"line_number":36,"context_line":"    ]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BoHw%3D","line":34,"updated":"2014-03-25 13:39:25.000000000","message":"+1 for increase default timeout for pyghmi, I got \"IPMI call failed: timeout\" error sometimes.","commit_id":"e4ff4493a3f7eac739aa438682a690708db03235"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6efdad36d94540c9463bd4115268699f2dd6032c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"opts \u003d ["},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027retry_timeout\u0027,"},{"line_number":34,"context_line":"               default\u003d60,"},{"line_number":35,"context_line":"               help\u003d\u0027Maximum time in seconds to retry IPMI operations.\u0027),"},{"line_number":36,"context_line":"    ]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BoHQ%3D","line":35,"updated":"2014-03-25 13:39:25.000000000","message":"From pyghmi doc:\n\n:param wait: If True, do not return until system actually completes\n                     requested state change for 300 seconds.\n                     If a non-zero number, adjust the wait time to the\n                     requested number of seconds\n\nI don\u0027t see any retries in code below.","commit_id":"e4ff4493a3f7eac739aa438682a690708db03235"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"075e79a078c1b0941603174e655d1cd5406901c6","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # Log failures but keep trying"},{"line_number":172,"context_line":"            LOG.warning(_(\"IPMI power on failed for node %s.\")"},{"line_number":173,"context_line":"                    % driver_info[\u0027uuid\u0027])"},{"line_number":174,"context_line":"        return retries[0] * 2"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    timer \u003d loopingcall.DynamicLoopingCall(_wait_for_power_on,"},{"line_number":177,"context_line":"                                                 state, retries)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FsvI%3D","line":174,"updated":"2014-03-14 12:20:58.000000000","message":"CONF.ipmi.retry_timeout config options: Maximum time in seconds to retry IPMI operations. (integer value), default\u003d 10.\nIn your patch with DynamicLoopingCall retries sequence (time sec from start) 0-\u003e2-\u003e6-\u003e12 ... 110 sec.\nIMO 1) we should edit description of option or/and 2) make limit of series smaller.","commit_id":"ff0d46523e5e4b9d8f816dd1c5bb12814490059b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2a75353d7ae260389dcc96ced48c85427e39927d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # Log failures but keep trying"},{"line_number":172,"context_line":"            LOG.warning(_(\"IPMI power on failed for node %s.\")"},{"line_number":173,"context_line":"                    % driver_info[\u0027uuid\u0027])"},{"line_number":174,"context_line":"        return retries[0] * 2"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    timer \u003d loopingcall.DynamicLoopingCall(_wait_for_power_on,"},{"line_number":177,"context_line":"                                                 state, retries)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FnuU%3D","line":174,"in_reply_to":"AAAAWH%2F%2FsJQ%3D","updated":"2014-03-14 23:06:19.000000000","message":"I agree with the intent of this patch, and with Yuriy\u0027s comments.\n\nDynamicLoopingCall is fine. We should update the doc string and default value accordingly.","commit_id":"ff0d46523e5e4b9d8f816dd1c5bb12814490059b"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"ddab7951ae7192986ecdf845dbaff705763dfb83","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # Log failures but keep trying"},{"line_number":172,"context_line":"            LOG.warning(_(\"IPMI power on failed for node %s.\")"},{"line_number":173,"context_line":"                    % driver_info[\u0027uuid\u0027])"},{"line_number":174,"context_line":"        return retries[0] * 2"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    timer \u003d loopingcall.DynamicLoopingCall(_wait_for_power_on,"},{"line_number":177,"context_line":"                                                 state, retries)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FsJQ%3D","line":174,"in_reply_to":"AAAAWH%2F%2FsvI%3D","updated":"2014-03-14 13:36:49.000000000","message":"Good point. I think we can accommodate that feature while still making use of DynamicLoopingCall. Although I would like to suggest we make the default much larger than 10 seconds.\n\n10 retries in 10 seconds is way to fast and is essentially the cause of the problems I\u0027m seeing.","commit_id":"ff0d46523e5e4b9d8f816dd1c5bb12814490059b"}]}