)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"896eb9519b033dbe0114dcd819380e31a7252410","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-11 11:17:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac and"},{"line_number":10,"context_line":"management.clear_job_queue as verify steps on iDRAC hardware type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"76b96af1_3450e56b","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":36},"updated":"2021-08-11 11:45:55.000000000","message":"leaving out `known_good_state` in commit message and release notes can be confusing. Although it calls reset_idrac and clear_job_queue in one step, it could be explicitly listed everywhere reset_idrac and clear_job_queue is mentioned as it is separate, independent step.","commit_id":"c322186efa500d7bf26b652ffd88db5abbec191e"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"9628db210fd1f7a8fdb758782cfd8d9aff0dafe7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-11 11:17:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac and"},{"line_number":10,"context_line":"management.clear_job_queue as verify steps on iDRAC hardware type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"6392afae_065e55f9","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":36},"in_reply_to":"76b96af1_3450e56b","updated":"2021-08-23 01:54:27.000000000","message":"Good point. Thank you Aija. Done.","commit_id":"c322186efa500d7bf26b652ffd88db5abbec191e"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"03ea07a3b1424c0da136550ab7f26ade21746b40","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-23 04:26:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac,"},{"line_number":10,"context_line":"management.clear_job_queue and management.known_good_state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"764c53bb_c6949a95","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"updated":"2021-08-23 08:41:12.000000000","message":"as all 3 steps do not fit in the title, can use \u0027iDRAC management steps\u0027 - this has been used before[0] to describe all 3 steps.\n\n\n[0] https://review.opendev.org/c/openstack/ironic/+/721593","commit_id":"8daa6ceda90b1573a17ff38226f3fc92c2265888"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5ad5a95d0f3fa7625a82f48fc2dbfedc7a852c93","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-23 04:26:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac,"},{"line_number":10,"context_line":"management.clear_job_queue and management.known_good_state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"d44cf691_a3dbf955","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"in_reply_to":"4d5c0916_7bb34766","updated":"2021-08-27 07:21:07.000000000","message":"don\u0027t see the change, only rebases","commit_id":"8daa6ceda90b1573a17ff38226f3fc92c2265888"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7777430ae0dc15de59d9ce10a1c4dde3931f7a08","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-23 04:26:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac,"},{"line_number":10,"context_line":"management.clear_job_queue and management.known_good_state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"57ee2ca2_7e737392","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"in_reply_to":"4ee411bb_935e9ec9","updated":"2021-08-30 08:14:34.000000000","message":"now I see, thanks","commit_id":"8daa6ceda90b1573a17ff38226f3fc92c2265888"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e60d683b049d89e43b979f4809cf5584336b8f50","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-23 04:26:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac,"},{"line_number":10,"context_line":"management.clear_job_queue and management.known_good_state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4d5c0916_7bb34766","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"in_reply_to":"764c53bb_c6949a95","updated":"2021-08-27 06:06:03.000000000","message":"Done","commit_id":"8daa6ceda90b1573a17ff38226f3fc92c2265888"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"ac552b2130efe1884f8a5a13b643f87a238c73ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjanders@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-23 04:26:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make reset_idrac and clear_job_queue verify steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables running management.reset_idrac,"},{"line_number":10,"context_line":"management.clear_job_queue and management.known_good_state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4ee411bb_935e9ec9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"in_reply_to":"d44cf691_a3dbf955","updated":"2021-08-27 08:38:29.000000000","message":"I changed it from the GUI (focused on the rebase and forgot about the commit message change). Can you see the updated one in the latest change?","commit_id":"8daa6ceda90b1573a17ff38226f3fc92c2265888"}],"releasenotes/notes/add-idrac-verify-steps-50c1a0f0fe299922.yaml":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"896eb9519b033dbe0114dcd819380e31a7252410","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding support for running ``management.clear_job_queue`` and"},{"line_number":5,"context_line":"    ``management.reset_idrac`` methods as verify steps on iDRAC hardware type."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    In order to use this feature, ``[conductor]verify_step_priority_override``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"db6afc6f_647f861b","line":5,"range":{"start_line":5,"start_character":58,"end_line":5,"end_character":77},"updated":"2021-08-11 11:45:55.000000000","message":"could explicitly say that it is both for idrac-wsman and idrac-redfish interfaces","commit_id":"c322186efa500d7bf26b652ffd88db5abbec191e"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"9628db210fd1f7a8fdb758782cfd8d9aff0dafe7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding support for running ``management.clear_job_queue`` and"},{"line_number":5,"context_line":"    ``management.reset_idrac`` methods as verify steps on iDRAC hardware type."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    In order to use this feature, ``[conductor]verify_step_priority_override``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e04b67a5_04909ffa","line":5,"range":{"start_line":5,"start_character":58,"end_line":5,"end_character":77},"in_reply_to":"db6afc6f_647f861b","updated":"2021-08-23 01:54:27.000000000","message":"Done","commit_id":"c322186efa500d7bf26b652ffd88db5abbec191e"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"896eb9519b033dbe0114dcd819380e31a7252410","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    ``management.reset_idrac`` methods as verify steps on iDRAC hardware type."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    In order to use this feature, ``[conductor]verify_step_priority_override``"},{"line_number":9,"context_line":"    needs to be used to set non-zero step priorties for the desired verify"},{"line_number":10,"context_line":"    steps."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"62fd83ec_a7bac46a","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":32},"updated":"2021-08-11 11:45:55.000000000","message":"\"this feature\" will be rendered out of context, these paragraphs will not be one after another. So each section needs to be self-contained. E.g., take a look how current release notes are rendered [1].\nThis should be replaced to smth like \" [..] to use iDRAC hardware type verify steps [..]\"\n\nOr maybe move this to features section, no need for separate upgrade as this is new feature.\n\n[1] https://docs.openstack.org/releasenotes/ironic/unreleased.html","commit_id":"c322186efa500d7bf26b652ffd88db5abbec191e"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"9628db210fd1f7a8fdb758782cfd8d9aff0dafe7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``management.reset_idrac`` methods as verify steps on iDRAC hardware type."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    In order to use this feature, ``[conductor]verify_step_priority_override``"},{"line_number":9,"context_line":"    needs to be used to set non-zero step priorties for the desired verify"},{"line_number":10,"context_line":"    steps."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"128ae3ab_9c15fecb","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":32},"in_reply_to":"62fd83ec_a7bac46a","updated":"2021-08-23 01:54:27.000000000","message":"Very good point Aija. I consolidated features and upgrade sections into one as per your suggestion. Thank you.","commit_id":"c322186efa500d7bf26b652ffd88db5abbec191e"}]}