)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2986ce9ff0f609b56e831e2273d448e2d8f4b887","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add RAID mode conversion for idrac-redfish"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating configuration convert eligible non-RAID drives"},{"line_number":10,"context_line":"to RAID mode and recalculates volume sizes when necessary"},{"line_number":11,"context_line":"after conversion changes available disk size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/x/sushy-oem-idrac/+/805655"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4a524020_d70ff556","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":29},"updated":"2021-08-26 13:05:10.000000000","message":"nit: recalculate","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b43c100ad55f2230547290231b81a3417a7c421","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add RAID mode conversion for idrac-redfish"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating configuration convert eligible non-RAID drives"},{"line_number":10,"context_line":"to RAID mode and recalculates volume sizes when necessary"},{"line_number":11,"context_line":"after conversion changes available disk size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/x/sushy-oem-idrac/+/805655"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"36c45a54_05fdca5c","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":29},"in_reply_to":"4a524020_d70ff556","updated":"2021-08-30 09:38:14.000000000","message":"Done","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"}],"driver-requirements.txt":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2986ce9ff0f609b56e831e2273d448e2d8f4b887","unresolved":true,"context_lines":[{"line_number":20,"context_line":"python-ibmcclient\u003e\u003d0.2.2,\u003c0.3.0"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Dell EMC iDRAC sushy OEM extension"},{"line_number":23,"context_line":"sushy-oem-idrac\u003e\u003d2.1.0,\u003c3.0.0 # TODO(ajya) update when new version released"}],"source_content_type":"text/plain","patch_set":4,"id":"817dd633_da68d975","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":75},"updated":"2021-08-26 13:05:10.000000000","message":"Thank you so much for making it clear this change requires a new version of sushy-oem-idrac :)","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b43c100ad55f2230547290231b81a3417a7c421","unresolved":false,"context_lines":[{"line_number":20,"context_line":"python-ibmcclient\u003e\u003d0.2.2,\u003c0.3.0"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Dell EMC iDRAC sushy OEM extension"},{"line_number":23,"context_line":"sushy-oem-idrac\u003e\u003d2.1.0,\u003c3.0.0 # TODO(ajya) update when new version released"}],"source_content_type":"text/plain","patch_set":4,"id":"2edfab5a_080ad0a1","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":75},"in_reply_to":"817dd633_da68d975","updated":"2021-08-30 09:38:14.000000000","message":"Ack","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2986ce9ff0f609b56e831e2273d448e2d8f4b887","unresolved":true,"context_lines":[{"line_number":1227,"context_line":"        if storage.identity \u003d\u003d identity:"},{"line_number":1228,"context_line":"            controller \u003d (storage.storage_controllers[0]"},{"line_number":1229,"context_line":"                          if storage.storage_controllers else None)"},{"line_number":1230,"context_line":"            if controller:"},{"line_number":1231,"context_line":"                return storage, controller"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"def _change_physical_disk_state(system, mode, controller_to_disks\u003dNone):"},{"line_number":1235,"context_line":"    \"\"\"Changes physical disk state and waits for it to complete"}],"source_content_type":"text/x-python","patch_set":4,"id":"6305772c_70d87023","line":1232,"range":{"start_line":1230,"start_character":0,"end_line":1232,"end_character":0},"updated":"2021-08-26 13:05:10.000000000","message":"If this function cannot find the controller, it should report an error. Since it returns a tuple, returning only None when it falls off the end seems insufficient. Please consider raising an exception here.","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b43c100ad55f2230547290231b81a3417a7c421","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"        if storage.identity \u003d\u003d identity:"},{"line_number":1228,"context_line":"            controller \u003d (storage.storage_controllers[0]"},{"line_number":1229,"context_line":"                          if storage.storage_controllers else None)"},{"line_number":1230,"context_line":"            if controller:"},{"line_number":1231,"context_line":"                return storage, controller"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"def _change_physical_disk_state(system, mode, controller_to_disks\u003dNone):"},{"line_number":1235,"context_line":"    \"\"\"Changes physical disk state and waits for it to complete"}],"source_content_type":"text/x-python","patch_set":4,"id":"83a740d4_8d7771f1","line":1232,"range":{"start_line":1230,"start_character":0,"end_line":1232,"end_character":0},"in_reply_to":"6305772c_70d87023","updated":"2021-08-30 09:38:14.000000000","message":"Done","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2986ce9ff0f609b56e831e2273d448e2d8f4b887","unresolved":true,"context_lines":[{"line_number":1247,"context_line":"        mode, controller_to_disks)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    for task_mon in task_mons:"},{"line_number":1250,"context_line":"        # All jobs should be real time as RAID controllers"},{"line_number":1251,"context_line":"        # support real-time except BOSS, but BOSS is excluded as"},{"line_number":1252,"context_line":"        # not supporting RAID mode conversion."},{"line_number":1253,"context_line":"        if task_mon.check_is_processing:"},{"line_number":1254,"context_line":"            task_mon.wait(CONF.drac.raid_job_timeout)"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"24143f62_7d56e462","line":1252,"range":{"start_line":1250,"start_character":29,"end_line":1252,"end_character":46},"updated":"2021-08-26 13:05:10.000000000","message":"Please consider changing this to the following:\n\nreal-time, because all RAID controllers that offer physical disk mode conversion support real-time task execution. Note that BOSS does not offer disk mode conversion nor support real-time task execution.","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b43c100ad55f2230547290231b81a3417a7c421","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"        mode, controller_to_disks)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    for task_mon in task_mons:"},{"line_number":1250,"context_line":"        # All jobs should be real time as RAID controllers"},{"line_number":1251,"context_line":"        # support real-time except BOSS, but BOSS is excluded as"},{"line_number":1252,"context_line":"        # not supporting RAID mode conversion."},{"line_number":1253,"context_line":"        if task_mon.check_is_processing:"},{"line_number":1254,"context_line":"            task_mon.wait(CONF.drac.raid_job_timeout)"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2555eff6_db169941","line":1252,"range":{"start_line":1250,"start_character":29,"end_line":1252,"end_character":46},"in_reply_to":"24143f62_7d56e462","updated":"2021-08-30 09:38:14.000000000","message":"Done","commit_id":"1bc43455a8e164eac75226c5427b4719e61c3247"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"7d4c44f460bffb0c30b0f5aaf044fec4ecbd2f98","unresolved":true,"context_lines":[{"line_number":1300,"context_line":""},{"line_number":1301,"context_line":"    return logical_disks_to_create"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"class DracRedfishRAID(redfish_raid.RedfishRAID):"},{"line_number":1305,"context_line":"    \"\"\"iDRAC Redfish interface for RAID related actions."},{"line_number":1306,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0a95240c_dedc29c9","line":1303,"updated":"2021-08-31 13:06:14.000000000","message":"These functions are similar to those for WS-Man. To make it clear they are for only Redfish, please consider making them @staticmethod s in class DracRedfishRAID.","commit_id":"2fd60c48dbad5d21c27369f9839d44f0fabe428e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4d05ec7581c9cbd6d445914603f75ca3ea1572ce","unresolved":true,"context_lines":[{"line_number":1349,"context_line":"        :controller_to_disks: dictionary of controllers and their"},{"line_number":1350,"context_line":"            drives. Optional. If not provided, then converting all"},{"line_number":1351,"context_line":"            eligible drives on system."},{"line_number":1352,"context_line":"        :returns: True if any drive got converted, otherwise False"},{"line_number":1353,"context_line":"        \"\"\""},{"line_number":1354,"context_line":"        oem_sys \u003d system.get_oem_extension(\u0027Dell\u0027)"},{"line_number":1355,"context_line":"        task_mons \u003d oem_sys.change_physical_disk_state("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa2d8897_abc98b01","line":1352,"updated":"2021-09-02 15:45:22.000000000","message":"Please add a comment about the exception that is raised when conversion completion times out.","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40e30e3ae50d0bc1011a12a0c8fa6288978e0e3e","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"        :controller_to_disks: dictionary of controllers and their"},{"line_number":1350,"context_line":"            drives. Optional. If not provided, then converting all"},{"line_number":1351,"context_line":"            eligible drives on system."},{"line_number":1352,"context_line":"        :returns: True if any drive got converted, otherwise False"},{"line_number":1353,"context_line":"        \"\"\""},{"line_number":1354,"context_line":"        oem_sys \u003d system.get_oem_extension(\u0027Dell\u0027)"},{"line_number":1355,"context_line":"        task_mons \u003d oem_sys.change_physical_disk_state("}],"source_content_type":"text/x-python","patch_set":7,"id":"93663bc3_efd6116b","line":1352,"in_reply_to":"fa2d8897_abc98b01","updated":"2021-09-06 07:01:00.000000000","message":"thinking about it, I\u0027m not adding it as it is not raised inside this method but within a method used here. If I start adding exceptions raised by other methods, then I should go through all methods and see what they are raising. Rather I document only exceptions that this method introduces.","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8a734d0f7802a8aeb1c05c8aceeced31013869c9","unresolved":true,"context_lines":[{"line_number":1359,"context_line":"                mode, controller_to_disks)"},{"line_number":1360,"context_line":"        except AttributeError as ae:"},{"line_number":1361,"context_line":"            # For backported version where libraries could be too old"},{"line_number":1362,"context_line":"            LOG.warning(\u0027Failed to find method to convert drives to RAID\u0027"},{"line_number":1363,"context_line":"                        \u0027mode. Possibly because `sushy-oem-idrac` is too old.\u0027"},{"line_number":1364,"context_line":"                        \u0027Without newer `sushy-oem-idrac` RAID configuration \u0027"},{"line_number":1365,"context_line":"                        \u0027will fail if selected physical disks are in non-RAID \u0027"},{"line_number":1366,"context_line":"                        \u0027mode. To avoid that update `sushy-oem-idrac`. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"58746fef_0b0713c3","line":1363,"range":{"start_line":1362,"start_character":24,"end_line":1363,"end_character":78},"updated":"2021-09-07 12:21:58.000000000","message":"Need a blank space at the end of these two (2) strings.","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bebe2c880c13d6575f0bf88bc30e7c7ebd5b5730","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"                mode, controller_to_disks)"},{"line_number":1360,"context_line":"        except AttributeError as ae:"},{"line_number":1361,"context_line":"            # For backported version where libraries could be too old"},{"line_number":1362,"context_line":"            LOG.warning(\u0027Failed to find method to convert drives to RAID\u0027"},{"line_number":1363,"context_line":"                        \u0027mode. Possibly because `sushy-oem-idrac` is too old.\u0027"},{"line_number":1364,"context_line":"                        \u0027Without newer `sushy-oem-idrac` RAID configuration \u0027"},{"line_number":1365,"context_line":"                        \u0027will fail if selected physical disks are in non-RAID \u0027"},{"line_number":1366,"context_line":"                        \u0027mode. To avoid that update `sushy-oem-idrac`. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1e29e2ad_58c2d741","line":1363,"range":{"start_line":1362,"start_character":24,"end_line":1363,"end_character":78},"in_reply_to":"58746fef_0b0713c3","updated":"2021-09-07 15:31:42.000000000","message":"Done","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"}],"ironic/drivers/modules/redfish/raid.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4d05ec7581c9cbd6d445914603f75ca3ea1572ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 DMTF. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"31d04b75_b9335185","line":2,"updated":"2021-09-02 15:45:22.000000000","message":"nit: Please add a copyright notice.","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40e30e3ae50d0bc1011a12a0c8fa6288978e0e3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 DMTF. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"a6547e93_cfcc2b2a","line":2,"in_reply_to":"31d04b75_b9335185","updated":"2021-09-06 07:01:00.000000000","message":"Done","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"}],"ironic/tests/unit/drivers/modules/drac/test_raid.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4d05ec7581c9cbd6d445914603f75ca3ea1572ce","unresolved":true,"context_lines":[{"line_number":2398,"context_line":""},{"line_number":2399,"context_line":"        logical_disks_to_create \u003d [{"},{"line_number":2400,"context_line":"            \u0027raid_level\u0027: \u00270\u0027,"},{"line_number":2401,"context_line":"            \u0027size_bytes\u0027: 107374182400,"},{"line_number":2402,"context_line":"            \u0027physical_disks\u0027: ["},{"line_number":2403,"context_line":"                \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":2404,"context_line":"            \u0027span_depth\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"18bb52be_3daa84b5","line":2401,"range":{"start_line":2401,"start_character":26,"end_line":2401,"end_character":38},"updated":"2021-09-02 15:45:22.000000000","message":"Is this value correct or should it be 400 bytes less, 107374182000?","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40e30e3ae50d0bc1011a12a0c8fa6288978e0e3e","unresolved":false,"context_lines":[{"line_number":2398,"context_line":""},{"line_number":2399,"context_line":"        logical_disks_to_create \u003d [{"},{"line_number":2400,"context_line":"            \u0027raid_level\u0027: \u00270\u0027,"},{"line_number":2401,"context_line":"            \u0027size_bytes\u0027: 107374182400,"},{"line_number":2402,"context_line":"            \u0027physical_disks\u0027: ["},{"line_number":2403,"context_line":"                \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":2404,"context_line":"            \u0027span_depth\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"6da9e743_30417008","line":2401,"range":{"start_line":2401,"start_character":26,"end_line":2401,"end_character":38},"in_reply_to":"18bb52be_3daa84b5","updated":"2021-09-06 07:01:00.000000000","message":"updated and took values from integration test","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4d05ec7581c9cbd6d445914603f75ca3ea1572ce","unresolved":true,"context_lines":[{"line_number":2413,"context_line":"              \u0027physical_disks\u0027: ["},{"line_number":2414,"context_line":"                  \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":2415,"context_line":"              \u0027raid_level\u0027: \u00270\u0027,"},{"line_number":2416,"context_line":"              \u0027size_bytes\u0027: 107307073536,"},{"line_number":2417,"context_line":"              \u0027span_depth\u0027: 1,"},{"line_number":2418,"context_line":"              \u0027span_length\u0027: 1.0}], result)"},{"line_number":2419,"context_line":"        fake_oem_system.change_physical_disk_state.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"d29191ec_f3ad3f76","line":2416,"range":{"start_line":2416,"start_character":28,"end_line":2416,"end_character":40},"updated":"2021-09-02 15:45:22.000000000","message":"Please double check this value.","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40e30e3ae50d0bc1011a12a0c8fa6288978e0e3e","unresolved":false,"context_lines":[{"line_number":2413,"context_line":"              \u0027physical_disks\u0027: ["},{"line_number":2414,"context_line":"                  \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":2415,"context_line":"              \u0027raid_level\u0027: \u00270\u0027,"},{"line_number":2416,"context_line":"              \u0027size_bytes\u0027: 107307073536,"},{"line_number":2417,"context_line":"              \u0027span_depth\u0027: 1,"},{"line_number":2418,"context_line":"              \u0027span_length\u0027: 1.0}], result)"},{"line_number":2419,"context_line":"        fake_oem_system.change_physical_disk_state.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"a40eba95_a0759c47","line":2416,"range":{"start_line":2416,"start_character":28,"end_line":2416,"end_character":40},"in_reply_to":"d29191ec_f3ad3f76","updated":"2021-09-06 07:01:00.000000000","message":"updated and took values from integration test","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"}],"ironic/tests/unit/drivers/third_party_driver_mock_specs.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4d05ec7581c9cbd6d445914603f75ca3ea1572ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"8268f283_c16b1e07","line":3,"updated":"2021-09-02 15:45:22.000000000","message":"nit: Please add a copyright notice.","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40e30e3ae50d0bc1011a12a0c8fa6288978e0e3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"5e595f67_e550b257","line":3,"in_reply_to":"8268f283_c16b1e07","updated":"2021-09-06 07:01:00.000000000","message":"Done","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8a734d0f7802a8aeb1c05c8aceeced31013869c9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel Corporation"},{"line_number":2,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"f8412766_f70c2618","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":51},"updated":"2021-09-07 12:21:58.000000000","message":"I believe the next line, \"All Rights Reserved.\", belongs with Intel\u0027s copyright notice.","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bebe2c880c13d6575f0bf88bc30e7c7ebd5b5730","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel Corporation"},{"line_number":2,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"114e6ced_f359a273","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":51},"in_reply_to":"f8412766_f70c2618","updated":"2021-09-07 15:31:42.000000000","message":"Done","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"}],"ironic/tests/unit/drivers/third_party_driver_mocks.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4d05ec7581c9cbd6d445914603f75ca3ea1572ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"4a5eb0eb_69c596cd","line":3,"updated":"2021-09-02 15:45:22.000000000","message":"nit: Please add a copyright notice.","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40e30e3ae50d0bc1011a12a0c8fa6288978e0e3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"29d977fa_1e9035c6","line":3,"in_reply_to":"4a5eb0eb_69c596cd","updated":"2021-09-06 07:01:00.000000000","message":"Done","commit_id":"f83afd5f81809a5bd95efd4d054cd5a0df431d1f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8a734d0f7802a8aeb1c05c8aceeced31013869c9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"a0d36f99_eb3e4864","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":51},"updated":"2021-09-07 12:21:58.000000000","message":"Ditto","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bebe2c880c13d6575f0bf88bc30e7c7ebd5b5730","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"35226452_ff63484e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":51},"in_reply_to":"a0d36f99_eb3e4864","updated":"2021-09-07 15:31:42.000000000","message":"Done","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"}],"releasenotes/notes/idrac-redfish-raid-convert-from-nonraid-e9b5bbac89c71537.yaml":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8a734d0f7802a8aeb1c05c8aceeced31013869c9","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``idrac-redfish`` RAID interface in ``create_configuration`` clean"},{"line_number":5,"context_line":"    step and ``apply_configuration`` deploy step when there are drives in"},{"line_number":6,"context_line":"    non-RAID mode on the system. With this fix non-RAID drives are converted to"},{"line_number":7,"context_line":"    RAID mode before creating virtual disks."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"10ad8106_a8fc03bc","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":46},"updated":"2021-09-07 12:21:58.000000000","message":"Please add a comma here.\n\n    With this fix, non-RAID ...","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8a734d0f7802a8aeb1c05c8aceeced31013869c9","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``idrac-redfish`` RAID interface in ``create_configuration`` clean"},{"line_number":5,"context_line":"    step and ``apply_configuration`` deploy step when there are drives in"},{"line_number":6,"context_line":"    non-RAID mode on the system. With this fix non-RAID drives are converted to"},{"line_number":7,"context_line":"    RAID mode before creating virtual disks."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8e3c8b9e_3910d514","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":31},"updated":"2021-09-07 12:21:58.000000000","message":"These words could be left out.","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bebe2c880c13d6575f0bf88bc30e7c7ebd5b5730","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``idrac-redfish`` RAID interface in ``create_configuration`` clean"},{"line_number":5,"context_line":"    step and ``apply_configuration`` deploy step when there are drives in"},{"line_number":6,"context_line":"    non-RAID mode on the system. With this fix non-RAID drives are converted to"},{"line_number":7,"context_line":"    RAID mode before creating virtual disks."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3d978d72_5306e622","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":46},"in_reply_to":"10ad8106_a8fc03bc","updated":"2021-09-07 15:31:42.000000000","message":"Done","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bebe2c880c13d6575f0bf88bc30e7c7ebd5b5730","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``idrac-redfish`` RAID interface in ``create_configuration`` clean"},{"line_number":5,"context_line":"    step and ``apply_configuration`` deploy step when there are drives in"},{"line_number":6,"context_line":"    non-RAID mode on the system. With this fix non-RAID drives are converted to"},{"line_number":7,"context_line":"    RAID mode before creating virtual disks."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d7c38b2f_9b445441","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":31},"in_reply_to":"8e3c8b9e_3910d514","updated":"2021-09-07 15:31:42.000000000","message":"Done","commit_id":"08f2f6246ba55ce433a59c12e973ae6785b24d0d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ac05e5db221d4f8326213b85f4cae36612d8af7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d821e8e5_ebaaaf28","line":8,"updated":"2021-09-08 14:06:26.000000000","message":"As an aside, I think this does make sense as a bug because without this, it *sounds* like raid set creations would fail if a user specified a non-raid disk.","commit_id":"f0b3695b3070d492f829b7ec5b84df1c8ace549c"}]}