)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3ab75ad79fe0cc4483bb5eeef597e94395e29608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03e05d4c_f1c25f66","updated":"2022-02-21 06:39:05.000000000","message":"recheck","commit_id":"06dce4a5a0aad6ecf92a91930d7349115f784145"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"efc4e2a1db0a9bc50eab3f7a6a4010281b033ecd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"caa0fb76_519fd608","updated":"2022-02-28 19:18:35.000000000","message":"I believe this needs to be split into distinct steps, which seems to align with RFE comments.","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"10b4b598bf5533382dbf74321acaf92e3c019553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"844c5840_eeb66c91","in_reply_to":"caa0fb76_519fd608","updated":"2022-03-01 11:46:54.000000000","message":"Yes true. It will be splitted into three distinct clean steps.","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"549dd351_76907994","updated":"2022-03-11 06:20:17.000000000","message":"Thank you Nisha.","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"920345ddb2ae3d927bd8b147c0e08801d9ff63d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"28a29cea_7582a96c","updated":"2022-03-04 11:04:12.000000000","message":"recheck","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"844b0946754a0f8ec92ccfd065802423dbf421d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"868a0019_6adee506","updated":"2022-03-06 16:54:37.000000000","message":"recheck","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"67f873fe7f3fe5dd286cd660b1689d24cd0667e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2ab7be4f_dd9039f2","updated":"2022-03-20 21:11:40.000000000","message":"Both create_csr and add_https_certificate are flagged as deprecated [1]. This happened about 2 weeks after the first revision of this change, but also authored by ankit[2].\n\nShould this change be reworked to use an undeprecated method such as add_ssl_certificate? I feel at least there should be a clear explanation of why new calls to deprecated methods are being added, and what the plan is for when they are removed, and what impact this has on the \"interface\" of ilo clean steps.\n\n[1] https://opendev.org/x/proliantutils/src/branch/master/proliantutils/ilo/client.py#L1037-L1055\n[2] https://opendev.org/x/proliantutils/commit/084b0acb8bf7d21fe3d6b82a09115b58f8bffe95","commit_id":"ce6d2e7f9f4d07f45a3881826bdee576a1e3d46a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f17819637626d0ab5ae5e2959dc855eb073dc408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"293425c7_deacdd58","in_reply_to":"2ab7be4f_dd9039f2","updated":"2022-03-21 06:49:02.000000000","message":"Yes initially it was planned to have a single step \"add_ssl_certificate\" and hence we added the comment that the steps \"create_csr\" and \"add_https_certificate\" are deprecated, Since it was discussed during RFE approval that it should be two step process(i.e. use create_csr and add_https_certificate) instead of single step process(i.e not to use add_ss_certificate). We can do a quick release of proliantutils(for Y release) by removing the deprecated comments.\nThere is no plan to remove the steps.","commit_id":"ce6d2e7f9f4d07f45a3881826bdee576a1e3d46a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b8beb4e136ad563b29732b8cef5993f1ed3382a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fd00a4f4_c3caf2fd","updated":"2022-03-28 09:46:54.000000000","message":"Thank you Nisha.","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"22c169893155bea2a5a8073ee21601c50659c3fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"05ee2fa3_8830d8c9","updated":"2022-03-22 09:17:00.000000000","message":"recheck","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dff219013de646c219c2ace4f5d9c4502871042a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cd7f77fd_4ee5ac49","updated":"2022-07-18 15:33:30.000000000","message":"Hi Nisha and Ankit,\n\nDo you have any plans on work on this no updates since end of March, this is something you are planing for Zed release? Thanks!\n","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"06a049cda37cd70ca2174f44210ec1c43de08326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"32bf178b_40d6b0e6","updated":"2022-07-19 17:59:57.000000000","message":"In agreement with Steve on his comments as well.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6cb9d2417719f544de8828a26dc93b0fb11326e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"76b4d37e_59d22f96","in_reply_to":"cd7f77fd_4ee5ac49","updated":"2022-08-02 11:59:39.000000000","message":"Hi Iury,\n\nYes since we had some in-house priority work and had to move our focus to it. We still want to get this in Zed release. It would be great if you could reconsider it for Zed release. I will check the comments and update the patch/comments acordingly.\n\nRegards\nNisha","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05d94f21f8286ad80ec90cd0d8cda20f802401e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"87915b25_cf1688ab","updated":"2022-09-13 10:11:52.000000000","message":"Thank you Nisha","commit_id":"9c19dd6ef3bac14859c8a297e5d84e2968feacf8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7f59d866eb5e25f4a053adfe3b3179fbe3f15369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6d4fc3e4_6c17ce48","updated":"2022-09-09 14:39:31.000000000","message":"This looks OK, and the iLo third party CI that usually passes is passing. I have not tested it as I have no access to iLo hardware.","commit_id":"9c19dd6ef3bac14859c8a297e5d84e2968feacf8"}],"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":55,"context_line":"* `Updating security parameters as manual clean step`_"},{"line_number":56,"context_line":"* `Update Minimum Password Length security parameter as manual clean step`_"},{"line_number":57,"context_line":"* `Update Authentication Failure Logging security parameter as manual clean step`_"},{"line_number":58,"context_line":"* `Create Certificate Signing Request as manual clean step`_"},{"line_number":59,"context_line":"* `Add Https Certificate as manual clean step`_"},{"line_number":60,"context_line":"* `Activating iLO Advanced license as manual clean step`_"},{"line_number":61,"context_line":"* `Removing CA certificates from iLO as manual clean step`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c1e7808d_8b2261c2","line":58,"range":{"start_line":58,"start_character":10,"end_line":58,"end_character":37},"updated":"2022-03-11 06:20:17.000000000","message":"nit: s/ Certificate Signing Request / Certificate Signing Request (CSR)","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":55,"context_line":"* `Updating security parameters as manual clean step`_"},{"line_number":56,"context_line":"* `Update Minimum Password Length security parameter as manual clean step`_"},{"line_number":57,"context_line":"* `Update Authentication Failure Logging security parameter as manual clean step`_"},{"line_number":58,"context_line":"* `Create Certificate Signing Request as manual clean step`_"},{"line_number":59,"context_line":"* `Add Https Certificate as manual clean step`_"},{"line_number":60,"context_line":"* `Activating iLO Advanced license as manual clean step`_"},{"line_number":61,"context_line":"* `Removing CA certificates from iLO as manual clean step`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"907df386_5b5363cf","line":58,"range":{"start_line":58,"start_character":10,"end_line":58,"end_character":37},"in_reply_to":"c1e7808d_8b2261c2","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":56,"context_line":"* `Update Minimum Password Length security parameter as manual clean step`_"},{"line_number":57,"context_line":"* `Update Authentication Failure Logging security parameter as manual clean step`_"},{"line_number":58,"context_line":"* `Create Certificate Signing Request as manual clean step`_"},{"line_number":59,"context_line":"* `Add Https Certificate as manual clean step`_"},{"line_number":60,"context_line":"* `Activating iLO Advanced license as manual clean step`_"},{"line_number":61,"context_line":"* `Removing CA certificates from iLO as manual clean step`_"},{"line_number":62,"context_line":"* `Firmware based UEFI iSCSI boot from volume support`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"0e78ffa3_9381b684","line":59,"range":{"start_line":59,"start_character":7,"end_line":59,"end_character":12},"updated":"2022-03-11 06:20:17.000000000","message":"s/ Https / HTTPS /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* `Update Minimum Password Length security parameter as manual clean step`_"},{"line_number":57,"context_line":"* `Update Authentication Failure Logging security parameter as manual clean step`_"},{"line_number":58,"context_line":"* `Create Certificate Signing Request as manual clean step`_"},{"line_number":59,"context_line":"* `Add Https Certificate as manual clean step`_"},{"line_number":60,"context_line":"* `Activating iLO Advanced license as manual clean step`_"},{"line_number":61,"context_line":"* `Removing CA certificates from iLO as manual clean step`_"},{"line_number":62,"context_line":"* `Firmware based UEFI iSCSI boot from volume support`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9250f169_74e90102","line":59,"range":{"start_line":59,"start_character":7,"end_line":59,"end_character":12},"in_reply_to":"0e78ffa3_9381b684","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":762,"context_line":"    Creates the certificate signing request. See `Create Certificate Signing Request as manual clean step`_"},{"line_number":763,"context_line":"    for user guidance on usage."},{"line_number":764,"context_line":"  ``add_https_certificate``:"},{"line_number":765,"context_line":"    Adds the HTTPS certificate to the iLO. See `Add Https Certificate as manual clean step`_ for user"},{"line_number":766,"context_line":"    guidance on usage."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"300e1826_6ff05b0f","line":765,"range":{"start_line":765,"start_character":13,"end_line":765,"end_character":30},"updated":"2022-03-11 06:20:17.000000000","message":"s/  HTTPS certificate / signed HTTPS certificate /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":762,"context_line":"    Creates the certificate signing request. See `Create Certificate Signing Request as manual clean step`_"},{"line_number":763,"context_line":"    for user guidance on usage."},{"line_number":764,"context_line":"  ``add_https_certificate``:"},{"line_number":765,"context_line":"    Adds the HTTPS certificate to the iLO. See `Add Https Certificate as manual clean step`_ for user"},{"line_number":766,"context_line":"    guidance on usage."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"38516352_b040271a","line":765,"range":{"start_line":765,"start_character":52,"end_line":765,"end_character":57},"updated":"2022-03-11 06:20:17.000000000","message":"s/ Https / HTTPS /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    Creates the certificate signing request. See `Create Certificate Signing Request as manual clean step`_"},{"line_number":763,"context_line":"    for user guidance on usage."},{"line_number":764,"context_line":"  ``add_https_certificate``:"},{"line_number":765,"context_line":"    Adds the HTTPS certificate to the iLO. See `Add Https Certificate as manual clean step`_ for user"},{"line_number":766,"context_line":"    guidance on usage."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"407d566b_8a4785b3","line":765,"range":{"start_line":765,"start_character":13,"end_line":765,"end_character":30},"in_reply_to":"300e1826_6ff05b0f","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    Creates the certificate signing request. See `Create Certificate Signing Request as manual clean step`_"},{"line_number":763,"context_line":"    for user guidance on usage."},{"line_number":764,"context_line":"  ``add_https_certificate``:"},{"line_number":765,"context_line":"    Adds the HTTPS certificate to the iLO. See `Add Https Certificate as manual clean step`_ for user"},{"line_number":766,"context_line":"    guidance on usage."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a0a307a3_c88fec56","line":765,"range":{"start_line":765,"start_character":52,"end_line":765,"end_character":57},"in_reply_to":"38516352_b040271a","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"Create Certificate Signing Request as manual clean step"},{"line_number":1846,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"iLO driver can invoke ``Create CSR`` request as a manual clean step. This feature is only supported for iLO5 based hardware."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"An example of a manual clean step with ``Create CSR`` as the only clean step could be::"},{"line_number":1851,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9fd16064_5fa677be","line":1848,"range":{"start_line":1848,"start_character":24,"end_line":1848,"end_character":34},"updated":"2022-03-11 06:20:17.000000000","message":"s/ Create CSR / create_csr /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"Create Certificate Signing Request as manual clean step"},{"line_number":1846,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"iLO driver can invoke ``Create CSR`` request as a manual clean step. This feature is only supported for iLO5 based hardware."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"An example of a manual clean step with ``Create CSR`` as the only clean step could be::"},{"line_number":1851,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"6a349947_2924a6b5","line":1848,"range":{"start_line":1848,"start_character":74,"end_line":1848,"end_character":81},"updated":"2022-03-11 06:20:17.000000000","message":"s/ feature / step /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"Create Certificate Signing Request as manual clean step"},{"line_number":1846,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"iLO driver can invoke ``Create CSR`` request as a manual clean step. This feature is only supported for iLO5 based hardware."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"An example of a manual clean step with ``Create CSR`` as the only clean step could be::"},{"line_number":1851,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"66ac946e_8f69ab42","line":1848,"range":{"start_line":1848,"start_character":74,"end_line":1848,"end_character":81},"in_reply_to":"6a349947_2924a6b5","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"Create Certificate Signing Request as manual clean step"},{"line_number":1846,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"iLO driver can invoke ``Create CSR`` request as a manual clean step. This feature is only supported for iLO5 based hardware."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"An example of a manual clean step with ``Create CSR`` as the only clean step could be::"},{"line_number":1851,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"660369dd_d05e378a","line":1848,"range":{"start_line":1848,"start_character":24,"end_line":1848,"end_character":34},"in_reply_to":"9fd16064_5fa677be","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"iLO driver can invoke ``Create CSR`` request as a manual clean step. This feature is only supported for iLO5 based hardware."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"An example of a manual clean step with ``Create CSR`` as the only clean step could be::"},{"line_number":1851,"context_line":""},{"line_number":1852,"context_line":"    \"clean_steps\": [{"},{"line_number":1853,"context_line":"        \"interface\": \"management\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"23738455_d2d83f22","line":1850,"range":{"start_line":1850,"start_character":41,"end_line":1850,"end_character":51},"updated":"2022-03-11 06:20:17.000000000","message":"ditto","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"iLO driver can invoke ``Create CSR`` request as a manual clean step. This feature is only supported for iLO5 based hardware."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"An example of a manual clean step with ``Create CSR`` as the only clean step could be::"},{"line_number":1851,"context_line":""},{"line_number":1852,"context_line":"    \"clean_steps\": [{"},{"line_number":1853,"context_line":"        \"interface\": \"management\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"e0c928cf_07cd956e","line":1850,"range":{"start_line":1850,"start_character":41,"end_line":1850,"end_character":51},"in_reply_to":"23738455_d2d83f22","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1855,"context_line":"        \"args\": {"},{"line_number":1856,"context_line":"            \"path\": \"/test1/\","},{"line_number":1857,"context_line":"            \"csr_params\": {"},{"line_number":1858,"context_line":"                \"City\": \"ABC\","},{"line_number":1859,"context_line":"                \"CommonName\": \"1.1.1.1\","},{"line_number":1860,"context_line":"                \"Country\": \"DEF\","},{"line_number":1861,"context_line":"                \"OrgName\": \"IJK\","},{"line_number":1862,"context_line":"                \"State\": \"UFO\""},{"line_number":1863,"context_line":"            }"},{"line_number":1864,"context_line":"        }"},{"line_number":1865,"context_line":"    }]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"d26505e7_57b329a7","line":1862,"range":{"start_line":1858,"start_character":16,"end_line":1862,"end_character":30},"updated":"2022-03-11 06:20:17.000000000","message":"May be you can give some valid values here. Also explain each of these required attributes.","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1855,"context_line":"        \"args\": {"},{"line_number":1856,"context_line":"            \"path\": \"/test1/\","},{"line_number":1857,"context_line":"            \"csr_params\": {"},{"line_number":1858,"context_line":"                \"City\": \"ABC\","},{"line_number":1859,"context_line":"                \"CommonName\": \"1.1.1.1\","},{"line_number":1860,"context_line":"                \"Country\": \"DEF\","},{"line_number":1861,"context_line":"                \"OrgName\": \"IJK\","},{"line_number":1862,"context_line":"                \"State\": \"UFO\""},{"line_number":1863,"context_line":"            }"},{"line_number":1864,"context_line":"        }"},{"line_number":1865,"context_line":"    }]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b6dcccf0_cc7d05da","line":1862,"range":{"start_line":1858,"start_character":16,"end_line":1862,"end_character":30},"in_reply_to":"d26505e7_57b329a7","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"Both the arguments ``path`` and ``csr_params`` are mandatory. ``path`` is the directory where CSR will be stored after"},{"line_number":1868,"context_line":"creation. If ``path`` doesn\u0027t exist then it will be created."},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"Add Https Certificate as manual clean step"},{"line_number":1871,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"iLO driver can invoke ``add_https_certificate`` request as a manual clean step. This feature is only supported for"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a96a21c_455a4b4c","line":1870,"range":{"start_line":1870,"start_character":4,"end_line":1870,"end_character":9},"updated":"2022-03-11 06:20:17.000000000","message":"ditto","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"Both the arguments ``path`` and ``csr_params`` are mandatory. ``path`` is the directory where CSR will be stored after"},{"line_number":1868,"context_line":"creation. If ``path`` doesn\u0027t exist then it will be created."},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"Add Https Certificate as manual clean step"},{"line_number":1871,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"iLO driver can invoke ``add_https_certificate`` request as a manual clean step. This feature is only supported for"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fb0e1be6_0b3eddbc","line":1870,"range":{"start_line":1870,"start_character":4,"end_line":1870,"end_character":9},"in_reply_to":"3a96a21c_455a4b4c","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1870,"context_line":"Add Https Certificate as manual clean step"},{"line_number":1871,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"iLO driver can invoke ``add_https_certificate`` request as a manual clean step. This feature is only supported for"},{"line_number":1874,"context_line":"iLO5 based hardware."},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"An example of a manual clean step with ``add_https_certificate`` as the only clean step could be::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"6c90f2d4_ed719281","line":1873,"range":{"start_line":1873,"start_character":85,"end_line":1873,"end_character":92},"updated":"2022-03-11 06:20:17.000000000","message":"s/ feature / step /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"Add Https Certificate as manual clean step"},{"line_number":1871,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"iLO driver can invoke ``add_https_certificate`` request as a manual clean step. This feature is only supported for"},{"line_number":1874,"context_line":"iLO5 based hardware."},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"An example of a manual clean step with ``add_https_certificate`` as the only clean step could be::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"037bd55e_b4995a71","line":1873,"range":{"start_line":1873,"start_character":85,"end_line":1873,"end_character":92},"in_reply_to":"6c90f2d4_ed719281","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. This contains the path of certificate file."},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"RAID Support"},{"line_number":1889,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e17f42fb_0795372e","line":1886,"range":{"start_line":1886,"start_character":37,"end_line":1886,"end_character":79},"updated":"2022-03-11 06:20:17.000000000","message":"Also need to explain how the CSR generated to be used to sign the certificate.","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. This contains the path of certificate file."},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"RAID Support"},{"line_number":1889,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e0b82719_3c76c3de","line":1886,"range":{"start_line":1886,"start_character":37,"end_line":1886,"end_character":41},"updated":"2022-03-11 06:20:17.000000000","message":"s/ This / It /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. This contains the path of certificate file."},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"RAID Support"},{"line_number":1889,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":7,"id":"58d78dfc_752b2ada","line":1886,"range":{"start_line":1886,"start_character":37,"end_line":1886,"end_character":41},"in_reply_to":"e0b82719_3c76c3de","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. This contains the path of certificate file."},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"RAID Support"},{"line_number":1889,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9ef33abe_6a0c6d6a","line":1886,"range":{"start_line":1886,"start_character":37,"end_line":1886,"end_character":79},"in_reply_to":"e17f42fb_0795372e","updated":"2022-03-19 16:46:05.000000000","message":"We dont need to document these as even iLO documentation just say that the CSR should be signed by a valid CA.","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b8beb4e136ad563b29732b8cef5993f1ed3382a8","unresolved":true,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. It contains the path of certificate file."},{"line_number":1887,"context_line":"The CSR generated in step ``create_csr`` needs to be sigend by a valid CA and the resultant HTTPS certificate should"},{"line_number":1888,"context_line":"be provided in ``cert_file``."},{"line_number":1889,"context_line":""},{"line_number":1890,"context_line":"RAID Support"},{"line_number":1891,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ecdcf983_cfd05080","line":1888,"range":{"start_line":1886,"start_character":0,"end_line":1888,"end_character":29},"updated":"2022-03-28 09:46:54.000000000","message":"It would be useful to add the detailed commands how CSR file could be used to sign a self generated certificate.","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1b60d75a01aa2c5875b7802693dc193bff7a322","unresolved":false,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. It contains the path of certificate file."},{"line_number":1887,"context_line":"The CSR generated in step ``create_csr`` needs to be sigend by a valid CA and the resultant HTTPS certificate should"},{"line_number":1888,"context_line":"be provided in ``cert_file``."},{"line_number":1889,"context_line":""},{"line_number":1890,"context_line":"RAID Support"},{"line_number":1891,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":10,"id":"6194cc8c_f32597ee","line":1888,"range":{"start_line":1886,"start_character":0,"end_line":1888,"end_character":29},"in_reply_to":"51e3c1dd_f86fb411","updated":"2022-03-29 16:25:34.000000000","message":"Done","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b681cb9a8cced142916e5579fab3e37ae1cd653c","unresolved":true,"context_lines":[{"line_number":1883,"context_line":"        }"},{"line_number":1884,"context_line":"    }]"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"Argument ``cert_file`` is mandatory. It contains the path of certificate file."},{"line_number":1887,"context_line":"The CSR generated in step ``create_csr`` needs to be sigend by a valid CA and the resultant HTTPS certificate should"},{"line_number":1888,"context_line":"be provided in ``cert_file``."},{"line_number":1889,"context_line":""},{"line_number":1890,"context_line":"RAID Support"},{"line_number":1891,"context_line":"^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":10,"id":"51e3c1dd_f86fb411","line":1888,"range":{"start_line":1886,"start_character":0,"end_line":1888,"end_character":29},"in_reply_to":"ecdcf983_cfd05080","updated":"2022-03-29 16:24:54.000000000","message":"iLO itself doesnt recommend self-signed certificate. As per iLO documentation, CSR needs to be signed by a valid CA, hence i dont think we should document anything here as even iLO doesnt document those steps.","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":1863,"context_line":"        }"},{"line_number":1864,"context_line":"    }]"},{"line_number":1865,"context_line":""},{"line_number":1866,"context_line":"The argument ``csr_params`` is mandatory. The configuration ``[ilo]csr_path`` is used as"},{"line_number":1867,"context_line":"directory path for creating the CSR."},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"If ``[ilo]csr_path`` is not provided by user, it takes the default path as"}],"source_content_type":"text/x-rst","patch_set":11,"id":"d0a79f51_d4ffb07f","line":1866,"range":{"start_line":1866,"start_character":42,"end_line":1866,"end_character":77},"updated":"2022-03-30 04:17:35.000000000","message":"To be consistent with other uses in this file:\n\n  The ``[ilo]csr_path`` option in ``ironic.conf`` is used as the directory path for creating the CSR, which defaults to ``/etc/pki/ilo``\n\n(but do the code changes first because all of these names might change ;)","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":false,"context_lines":[{"line_number":1863,"context_line":"        }"},{"line_number":1864,"context_line":"    }]"},{"line_number":1865,"context_line":""},{"line_number":1866,"context_line":"The argument ``csr_params`` is mandatory. The configuration ``[ilo]csr_path`` is used as"},{"line_number":1867,"context_line":"directory path for creating the CSR."},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"If ``[ilo]csr_path`` is not provided by user, it takes the default path as"}],"source_content_type":"text/x-rst","patch_set":11,"id":"6df1c0d8_9ad5d1c2","line":1866,"range":{"start_line":1866,"start_character":42,"end_line":1866,"end_character":77},"in_reply_to":"d0a79f51_d4ffb07f","updated":"2022-09-09 06:23:10.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":1866,"context_line":"The argument ``csr_params`` is mandatory. The configuration ``[ilo]csr_path`` is used as"},{"line_number":1867,"context_line":"directory path for creating the CSR."},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"If ``[ilo]csr_path`` is not provided by user, it takes the default path as"},{"line_number":1870,"context_line":"\"/etc/pki/ilo\". If the path doesn\u0027t exist, it creates the path."},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":"Add HTTPS Certificate as manual clean step"},{"line_number":1873,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7db6a253_972f4bb7","line":1870,"range":{"start_line":1869,"start_character":0,"end_line":1870,"end_character":63},"updated":"2022-03-30 04:17:35.000000000","message":"This probably isn\u0027t required with the above change.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"The argument ``csr_params`` is mandatory. The configuration ``[ilo]csr_path`` is used as"},{"line_number":1867,"context_line":"directory path for creating the CSR."},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"If ``[ilo]csr_path`` is not provided by user, it takes the default path as"},{"line_number":1870,"context_line":"\"/etc/pki/ilo\". If the path doesn\u0027t exist, it creates the path."},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":"Add HTTPS Certificate as manual clean step"},{"line_number":1873,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":11,"id":"8c819d2d_c3c5ee34","line":1870,"range":{"start_line":1869,"start_character":0,"end_line":1870,"end_character":63},"in_reply_to":"7db6a253_972f4bb7","updated":"2022-09-09 06:23:10.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":1881,"context_line":"        \"interface\": \"management\","},{"line_number":1882,"context_line":"        \"step\": \"add_https_certificate\","},{"line_number":1883,"context_line":"        \"args\": {"},{"line_number":1884,"context_line":"            \"cert_file\": \"/test1/iLO.crt\""},{"line_number":1885,"context_line":"        }"},{"line_number":1886,"context_line":"    }]"},{"line_number":1887,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"36c71e07_5b231b99","line":1884,"updated":"2022-03-30 04:17:35.000000000","message":"To future proof this, I\u0027d suggest doing like firmware_images and mandating that this be a valid URL, but only supporting the file:// protocol at this stage.\n\nHaving access to manually write /test1/iLO.crt to the controller filesystem will be a barrier for some operator scenarios, in the future other protocols can be added like https://, swift:.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"43364912f73592fe36f1d8346affb6676d79e0c0","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"        \"interface\": \"management\","},{"line_number":1882,"context_line":"        \"step\": \"add_https_certificate\","},{"line_number":1883,"context_line":"        \"args\": {"},{"line_number":1884,"context_line":"            \"cert_file\": \"/test1/iLO.crt\""},{"line_number":1885,"context_line":"        }"},{"line_number":1886,"context_line":"    }]"},{"line_number":1887,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"0a44e162_5beeba66","line":1884,"in_reply_to":"36c71e07_5b231b99","updated":"2022-09-09 06:23:58.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":1886,"context_line":"    }]"},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"Argument ``cert_file`` is mandatory. It contains the path of certificate file."},{"line_number":1889,"context_line":"The CSR generated in step ``create_csr`` needs to be sigend by a valid CA and the resultant HTTPS certificate should"},{"line_number":1890,"context_line":"be provided in ``cert_file``. It copies the ``cert_file`` to ``[ilo]csr_path`` under ``node.uuid`` before adding"},{"line_number":1891,"context_line":"it to iLO."},{"line_number":1892,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"e9c5c201_d7091bf1","line":1889,"range":{"start_line":1889,"start_character":53,"end_line":1889,"end_character":59},"updated":"2022-03-30 04:17:35.000000000","message":"signed","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":false,"context_lines":[{"line_number":1886,"context_line":"    }]"},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"Argument ``cert_file`` is mandatory. It contains the path of certificate file."},{"line_number":1889,"context_line":"The CSR generated in step ``create_csr`` needs to be sigend by a valid CA and the resultant HTTPS certificate should"},{"line_number":1890,"context_line":"be provided in ``cert_file``. It copies the ``cert_file`` to ``[ilo]csr_path`` under ``node.uuid`` before adding"},{"line_number":1891,"context_line":"it to iLO."},{"line_number":1892,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"e74c5ab5_001983fc","line":1889,"range":{"start_line":1889,"start_character":53,"end_line":1889,"end_character":59},"in_reply_to":"e9c5c201_d7091bf1","updated":"2022-09-09 06:23:10.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7f59d866eb5e25f4a053adfe3b3179fbe3f15369","unresolved":true,"context_lines":[{"line_number":1084,"context_line":"Deploy Process"},{"line_number":1085,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"Glance and swift for partition images"},{"line_number":1088,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":".. seqdiag::"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ce7726c6_78e7372f","line":1087,"updated":"2022-09-09 14:39:31.000000000","message":"nit: OpenStack project names (e.g. Swift) are usually capitalized in our documentation.","commit_id":"9c19dd6ef3bac14859c8a297e5d84e2968feacf8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b8beba18474eef2d88dbd7f16029a4ab3a983339","unresolved":true,"context_lines":[{"line_number":1084,"context_line":"Deploy Process"},{"line_number":1085,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"Glance and swift for partition images"},{"line_number":1088,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":".. seqdiag::"}],"source_content_type":"text/x-rst","patch_set":15,"id":"e7b745a8_b88dd089","line":1087,"in_reply_to":"ce7726c6_78e7372f","updated":"2022-09-09 16:32:22.000000000","message":"Ack. Will fix it in another bug as its unrelated to this patch.","commit_id":"9c19dd6ef3bac14859c8a297e5d84e2968feacf8"}],"ironic/conf/ilo.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                      \u0027/proc/cmdline. Mind severe cmdline size limit! Can be \u0027"},{"line_number":121,"context_line":"                      \u0027overridden by `instance_info/kernel_append_params` \u0027"},{"line_number":122,"context_line":"                      \u0027property.\u0027)),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027csr_path\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027/etc/pki/ilo/\u0027,"},{"line_number":125,"context_line":"               help\u003d_(\u0027On the ironic-conductor node, directory where ilo \u0027"},{"line_number":126,"context_line":"                      \u0027driver stores the CSR.\u0027)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ec378be7_b9035eef","line":123,"range":{"start_line":123,"start_character":16,"end_line":123,"end_character":24},"updated":"2022-03-30 04:17:35.000000000","message":"If this directory will be storing both CSRs and signed certificates then maybe it should be called cert_path","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                      \u0027/proc/cmdline. Mind severe cmdline size limit! Can be \u0027"},{"line_number":121,"context_line":"                      \u0027overridden by `instance_info/kernel_append_params` \u0027"},{"line_number":122,"context_line":"                      \u0027property.\u0027)),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027csr_path\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027/etc/pki/ilo/\u0027,"},{"line_number":125,"context_line":"               help\u003d_(\u0027On the ironic-conductor node, directory where ilo \u0027"},{"line_number":126,"context_line":"                      \u0027driver stores the CSR.\u0027)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"fec40a4e_5302e26c","line":123,"range":{"start_line":123,"start_character":16,"end_line":123,"end_character":24},"in_reply_to":"ec378be7_b9035eef","updated":"2022-09-09 06:23:10.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                      \u0027overridden by `instance_info/kernel_append_params` \u0027"},{"line_number":122,"context_line":"                      \u0027property.\u0027)),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027csr_path\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027/etc/pki/ilo/\u0027,"},{"line_number":125,"context_line":"               help\u003d_(\u0027On the ironic-conductor node, directory where ilo \u0027"},{"line_number":126,"context_line":"                      \u0027driver stores the CSR.\u0027)),"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fb295545_ef2e61b4","line":124,"updated":"2022-03-30 04:17:35.000000000","message":"I know this was my suggestion as a default but I think some consideration is required, and other reviewers should offer their thoughts.\n\nThe contents of this directory is state modified by the operator over time, so maybe /var/lib/ironic/ilo_cert?","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                      \u0027overridden by `instance_info/kernel_append_params` \u0027"},{"line_number":122,"context_line":"                      \u0027property.\u0027)),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027csr_path\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027/etc/pki/ilo/\u0027,"},{"line_number":125,"context_line":"               help\u003d_(\u0027On the ironic-conductor node, directory where ilo \u0027"},{"line_number":126,"context_line":"                      \u0027driver stores the CSR.\u0027)),"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"958f6705_6ba4693d","line":124,"in_reply_to":"a5f9b075_aa18a99f","updated":"2022-09-09 06:23:10.000000000","message":"I have defined it as \"/var/lib/ironic/ilo\"","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"06a049cda37cd70ca2174f44210ec1c43de08326","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                      \u0027overridden by `instance_info/kernel_append_params` \u0027"},{"line_number":122,"context_line":"                      \u0027property.\u0027)),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027csr_path\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027/etc/pki/ilo/\u0027,"},{"line_number":125,"context_line":"               help\u003d_(\u0027On the ironic-conductor node, directory where ilo \u0027"},{"line_number":126,"context_line":"                      \u0027driver stores the CSR.\u0027)),"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"a5f9b075_aa18a99f","line":124,"in_reply_to":"fb295545_ef2e61b4","updated":"2022-07-19 17:59:57.000000000","message":"If this is for Ironic-use-only, /var/lib/ironic/[something] makes sense.\n\nIf this is for operator use, it should probably be in etc (likely /etc/ironic/[something] rather than /etc/pki/[somethign] -- since /etc/pki is a distro-ism).","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"efc4e2a1db0a9bc50eab3f7a6a4010281b033ecd","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        ),"},{"line_number":88,"context_line":"        \u0027required\u0027: True"},{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \u0027signed_cert\u0027: {"},{"line_number":91,"context_line":"        \u0027description\u0027: ("},{"line_number":92,"context_line":"            \"This argument represents signed certificate \""},{"line_number":93,"context_line":"            \"which will be used to sign the created CSR.\""},{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    },"},{"line_number":97,"context_line":"    \u0027private_key\u0027: {"},{"line_number":98,"context_line":"        \u0027description\u0027: ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1e08b938_8bcd7349","line":95,"range":{"start_line":90,"start_character":0,"end_line":95,"end_character":24},"updated":"2022-02-28 19:18:35.000000000","message":"Typically signing occurs remotely, this doesn\u0027t seem like it would be required in all cases, unless this is actually something else?\n\nBottom line, I don\u0027t think the name matches the description, which doesn\u0027t really align with the parameters/variables usage.\n\nAdditionally, if this is provided, then maybe a password to decrypt an attached private key, but you don\u0027t need new CSR parameters...\n\nI guess this is a bit confusing, I would break this into multiple distinct, separate, steps.","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        ),"},{"line_number":88,"context_line":"        \u0027required\u0027: True"},{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \u0027signed_cert\u0027: {"},{"line_number":91,"context_line":"        \u0027description\u0027: ("},{"line_number":92,"context_line":"            \"This argument represents signed certificate \""},{"line_number":93,"context_line":"            \"which will be used to sign the created CSR.\""},{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    },"},{"line_number":97,"context_line":"    \u0027private_key\u0027: {"},{"line_number":98,"context_line":"        \u0027description\u0027: ("}],"source_content_type":"text/x-python","patch_set":6,"id":"9043f48d_9e7cb20b","line":95,"range":{"start_line":90,"start_character":0,"end_line":95,"end_character":24},"in_reply_to":"1382d2ff_b8f157bd","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"10b4b598bf5533382dbf74321acaf92e3c019553","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        ),"},{"line_number":88,"context_line":"        \u0027required\u0027: True"},{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \u0027signed_cert\u0027: {"},{"line_number":91,"context_line":"        \u0027description\u0027: ("},{"line_number":92,"context_line":"            \"This argument represents signed certificate \""},{"line_number":93,"context_line":"            \"which will be used to sign the created CSR.\""},{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    },"},{"line_number":97,"context_line":"    \u0027private_key\u0027: {"},{"line_number":98,"context_line":"        \u0027description\u0027: ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1382d2ff_b8f157bd","line":95,"range":{"start_line":90,"start_character":0,"end_line":95,"end_character":24},"in_reply_to":"1e08b938_8bcd7349","updated":"2022-03-01 11:46:54.000000000","message":"The steps to import the certificate are:\n1. Generate a CSR\n2. Send the CSR to a CA and receive a certificate\n3.Import/add the certificate to ilo.\n4. restart the ilo","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"efc4e2a1db0a9bc50eab3f7a6a4010281b033ecd","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    },"},{"line_number":97,"context_line":"    \u0027private_key\u0027: {"},{"line_number":98,"context_line":"        \u0027description\u0027: ("},{"line_number":99,"context_line":"            \"This argument represents private key used to \""},{"line_number":100,"context_line":"            \"create the signed certificate.\""},{"line_number":101,"context_line":"        ),"},{"line_number":102,"context_line":"        \u0027required\u0027: True"},{"line_number":103,"context_line":"    },"},{"line_number":104,"context_line":"    \u0027pass_phrase\u0027: {"},{"line_number":105,"context_line":"        \u0027description\u0027: ("},{"line_number":106,"context_line":"            \"This argument represents the pass phrase \""}],"source_content_type":"text/x-python","patch_set":6,"id":"fd1296f7_2ff8a587","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":0},"updated":"2022-02-28 19:18:35.000000000","message":"Why would a private key be required *if* the bmc is going to generate the CSR itself?","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    },"},{"line_number":97,"context_line":"    \u0027private_key\u0027: {"},{"line_number":98,"context_line":"        \u0027description\u0027: ("},{"line_number":99,"context_line":"            \"This argument represents private key used to \""},{"line_number":100,"context_line":"            \"create the signed certificate.\""},{"line_number":101,"context_line":"        ),"},{"line_number":102,"context_line":"        \u0027required\u0027: True"},{"line_number":103,"context_line":"    },"},{"line_number":104,"context_line":"    \u0027pass_phrase\u0027: {"},{"line_number":105,"context_line":"        \u0027description\u0027: ("},{"line_number":106,"context_line":"            \"This argument represents the pass phrase \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f16304b_74e7f86a","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":0},"in_reply_to":"fd1296f7_2ff8a587","updated":"2022-03-19 16:46:05.000000000","message":"The private key is required to sign the CSR with a Valid CA/self-signed certificate which in turn generates the HTTPS certificate. Anyway sincethe steps are splitted , user is expected to do it by himself.","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"efc4e2a1db0a9bc50eab3f7a6a4010281b033ecd","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        ),"},{"line_number":102,"context_line":"        \u0027required\u0027: True"},{"line_number":103,"context_line":"    },"},{"line_number":104,"context_line":"    \u0027pass_phrase\u0027: {"},{"line_number":105,"context_line":"        \u0027description\u0027: ("},{"line_number":106,"context_line":"            \"This argument represents the pass phrase \""},{"line_number":107,"context_line":"            \"for the private key.\""},{"line_number":108,"context_line":"        ),"},{"line_number":109,"context_line":"        \u0027required\u0027: True"},{"line_number":110,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"c0236df6_ab60eae9","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":34},"updated":"2022-02-28 19:18:35.000000000","message":"So, if I\u0027m supplying a private key, then it *may* be encrypted or not, and I would need to supply a pass phrase.\n\nI guess, this doesn\u0027t seem required if it is just for the private key, but at the same time the private key shouldn\u0027t be a mandatory thing to be provided as it risks operational security.\n\nTo put this another way:\n\nif I have the Private Key which will be used, then I don\u0027t need to involve the system to create a CSR to get signed and then upload to the BMC as a completely separate operation.","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        ),"},{"line_number":102,"context_line":"        \u0027required\u0027: True"},{"line_number":103,"context_line":"    },"},{"line_number":104,"context_line":"    \u0027pass_phrase\u0027: {"},{"line_number":105,"context_line":"        \u0027description\u0027: ("},{"line_number":106,"context_line":"            \"This argument represents the pass phrase \""},{"line_number":107,"context_line":"            \"for the private key.\""},{"line_number":108,"context_line":"        ),"},{"line_number":109,"context_line":"        \u0027required\u0027: True"},{"line_number":110,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f517daf_b6d2d25b","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":34},"in_reply_to":"c0236df6_ab60eae9","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"a50eabd240390e067bdd1f1955ab7dc9c9823038"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    \u0027path\u0027: {"},{"line_number":84,"context_line":"        \u0027description\u0027: ("},{"line_number":85,"context_line":"            \"This argument represents the path to store the CSR certificate \""},{"line_number":86,"context_line":"            \"created. If path doesn\u0027t exist, it will create the folder.\""},{"line_number":87,"context_line":"        ),"},{"line_number":88,"context_line":"        \u0027required\u0027: True"},{"line_number":89,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":7,"id":"85b34ede_b8faa3c5","line":86,"range":{"start_line":86,"start_character":64,"end_line":86,"end_character":70},"updated":"2022-03-11 06:20:17.000000000","message":"s/ folder / corresponding directory /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0027path\u0027: {"},{"line_number":84,"context_line":"        \u0027description\u0027: ("},{"line_number":85,"context_line":"            \"This argument represents the path to store the CSR certificate \""},{"line_number":86,"context_line":"            \"created. If path doesn\u0027t exist, it will create the folder.\""},{"line_number":87,"context_line":"        ),"},{"line_number":88,"context_line":"        \u0027required\u0027: True"},{"line_number":89,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb4a6489_13dd92cc","line":86,"range":{"start_line":86,"start_character":64,"end_line":86,"end_character":70},"in_reply_to":"85b34ede_b8faa3c5","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \u0027csr_params\u0027: {"},{"line_number":91,"context_line":"        \u0027description\u0027: ("},{"line_number":92,"context_line":"            \"This arguments represents the information needed \""},{"line_number":93,"context_line":"            \"to create the CSR certificate.\""},{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":7,"id":"beb22602_ea5558a1","line":93,"range":{"start_line":92,"start_character":12,"end_line":93,"end_character":43},"updated":"2022-03-11 06:20:17.000000000","message":"Need to mention the supported list of keys here.","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \u0027csr_params\u0027: {"},{"line_number":91,"context_line":"        \u0027description\u0027: ("},{"line_number":92,"context_line":"            \"This arguments represents the information needed \""},{"line_number":93,"context_line":"            \"to create the CSR certificate.\""},{"line_number":94,"context_line":"        ),"},{"line_number":95,"context_line":"        \u0027required\u0027: True"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":7,"id":"86077e0a_6b0fc4cc","line":93,"range":{"start_line":92,"start_character":12,"end_line":93,"end_character":43},"in_reply_to":"beb22602_ea5558a1","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":99,"context_line":"_ADD_HTTPS_CERT_ARGSINFO \u003d {"},{"line_number":100,"context_line":"    \u0027cert_file\u0027: {"},{"line_number":101,"context_line":"        \u0027description\u0027: ("},{"line_number":102,"context_line":"            \"This argument represents the https certificate which will \""},{"line_number":103,"context_line":"            \"be added to the iLO.\""},{"line_number":104,"context_line":"        ),"},{"line_number":105,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":7,"id":"87c38d96_c1b737e3","line":102,"range":{"start_line":102,"start_character":48,"end_line":102,"end_character":59},"updated":"2022-03-11 06:20:17.000000000","message":"Should be signed?","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":99,"context_line":"_ADD_HTTPS_CERT_ARGSINFO \u003d {"},{"line_number":100,"context_line":"    \u0027cert_file\u0027: {"},{"line_number":101,"context_line":"        \u0027description\u0027: ("},{"line_number":102,"context_line":"            \"This argument represents the https certificate which will \""},{"line_number":103,"context_line":"            \"be added to the iLO.\""},{"line_number":104,"context_line":"        ),"},{"line_number":105,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":7,"id":"5c033670_cfd2a390","line":102,"range":{"start_line":102,"start_character":38,"end_line":102,"end_character":47},"updated":"2022-03-11 06:20:17.000000000","message":"s/ the https / the path to HTTPS /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":99,"context_line":"_ADD_HTTPS_CERT_ARGSINFO \u003d {"},{"line_number":100,"context_line":"    \u0027cert_file\u0027: {"},{"line_number":101,"context_line":"        \u0027description\u0027: ("},{"line_number":102,"context_line":"            \"This argument represents the https certificate which will \""},{"line_number":103,"context_line":"            \"be added to the iLO.\""},{"line_number":104,"context_line":"        ),"},{"line_number":105,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":7,"id":"43b9623f_565d4ddb","line":102,"range":{"start_line":102,"start_character":38,"end_line":102,"end_character":47},"in_reply_to":"5c033670_cfd2a390","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":99,"context_line":"_ADD_HTTPS_CERT_ARGSINFO \u003d {"},{"line_number":100,"context_line":"    \u0027cert_file\u0027: {"},{"line_number":101,"context_line":"        \u0027description\u0027: ("},{"line_number":102,"context_line":"            \"This argument represents the https certificate which will \""},{"line_number":103,"context_line":"            \"be added to the iLO.\""},{"line_number":104,"context_line":"        ),"},{"line_number":105,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":7,"id":"73063d20_114c9194","line":102,"range":{"start_line":102,"start_character":48,"end_line":102,"end_character":59},"in_reply_to":"87c38d96_c1b737e3","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":605,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse,"},{"line_number":606,"context_line":"                     argsinfo\u003d_CREATE_CSR_ARGSINFO)"},{"line_number":607,"context_line":"    def create_csr(self, task, **kwargs):"},{"line_number":608,"context_line":"        \"\"\"Creates the CSR certificate."},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        :param task: a TaskManager object."},{"line_number":611,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"015db8c3_0dc4f558","line":608,"range":{"start_line":608,"start_character":27,"end_line":608,"end_character":38},"updated":"2022-03-11 06:20:17.000000000","message":"s/ certificate //","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":605,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse,"},{"line_number":606,"context_line":"                     argsinfo\u003d_CREATE_CSR_ARGSINFO)"},{"line_number":607,"context_line":"    def create_csr(self, task, **kwargs):"},{"line_number":608,"context_line":"        \"\"\"Creates the CSR certificate."},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        :param task: a TaskManager object."},{"line_number":611,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"b4ce7998_585959fa","line":608,"range":{"start_line":608,"start_character":27,"end_line":608,"end_character":38},"in_reply_to":"015db8c3_0dc4f558","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        path \u003d kwargs.get(\u0027path\u0027)"},{"line_number":614,"context_line":"        csr_params \u003d kwargs.get(\u0027csr_params\u0027)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        LOG.debug(\"Creating CSR certificate for node %(node)s ..\","},{"line_number":617,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":618,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":619,"context_line":"        LOG.info(\"Creation of CSR certificate for node %(node)s is \""}],"source_content_type":"text/x-python","patch_set":7,"id":"568e4bca_18c37dcb","line":616,"range":{"start_line":616,"start_character":32,"end_line":616,"end_character":43},"updated":"2022-03-11 06:20:17.000000000","message":"s/ certificate //","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        path \u003d kwargs.get(\u0027path\u0027)"},{"line_number":614,"context_line":"        csr_params \u003d kwargs.get(\u0027csr_params\u0027)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        LOG.debug(\"Creating CSR certificate for node %(node)s ..\","},{"line_number":617,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":618,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":619,"context_line":"        LOG.info(\"Creation of CSR certificate for node %(node)s is \""}],"source_content_type":"text/x-python","patch_set":7,"id":"ed307dae_734c19b1","line":616,"range":{"start_line":616,"start_character":32,"end_line":616,"end_character":43},"in_reply_to":"568e4bca_18c37dcb","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":616,"context_line":"        LOG.debug(\"Creating CSR certificate for node %(node)s ..\","},{"line_number":617,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":618,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":619,"context_line":"        LOG.info(\"Creation of CSR certificate for node %(node)s is \""},{"line_number":620,"context_line":"                 \"completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    @METRICS.timer(\u0027IloManagement.add_https_certificate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"0c02986f_2db7e9f1","line":619,"range":{"start_line":619,"start_character":34,"end_line":619,"end_character":45},"updated":"2022-03-11 06:20:17.000000000","message":"ditto","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        LOG.debug(\"Creating CSR certificate for node %(node)s ..\","},{"line_number":617,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":618,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":619,"context_line":"        LOG.info(\"Creation of CSR certificate for node %(node)s is \""},{"line_number":620,"context_line":"                 \"completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    @METRICS.timer(\u0027IloManagement.add_https_certificate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"31cad81c_2cbeed7b","line":619,"range":{"start_line":619,"start_character":34,"end_line":619,"end_character":45},"in_reply_to":"0c02986f_2db7e9f1","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":630,"context_line":"        node \u003d task.node"},{"line_number":631,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        LOG.debug(\"Adding the signed https certificate to the \""},{"line_number":634,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"},{"line_number":635,"context_line":"        _execute_ilo_step(node, \u0027add_https_certificate\u0027, cert_file)"},{"line_number":636,"context_line":"        LOG.info(\"Adding of HTTPS certificate to the node %(node)s \""}],"source_content_type":"text/x-python","patch_set":7,"id":"aa322a50_ebc086ea","line":633,"range":{"start_line":633,"start_character":37,"end_line":633,"end_character":42},"updated":"2022-03-11 06:20:17.000000000","message":"s/ https / HTTPS /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        node \u003d task.node"},{"line_number":631,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        LOG.debug(\"Adding the signed https certificate to the \""},{"line_number":634,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"},{"line_number":635,"context_line":"        _execute_ilo_step(node, \u0027add_https_certificate\u0027, cert_file)"},{"line_number":636,"context_line":"        LOG.info(\"Adding of HTTPS certificate to the node %(node)s \""}],"source_content_type":"text/x-python","patch_set":7,"id":"6dc5e147_6a5d7779","line":633,"range":{"start_line":633,"start_character":37,"end_line":633,"end_character":42},"in_reply_to":"aa322a50_ebc086ea","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fdd4bb4cb3c5ab7148aa8b5559596744e0a07736","unresolved":true,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        LOG.debug(\"Creating CSR for node %(node)s ..\","},{"line_number":619,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":620,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":621,"context_line":"        LOG.info(\"Creation of CSR for node %(node)s is \""},{"line_number":622,"context_line":"                 \"completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8e8acfca_ff35712e","line":620,"updated":"2022-03-28 21:51:21.000000000","message":"It looks like proliantutils is not ready to receive a create_csr call, it is not implemented in RISOperations or RIBCLOperations. And in RedfishOperations the create_csr method is missing the path parameter, and just writes to a temporary file.\n\nAssuming RedfishOperations.create_csr should take a path and write the csr to that path, this raises a few issues:\n- \u0027path\u0027 is documented as a directory, what actual filename is written, and how does the user discover that?\n- \u0027path\u0027 is a user provided value which results in writing a file to the controller node, and there is no validation that the destination path is safe. This suggests there needs to be a new [ilo] configuration value like csr_path with a sensible default like /etc/pki/ilo (or /etc/ironic/csr?), and validation added so that create_csr and add_https_certificate calls *must* be constrained to files inside ironic.conf [ilo]csr_path.","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b681cb9a8cced142916e5579fab3e37ae1cd653c","unresolved":true,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        LOG.debug(\"Creating CSR for node %(node)s ..\","},{"line_number":619,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":620,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":621,"context_line":"        LOG.info(\"Creation of CSR for node %(node)s is \""},{"line_number":622,"context_line":"                 \"completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"89258ebb_9f67868a","line":620,"in_reply_to":"79840c58_e89b23df","updated":"2022-03-29 16:24:54.000000000","message":"I have declared the ilo config in next patchset \"[ilo]csr_path\". \ncreate_csr is constrained to [ilo]csr_path. \nUser can provide the certificate for Add_https_certificate from anyplace, and code will copy that to [ilo]csr_path and then pass on to proliantutils. \nThe reasons:\n- both steps are though interlinked but still independent steps and user can do one by himself without ironic also.\n- There is no way add_https_certificate can find if user has called create_csr or not.\n\nI will post the patch now and let me know the comments. I tried to address the comments as per my understanding. The patch has been tested thoroughly with proliantutils 2.13.2","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1b60d75a01aa2c5875b7802693dc193bff7a322","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        LOG.debug(\"Creating CSR for node %(node)s ..\","},{"line_number":619,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":620,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":621,"context_line":"        LOG.info(\"Creation of CSR for node %(node)s is \""},{"line_number":622,"context_line":"                 \"completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ccdc0d89_b969f03e","line":620,"in_reply_to":"89258ebb_9f67868a","updated":"2022-03-29 16:25:34.000000000","message":"Done","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bf9465da30bb870ac9b4c437939d65ef6d06b8db","unresolved":true,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        LOG.debug(\"Creating CSR for node %(node)s ..\","},{"line_number":619,"context_line":"                  {\u0027node\u0027: node.uuid})"},{"line_number":620,"context_line":"        _execute_ilo_step(node, \u0027create_csr\u0027, path, csr_params)"},{"line_number":621,"context_line":"        LOG.info(\"Creation of CSR for node %(node)s is \""},{"line_number":622,"context_line":"                 \"completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"79840c58_e89b23df","line":620,"in_reply_to":"8e8acfca_ff35712e","updated":"2022-03-29 08:44:34.000000000","message":"+1","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fdd4bb4cb3c5ab7148aa8b5559596744e0a07736","unresolved":true,"context_lines":[{"line_number":630,"context_line":"        :param task: a TaskManager object."},{"line_number":631,"context_line":"        \"\"\""},{"line_number":632,"context_line":"        node \u003d task.node"},{"line_number":633,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""},{"line_number":636,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"eb6c949f_6d7a71aa","line":633,"updated":"2022-03-28 21:51:21.000000000","message":"Again, we\u0027re passing user input to read a file from the controller node. A hostile user could specify a cert they shouldn\u0027t have access to, or specify a very large file and DOS the controller process.\n\ncert_file should also be validated with ironic.conf [ilo]csr_path, as for the above comment.","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1b60d75a01aa2c5875b7802693dc193bff7a322","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        :param task: a TaskManager object."},{"line_number":631,"context_line":"        \"\"\""},{"line_number":632,"context_line":"        node \u003d task.node"},{"line_number":633,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""},{"line_number":636,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"17cdd662_1d9ab75d","line":633,"in_reply_to":"9c10d64a_cfecbba6","updated":"2022-03-29 16:25:34.000000000","message":"Done","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b681cb9a8cced142916e5579fab3e37ae1cd653c","unresolved":true,"context_lines":[{"line_number":630,"context_line":"        :param task: a TaskManager object."},{"line_number":631,"context_line":"        \"\"\""},{"line_number":632,"context_line":"        node \u003d task.node"},{"line_number":633,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""},{"line_number":636,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9c10d64a_cfecbba6","line":633,"in_reply_to":"eb6c949f_6d7a71aa","updated":"2022-03-29 16:24:54.000000000","message":"I have copied the cert into the directories as suggested, but i dont know how we can really validate if the certificate itself is malicious/wrong.","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":609,"context_line":"        csr_path \u003d CONF.ilo.csr_path"},{"line_number":610,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":611,"context_line":"        if not os.path.exists(path):"},{"line_number":612,"context_line":"            os.makedirs(path, 0o755)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        LOG.debug(\"Creating CSR for node %(node)s ..\","},{"line_number":615,"context_line":"                  {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":11,"id":"8ca83cf5_17d30241","line":612,"updated":"2022-03-30 04:17:35.000000000","message":"Another reason to make the default /var/lib/ironic/ilo_cert is that there is no way the ironic system user will have write permissions to /etc/pki for this call to work","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":true,"context_lines":[{"line_number":609,"context_line":"        csr_path \u003d CONF.ilo.csr_path"},{"line_number":610,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":611,"context_line":"        if not os.path.exists(path):"},{"line_number":612,"context_line":"            os.makedirs(path, 0o755)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        LOG.debug(\"Creating CSR for node %(node)s ..\","},{"line_number":615,"context_line":"                  {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ff68aa4_8acf98f1","line":612,"in_reply_to":"8ca83cf5_17d30241","updated":"2022-09-09 06:23:10.000000000","message":"Should i change /var/lib/ironic/ilo to /var/lib/ironic/ilo_cert ?","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":626,"context_line":"        :param task: a TaskManager object."},{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":"        node \u003d task.node"},{"line_number":629,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":630,"context_line":"        csr_path \u003d CONF.ilo.csr_path"},{"line_number":631,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":632,"context_line":"        if not os.path.exists(path):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ae153a4f_ace61e54","line":629,"updated":"2022-03-30 04:17:35.000000000","message":"See my comment in ilo.rst about this being a valid URL, but only supporting the file:// protocol for now","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":true,"context_lines":[{"line_number":626,"context_line":"        :param task: a TaskManager object."},{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":"        node \u003d task.node"},{"line_number":629,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":630,"context_line":"        csr_path \u003d CONF.ilo.csr_path"},{"line_number":631,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":632,"context_line":"        if not os.path.exists(path):"}],"source_content_type":"text/x-python","patch_set":11,"id":"44529846_27970d2e","line":629,"in_reply_to":"ae153a4f_ace61e54","updated":"2022-09-09 06:23:10.000000000","message":"I have supported file, http and https urls along with absolute directory path.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":628,"context_line":"        node \u003d task.node"},{"line_number":629,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":630,"context_line":"        csr_path \u003d CONF.ilo.csr_path"},{"line_number":631,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":632,"context_line":"        if not os.path.exists(path):"},{"line_number":633,"context_line":"            os.makedirs(path, 0o755)"},{"line_number":634,"context_line":"        cert_file_path \u003d path + node.uuid + \".crt\""}],"source_content_type":"text/x-python","patch_set":11,"id":"f81e5dd4_f63beee7","line":631,"updated":"2022-03-30 04:17:35.000000000","message":"always use os.path.join for building paths, there can\u0027t be an assumption that csr_path has a trailing slash.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        node \u003d task.node"},{"line_number":629,"context_line":"        cert_file \u003d kwargs.get(\u0027cert_file\u0027)"},{"line_number":630,"context_line":"        csr_path \u003d CONF.ilo.csr_path"},{"line_number":631,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":632,"context_line":"        if not os.path.exists(path):"},{"line_number":633,"context_line":"            os.makedirs(path, 0o755)"},{"line_number":634,"context_line":"        cert_file_path \u003d path + node.uuid + \".crt\""}],"source_content_type":"text/x-python","patch_set":11,"id":"4f5e6866_3d5367e9","line":631,"in_reply_to":"f81e5dd4_f63beee7","updated":"2022-09-09 06:23:10.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":632,"context_line":"        if not os.path.exists(path):"},{"line_number":633,"context_line":"            os.makedirs(path, 0o755)"},{"line_number":634,"context_line":"        cert_file_path \u003d path + node.uuid + \".crt\""},{"line_number":635,"context_line":"        shutil.copy(cert_file, cert_file_path)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""}],"source_content_type":"text/x-python","patch_set":11,"id":"74f1e6b2_ba3b10bf","line":634,"updated":"2022-03-30 04:17:35.000000000","message":"os.path.join again\n\nso the cert file path is stored in \u003ccsr_path\u003e/\u003cuuid\u003e/\u003cuuid\u003e.crt? This should be documented clearly in ilo.rst. Although once it is written it is never read again. How about cert_file becomes an optional parameter, so that if it is not specified then \u003ccsr_path\u003e/\u003cuuid\u003e/\u003cuuid\u003e.crt will be the fallback. That way cert_file only needs to be specified once for a node.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        path \u003d csr_path + task.node.uuid + \"/\""},{"line_number":632,"context_line":"        if not os.path.exists(path):"},{"line_number":633,"context_line":"            os.makedirs(path, 0o755)"},{"line_number":634,"context_line":"        cert_file_path \u003d path + node.uuid + \".crt\""},{"line_number":635,"context_line":"        shutil.copy(cert_file, cert_file_path)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""}],"source_content_type":"text/x-python","patch_set":11,"id":"0577ec99_9a42a2cc","line":634,"in_reply_to":"74f1e6b2_ba3b10bf","updated":"2022-09-09 06:23:10.000000000","message":"I havent made it optional. But i have supported the file, http and https.","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb916f3184ee657760d8b5bb144523dce723bece","unresolved":true,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""},{"line_number":638,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"},{"line_number":639,"context_line":"        _execute_ilo_step(node, \u0027add_https_certificate\u0027, cert_file)"},{"line_number":640,"context_line":"        LOG.info(\"Adding of HTTPS certificate to the node %(node)s \""},{"line_number":641,"context_line":"                 \"is completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3c74c7c2_ded06598","line":639,"range":{"start_line":639,"start_character":57,"end_line":639,"end_character":66},"updated":"2022-03-30 04:17:35.000000000","message":"cert_file_path","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91c9af522805afd5c8769628713f86d7c4ba734b","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        LOG.debug(\"Adding the signed HTTPS certificate to the \""},{"line_number":638,"context_line":"                  \"node %(node)s ..\", {\u0027node\u0027: node.uuid})"},{"line_number":639,"context_line":"        _execute_ilo_step(node, \u0027add_https_certificate\u0027, cert_file)"},{"line_number":640,"context_line":"        LOG.info(\"Adding of HTTPS certificate to the node %(node)s \""},{"line_number":641,"context_line":"                 \"is completed.\", {\u0027node\u0027: node.uuid})"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"cdb6db08_c622228f","line":639,"range":{"start_line":639,"start_character":57,"end_line":639,"end_character":66},"in_reply_to":"3c74c7c2_ded06598","updated":"2022-09-09 06:23:10.000000000","message":"Done","commit_id":"d6426868202643fa59f2d7fce7f486582ac7a9b7"}],"releasenotes/notes/create_csr_clean_step-a720932f61b42118.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new clean steps ``create_csr`` and ``add_https_certificate``"},{"line_number":5,"context_line":"    to ``ilo`` hardware type which allows users to create certificate"},{"line_number":6,"context_line":"    signing request and adds https certificate to the iLO."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"970acc70_0016e8f7","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":14},"updated":"2022-03-11 06:20:17.000000000","message":"s/ ``ilo`` / ``ilo`` and ``ilo5`` /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new clean steps ``create_csr`` and ``add_https_certificate``"},{"line_number":5,"context_line":"    to ``ilo`` hardware type which allows users to create certificate"},{"line_number":6,"context_line":"    signing request and adds https certificate to the iLO."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a2d9e4ac_bad8e305","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":14},"in_reply_to":"970acc70_0016e8f7","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"607fd6187ffe0f15a9b0709513dc2e14e60af743","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new clean steps ``create_csr`` and ``add_https_certificate``"},{"line_number":5,"context_line":"    to ``ilo`` hardware type which allows users to create certificate"},{"line_number":6,"context_line":"    signing request and adds https certificate to the iLO."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5cd592cd_f41540cc","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":34},"updated":"2022-03-11 06:20:17.000000000","message":"s/ https / HTTPS /","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfd3daee5c1905b02917124ee8e882d8d82c0201","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new clean steps ``create_csr`` and ``add_https_certificate``"},{"line_number":5,"context_line":"    to ``ilo`` hardware type which allows users to create certificate"},{"line_number":6,"context_line":"    signing request and adds https certificate to the iLO."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f151e761_2a65dffe","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":34},"in_reply_to":"5cd592cd_f41540cc","updated":"2022-03-19 16:46:05.000000000","message":"Done","commit_id":"0057fa46708cf2037ca5deb0c7c8a677fe421f6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b8beb4e136ad563b29732b8cef5993f1ed3382a8","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new clean steps ``create_csr`` and ``add_https_certificate``"},{"line_number":5,"context_line":"    to ``ilo`` and ``ilo5`` hardware types which allows users to "},{"line_number":6,"context_line":"    create Certificate Signing Request(CSR) and adds signed HTTPS"},{"line_number":7,"context_line":"    certificate to the iLO."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3cb536c4_83e3adc2","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":65},"updated":"2022-03-28 09:46:54.000000000","message":"nit: s/ //","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b681cb9a8cced142916e5579fab3e37ae1cd653c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new clean steps ``create_csr`` and ``add_https_certificate``"},{"line_number":5,"context_line":"    to ``ilo`` and ``ilo5`` hardware types which allows users to "},{"line_number":6,"context_line":"    create Certificate Signing Request(CSR) and adds signed HTTPS"},{"line_number":7,"context_line":"    certificate to the iLO."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d37a710e_675c2c69","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":65},"in_reply_to":"3cb536c4_83e3adc2","updated":"2022-03-29 16:24:54.000000000","message":"Done","commit_id":"86dce26ae096e7d6ab12b272f02e3a07f39a7f2f"}]}