)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b33663fee4de304a7e9193a900d76a119d26ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aija Jauntēva \u003caija.jaunteva@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-30 07:32:21 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix iDRAC import configuration job with errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In iDRAC import configuration task can be completed with OK health"},{"line_number":10,"context_line":"but having some errors, for example, when one disk failed to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5b1912b1_c21c6340","line":7,"updated":"2021-08-31 12:00:29.000000000","message":"Could you add a release note for the fix?","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c4e7ded7410c262c1355276b28be538848d97745","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aija Jauntēva \u003caija.jaunteva@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-30 07:32:21 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix iDRAC import configuration job with errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In iDRAC import configuration task can be completed with OK health"},{"line_number":10,"context_line":"but having some errors, for example, when one disk failed to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf69efe8_f7182ee1","line":7,"in_reply_to":"5b1912b1_c21c6340","updated":"2021-09-01 07:39:49.000000000","message":"done","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"399a88783c665b14ec8e3bfc8c1b92d8d6c12912","unresolved":true,"context_lines":[{"line_number":10,"context_line":"but having some errors, for example, when one disk failed to be"},{"line_number":11,"context_line":"created and another succeeded."},{"line_number":12,"context_line":"Also changed to exclude informational messages for error reporting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I02b63547566c94ffa1a5d0e84bd1b1f10d28bfc3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ea853cd2_0c35cb77","line":13,"updated":"2021-09-08 17:19:00.000000000","message":"a story might be good to document this...","commit_id":"d8b29208a019f17939e5e09a5c1289fa39493f50"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7635a3414eaf88ee966ee482353133023fd3a583","unresolved":false,"context_lines":[{"line_number":10,"context_line":"but having some errors, for example, when one disk failed to be"},{"line_number":11,"context_line":"created and another succeeded."},{"line_number":12,"context_line":"Also changed to exclude informational messages for error reporting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I02b63547566c94ffa1a5d0e84bd1b1f10d28bfc3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7c7fd538_0c18aad8","line":13,"in_reply_to":"ea853cd2_0c35cb77","updated":"2021-09-09 09:14:06.000000000","message":"Done","commit_id":"d8b29208a019f17939e5e09a5c1289fa39493f50"}],"ironic/drivers/modules/drac/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b33663fee4de304a7e9193a900d76a119d26ed","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                # Task could complete with errors (partial success)"},{"line_number":523,"context_line":"                # iDRAC 5.00.00.00 has stopped reporting Critical messages"},{"line_number":524,"context_line":"                # so checking also by message_id"},{"line_number":525,"context_line":"                nonok_messages \u003d [m.message for m in import_task.messages"},{"line_number":526,"context_line":"                                  if m.severity is not None"},{"line_number":527,"context_line":"                                  and m.severity !\u003d sushy.SEVERITY_OK"},{"line_number":528,"context_line":"                                  or m.message_id and \u0027SYS055\u0027 in m.message_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ebf4e6cf_a64bc217","line":525,"updated":"2021-08-31 12:00:29.000000000","message":"nit: you can use any(..) to avoid building an unnecessary list\n\n succeeded \u003d any(m.message for m ...)","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c4e7ded7410c262c1355276b28be538848d97745","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                # Task could complete with errors (partial success)"},{"line_number":523,"context_line":"                # iDRAC 5.00.00.00 has stopped reporting Critical messages"},{"line_number":524,"context_line":"                # so checking also by message_id"},{"line_number":525,"context_line":"                nonok_messages \u003d [m.message for m in import_task.messages"},{"line_number":526,"context_line":"                                  if m.severity is not None"},{"line_number":527,"context_line":"                                  and m.severity !\u003d sushy.SEVERITY_OK"},{"line_number":528,"context_line":"                                  or m.message_id and \u0027SYS055\u0027 in m.message_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"f56420e7_38c1e5bb","line":525,"in_reply_to":"ebf4e6cf_a64bc217","updated":"2021-09-01 07:39:49.000000000","message":"done","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b33663fee4de304a7e9193a900d76a119d26ed","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                nonok_messages \u003d [m.message for m in import_task.messages"},{"line_number":526,"context_line":"                                  if m.severity is not None"},{"line_number":527,"context_line":"                                  and m.severity !\u003d sushy.SEVERITY_OK"},{"line_number":528,"context_line":"                                  or m.message_id and \u0027SYS055\u0027 in m.message_id]"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"                if not nonok_messages:"},{"line_number":531,"context_line":"                    succeeded \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"b1d3f158_38b0dada","line":528,"updated":"2021-08-31 12:00:29.000000000","message":"nit: the logic seems correct here, but I\u0027d use brackets to make it the operator ordering obvious","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c4e7ded7410c262c1355276b28be538848d97745","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                nonok_messages \u003d [m.message for m in import_task.messages"},{"line_number":526,"context_line":"                                  if m.severity is not None"},{"line_number":527,"context_line":"                                  and m.severity !\u003d sushy.SEVERITY_OK"},{"line_number":528,"context_line":"                                  or m.message_id and \u0027SYS055\u0027 in m.message_id]"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"                if not nonok_messages:"},{"line_number":531,"context_line":"                    succeeded \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"229a5a29_ee38b8fc","line":528,"in_reply_to":"b1d3f158_38b0dada","updated":"2021-09-01 07:39:49.000000000","message":"done","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b33663fee4de304a7e9193a900d76a119d26ed","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                # Select all messages, skipping OEM messages that don\u0027t have"},{"line_number":561,"context_line":"                # `message` field populated."},{"line_number":562,"context_line":"                messages \u003d [m.message for m in import_task.messages"},{"line_number":563,"context_line":"                            if m.message is not None]"},{"line_number":564,"context_line":"                error_msg \u003d (_(\"Failed import configuration task: \""},{"line_number":565,"context_line":"                               \"%(task_monitor_url)s. Message: \u0027%(message)s\u0027.\")"},{"line_number":566,"context_line":"                             % {\u0027task_monitor_url\u0027: task_monitor_url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e33a5028_00d4ca19","line":563,"updated":"2021-08-31 12:00:29.000000000","message":"I think you should now check severity here as well","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c4e7ded7410c262c1355276b28be538848d97745","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                # Select all messages, skipping OEM messages that don\u0027t have"},{"line_number":561,"context_line":"                # `message` field populated."},{"line_number":562,"context_line":"                messages \u003d [m.message for m in import_task.messages"},{"line_number":563,"context_line":"                            if m.message is not None]"},{"line_number":564,"context_line":"                error_msg \u003d (_(\"Failed import configuration task: \""},{"line_number":565,"context_line":"                               \"%(task_monitor_url)s. Message: \u0027%(message)s\u0027.\")"},{"line_number":566,"context_line":"                             % {\u0027task_monitor_url\u0027: task_monitor_url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"73d0b50b_8d29aef0","line":563,"in_reply_to":"e33a5028_00d4ca19","updated":"2021-09-01 07:39:49.000000000","message":"done","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"}],"ironic/tests/unit/drivers/modules/drac/test_management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b33663fee4de304a7e9193a900d76a119d26ed","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"            self.management._set_failed.assert_called_once_with("},{"line_number":1185,"context_line":"                task, mock.ANY,"},{"line_number":1186,"context_line":"                \"Failed import configuration task: /TaskService/123. Message: \""},{"line_number":1187,"context_line":"                \"\u0027The operation successfully completed, \""},{"line_number":1188,"context_line":"                \"Firmware upgrade failed\u0027.\")"},{"line_number":1189,"context_line":"            self.management._set_success.assert_not_called()"},{"line_number":1190,"context_line":"            self.assertIsNone("}],"source_content_type":"text/x-python","patch_set":3,"id":"b704f116_b1c3ebd6","line":1187,"updated":"2021-08-31 12:00:29.000000000","message":"This should not be a part of the failure message, it\u0027s confusing.","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c4e7ded7410c262c1355276b28be538848d97745","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"            self.management._set_failed.assert_called_once_with("},{"line_number":1185,"context_line":"                task, mock.ANY,"},{"line_number":1186,"context_line":"                \"Failed import configuration task: /TaskService/123. Message: \""},{"line_number":1187,"context_line":"                \"\u0027The operation successfully completed, \""},{"line_number":1188,"context_line":"                \"Firmware upgrade failed\u0027.\")"},{"line_number":1189,"context_line":"            self.management._set_success.assert_not_called()"},{"line_number":1190,"context_line":"            self.assertIsNone("}],"source_content_type":"text/x-python","patch_set":3,"id":"c1409505_8b90b963","line":1187,"in_reply_to":"b704f116_b1c3ebd6","updated":"2021-09-01 07:39:49.000000000","message":"done","commit_id":"72ac8cdeffb4098a01219cb101f5425a6b28acbf"}],"releasenotes/notes/idrac-import-conf-partial-success-86b8bd1983d227f6.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"77ed93daf4f15b81fe2fcf1280c541f58d0e27ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In ``idrac-redfish`` clean/deploy step ``import_configuration``"},{"line_number":5,"context_line":"    fixes handling of iDRAC job that has status \"Completed with errors\"."},{"line_number":6,"context_line":"    Without this fix the step completed successfully without any fault"},{"line_number":7,"context_line":"    indication that changes to system succeeded partially. Now it is reported"},{"line_number":8,"context_line":"    as failed step."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7164237b_ea3460bf","line":5,"range":{"start_line":4,"start_character":3,"end_line":5,"end_character":3},"updated":"2021-09-08 17:21:15.000000000","message":"Typically we start these with \"fixes issue\" so \"Fixes issue in ``idrac-redfish`` clean/deploy step ``import_configuration`` where partially successful jobs were treated as fully successful. These failures are now treated as failures.\"  Or something like that.","commit_id":"d8b29208a019f17939e5e09a5c1289fa39493f50"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7635a3414eaf88ee966ee482353133023fd3a583","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In ``idrac-redfish`` clean/deploy step ``import_configuration``"},{"line_number":5,"context_line":"    fixes handling of iDRAC job that has status \"Completed with errors\"."},{"line_number":6,"context_line":"    Without this fix the step completed successfully without any fault"},{"line_number":7,"context_line":"    indication that changes to system succeeded partially. Now it is reported"},{"line_number":8,"context_line":"    as failed step."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e04dccce_4aace232","line":5,"range":{"start_line":4,"start_character":3,"end_line":5,"end_character":3},"in_reply_to":"7164237b_ea3460bf","updated":"2021-09-09 09:14:06.000000000","message":"Done","commit_id":"d8b29208a019f17939e5e09a5c1289fa39493f50"}]}