)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bba4f7a3257ba3abdbba65b99d7c627a1127e952","unresolved":true,"context_lines":[{"line_number":658,"context_line":"            IRONIC_GRUB2_SHIM_FILE\u003d/usr/lib/shim/shimx64.efi"},{"line_number":659,"context_line":"        fi"},{"line_number":660,"context_line":"        IRONIC_GRUB2_FILE\u003d/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed"},{"line_number":661,"context_line":"        IRONIC_GRUB2_NETWORK_FILE\u003d/usr/lib/grub/x86_64-efi-signed/grubnetx64.efi.signed"},{"line_number":662,"context_line":"    fi"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ae52bbd3_c374629a","line":661,"updated":"2021-09-02 20:46:43.000000000","message":"grubx64.efi.signed may be the correct one to use, so IRONIC_GRUB2_NETWORK_FILE might not be needed","commit_id":"19f5587fd25b31a819ddae5626e9fcdc2c6f23ec"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6e8cb8ed3abef4bfef8c6e91962b1333fdfe6a1c","unresolved":true,"context_lines":[{"line_number":2717,"context_line":"configfile $IRONIC_TFTPBOOT_DIR/\\$net_default_mac.conf"},{"line_number":2718,"context_line":"}"},{"line_number":2719,"context_line":"EOF"},{"line_number":2720,"context_line":"        chmod 644 grub_dir/grub.cfg"},{"line_number":2721,"context_line":"        iniset $IRONIC_CONF_FILE pxe uefi_pxe_config_template \u0027$pybasedir/drivers/modules/pxe_grub_config.template\u0027"},{"line_number":2722,"context_line":"        iniset $IRONIC_CONF_FILE pxe uefi_pxe_bootfile_name  \"bootx64.efi\""},{"line_number":2723,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"41aedd9b_5a287997","line":2720,"range":{"start_line":2720,"start_character":18,"end_line":2720,"end_character":26},"updated":"2021-09-02 22:29:01.000000000","message":"$grub_dir","commit_id":"316660edf1faaa0238e54b3e5dda1e07206205f6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6e8cb8ed3abef4bfef8c6e91962b1333fdfe6a1c","unresolved":true,"context_lines":[{"line_number":2718,"context_line":"}"},{"line_number":2719,"context_line":"EOF"},{"line_number":2720,"context_line":"        chmod 644 grub_dir/grub.cfg"},{"line_number":2721,"context_line":"        iniset $IRONIC_CONF_FILE pxe uefi_pxe_config_template \u0027$pybasedir/drivers/modules/pxe_grub_config.template\u0027"},{"line_number":2722,"context_line":"        iniset $IRONIC_CONF_FILE pxe uefi_pxe_bootfile_name  \"bootx64.efi\""},{"line_number":2723,"context_line":"    else"},{"line_number":2724,"context_line":"        echo \"r ^([^/]) $IRONIC_TFTPBOOT_DIR/\\1\" \u003e$IRONIC_TFTPBOOT_DIR/map-file"},{"line_number":2725,"context_line":"        echo \"r ^(/tftpboot/) $IRONIC_TFTPBOOT_DIR/\\2\" \u003e\u003e$IRONIC_TFTPBOOT_DIR/map-file"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4b755729_2bc3a3ab","line":2722,"range":{"start_line":2721,"start_character":0,"end_line":2722,"end_character":74},"updated":"2021-09-02 22:29:01.000000000","message":"These are the default configuration values, so this isn\u0027t required","commit_id":"316660edf1faaa0238e54b3e5dda1e07206205f6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"18c9f69a95c3da8725405d14679fee6ca4785b7f","unresolved":true,"context_lines":[{"line_number":2707,"context_line":"        fi"},{"line_number":2708,"context_line":"        grub_dir\u003d$IRONIC_TFTPBOOT_DIR/$grub_subdir"},{"line_number":2709,"context_line":"        mkdir -p $grub_dir"},{"line_number":2710,"context_line":"        # Grub looks for numerous files when the grubnetx.efi binary is used :\\"},{"line_number":2711,"context_line":"        # specifically .lst files which define module lists which we can\u0027t seem"},{"line_number":2712,"context_line":"        # to find on disk. That being said, the grub-mknetdir utility generates"},{"line_number":2713,"context_line":"        # these files for us."},{"line_number":2714,"context_line":"        grub-mknetdir --net-directory\u003d\"$IRONIC_TFTPBOOT_DIR\" --subdir\u003d\"$grub_subdir\""},{"line_number":2715,"context_line":"        cat \u003c\u003c EOF \u003e $grub_dir/grub.cfg"},{"line_number":2716,"context_line":"set default\u003dmaster"},{"line_number":2717,"context_line":"set timeout\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"16e1a506_cfb0fd57","line":2714,"range":{"start_line":2710,"start_character":0,"end_line":2714,"end_character":84},"updated":"2021-09-03 02:43:53.000000000","message":"Now that ironic-tempest-ipa-partition-uefi-pxe-grub2 is green with this change I\u0027m going to try removing this grub-mknetdir call. My theory is that when grub remotely requests grub/x86_64-efi/*.lst files and they\u0027re missing, it will continue without error.\n\nIt will mean noisier dnsmasq logs, but simpler setup of the tftpboot directory.","commit_id":"e36a48c6e867411322ed1fe114f462782b640861"}]}