)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"50500a82a97210c1d6c6c8b650aed2e934de12e9","unresolved":true,"context_lines":[{"line_number":16,"context_line":"if the driver in question was for the the driver interface in"},{"line_number":17,"context_line":"question and *then* evaluate if work had to be performed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"However, that field containing a pointer to if work needed to be"},{"line_number":20,"context_line":"performed as often already queried from the database on the"},{"line_number":21,"context_line":"very initial query to generate the list of nodes to evaluate."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In essence, we\u0027ve moved this up in the sequence so we evaluate"},{"line_number":24,"context_line":"that field in question prior to creating the task, potentially"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d20cb8d3_a3a68532","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":61},"updated":"2021-09-13 22:25:43.000000000","message":"I can\u0027t quite scan the meaning of this sentence","commit_id":"4fc1abf91fe622b3eca52547dca086396acf9436"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"81f99266bda579148dd9f9d76c699c7439d3c120","unresolved":true,"context_lines":[{"line_number":16,"context_line":"if the driver in question was for the the driver interface in"},{"line_number":17,"context_line":"question and *then* evaluate if work had to be performed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"However, that field containing a pointer to if work needed to be"},{"line_number":20,"context_line":"performed as often already queried from the database on the"},{"line_number":21,"context_line":"very initial query to generate the list of nodes to evaluate."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In essence, we\u0027ve moved this up in the sequence so we evaluate"},{"line_number":24,"context_line":"that field in question prior to creating the task, potentially"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"158047a3_894bcc45","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":61},"in_reply_to":"d20cb8d3_a3a68532","updated":"2021-09-13 22:34:34.000000000","message":"Ahh, err. I must have been interrupted somewhere along the way. Basically:\n\nCommon pattern includes geting something like driver_internal_info on the list of nodes,\nand then using it\u0027s contents to tell us if we need to do something.","commit_id":"4fc1abf91fe622b3eca52547dca086396acf9436"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7a13a7e4646bcbc0269e2ef40541cdc06434d780","unresolved":true,"context_lines":[{"line_number":25,"context_line":"across every conductor, depending on the query, and ultimately"},{"line_number":26,"context_line":"which drivers are enabled."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"This saves potentially saves hundreds of thousands of needless"},{"line_number":29,"context_line":"database queries on a medium size deployment per single day,"},{"line_number":30,"context_line":"depending on which drivers and driver interfaces are in use."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2b3b5280_21fbf2ec","line":28,"range":{"start_line":28,"start_character":5,"end_line":28,"end_character":28},"updated":"2021-09-14 07:43:39.000000000","message":"no need to repeat \"saves\" twice?","commit_id":"4fc1abf91fe622b3eca52547dca086396acf9436"}],"ironic/drivers/modules/drac/bios.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7a13a7e4646bcbc0269e2ef40541cdc06434d780","unresolved":true,"context_lines":[{"line_number":169,"context_line":"        for (node_uuid, driver, conductor_group,"},{"line_number":170,"context_line":"             driver_internal_info) in node_list:"},{"line_number":171,"context_line":"            try:"},{"line_number":172,"context_line":"                # NOTE(TheJulia) Evaluate if work is actually required before"},{"line_number":173,"context_line":"                # creating a task for every node in the deployment which does"},{"line_number":174,"context_line":"                # not have a lock and is not in maintenance mode."},{"line_number":175,"context_line":"                if (not driver_internal_info.get(\"bios_config_job_ids\")"},{"line_number":176,"context_line":"                    and not driver_internal_info.get("},{"line_number":177,"context_line":"                        \"factory_reset_time_before_reboot\")):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6282c556_31c6f1d0","line":174,"range":{"start_line":172,"start_character":16,"end_line":174,"end_character":65},"updated":"2021-09-14 07:43:39.000000000","message":"here and elsewhere would drop these multiline comments, the code makes sense on its now, and comment is repetitive. In future the pattern will be copied without questioning :)","commit_id":"4fc1abf91fe622b3eca52547dca086396acf9436"}]}