)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"9c38be164b6d72745b51350aaf3fed2c84d0dfe8","unresolved":true,"context_lines":[{"line_number":11,"context_line":"operation. This change introduces a helper decorator for that and"},{"line_number":12,"context_line":"migrates the drivers to it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"I\u0027m intentionally leaving unit tests intact to demonstrate that the"},{"line_number":15,"context_line":"new decorator works exactly the same way (modulo cosmetic changes)"},{"line_number":16,"context_line":"as the previous hand-written code."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"195d14ee_2f28fedd","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":37},"updated":"2021-10-08 08:29:57.000000000","message":"a Q: could they be removed in future patches? To remove repetitive unit tests and have existing code as reference implementation+unit tests?","commit_id":"29e36838bb4b17343e42665f1bb322bfc6269ed0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8be936b2fdc400acba5ecdd391ea8ffa5c81aa12","unresolved":false,"context_lines":[{"line_number":11,"context_line":"operation. This change introduces a helper decorator for that and"},{"line_number":12,"context_line":"migrates the drivers to it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"I\u0027m intentionally leaving unit tests intact to demonstrate that the"},{"line_number":15,"context_line":"new decorator works exactly the same way (modulo cosmetic changes)"},{"line_number":16,"context_line":"as the previous hand-written code."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9e83b871_9a29e0f0","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":37},"in_reply_to":"195d14ee_2f28fedd","updated":"2021-10-11 15:25:50.000000000","message":"Yep, I\u0027d like to do it in the next iteration.","commit_id":"29e36838bb4b17343e42665f1bb322bfc6269ed0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f3c33bcf00f1cc52b27c2c5edeffe6511012eef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b07a7599_7ef7730b","updated":"2021-10-14 06:50:29.000000000","message":"Thank you Dmitry.","commit_id":"cf1b42ea3d35d51d327e3aff0a05a9d402af0e15"}],"doc/source/contributor/deploy-steps.rst":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"9c38be164b6d72745b51350aaf3fed2c84d0dfe8","unresolved":true,"context_lines":[{"line_number":251,"context_line":"            predicate\u003dlambda n: n.driver_internal_info.get(\u0027in_my_action\u0027),"},{"line_number":252,"context_line":"        )"},{"line_number":253,"context_line":"        def check_my_action(self, task, manager, context):"},{"line_number":254,"context_line":"            # Double-check that the node is managed by this interface"},{"line_number":255,"context_line":"            if not isinstance(task.driver.management, MyManagement):"},{"line_number":256,"context_line":"                return"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"            if not needs_actions():  # insert your checks here"},{"line_number":259,"context_line":"                return"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dc53de68_ad1e5448","line":256,"range":{"start_line":254,"start_character":11,"end_line":256,"end_character":22},"updated":"2021-10-08 08:29:57.000000000","message":"thinking if this could be part of the periodic too as it is repeating and potentially could be forgotten to be added in new implementations. Though then it makes the node_periodic signature even bigger. Maybe reflection could help to determine that node_periodic is used on, e.g., management+MyManagement method?","commit_id":"29e36838bb4b17343e42665f1bb322bfc6269ed0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8be936b2fdc400acba5ecdd391ea8ffa5c81aa12","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            predicate\u003dlambda n: n.driver_internal_info.get(\u0027in_my_action\u0027),"},{"line_number":252,"context_line":"        )"},{"line_number":253,"context_line":"        def check_my_action(self, task, manager, context):"},{"line_number":254,"context_line":"            # Double-check that the node is managed by this interface"},{"line_number":255,"context_line":"            if not isinstance(task.driver.management, MyManagement):"},{"line_number":256,"context_line":"                return"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"            if not needs_actions():  # insert your checks here"},{"line_number":259,"context_line":"                return"}],"source_content_type":"text/x-rst","patch_set":8,"id":"cf93fa7c_ed5182b5","line":256,"range":{"start_line":254,"start_character":11,"end_line":256,"end_character":22},"in_reply_to":"dc53de68_ad1e5448","updated":"2021-10-11 15:25:50.000000000","message":"I\u0027ll play with it in a follow-up.","commit_id":"29e36838bb4b17343e42665f1bb322bfc6269ed0"}],"ironic/conductor/periodics.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2fd06c67a6c520443107c249a525a75d36542cb9","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    to abort the current iteration of the task and reschedule it."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    :param purpose: a human-readable description of the activity, e.g."},{"line_number":64,"context_line":"        \"verifying that the cat is purring\"."},{"line_number":65,"context_line":"    :param spacing: how often (in seconds) to run the periodic task."},{"line_number":66,"context_line":"    :param enabled: whether the task is enabled; defaults to ``spacing \u003e 0``."},{"line_number":67,"context_line":"    :param filters: database-level filters for the nodes."}],"source_content_type":"text/x-python","patch_set":9,"id":"17a0448b_3432dd2e","line":64,"updated":"2021-10-12 09:46:37.000000000","message":"lol","commit_id":"cf1b42ea3d35d51d327e3aff0a05a9d402af0e15"}]}