)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70437951998bd45d76ca562679785ed33dd1a805","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4843bc63_575fce61","updated":"2021-10-16 18:25:09.000000000","message":"recheck","commit_id":"7d85694fdf85a269cb3023083bf567a0e7e4ec13"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f46909fa88f442b7782ea63da70adee673da2b97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77dbc7e1_92256ccc","updated":"2021-10-18 08:12:26.000000000","message":"recheck","commit_id":"7d85694fdf85a269cb3023083bf567a0e7e4ec13"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d17bc292d387414a7c5c1e4c36eb4ed2c47466d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c11e0599_fff014ed","updated":"2021-10-17 12:42:34.000000000","message":"recheck","commit_id":"7d85694fdf85a269cb3023083bf567a0e7e4ec13"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d2d57cc64553b99fe5aa4bad8394a3dc36ccca7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8b0a85d_8838bb2f","updated":"2021-10-18 13:02:40.000000000","message":"recheck","commit_id":"7d85694fdf85a269cb3023083bf567a0e7e4ec13"}],"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4021637331d981643b167aa1aeb7162b09e2e877","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":162,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":163,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":164,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.basename(master_path))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            with _concurrency_semaphore:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2db44a04_7a785d8d","line":164,"updated":"2021-10-15 17:20:05.000000000","message":"what are the chances that in the future, master_path\u0027s basename changes to some long string instead of a uuid? (almost worth adding a comment here wrt length of tmp_path)? I guess we want this to make it easier to debug? (vs some random path since tmp_dir is already random.)","commit_id":"7d85694fdf85a269cb3023083bf567a0e7e4ec13"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6aaaf541af84e17f8ab43eda5e85fb22cb1bbd61","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":162,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":163,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":164,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.basename(master_path))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            with _concurrency_semaphore:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8e1b0de_4984db2e","line":164,"in_reply_to":"2db44a04_7a785d8d","updated":"2021-10-16 18:25:00.000000000","message":"Currently the basename of master_path is very explicitly a UUID, and I hope it stays like this.","commit_id":"7d85694fdf85a269cb3023083bf567a0e7e4ec13"}]}